[clang] 438f0e1 - [clang-format] Use EXPECT_EQ instead of setting style to a default value. NFC.

Author: Marek Kurdej Date: 2022-01-31T09:06:00+01:00 New Revision: 438f0e1f00ada4827d8138dd236e850b26c4141f URL: https://github.com/llvm/llvm-project/commit/438f0e1f00ada4827d8138dd236e850b26c4141f DIFF: https://github.com/llvm/llvm-project/commit/438f0e1f00ada4827d8138dd236e850b26c4141f.diff

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:448 +addSystemInclude(DriverArgs, CC1Args, + getDriver().SysRoot + "/include/c++/11"); +break; sbc100 wrote: > Where does `11` come from here? Do o

[PATCH] D31696: Automatically add include-what-you-use for when building in tree

kimgr added a comment. We've had reports from users that it's now possible to build IWYU together with Clang and LLVM using LLVM_EXTERNAL_PROJECTS, so this can be closed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31696/new/ https://reviews.llvm.org/D31696 _

[PATCH] D117390: [AST] Reformat CastExpr unittest suite

kimgr added a comment. @rsmith Gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117390/new/ https://reviews.llvm.org/D117390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D117391: [AST] Ignore implicit nodes in CastExpr::getConversionFunction

kimgr added a comment. @rsmith Gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117391/new/ https://reviews.llvm.org/D117391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D115972: [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting.

curdeius updated this revision to Diff 404431. curdeius added a comment. This revision is now accepted and ready to land. Fix cases with lambdas. Added a (still) failing test with a ternary operator and multi-line continuation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115972: [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting.

curdeius added a comment. This is still a WIP, but I'd like to have your opinion on how to tackle this problem. What I'd like to do basically is to avoid shifting right the body of the lambda but still align things inside the lambda body. This patch, for the moment, basically disables alignment

[PATCH] D115972: [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting.

MyDeveloperDay added a comment. > This patch, for the moment, basically disables alignment in the lambdas which > is not what I want. I sort of feel that's ok for now. > This is still a WIP, but I'd like to have your opinion on how to tackle this > problem. What are we trying to achieve? what

[PATCH] D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring.

balazske updated this revision to Diff 404434. balazske marked an inline comment as done. balazske added a comment. Corrected the comment problems, explained why return value of `checkFunction` is ignored. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D113874: [clang] Propagate requires-clause from constructor template to implicit deduction guide

nridge created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. nridge updated this revision to Diff 404437. nridge added a comment. nridge retitled this revision from "[WIP] [clang] Attempt to fix crash in https://github.com/clangd/clangd/issues/890"; to "[clang] Propagate

[clang-tools-extra] ab3b898 - Revert "enable plugins for clang-tidy"

Author: Petr Hosek Date: 2022-01-31T00:55:43-08:00 New Revision: ab3b89855c5318f0009e1f016ffe5b1483507fd0 URL: https://github.com/llvm/llvm-project/commit/ab3b89855c5318f0009e1f016ffe5b1483507fd0 DIFF: https://github.com/llvm/llvm-project/commit/ab3b89855c5318f0009e1f016ffe5b1483507fd0.diff LO

[PATCH] D111100: enable plugins for clang-tidy

phosek added a comment. In D00#3282760 , @vtjnash wrote: > Yes, please push a revert so I can look later. Do you have a link to the > buildbot configuration, so I can reproduce that? I did some debugging and it looks like this failure is due to `-D

[PATCH] D115972: [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting.

curdeius added a comment. In D115972#3283229 , @MyDeveloperDay wrote: >> This patch, for the moment, basically disables alignment in the lambdas >> which is not what I want. > > I sort of feel that's ok for now. Ok. >> This is still a WIP, but I'd lik

[PATCH] D115972: [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting.

curdeius updated this revision to Diff 404438. curdeius added a comment. - Add FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115972/new/ https://reviews.llvm.org/D115972 Files: clang/lib/Format/WhitespaceManager.cpp clang/unittests/Form

[clang-tools-extra] b088237 - [clang-tidy] bugprone-signal-handler improvements: display call chain

Author: Balázs Kéri Date: 2022-01-31T10:35:23+01:00 New Revision: b088237f08c4c48be64890a9418ae88532075888 URL: https://github.com/llvm/llvm-project/commit/b088237f08c4c48be64890a9418ae88532075888 DIFF: https://github.com/llvm/llvm-project/commit/b088237f08c4c48be64890a9418ae88532075888.diff L

[PATCH] D118224: [clang-tidy] bugprone-signal-handler improvements: display call chain

This revision was automatically updated to reflect the committed changes. Closed by commit rGb088237f08c4: [clang-tidy] bugprone-signal-handler improvements: display call chain (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

hokein updated this revision to Diff 404442. hokein added a comment. Polish the LRTable implementation, using two flat vectors memory-size (bytes): 1380908 => 664600 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118196/new/ https://reviews.llvm.or

[PATCH] D116583: Change the default optimisation level of PTXAS from -O0 to -O3. This makes the optimisation levels of PTXAS and the ptxjitcompiler equal (ptxjitcompiler defaults to -O3).

hdelan added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:433 } else { -// If no -O was passed, pass -O0 to ptxas -- no opt flag should correspond -// to no optimizations, but ptxas's default is -O3. -CmdArgs.push_back("-O0"); +// If no -O

[PATCH] D116583: Change the default optimisation level of PTXAS from -O0 to -O3. This makes the optimisation levels of PTXAS and the ptxjitcompiler equal (ptxjitcompiler defaults to -O3).

hdelan abandoned this revision. hdelan added a comment. Closing revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116583/new/ https://reviews.llvm.org/D116583 ___ cfe-commits mailing list cfe-commit

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen updated this revision to Diff 404440. steffenlarsen edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/ https://reviews.llvm.org/D114439 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

njames93 added a comment. @Eugene.Zelenko Do you think I should update release notes for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118520/new/ https://reviews.llvm.org/D118520 ___ cfe-commits m

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

svenvh added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:73 #if (defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= 200) +#define __opencl_c_generic_address_space 1 #define cl_khr_subgroup_extended_types 1 Anastasia wr

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro added a comment. In D91607#3280808 , @efriedma wrote: > Testcase? I thought the 3 testcases adjusted in D91608 to use `__builtin_extract_return_addr` and fixed by this patch were enough. Otherwise, should I just aug

[clang] b8290ff - Fix -Wreserved-identifier in presence of system macro

Author: serge-sans-paille Date: 2022-01-31T11:16:28+01:00 New Revision: b8290ffa9fd935b8a0e99634fccfae9ed87ad9b5 URL: https://github.com/llvm/llvm-project/commit/b8290ffa9fd935b8a0e99634fccfae9ed87ad9b5 DIFF: https://github.com/llvm/llvm-project/commit/b8290ffa9fd935b8a0e99634fccfae9ed87ad9b5.d

[PATCH] D118532: Fix -Wreserved-identifier in presence of system macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb8290ffa9fd9: Fix -Wreserved-identifier in presence of system macro (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm

[clang-tools-extra] e07823a - [clang-tidy] Make header compile standalone. NFC.

Author: Benjamin Kramer Date: 2022-01-31T11:18:00+01:00 New Revision: e07823ad729a16c609e9e234849f56bf9f1d5f00 URL: https://github.com/llvm/llvm-project/commit/e07823ad729a16c609e9e234849f56bf9f1d5f00 DIFF: https://github.com/llvm/llvm-project/commit/e07823ad729a16c609e9e234849f56bf9f1d5f00.dif

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers added a comment. I took a run at the improvements, and the rabbit hole keeps getting deeper :/ @steakhal, I'll contact you offline to work out the problems. Best Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118050/new/ https://review

[clang] 8e60992 - [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

Author: Sven van Haastregt Date: 2022-01-31T10:21:05Z New Revision: 8e6099291dcb49b90e59a591ec24c77f348239b6 URL: https://github.com/llvm/llvm-project/commit/8e6099291dcb49b90e59a591ec24c77f348239b6 DIFF: https://github.com/llvm/llvm-project/commit/8e6099291dcb49b90e59a591ec24c77f348239b6.diff

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e6099291dcb: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CH

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen marked 7 inline comments as done and an inline comment as not done. steffenlarsen added inline comments. Comment at: clang/include/clang/AST/Attr.h:51 unsigned Implicit : 1; + unsigned ArgsDelayed : 1; // FIXME: These are properties of the attribute kind, no

[clang] 280b430 - [Analyzer] Add docs to StdCLibraryFunctionArgsChecker

Author: Gabor Marton Date: 2022-01-31T11:25:31+01:00 New Revision: 280b43031ca05bfb674017f91988b7c9b659a820 URL: https://github.com/llvm/llvm-project/commit/280b43031ca05bfb674017f91988b7c9b659a820 DIFF: https://github.com/llvm/llvm-project/commit/280b43031ca05bfb674017f91988b7c9b659a820.diff

[PATCH] D117568: [Analyzer] Add docs to StdCLibraryFunctionArgsChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rG280b43031ca0: [Analyzer] Add docs to StdCLibraryFunctionArgsChecker (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117568/new/ https:/

[PATCH] D118592: [cte] Add release notes for clangd-14

kadircet created this revision. kadircet added a reviewer: kbobyrev. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Mon

[PATCH] D118380: Add info on PACBTI-M to the Clang release notes

amilendra added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118380/new/ https://reviews.llvm.org/D118380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D115972: [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting.

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16608 + // "auto b= f(a,\n" + // " ccc ? a : b,\n" + // " dd)

[PATCH] D118596: [clang][dataflow] Enable comparison of distinct values in Environment

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. Make specializations of `DataflowAnalysis` extendable with domain-specific logic fo

[PATCH] D115972: [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting.

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16608 + // "auto b= f(a,\n" + // " ccc ? a : b,\n" + // " dd);", --

[PATCH] D118578: [RISCV] Make Zfhmin in march imply F.

achieveartificialintelligence accepted this revision. achieveartificialintelligence added a comment. This revision is now accepted and ready to land. LGTM. I think this is indeed a better way to implement `Zfhmin`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D117740: [NFC][clang] Simplify `isOneOf` function

achieveartificialintelligence added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117740/new/ https://reviews.llvm.org/D117740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] 9a6b0af - Don't rely on clang being named clang in test

Author: Benjamin Kramer Date: 2022-01-31T13:50:57+01:00 New Revision: 9a6b0afbe18d3abdc17d6208daecb8839b994e4a URL: https://github.com/llvm/llvm-project/commit/9a6b0afbe18d3abdc17d6208daecb8839b994e4a DIFF: https://github.com/llvm/llvm-project/commit/9a6b0afbe18d3abdc17d6208daecb8839b994e4a.dif

Re: [Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

Hi I just wanted to say Thanks Rachel Lane 07459167844 > On 29 Jan 2022, at 10:57, Simon Pilgrim via Phabricator via lldb-commits > wrote: > > This revision was landed with ongoing or failed builds. > This revision was automatically updated to reflect the committed changes. > Closed by commi

Re: [Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

Rachel Lane 07459167844 > On 29 Jan 2022, at 10:57, Simon Pilgrim via Phabricator via lldb-commits > wrote: > > This revision was landed with ongoing or failed builds. > This revision was automatically updated to reflect the committed changes. > Closed by commit rG058c5dfc78cd: Raise the min

Re: [PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

Sorry i just noticed this email. I will take a look next week. On Sun, Jan 30, 2022, 2:50 AM Simon Pilgrim via Phabricator < revi...@reviews.llvm.org> wrote: > RKSimon added inline comments. > > > > Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1534 >}

[PATCH] D118428: [clang-cl] Support the /JMC flag

hans added a comment. This is great stuff, thanks! Comment at: clang/docs/ReleaseNotes.rst:155 +- Add support for MSVC-compatible ``/JMC``/``/JMC-`` flag in clang-cl, and + equivalent -cc1 flag ``-fjmc``. ``/JMC`` could only be used when ``/Zi`` or + ``/Z7`` is turned on. Wi

[PATCH] D118493: [WIP]Set rpath on openmp executables

JonChesterfield updated this revision to Diff 404496. JonChesterfield added a comment. - Test rpath and runpath setting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118493/new/ https://reviews.llvm.org/D118493 Files: clang/include/clang/Driver/

[PATCH] D118493: [WIP]Set rpath on openmp executables

JonChesterfield updated this revision to Diff 404497. JonChesterfield added a comment. - composes with user specified rpath flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118493/new/ https://reviews.llvm.org/D118493 Files: clang/include/cla

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield updated this revision to Diff 404498. JonChesterfield added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. - Disable implicit rpath for the tests so we can be certain the tests aren't picking up unrelated libs Repository: rG LLVM Github M

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield updated this revision to Diff 404499. JonChesterfield added a comment. - rebase and format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118493/new/ https://reviews.llvm.org/D118493 Files: clang/include/clang/Driver/Options.td

[PATCH] D118428: [clang-cl] Support the /JMC flag

aganea added inline comments. Comment at: clang/docs/ReleaseNotes.rst:155 +- Add support for MSVC-compatible ``/JMC``/``/JMC-`` flag in clang-cl, and + equivalent -cc1 flag ``-fjmc``. ``/JMC`` could only be used when ``/Zi`` or + ``/Z7`` is turned on. With this addition, clang

[PATCH] D118592: [cte] Add release notes for clangd-14

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks for taking care of this! Comment at: clang-tools-extra/docs/ReleaseNotes.rst:54 + +- Diagnostics and fixes for unused include directives, according to IWYU style.

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b1e844b69f1: [ARM] Add Cortex-X1C Support for Clang and LLVM (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117202/new/ https://reviews

[PATCH] D118471: [clang][Lexer] Make raw and normal lexer behave the same for line comments

sammccall added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:2387 // unit. LangOpts.LineComment = true; } It's much less obvious what this does in raw lexing mode. My rough understanding is raw lexing mode is ~stateless and we may choose to

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. In D118104#3279654 , @njames93 wrote: > In D118104#3279524 , @JesApp wrote: > >> I can (re)start a build manually. Let's see how that goes, before we start >> doing workarounds like that.

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

erichkeane added a comment. I'm down to 1 little thing in how we handle the attribute itself, and I think @aaron.ballman understands the parsing section better than I do... Comment at: clang/lib/Parse/ParseDecl.cpp:386 ArgsVector ArgExprs; if (Tok.is(tok::identifier)) {

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1760 + for (StringRef OffloadObject : CGOpts.OffloadObjects) { +auto FilenameAndSection = OffloadObject.split(','); +llvm::ErrorOr> ObjectOrErr = Could we have a type he

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1771 +SmallString<128> SectionName( +{".llvm.offloading.", std::get<1>(FilenameAndSection)}); +llvm::EmbedBufferInModule(*M, **ObjectOrErr, SectionName); OK, so o

[PATCH] D118592: [cte] Add release notes for clangd-14

kadircet updated this revision to Diff 404503. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118592/new/ https://reviews.llvm.org/D118592 Files: clang-tools-

[PATCH] D118471: [clang][Lexer] Make raw and normal lexer behave the same for line comments

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Lex/Lexer.cpp:2387 // unit. LangOpts.LineComment = true; } sammccall wrote: > It's much less obvious what this d

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1760 + for (StringRef OffloadObject : CGOpts.OffloadObjects) { +auto FilenameAndSection = OffloadObject.split(','); +llvm::ErrorOr> ObjectOrErr = JonChesterfield wrote:

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen marked 2 inline comments as done. steffenlarsen added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:386 ArgsVector ArgExprs; if (Tok.is(tok::identifier)) { // If this attribute wants an 'identifier' argument, make it so. eric

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

jhuber6 updated this revision to Diff 404506. jhuber6 added a comment. Add error handling routine to ensure that the embedding string is always a pair separated by a single ','. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116542/new/ https://rev

[PATCH] D116543: [OpenMP] Embed device files into the host IR

JonChesterfield added a comment. Description and test have slightly diverged from implementation - filename is appended to disambiguate, but the filecheck regex only looks at the prefix and the name described in the commit message is missing the filename Repository: rG LLVM Github Monorepo

[PATCH] D116543: [OpenMP] Embed device files into the host IR

jhuber6 added a comment. In D116543#3283874 , @JonChesterfield wrote: > Description and test have slightly diverged from implementation - filename is > appended to disambiguate, but the filecheck regex only looks at the prefix > and the name described

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks for sticking with me on this! LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116542/new/ https://reviews.llvm.org/D11

[PATCH] D118592: [cte] Add release notes for clangd-14

tschuett added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:65 + +- New semantic hihlighting kinds for: + - Virtual methods highlighting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118592

[PATCH] D116544: [Clang] Introduce Clang Linker Wrapper Tool

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I think this is reasonable. It's a lot of boilerplate to put the interception shim in the right place, but we do want a specific point to inject offloading functionality and

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: Naghasan, ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. OpenCL

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov updated this revision to Diff 404511. azabaznov added a comment. Remove no longer required comment in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 Files: clang/include/clang/Basic

[clang] ff77071 - [clang][Lexer] Make raw and normal lexer behave the same for line comments

Author: Kadir Cetinkaya Date: 2022-01-31T16:15:16+01:00 New Revision: ff77071a4d672fab7c8b30bea8525b89be8596fc URL: https://github.com/llvm/llvm-project/commit/ff77071a4d672fab7c8b30bea8525b89be8596fc DIFF: https://github.com/llvm/llvm-project/commit/ff77071a4d672fab7c8b30bea8525b89be8596fc.dif

[PATCH] D116543: [OpenMP] Embed device files into the host IR

jhuber6 updated this revision to Diff 404513. jhuber6 added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116543/new/ https://reviews.llvm.org/D116543 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/openmp-of

[PATCH] D118471: [clang][Lexer] Make raw and normal lexer behave the same for line comments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kadircet marked 2 inline comments as done. Closed by commit rGff77071a4d67: [clang][Lexer] Make raw and normal lexer behave the same for line comments (authored by kadi

[PATCH] D118592: [cte] Add release notes for clangd-14

kadircet updated this revision to Diff 404515. kadircet added a comment. - Fix spelling of `highlighting` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118592/new/ https://reviews.llvm.org/D118592 Files: clang-tools-extra/docs/ReleaseNotes.rst

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

Eugene.Zelenko added a comment. Sure, this is important improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118520/new/ https://reviews.llvm.org/D118520 ___ cfe-commits mailing list cfe-commits@li

[clang-tools-extra] 236458e - [cte] Add release notes for clangd-14

Author: Kadir Cetinkaya Date: 2022-01-31T16:32:25+01:00 New Revision: 236458ef0298a5e078cabe775ed6884b1332426c URL: https://github.com/llvm/llvm-project/commit/236458ef0298a5e078cabe775ed6884b1332426c DIFF: https://github.com/llvm/llvm-project/commit/236458ef0298a5e078cabe775ed6884b1332426c.dif

[PATCH] D118592: [cte] Add release notes for clangd-14

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG236458ef0298: [cte] Add release notes for clangd-14 (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:386 ArgsVector ArgExprs; if (Tok.is(tok::identifier)) { // If this attribute wants an 'identifier' argument, make it so. steffenlarsen wrote: > erichkeane wrote: > > So does

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield added inline comments. Comment at: clang/test/OpenMP/implicit_rpath.c:28 +// CHECK-COMPOSABLE: ({{R|RUN}}PATH) Library {{r|run}}path: [early:late:{{.*}}llvm/lib] + +int main() {} This ^ probably has path separator issues on windows, will try to f

[PATCH] D118608: [NFC] Increase initial size of FoldingSets used in ASTContext and CodeGenTypes

yurai007 created this revision. yurai007 added reviewers: nikic, xbolva00, aeubanks, ChuanqiXu, v.g.vassilev, serge-sans-paille. yurai007 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Among many FoldingSet users most notable seem to be A

[PATCH] D118493: Set rpath on openmp executables

jhuber6 added inline comments. Comment at: clang/test/OpenMP/implicit_rpath.c:28 +// CHECK-COMPOSABLE: ({{R|RUN}}PATH) Library {{r|run}}path: [early:late:{{.*}}llvm/lib] + +int main() {} JonChesterfield wrote: > This ^ probably has path separator issues on windo

[PATCH] D118493: Set rpath on openmp executables

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM, unless someone else has reservations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118493/new/ https://reviews.llvm.org/D118493 __

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen updated this revision to Diff 404526. steffenlarsen added a comment. Removed unnecessary test for arguments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/ https://reviews.llvm.org/D114439 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/D

[PATCH] D116975: [OpenMP] Initial Implementation of LTO and bitcode linking in linker wrapper

jhuber6 updated this revision to Diff 404528. jhuber6 added a comment. Moving adding OpenMPOpt to LTO pipeline to a new patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116975/new/ https://reviews.llvm.org/D116975 Files: clang/lib/Driver/Dri

[PATCH] D118609: Remove redundant LLVM_HAS_RVALUE_REFERENCE_THIS and LLVM_LVALUE_FUNCTION defines

RKSimon created this revision. RKSimon added reviewers: rnk, aaron.ballman, zturner, jhenderson. Herald added a subscriber: dexonsmith. RKSimon requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Now that VS2017 support has been dropped (D

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield added a comment. Yep. I'm not totally confident what windows builds will embed in the dynamic table - might be windows style \ or it might be linux style /. Or it might be \\, which can be matched as in D109057 . I think I'm going with the very

[PATCH] D118542: [Clang][OpenMPIRBuilder] Fix off-by-one error when dividing by stepsize.

Meinersbur added a comment. Pre-merge failures are unrelated. See https://github.com/llvm/llvm-project/issues/53467 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118542/new/ https://reviews.llvm.org/D118542 ___

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4202 + // If the first argument is value dependent we delay setting the arguments. + if (AllArgs.size() && AllArgs[0]->isValueDependent()) { +auto *Attr = AnnotateAttr::CreateWithDelayedArgs( -

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield updated this revision to Diff 404536. JonChesterfield added a comment. - More paranoid regex - not sure what windows uses as the path separator in the dynamic table Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118493/new/ https://

[clang] a80d5c3 - Set rpath on openmp executables

Author: Jon Chesterfield Date: 2022-01-31T16:01:08Z New Revision: a80d5c34e4b99f21fa371160ac7eb7e9db093997 URL: https://github.com/llvm/llvm-project/commit/a80d5c34e4b99f21fa371160ac7eb7e9db093997 DIFF: https://github.com/llvm/llvm-project/commit/a80d5c34e4b99f21fa371160ac7eb7e9db093997.diff L

[PATCH] D118493: Set rpath on openmp executables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa80d5c34e4b9: Set rpath on openmp executables (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D117390: [AST] Reformat CastExpr unittest suite

aaron.ballman accepted this revision. aaron.ballman added a comment. The NFC changes LGTM! What name and email address would you like me to use for patch attribution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117390/new/ https://reviews.llvm.o

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

sbc100 added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:448 +addSystemInclude(DriverArgs, CC1Args, + getDriver().SysRoot + "/include/c++/11"); +break; tbaeder wrote: > sbc100 wrote: > > Where does `11` com

[PATCH] D117391: [AST] Ignore implicit nodes in CastExpr::getConversionFunction

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. I think the changes here look reasonable, though I think it can be simplified a bit. Comment at: clang/lib/AST/Expr.cpp:1946-1947 for (const CastExpr *E = this; E; E = dyn_cast(SubExpr)) { Su

[clang] a841a3a - Revert "Set rpath on openmp executables"

Author: Jon Chesterfield Date: 2022-01-31T16:18:03Z New Revision: a841a3a5791dc653567b48593a6b99b9db2748bb URL: https://github.com/llvm/llvm-project/commit/a841a3a5791dc653567b48593a6b99b9db2748bb DIFF: https://github.com/llvm/llvm-project/commit/a841a3a5791dc653567b48593a6b99b9db2748bb.diff L

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. It looks like this is probably the first time that a test was written for a PLUGIN_TOOL, outside of the docs, so we are likely in new territory here :/ There seem to be a couple of paths forward: 1. disable the PLUGIN_TOOL option in cmake if the user has disabled the he

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Tweak.h:85 +/// Merge the replacement's edit in the file corresponding to Loc. +/// Fails if we cannot figure out the absolute path for the corresponding I don't think mergin

[clang] 9b9d081 - Set rpath on openmp executables

Author: Jon Chesterfield Date: 2022-01-31T16:35:00Z New Revision: 9b9d08111b618d74574ba03e5cc3d752ecc56f55 URL: https://github.com/llvm/llvm-project/commit/9b9d08111b618d74574ba03e5cc3d752ecc56f55 DIFF: https://github.com/llvm/llvm-project/commit/9b9d08111b618d74574ba03e5cc3d752ecc56f55.diff L

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield added a comment. Apologies for the noise, turns out 'llvm/lib' and 'llvm/lib64' are not the only two options. Made it more permissive and reapplied. Also looks like ppc64le defaults to rpath as opposed to runpath, so that's worth knowing. Repository: rG LLVM Github Monorepo

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. ro wrote: > ro wrote: > > glaubitz wrote: > > > ro wrote: >

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen updated this revision to Diff 404548. steffenlarsen added a comment. Adds check and diagnostic for no arguments in annotate attribute. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/ https://reviews.llvm.org/D114439 Files: clang/include/clang/Basic/Attr.td c

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4202 + // If the first argument is value dependent we delay setting the arguments. + if (AllArgs.size() && AllArgs[0]->isValueDependent()) { +auto *Attr = AnnotateAttr::CreateWithDelayedArgs( -

  1   2   3   >