svenvh added inline comments.
================ Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:73 #if (defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= 200) +#define __opencl_c_generic_address_space 1 #define cl_khr_subgroup_extended_types 1 ---------------- Anastasia wrote: > btw this is not correct for C++ for OpenCL 2021 but we are not testing this > with C++ for OpenCL 2021 which we should. > > However it doesn't belong to this patch, but would you be able to add a FIXME > here to indicate the issue? I'll add C++ for OpenCL 2021 (and CL3.0) testing in a separate commit. As discussed offline, we are likely to drop headerless testing from here soonish, since we're relying more and more on opencl-c-base.h for `-fdeclare-opencl-builtins`. We essentially have to redefine all the feature macros in the test too, when they're already in the header that we're deliberately excluding. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107769/new/ https://reviews.llvm.org/D107769 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
