[PATCH] D117929: [XRay] Add support for RISCV

jrtc27 added inline comments. Comment at: compiler-rt/lib/xray/xray_riscv.cpp:122-123 + //lui t2, %highest(__xray_FunctionEntry/Exit) + //slli t2, t2, 32 ;lui sign extends values + //srli t2, t2, 32 ;

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon added a comment. In D116778#3276421 , @aaron.ballman wrote: > In D116778#3259189 , > @MuAlphaOmegaEpsilon wrote: > >> In D116778#3255414 , >> @aaron

[clang] 9be5f4d - [clang] Don't typo-fix an expression in a SFINAE context.

Author: Arthur O'Dwyer Date: 2022-01-27T14:21:50-05:00 New Revision: 9be5f4d5afd9a1b6e88a268f6ea6eb282d77d9fe URL: https://github.com/llvm/llvm-project/commit/9be5f4d5afd9a1b6e88a268f6ea6eb282d77d9fe DIFF: https://github.com/llvm/llvm-project/commit/9be5f4d5afd9a1b6e88a268f6ea6eb282d77d9fe.diff

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

This revision was automatically updated to reflect the committed changes. Closed by commit rG9be5f4d5afd9: [clang] Don't typo-fix an expression in a SFINAE context. (authored by arthur.j.odwyer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117603/n

[PATCH] D105876: OMPIRBuilder for Interop directive

tianshilei1992 updated this revision to Diff 403737. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files: clang/lib/CodeGen/CGStmt.cpp clang/lib/CodeGen/CGStmt

[PATCH] D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default

stevewan added inline comments. Comment at: clang/test/ClangScanDeps/headerwithdirname.cpp:16 -// CHECK: headerwithdirname_input.o +// CHECK: headerwithdirname_input{{.*}}{{.o|.s}} // CHECK-NEXT: headerwithdirname_input.cpp Jake-Egan wrote: > jansvoboda11 wrot

[clang] 5aa2455 - OMPIRBuilder for Interop directive

Author: Sri Hari Krishna Narayanan Date: 2022-01-27T14:53:18-05:00 New Revision: 5aa24558cfa67e2a2e99c4e9c6d6b68bf372e00e URL: https://github.com/llvm/llvm-project/commit/5aa24558cfa67e2a2e99c4e9c6d6b68bf372e00e DIFF: https://github.com/llvm/llvm-project/commit/5aa24558cfa67e2a2e99c4e9c6d6b68bf

[PATCH] D105876: OMPIRBuilder for Interop directive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5aa24558cfa6: OMPIRBuilder for Interop directive (authored by sriharikrishna, committed by tianshilei1992). Repository: rG LLVM Github Monorepo C

[PATCH] D118399: [OpenMP] Introduce new flag to indicate OpenMP runtime compilation

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield. Herald added subscribers: dexonsmith, dang, guansong, yaxunl, mgorny. jhuber6 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added projects

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish updated this revision to Diff 403746. snehasish added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115393/new/ https://reviews.llvm.org/D115393 Files: llvm/include/llvm/ProfileData/InstrProf.h llvm/include/llvm/Pr

[PATCH] D118399: [OpenMP] Introduce new flag to indicate OpenMP runtime compilation

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118399/new/ https://reviews.llvm.org/D118399 ___

[PATCH] D118153: [CUDA][HIP] Do not treat host var address as constant in device compilation

tra added a subscriber: rsmith. tra added a comment. @rsmith -- is there anything else we need to worry about when it comes to treating pointers as constant values (or not)? Comment at: clang/lib/AST/ExprConstant.cpp:2227 +!Var->hasAttr() && +!Var->hasA

[PATCH] D106674: Runtime for Interop directive

tianshilei1992 updated this revision to Diff 403750. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106674/new/ https://reviews.llvm.org/D106674 Files: openmp/libomptarget/include/interop.h openmp/libompta

[PATCH] D106674: Runtime for Interop directive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf44e41af4121: Runtime for Interop directive (authored by sriharikrishna, committed by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D118402: [C2x][ObjC] Do not crash when trying to encode a _BitInt type

aaron.ballman created this revision. aaron.ballman added reviewers: rjmccall, ahatanak, erichkeane. aaron.ballman requested review of this revision. Herald added a project: clang. Using a `_BitInt` (or `_ExtInt`) type as a block parameter or block return type hits an "unreachable" when trying to

[clang-tools-extra] 4cb1686 - [clangd] Fix a selection tree crash for unmatched-bracket code.

Author: Haojian Wu Date: 2022-01-27T21:21:40+01:00 New Revision: 4cb1686bfe8ef847b583922bb5650c33453ad096 URL: https://github.com/llvm/llvm-project/commit/4cb1686bfe8ef847b583922bb5650c33453ad096 DIFF: https://github.com/llvm/llvm-project/commit/4cb1686bfe8ef847b583922bb5650c33453ad096.diff LO

[PATCH] D118322: [clangd] Fix a selection tree crash for unmatched-bracket code.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cb1686bfe8e: [clangd] Fix a selection tree crash for unmatched-bracket code. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D118322?vs=403516&id=403753#toc Repository: rG LL

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

aaron.ballman added a comment. Ping @jyknight -- I'd like to get this in before the Clang 14 branch, if possible. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117238/new/ https://reviews.llvm.org/D117238 ___ cfe-commits mailing list cfe-com

[PATCH] D118402: [C2x][ObjC] Do not crash when trying to encode a _BitInt type

erichkeane added a comment. These seems right to me, but I think @rjmccall knows more about ObjC to make sure nothing silly is happening here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118402/new/ https://reviews.llvm.org/D118402

[PATCH] D118399: [OpenMP] Introduce new flag to indicate OpenMP runtime compilation

tianshilei1992 added a comment. Do we have an alternative w/o need to add a flag dedicated for building a very specific target, OpenMP device runtime? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118399/new/ https://reviews.llvm.org/D118399

[PATCH] D118399: [OpenMP] Introduce new flag to indicate OpenMP runtime compilation

jhuber6 added a comment. In D118399#3277221 , @tianshilei1992 wrote: > Do we have an alternative w/o need to add a flag dedicated for building a > very specific target, OpenMP device runtime? The only difference between building the OpenMP device runti

[clang-tools-extra] 0cf75aa - [clangd] Enable hover on character literal.

Author: Haojian Wu Date: 2022-01-27T21:22:03+01:00 New Revision: 0cf75aac42eb6bd800405d152dfe7414a9ab6d99 URL: https://github.com/llvm/llvm-project/commit/0cf75aac42eb6bd800405d152dfe7414a9ab6d99 DIFF: https://github.com/llvm/llvm-project/commit/0cf75aac42eb6bd800405d152dfe7414a9ab6d99.diff LO

[PATCH] D117864: [clangd] Enable hover on character literal.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG0cf75aac42eb: [clangd] Enable hover on character literal. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D118399: [OpenMP] Introduce new flag to indicate OpenMP runtime compilation

jhuber6 added a comment. In D118399#3277222 , @jhuber6 wrote: > In D118399#3277221 , > @tianshilei1992 wrote: > >> Do we have an alternative w/o need to add a flag dedicated for building a >> very specific targe

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 403760. lichray added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/AST/Pre

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

MaskRay added a comment. In D117744#3275226 , @labath wrote: > This (unsurprisingly) broke an lldb test for the gnu style compression. You > didn't get the notification because the bot was already red at the time. I've > already fixed the situation by c

[PATCH] D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default

Jake-Egan updated this revision to Diff 403761. Jake-Egan added a comment. Updated patch to use a more accurate check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118152/new/ https://reviews.llvm.org/D118152 Files: clang/test/ClangScanDeps/hea

[PATCH] D118399: [OpenMP] Only generate runtime flags with host input

jhuber6 updated this revision to Diff 403762. jhuber6 added a comment. Changing to use host bitcode instead of adding a new flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118399/new/ https://reviews.llvm.org/D118399 Files: clang/lib/CodeGen

[PATCH] D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default

Jake-Egan updated this revision to Diff 403763. Jake-Egan added a comment. Fixed diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118152/new/ https://reviews.llvm.org/D118152 Files: clang/test/ClangScanDeps/headerwithdirname.cpp clang/test/

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG13d89477be56: [InstrProf][NFC] Refactor Profile kind into a bitset enum. (authored by snehasish). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D118399: [OpenMP] Only generate runtime flags with host input

ABataev added a comment. Tests, if possible? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118399/new/ https://reviews.llvm.org/D118399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

rsmith added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1890 - bool FieldPacked = Packed || D->hasAttr(); + llvm::Triple Target = Context.getTargetInfo().getTriple(); + bool FieldPacked = (Packed && (!FieldClass || FieldClass->isPOD() || -

[PATCH] D118399: [OpenMP] Only generate runtime flags with host input

JonChesterfield added a comment. There's an existing flag for compile for device only, that's probably close enough to the right condition to not emit these flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118399/new/ https://reviews.llvm.org/

[PATCH] D118399: [OpenMP] Only generate runtime flags with host input

jhuber6 added a comment. In D118399#3277328 , @ABataev wrote: > Tests, if possible? The flags being generated should be covered by an existing test, I'll add a line where we don't specify a bitcode library. In D118399#3277357

[PATCH] D118399: [OpenMP] Only generate runtime flags with host input

jhuber6 updated this revision to Diff 403775. jhuber6 added a comment. Adding test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118399/new/ https://reviews.llvm.org/D118399 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/test/OpenMP/tar

[clang-tools-extra] 15dfe7a - [clangd] Fix a typo , => ; in hovertest.

Author: Haojian Wu Date: 2022-01-27T22:19:09+01:00 New Revision: 15dfe7a3f12c4862999e275195a14ef746ab975a URL: https://github.com/llvm/llvm-project/commit/15dfe7a3f12c4862999e275195a14ef746ab975a DIFF: https://github.com/llvm/llvm-project/commit/15dfe7a3f12c4862999e275195a14ef746ab975a.diff LO

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

mtrofin added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProfReader.h:495 + InstrProfKind getProfileKind() const override { +InstrProfKind ProfileKind = InstrProfKind::Unknown; This looks a lot like line 290, can it be refactored (or a

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

ellis added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProf.h:284-287 + FE = 0x1, // A frontend clang profile, incompatible with other attrs. + IR = 0x2, // An IR-level profile (default when -fprofile-generate is used). + BB = 0x4, // A profile with entry

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

zoecarver added a comment. This patch looks awesome, Chris. Does it make sense to have builtins for `add_const`, etc.? Isn't `T const` already kind of a builtin for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://reviews.l

[clang] 63cf206 - [NFC][Clang][OpaquePtr] Move away from deprecated Address constructor in EmitNewArrayInitializer()

Author: Arthur Eubanks Date: 2022-01-27T14:00:16-08:00 New Revision: 63cf2063a20bf051b7d7d748311b0e0c426a56c1 URL: https://github.com/llvm/llvm-project/commit/63cf2063a20bf051b7d7d748311b0e0c426a56c1 DIFF: https://github.com/llvm/llvm-project/commit/63cf2063a20bf051b7d7d748311b0e0c426a56c1.diff

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

bmahjour added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:386 + if (TM.getOptLevel() == CodeGenOpt::Aggressive){ +setOperationAction(ISD::FSIN , MVT::f64, Custom); +setOperationAction(ISD::FCOS , MVT::f64, Custom); what abou

[libunwind] cd20e57 - [unwind] fix build with GCC on PPC32

Author: Sam James Date: 2022-01-27T23:05:11+01:00 New Revision: cd20e579df07517a4ddbf6eef58b96d04f6bd9a9 URL: https://github.com/llvm/llvm-project/commit/cd20e579df07517a4ddbf6eef58b96d04f6bd9a9 DIFF: https://github.com/llvm/llvm-project/commit/cd20e579df07517a4ddbf6eef58b96d04f6bd9a9.diff LOG

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra updated this revision to Diff 403801. amilendra added a comment. Fix clang-format errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115501/new/ https://reviews.llvm.org/D115501 Files: clang/include/clang/Basic/DiagnosticCommonKinds

[clang] f171238 - [NFC][Clang][OpaquePtr] Move away from deprecated Address constructor in CreateTempAlloca()

Author: Arthur Eubanks Date: 2022-01-27T14:18:54-08:00 New Revision: f17123831e47073f7850ea17560bc1f756b65298 URL: https://github.com/llvm/llvm-project/commit/f17123831e47073f7850ea17560bc1f756b65298 DIFF: https://github.com/llvm/llvm-project/commit/f17123831e47073f7850ea17560bc1f756b65298.diff

[libunwind] 11c2ef5 - unwind: fix typo for __powerpc__

Author: Sam James Date: 2022-01-27T23:21:07+01:00 New Revision: 11c2ef5638c3cff489744f1d342cd92e2a864614 URL: https://github.com/llvm/llvm-project/commit/11c2ef5638c3cff489744f1d342cd92e2a864614 DIFF: https://github.com/llvm/llvm-project/commit/11c2ef5638c3cff489744f1d342cd92e2a864614.diff LOG

[clang] f9a00b3 - Revert "[clang] Don't typo-fix an expression in a SFINAE context."

Author: Arthur O'Dwyer Date: 2022-01-27T17:36:08-05:00 New Revision: f9a00b3cbc580cf79688fa813c6e898e90b4fd43 URL: https://github.com/llvm/llvm-project/commit/f9a00b3cbc580cf79688fa813c6e898e90b4fd43 DIFF: https://github.com/llvm/llvm-project/commit/f9a00b3cbc580cf79688fa813c6e898e90b4fd43.diff

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

Quuxplusone reopened this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. I'm not sure if this caused https://lab.llvm.org/buildbot/#/builders/60/builds/6350 https://lab.llvm.org/buildbot/#/builders/119/builds/7433 but I'm acting as if it did. Anyone see ho

[clang] 6e8a66b - [NFC][Clang][OpaquePtr] Move away from deprecated Address constructor in EmitCXXMemberDataPointerAddress()

Author: Arthur Eubanks Date: 2022-01-27T14:44:53-08:00 New Revision: 6e8a66bdad59d7e1bd87528c0fbefc88ae761ca2 URL: https://github.com/llvm/llvm-project/commit/6e8a66bdad59d7e1bd87528c0fbefc88ae761ca2 DIFF: https://github.com/llvm/llvm-project/commit/6e8a66bdad59d7e1bd87528c0fbefc88ae761ca2.diff

[clang] 662ef6d - [NFC][Clang][OpaquePtr] Move away from deprecated Address constructor in VisitArrayInitLoopExpr

Author: Arthur Eubanks Date: 2022-01-27T14:44:53-08:00 New Revision: 662ef6d177fe8eec7f88f523293eec44f238a2aa URL: https://github.com/llvm/llvm-project/commit/662ef6d177fe8eec7f88f523293eec44f238a2aa DIFF: https://github.com/llvm/llvm-project/commit/662ef6d177fe8eec7f88f523293eec44f238a2aa.diff

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.h:29 + : ClangTidyCheck(Name, Context), +AnalyzeValues(Options.get("AnalyzeValues", 1)), +AnalyzeReferences(Options.get("AnalyzeReferences", 1)),

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

iana added inline comments. Comment at: clang/docs/Modules.rst:651 + +requires cplusplus { + header "vector" Is there any kind of `else` syntax here? Or do you just use `!whatever` for the else? Is something like this valid? ``` requires cplusplus11 {

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

Bigcheese added inline comments. Comment at: clang/docs/Modules.rst:651 + +requires cplusplus { + header "vector" iana wrote: > Is there any kind of `else` syntax here? Or do you just use `!whatever` for > the else? Is something like this valid? > > ``

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

iana added inline comments. Comment at: clang/docs/Modules.rst:651 + +requires cplusplus { + header "vector" Bigcheese wrote: > iana wrote: > > Is there any kind of `else` syntax here? Or do you just use `!whatever` for > > the else? Is something like t

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 403815. void added a comment. WIP: Updated to make selecing registers to zero out more generic. Combined a few tests into one, and made the logic emitting the "xors" a bit nicer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] 2945f11 - [OpenMP] Only generate runtime flags with host input

Author: Joseph Huber Date: 2022-01-27T18:43:41-05:00 New Revision: 2945f11c605b059446ac997f62458a6c489e46f7 URL: https://github.com/llvm/llvm-project/commit/2945f11c605b059446ac997f62458a6c489e46f7 DIFF: https://github.com/llvm/llvm-project/commit/2945f11c605b059446ac997f62458a6c489e46f7.diff

[PATCH] D118399: [OpenMP] Only generate runtime flags with host input

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2945f11c605b: [OpenMP] Only generate runtime flags with host input (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie updated this revision to Diff 403825. dblaikie marked 3 inline comments as done. dblaikie added a comment. rsmith's fixes for release notes added some more test coverage to demonstrate that other fields are still packed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1891 + llvm::Triple Target = Context.getTargetInfo().getTriple(); + bool FieldPacked = (Packed && (!FieldClass || FieldClass->isPOD() || + Context.getLangOpts().get

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1891 + llvm::Triple Target = Context.getTargetInfo().getTriple(); + bool FieldPacked = (Packed && (!FieldClass || Fie

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie added a comment. Will wait on this 'til next Monday at least. Wouldn't mind a double-check/confirmation from @rjmccall that the Darwin checking is suitable (since I didn't see any other Darwin checking in RecordLayoutBuilder). Comment at: clang/lib/AST/RecordLayoutBu

[PATCH] D117622: cleanups from 1b1c8d83d3567a60280291c0adb95d1d60335509

vitalybuka added a comment. I recommend to delay this from some time until we sure it's not going to be reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117622/new/ https://reviews.llvm.org/D117622 _

[PATCH] D117622: cleanups from 1b1c8d83d3567a60280291c0adb95d1d60335509

vitalybuka added inline comments. Comment at: compiler-rt/test/msan/noundef_analysis.cpp:5 // RUN: FileCheck %s < %t.out -// RUN: %clangxx_msan %s -disable-noundef-analysis -s -fsanitize-memory-param-retval -o %t && not %run %t >%t.out 2>&1 +// RUN: %clangxx_msan %s -disable-no

[PATCH] D112915: [clang][modules] Track included files per submodule

vsapsai added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:1251-1260 + const IncludedFilesSet *getNullSubmoduleIncludes() const { +auto It = IncludedFilesPerSubmodule.find(nullptr); +return It == IncludedFilesPerSubmodule.end() ? nullptr : &It->sec

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

rjmccall added a comment. Yes, I think that's an okay way to check this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117616/new/ https://reviews.llvm.org/D117616 ___ cfe-commits mailing list cfe-commit

[PATCH] D118070: Add /winsysroot support to lld

thakis added a comment. This looks super nice. Things that can still improve: 1. This now does way more than just /winsysroot:. It also makes it so that lld-link works in a non-msvc shell by looking up libpaths in either registry or via setup api. 2. Some of the new lld-link code still looks (

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

ChuanqiXu added a comment. The problem looks similar with what we met in: https://github.com/llvm/llvm-project/issues/52909#issuecomment-1021631943 Maybe both of the problem could be solved at the same time. > Anyone see how this patch might have caused a placeholder type to survive > into mang

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 403857. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. - Fixed formatting - Fixed test case - Check for when Arg is nullptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

jacquesguan updated this revision to Diff 403858. jacquesguan added a comment. Update code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118225/new/ https://reviews.llvm.org/D118225 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/CodeGen/R

[clang] 232c601 - [Driver] Update clang -B help message

Author: Fangrui Song Date: 2022-01-27T19:05:10-08:00 New Revision: 232c601676a2940934d037b8c38efc24a2e269b1 URL: https://github.com/llvm/llvm-project/commit/232c601676a2940934d037b8c38efc24a2e269b1 DIFF: https://github.com/llvm/llvm-project/commit/232c601676a2940934d037b8c38efc24a2e269b1.diff

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:296 - $ cmake -G "Visual Studio 15 2017 Win64" -Thost=x64 + $ cmake -G "Visual Studio 16 2019 Win64" -Thost=x64 This line should change a bit more. For VS2019, it also nee

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito updated this revision to Diff 403861. psigillito marked 8 inline comments as done. psigillito added a comment. - Merge branch 'main' of https://github.com/llvm/llvm-project - code review syntax cleanup, sorted vector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito updated this revision to Diff 403862. psigillito marked 2 inline comments as done. psigillito added a comment. - revert auto formatting comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416

[PATCH] D117717: [clang] Ignore -fconserve-stack

nathanchance abandoned this revision. nathanchance added a comment. As discussed, this is not the right fix for the issue. I have just gone ahead and told the original reporter to use `scan-build` with the `--use-cc=clang` flag to avoid these issues. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen created this revision. ychen added reviewers: rnk, aganea, hans. Herald added subscribers: ormris, dexonsmith, dang, pengfei, hiraditya, mgorny. ychen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The introduction

[PATCH] D118095: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 403867. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ https://reviews.llvm.org/D118095 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Dr

[PATCH] D118095: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:393 + if (FamilyName.hasValue() && + (FamilyName->equals("avr1") || FamilyName->equals("avrtiny"))) { +// Only '-x assembler-with-cpp' or '-x assembler' is allowed for avr1. ---

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen updated this revision to Diff 403870. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118428/new/ https://reviews.llvm.org/D118428 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/CodeGenOptions.

[PATCH] D118361: clang-format: [JS] sort import aliases.

vitalybuka added a comment. After this patch https://lab.llvm.org/buildbot/#/builders/74/builds/9049/steps/15/logs/stdio Note: Google Test filter = SortImportsTestJS.ImportEqAliases [==] Running 1 test from 1 test suite. [--] Global test environment set-up. [--] 1

[clang] f750c3d - Revert "clang-format: [JS] sort import aliases."

Author: Vitaly Buka Date: 2022-01-27T21:16:53-08:00 New Revision: f750c3d95a0c8bf1d21380ae753fce12010a7561 URL: https://github.com/llvm/llvm-project/commit/f750c3d95a0c8bf1d21380ae753fce12010a7561 DIFF: https://github.com/llvm/llvm-project/commit/f750c3d95a0c8bf1d21380ae753fce12010a7561.diff L

[PATCH] D118361: clang-format: [JS] sort import aliases.

vitalybuka added a comment. reverted with f750c3d95a0c8bf1d21380ae753fce12010a7561 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118361/new/ https://reviews.llvm.org/D118361 __

[clang] 8cc23bd - [NFC] Mark the parameter const for isSame* methods in ASTContext

Author: Chuanqi Xu Date: 2022-01-28T13:56:19+08:00 New Revision: 8cc23bde264e6b19eb10784750cf1cf70bbb2475 URL: https://github.com/llvm/llvm-project/commit/8cc23bde264e6b19eb10784750cf1cf70bbb2475 DIFF: https://github.com/llvm/llvm-project/commit/8cc23bde264e6b19eb10784750cf1cf70bbb2475.diff LO

[PATCH] D118402: [C2x][ObjC] Do not crash when trying to encode a _BitInt type

rjmccall added a comment. I don't think you really need the FIXME when we don't have it for all the other types that we don't have encodings for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118402/new/ https://reviews.llvm.org/D118402 _

[PATCH] D118402: [C2x][ObjC] Do not crash when trying to encode a _BitInt type

rjmccall added a comment. But overall this seems fine, yeah. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118402/new/ https://reviews.llvm.org/D118402 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] 61528a7 - [NFC] Add tests for ODR checking of default template argument

Author: Chuanqi Xu Date: 2022-01-28T15:32:28+08:00 New Revision: 61528a77780e696a657b1a55de6bb48db7026245 URL: https://github.com/llvm/llvm-project/commit/61528a77780e696a657b1a55de6bb48db7026245 DIFF: https://github.com/llvm/llvm-project/commit/61528a77780e696a657b1a55de6bb48db7026245.diff LO

[PATCH] D118437: [NFC] [Modules] Refactor ODR checking for default template argument in ASTReader

ChuanqiXu created this revision. ChuanqiXu added reviewers: urnathan, erichkeane, aaron.ballman, rjmccall, rsmith. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. This patch tries to refactor ODR checking process for default t

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. Anyone have an idea why it's still building? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

<    1   2