mtrofin added inline comments.
================ Comment at: llvm/include/llvm/ProfileData/InstrProfReader.h:495 + InstrProfKind getProfileKind() const override { + InstrProfKind ProfileKind = InstrProfKind::Unknown; ---------------- This looks a lot like line 290, can it be refactored (or am I missing something?) ================ Comment at: llvm/lib/ProfileData/InstrProfWriter.cpp:337 uint64_t CSSummarySize = 0; - if (ProfileKind == PF_IRLevelWithCS) { + if (static_cast<bool>(ProfileKind & InstrProfKind::CS)) { CSSummaryOffset = OS.tell(); ---------------- consider adding helper APIs for test/set? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115393/new/ https://reviews.llvm.org/D115393 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits