[PATCH] D118322: [clangd] Fix a selection tree crash for unmatched-bracket code.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Wow, nice find! I'd argue the bug is probably rather in `TokenBuffer::expandedTokens(SourceRange)` that produced this span. The idea that it might *rarely* include the EOF token seems l

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

MyDeveloperDay added a comment. please mark your review comments as done when done so we know its a complete review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116638/new/ https://reviews.llvm.org/D116638 ___ cfe-commits mailing list cfe-c

[PATCH] D118224: [clang-tidy] bugprone-signal-handler improvements: display call chain

balazske updated this revision to Diff 403528. balazske marked an inline comment as done. balazske added a comment. Added assert, added test with function pointer, improved text message generation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1182

[PATCH] D118211: Add missing namespace to PPCLinux.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd71493ff060: Add missing namespace to PPCLinux.cpp (authored by glandium, committed by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHA

[clang] fd71493 - Add missing namespace to PPCLinux.cpp

Author: Mike Hommey Date: 2022-01-27T09:26:46+01:00 New Revision: fd71493ff0602d7d81763263df2f2074fe0db094 URL: https://github.com/llvm/llvm-project/commit/fd71493ff0602d7d81763263df2f2074fe0db094 DIFF: https://github.com/llvm/llvm-project/commit/fd71493ff0602d7d81763263df2f2074fe0db094.diff L

[PATCH] D118169: [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls

yurai007 added a comment. Thank you all for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118169/new/ https://reviews.llvm.org/D118169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D112774: Support k-ext clang intrinsics

liaolucy added a comment. Herald added a subscriber: pcwang-thead. The scalar crypto v1.0 builtins/intrinsics is still under discussion. Maybe we should wait for the final results？ Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

nikic added a comment. So this just forces you to change `-fno-experimental-new-pass-manager` to `-flegacy-pass-manager`? I'm not sure I see the point. Note that removal of middle-end LegacyPM functionality is currently blocked on https://reviews.llvm.org/D98481 landing, which prevents NewPM de

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

MaskRay added a comment. In D118313#3275059 , @nikic wrote: > So this just forces you to change `-fno-experimental-new-pass-manager` to > `-flegacy-pass-manager`? I'm not sure I see the point. > > Note that removal of middle-end LegacyPM functionality is

[PATCH] D115634: [clangd] Cleanup of readability-identifier-naming

kuhnel updated this revision to Diff 403538. kuhnel added a comment. Herald added a subscriber: aheejin. Re-created the patch as there were too many changes in the repo. Excluding gtest Matchers from naming checks as gtest convention does not match LLVM convention. Repository: rG LLVM Github

[PATCH] D116395: [Clang] Emit warning for -x option without effects

qiucf added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116395/new/ https://reviews.llvm.org/D116395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

tbaeder added a comment. I just noticed this as well. @arichardson, has there been any work towards a working solution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109611/new/ https://reviews.llvm.org/D109611 ___

[clang] 52fddcd - [clang-format] Format ParseOpenMP.cpp changes

Author: Saiyedul Islam Date: 2022-01-27T09:00:34Z New Revision: 52fddcdd9c90a550d7a50cbc2013be3314f91d08 URL: https://github.com/llvm/llvm-project/commit/52fddcdd9c90a550d7a50cbc2013be3314f91d08 DIFF: https://github.com/llvm/llvm-project/commit/52fddcdd9c90a550d7a50cbc2013be3314f91d08.diff LOG

[PATCH] D115634: [clangd] Cleanup of readability-identifier-naming

kuhnel updated this revision to Diff 403539. kuhnel marked an inline comment as done. kuhnel added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115634/new/ https://reviews.llvm.org/D115634 Files: .clang-tidy

[PATCH] D115634: [clangd] Cleanup of readability-identifier-naming

kuhnel marked 6 inline comments as done. kuhnel added inline comments. Comment at: clang-tools-extra/clangd/fuzzer/FuzzerClangdMain.cpp:15 +// NOLINTNEXTLINE(readability-identifier-naming) extern "C" int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size); ---

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp updated this revision to Diff 403541. JesApp marked 2 inline comments as done. JesApp added a comment. Resubmitting the same changes after rebasing onto current main. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 Files: clang-tools-

[PATCH] D118333: [RISCV] Update computeTargetABI implementation.

khchen created this revision. khchen added reviewers: craig.topper, jrtc27, frasercrmck, kito-cheng, arcbbb, monkchiang, eopXD. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, armkevincheng, eric-k256, vkmr, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

labath added a comment. This (unsurprisingly) broke an lldb test for the gnu style compression. You didn't get the notification because the bot was already red at the time. I've already fixed the situation by converting the test to yaml, but I thought you may want to know what happened. Repos

[PATCH] D118260: [clangd][Hover] Suppress initializers with many tokens

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Hover.cpp:131 +const syntax::TokenBuffer &TB) { + if (auto *VD = llvm::dyn_cast(D)) { +if (aut

[clang] b88ca61 - [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls

Author: Dawid Jurczak Date: 2022-01-27T10:57:48+01:00 New Revision: b88ca619d33bc74e1776d879e43c6fc812ac4ff5 URL: https://github.com/llvm/llvm-project/commit/b88ca619d33bc74e1776d879e43c6fc812ac4ff5 DIFF: https://github.com/llvm/llvm-project/commit/b88ca619d33bc74e1776d879e43c6fc812ac4ff5.diff

[PATCH] D118169: [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb88ca619d33b: [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls (authored by yurai007). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

fhahn added a comment. Does this clang test actually need to check the generated assembly? Shouldn't it be enough to check that the correct intrinsics are generated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118259/new/ https://reviews.llvm.or

[clang] 792a409 - [CMake][Fuchsia] Only build iossim runtimes for arm64

Author: Petr Hosek Date: 2022-01-27T02:28:13-08:00 New Revision: 792a4095c5514c89330571e764e8981b484bd6ca URL: https://github.com/llvm/llvm-project/commit/792a4095c5514c89330571e764e8981b484bd6ca DIFF: https://github.com/llvm/llvm-project/commit/792a4095c5514c89330571e764e8981b484bd6ca.diff LO

[clang] 35fff20 - [OpenCL] opencl-c.h: add missing read_write image guards

Author: Sven van Haastregt Date: 2022-01-27T10:33:12Z New Revision: 35fff208cad6f271410800998447dc0dd2704085 URL: https://github.com/llvm/llvm-project/commit/35fff208cad6f271410800998447dc0dd2704085 DIFF: https://github.com/llvm/llvm-project/commit/35fff208cad6f271410800998447dc0dd2704085.diff

[PATCH] D118337: [clang-format] Fix AllowShortFunctionsOnASingleLine: InlineOnly with wrapping after record.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/53430. Initially, I had a qui

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115640/new/ https://reviews.llvm.org/D115640 _

[PATCH] D118253: [RISCV] Add the passthru operand for some RVV nomask unary and nullary intrinsics.

frasercrmck accepted this revision. frasercrmck added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118253/new/ https://reviews.llvm.org/D118253

[PATCH] D118337: [clang-format] Fix AllowShortFunctionsOnASingleLine: InlineOnly with wrapping after record.

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:280 +if (Style.isJavaScript() && (*I)->Last->is(TT_FunctionLBrace)) + return true; + we didn't need this anymore? Repository: rG LLVM Github

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 403574. RKSimon added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. update lldb docs as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.or

[clang] a5de66c - [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

Author: Anton Zabaznov Date: 2022-01-27T14:25:59+03:00 New Revision: a5de66c4c50b5dec085ffbcd2afefd47f3f18d7f URL: https://github.com/llvm/llvm-project/commit/a5de66c4c50b5dec085ffbcd2afefd47f3f18d7f DIFF: https://github.com/llvm/llvm-project/commit/a5de66c4c50b5dec085ffbcd2afefd47f3f18d7f.diff

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5de66c4c50b: [OpenCL] Add support of __opencl_c_device_enqueue feature macro. (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D118337: [clang-format] Fix AllowShortFunctionsOnASingleLine: InlineOnly with wrapping after record.

curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:280 +if (Style.isJavaScript() && (*I)->Last->is(TT_FunctionLBrace)) + return true; + MyDeveloperDay wrote: > we didn't need this anymore? Before it wa

[PATCH] D118260: [clangd][Hover] Suppress initializers with many tokens

kadircet updated this revision to Diff 403583. kadircet added a comment. - Add comments about why we suppress initializer printing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118260/new/ https://reviews.llvm.org/D118260 Files: clang-tools-extr

[clang-tools-extra] c4e6895 - [clangd][Hover] Suppress initializers with many tokens

Author: Kadir Cetinkaya Date: 2022-01-27T13:01:55+01:00 New Revision: c4e68953f6443b9854ce3ec1dc8756789beafcc1 URL: https://github.com/llvm/llvm-project/commit/c4e68953f6443b9854ce3ec1dc8756789beafcc1 DIFF: https://github.com/llvm/llvm-project/commit/c4e68953f6443b9854ce3ec1dc8756789beafcc1.dif

[PATCH] D118260: [clangd][Hover] Suppress initializers with many tokens

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4e68953f644: [clangd][Hover] Suppress initializers with many tokens (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen updated this revision to Diff 403578. steffenlarsen retitled this revision from "[Annotation] Allow parameter pack expansions in annotate attribute" to "[Annotation] Allow parameter pack expansions and initializer lists in annotate attribute". steffenlarsen edited the summary of thi

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen added a comment. Upon offline sync with @aaron.ballman and @erichkeane I have changed the strategy of this patch to lift the restriction of pack expansion not spanning argument boundaries. This is implemented in `clang::annotate` by delaying arguments to after template-instantiat

[PATCH] D118350: [AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA created this revision. ZarkoCA added reviewers: hubert.reinterpretcast, sfertile, cebowleratibm, stevewan, Jake-Egan, aaron.ballman, tmatheson, dnsampaio. ZarkoCA added projects: clang, PowerPC. Herald added subscribers: shchenz, nemanjai. ZarkoCA requested review of this revision. Herald

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

aaron.ballman added a comment. Herald added a subscriber: JDevlieghere. In D114639#3273831 , @RKSimon wrote: > In D114639#3273761 , > @stella.stamenova wrote: > >> Can we update the lldb instructions as part of t

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro updated this revision to Diff 403604. ro added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. - Clarify comment. - Use `__ATOMIC_SEQ_CST`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/ https://r

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro updated this revision to Diff 403607. ro marked an inline comment as done. ro added a comment. Omit `sanitizer_atomic_clang.h` part, belongs to D118021 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

curdeius added a comment. Have you updated the diff? I still see `std::set` and not a sorted vector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416 ___ cfe-com

[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

dmgreen added inline comments. Comment at: clang/lib/Headers/arm_acle.h:734 +/* Memory Operations Intrinsics */ +#if __ARM_FEATURE_MOPS && __ARM_FEATURE_MEMORY_TAGGING +#define __arm_mops_memset_tag(tagged_address, value, size) \ tyb0807 wrot

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

john.brawn updated this revision to Diff 403614. john.brawn retitled this revision from "[AArch64] Fixes for strict FP vector instructions" to "[AArch64] Add some missing strict FP vector lowering". john.brawn edited the summary of this revision. john.brawn added a comment. The other parts of thi

[PATCH] D118337: [clang-format] Fix AllowShortFunctionsOnASingleLine: InlineOnly with wrapping after record.

lichray added a comment. Looks nice, and works for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118337/new/ https://reviews.llvm.org/D118337 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D115232: [clangd] Indexing of standard library

kadircet added a comment. thanks LG, mostly nits and a couple of questions Comment at: clang-tools-extra/clangd/ClangdServer.cpp:91 +if (Tasks) + Tasks->runAsync("IndexStdlib", std::move(Task)); +else I suppose this should be rare hence won't bite

[PATCH] D118355: Add -mmanual-endbr switch to allow manual selection of control-flow protection

gftg created this revision. gftg added reviewers: xiangzhangllvm, pengfei, erichkeane, joaomoreira. Herald added subscribers: ormris, dexonsmith, dang, jdoerfert, steven_wu, martong, hiraditya. Herald added a reviewer: aaron.ballman. gftg requested review of this revision. Herald added projects: c

[PATCH] D118355: Add -mmanual-endbr switch to allow manual selection of control-flow protection

gftg added a comment. This patch as-is doesn't build. To build it needs another change that I know is wrong, so I'm posting it below to ask for your help: [RFC] How to add more bits to the Type class? After reading https://reviews.llvm.org/D50630, I learned that keeping the

[PATCH] D118333: [RISCV] Update computeTargetABI implementation.

jrtc27 added a comment. I think this is the same idea as D118333 ? Other than being a cleaner way of achieving the same goal. I've not looked to see if there are any functional differences between the two. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D118333: [RISCV] Update computeTargetABI implementation.

jrtc27 added a comment. Uh D113959 even Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118333/new/ https://reviews.llvm.org/D118333 ___ cfe-commits mailing list cfe-comm

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

clementval added inline comments. Comment at: flang/include/flang/Frontend/CompilerInvocation.h:89 + /// These values are found in the preprocessor options. + void setFortranOpts(); }; @awarzynski I was looking at this file recently and I was wondering why we

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

frasercrmck added a comment. In D107290#3268949 , @paulwalker-arm wrote: > Does this mean `RISCVTTIImpl::getMaxVScale()` can be removed? Good question. I'm unsure at this stage. At hinted at in the description, `getMaxVScale` can make use of backend-sp

[PATCH] D117939: [clang-tidy] Add more documentation about check development

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you for these fantastic improvements to the docs! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117939/new/ https://reviews.llvm.org/D117939 ___ cfe-commits mail

[PATCH] D118337: [clang-format] Fix AllowShortFunctionsOnASingleLine: InlineOnly with wrapping after record.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. +1 for the TokenAnnotatorTests, I think we need more of those instead of testing the formatted output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118337/new/ https:/

[PATCH] D118361: clang-format: [JS] sort import aliases.

mprobst created this revision. mprobst added a reviewer: krasimir. Herald added a subscriber: jeroen.dobbelaere. mprobst requested review of this revision. Herald added a project: clang. Users can define aliases for long symbols using import aliases: import X = A.B.C; Previously, these were un

[PATCH] D118363: clang-format: [JS] sort import aliases.

mprobst created this revision. mprobst added a reviewer: krasimir. Herald added a subscriber: jeroen.dobbelaere. mprobst requested review of this revision. Herald added a project: clang. Users can define aliases for long symbols using import aliases: import X = A.B.C; Previously, these were un

[PATCH] D118361: clang-format: [JS] sort import aliases.

mprobst abandoned this revision. mprobst added a comment. Superseded by https://reviews.llvm.org/D118363 (sorry for the diff confusion). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118361/new/ https://reviews.llvm.org/D118361 ___

[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

SjoerdMeijer added inline comments. Comment at: clang/lib/Headers/arm_acle.h:734 +/* Memory Operations Intrinsics */ +#if __ARM_FEATURE_MOPS && __ARM_FEATURE_MEMORY_TAGGING +#define __arm_mops_memset_tag(tagged_address, value, size) \ dmgreen

[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

dmgreen added inline comments. Comment at: clang/lib/Headers/arm_acle.h:734 +/* Memory Operations Intrinsics */ +#if __ARM_FEATURE_MOPS && __ARM_FEATURE_MEMORY_TAGGING +#define __arm_mops_memset_tag(tagged_address, value, size) \ SjoerdMeijer

[PATCH] D118361: clang-format: [JS] sort import aliases.

mprobst updated this revision to Diff 403646. mprobst added a comment. - make test break if we used alphasort Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118361/new/ https://reviews.llvm.org/D118361 Files: clang/unittests/Format/SortImportsTes

[clang] c6d5efb - clang-format: [JS] sort import aliases.

Author: Martin Probst Date: 2022-01-27T16:16:37+01:00 New Revision: c6d5efb5d98093c4bd7578b2ea52c9032d20dea3 URL: https://github.com/llvm/llvm-project/commit/c6d5efb5d98093c4bd7578b2ea52c9032d20dea3 DIFF: https://github.com/llvm/llvm-project/commit/c6d5efb5d98093c4bd7578b2ea52c9032d20dea3.diff

[PATCH] D118363: clang-format: [JS] sort import aliases.

mprobst closed this revision. mprobst added a comment. Landed in https://github.com/llvm/llvm-project/commit/c6d5efb5d98093c4bd7578b2ea52c9032d20dea3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118363/new/ https://reviews.llvm.org/D118363 _

[PATCH] D118370: [clang-tidy] bugprone-signal-handler: Code refactor (NFC)

balazske created this revision. Herald added subscribers: carlosgalvezp, steakhal, martong, gamesh411, Szelethus, dkrupp, xazax.hun. balazske requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Another change of the code design. Co

[PATCH] D116395: [Clang] Emit warning for -x option without effects

hans added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2416 } + if (Inputs.size() == InputsBeforeOptX && InputTypeArg != nullptr) +Diag(diag::warn_drv_ignored_option_x) << InputTypeArg->getValue(0); Could we end up here in clang-cl mode with

[PATCH] D118044: [ARM] Undeprecate complex IT blocks

dmgreen added a reviewer: samparker. dmgreen added inline comments. Comment at: llvm/test/CodeGen/ARM/hoist-and-by-const-from-lshr-in-eqcmp-zero.ll:498 +; THUMB8-NEXT:it pl +; THUMB8-NEXT:lslpl.w r1, r0, r ; THUMB8-NEXT:lsl.w r0, r0, r2 Can you make

[PATCH] D118044: [ARM] Undeprecate complex IT blocks

DavidSpickett added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:87 * Added support for the Armv8.1-M PACBTI-M extension. +* Removed the deprecation of ARMv8-A T32 Complex IT blocks. Such blocks + are now enabled by default, but may be turned off if required. No

[PATCH] D118224: [clang-tidy] bugprone-signal-handler improvements: display call chain

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118224/new/ https://reviews.llvm.org/D118224

[PATCH] D118333: [RISCV] Update computeTargetABI implementation.

khchen added a comment. In D118333#3275940 , @jrtc27 wrote: > I think this is the same idea as D118333 ? > Other than being a cleaner way of achieving the same goal. I've not looked to > see if there are any functional

[PATCH] D116395: [Clang] Emit warning for -x option without effects

awarzynski added inline comments. Comment at: clang/test/Driver/redundant-args.c:2 +// RUN: %clang -target x86_64-apple-darwin10 -Werror -x c -x c -fsyntax-only %s +// RUN: %clang -target x86_64-apple-darwin10 %s -### -x c 2>&1 | FileCheck %s + hans wrote: > Thes

[PATCH] D118044: [ARM] Undeprecate complex IT blocks

john.brawn added inline comments. Comment at: llvm/test/CodeGen/ARM/2013-05-05-IfConvertBug.ll:1-4 ; RUN: llc < %s -mtriple=thumbv7-apple-ios -mcpu=cortex-a8 | FileCheck %s ; RUN: llc < %s -mtriple=thumbv8 | FileCheck -check-prefix=CHECK-V8 %s -; RUN: llc < %s -mtriple=thumbv7

[clang] ccce1a0 - Don't trigger unused-parameter warnings on naked functions

Author: MuAlphaOmegaEpsilon Date: 2022-01-27T11:40:08-05:00 New Revision: ccce1a03c9ce9c3917b310097c89e39bb68527e2 URL: https://github.com/llvm/llvm-project/commit/ccce1a03c9ce9c3917b310097c89e39bb68527e2 DIFF: https://github.com/llvm/llvm-project/commit/ccce1a03c9ce9c3917b310097c89e39bb68527e2

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

aaron.ballman closed this revision. aaron.ballman added a comment. In D116778#3259189 , @MuAlphaOmegaEpsilon wrote: > In D116778#3255414 , @aaron.ballman > wrote: > >> LGTM! The CI failure is finally down to jus

[PATCH] D118044: [ARM] Undeprecate complex IT blocks

DavidSpickett added a comment. FWIW, a 2 stage build on armv8 with `-mthumb` didn't turn up any codegen Gremlins. (that's how I saw the unused var) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118044/new/ https://reviews.llvm.org/D118044 ___

[PATCH] D108032: [analyzer] Retrieve a character from CompoundLiteralExpr as an initializer for constant arrays.

ASDenysPetrov abandoned this revision. ASDenysPetrov added a comment. Paused for a while. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108032/new/ https://reviews.llvm.org/D108032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang-tools-extra] 8ce99da - [clang-tidy] Add more documentation about check development (NFC)

Author: Richard Date: 2022-01-27T09:44:09-07:00 New Revision: 8ce99dadb007dd0dbbf1ddbe4090e9ff43e780c5 URL: https://github.com/llvm/llvm-project/commit/8ce99dadb007dd0dbbf1ddbe4090e9ff43e780c5 DIFF: https://github.com/llvm/llvm-project/commit/8ce99dadb007dd0dbbf1ddbe4090e9ff43e780c5.diff LOG:

[PATCH] D117939: [clang-tidy] Add more documentation about check development

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ce99dadb007: [clang-tidy] Add more documentation about check development (NFC) (authored by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D118380: Add info on PACBTI-M to the Clang release notes

stuij created this revision. stuij requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118380 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst ==

[PATCH] D118070: Add /winsysroot support to lld

pkasting updated this revision to Diff 403679. pkasting added a comment. Herald added subscribers: hiraditya, mgorny. Refactored to share code with clang-cl. Still no tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

awarzynski added inline comments. Comment at: flang/include/flang/Frontend/CompilerInvocation.h:89 + /// These values are found in the preprocessor options. + void setFortranOpts(); }; clementval wrote: > @awarzynski I was looking at this file recently and I w

[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

tyb0807 updated this revision to Diff 403686. tyb0807 marked an inline comment as done. tyb0807 added a comment. Update accordingly to change from ACLE specification: `__builtin_arm_mops_memset_tag` required _both_ MOPS and MTE features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D118370: [clang-tidy] bugprone-signal-handler: Code refactor (NFC)

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:146 + if (!HandlerDecl->hasBody()) { +checkFunction(HandlerDecl, HandlerExpr); return; Why do we ignore the return value of `checkFunction`

[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

tyb0807 updated this revision to Diff 403687. tyb0807 marked 3 inline comments as done. tyb0807 edited the summary of this revision. tyb0807 added a comment. Update link to the relevant section of ACLE specification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

yurai007 created this revision. yurai007 added reviewers: nikic, xbolva00, aeubanks, ChuanqiXu, v.g.vassilev, serge-sans-paille, rsmith. Herald added subscribers: dexonsmith, pengfei, hiraditya. yurai007 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscriber

[PATCH] D118383: [OpenMP] Enable inoutset dependency-type in depend clause.

ABataev added a comment. Is it a new mode from OpenMP 5.2? Or 5.1? Can you add a check for OpenMP version, if so? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118383/new/ https://reviews.llvm.org/D118383 _

[clang] 36622c4 - [clang-format] Fix AllowShortFunctionsOnASingleLine: InlineOnly with wrapping after record.

Author: Marek Kurdej Date: 2022-01-27T18:06:31+01:00 New Revision: 36622c4e1a48cd02209524592abb9d929fff1e22 URL: https://github.com/llvm/llvm-project/commit/36622c4e1a48cd02209524592abb9d929fff1e22 DIFF: https://github.com/llvm/llvm-project/commit/36622c4e1a48cd02209524592abb9d929fff1e22.diff

[PATCH] D118337: [clang-format] Fix AllowShortFunctionsOnASingleLine: InlineOnly with wrapping after record.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36622c4e1a48: [clang-format] Fix AllowShortFunctionsOnASingleLine: InlineOnly with wrapping… (authored by curdeius). Repository: rG LLVM Github M

[PATCH] D118370: [clang-tidy] bugprone-signal-handler: Code refactor (NFC)

balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:146 + if (!HandlerDecl->hasBody()) { +checkFunction(HandlerDecl, HandlerExpr); return; LegalizeAdulthood wrote: > Why do we ignore the return value

[PATCH] D118386: [Support][NFC] Fix generic `ChildrenGetterTy` of `IDFCalculatorBase`

zero9178 created this revision. zero9178 added reviewers: Szelethus, jmorse, kuhar. Herald added subscribers: Chia-hungDuan, dexonsmith, rriddle, hiraditya. zero9178 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, stephenneuendorffer. Herald added projects: c

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

serge-sans-paille added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:214 mutable llvm::FoldingSet ComplexTypes; - mutable llvm::FoldingSet PointerTypes; + mutable llvm::FoldingSet PointerTypes{9}; mutable llvm::FoldingSet AdjustedTypes; --

[PATCH] D118370: [clang-tidy] bugprone-signal-handler: Code refactor (NFC)

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:167 + const Expr *CallOrRef) { + const bool FunctionIsCalled = isa(CallOrRef); + This can probably just be inlined into

[PATCH] D118383: [OpenMP] Enable inoutset dependency-type in depend clause.

ddpagan added a comment. > Is it a new mode from OpenMP 5.2? Or 5.1? Can you add a check for OpenMP > version, if so? Thanks for catching this, Alexey. It is new in OpenMP 5.1. I'll add a check for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

svenvh updated this revision to Diff 403705. svenvh edited the summary of this revision. svenvh added a comment. Make use of the `__opencl_c_named_address_space_builtins` internal feature added by D118158 . This should avoid affecting OpenCL 2.0. CHANGES SINC

[PATCH] D117929: [XRay] Add support for RISCV

ashwin98 updated this revision to Diff 403707. ashwin98 added a comment. Fixed another lint issue, they should all be done for now hopefully. @dberris Sorry, I'm a little confused, do you mean I need to update some of the clang tests for XRay instrumentation to test compilation and linking, or a

[PATCH] D118153: [CUDA][HIP] Do not treat host var address as constant in device compilation

yaxunl updated this revision to Diff 403706. yaxunl added a comment. Fix the regression in lit tests. Basically in device compilation we still evaluate constant expression for host functions or host template instantiation. If we just disallow host variable in any constant expressions we will ge

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

khchen added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVTargetMachine.cpp:99 + if (VScaleRangeAttr.isValid()) { +RVVBitsMin = VScaleRangeAttr.getVScaleRangeMin() * RISCV::RVVBitsPerBlock; +if (VScaleRangeAttr.getVScaleRangeMax().hasValue())

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

RKSimon added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117898/new/ https://reviews.llvm.org/D117898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

ellis added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProf.h:281-282 +/// An enum describing the attributes of an instrumented profile. +enum class InstrProfKind { + Unknown = 0x0, I've been working on a new coverage instrumentation in D1

[clang] 1fec215 - [ARM][AArch64] Cleanup and autogenerate v8.1a vqdrmlah tests. NFC

Author: David Green Date: 2022-01-27T18:43:06Z New Revision: 1fec2154b29f84b53dd578b9f87f34e255630771 URL: https://github.com/llvm/llvm-project/commit/1fec2154b29f84b53dd578b9f87f34e255630771 DIFF: https://github.com/llvm/llvm-project/commit/1fec2154b29f84b53dd578b9f87f34e255630771.diff LOG: [

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProf.h:281-282 +/// An enum describing the attributes of an instrumented profile. +enum class InstrProfKind { + Unknown = 0x0, ellis wrote: > I've been working on a new coverage in

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

rnk added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1890 - bool FieldPacked = Packed || D->hasAttr(); + llvm::Triple Target = Context.getTargetInfo().getTriple(); + bool FieldPacked = (Packed && (!FieldClass || FieldClass->isPOD() ||

  1   2   >