[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat/CreateShuffleVector use poison as placeholder

Allen added a comment. I have a babyism question, why poison is preferred to the undef in the pattern ConstantVector::getSplat ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93793/new/ https://reviews.llvm.org/D93793

[clang] 491984c - Document __builtin_trap and __builtin_debugtrap

Author: serge-sans-paille Date: 2022-01-05T03:10:17-05:00 New Revision: 491984c4e60c0f0de9dd00dc1a19e90a7b3535eb URL: https://github.com/llvm/llvm-project/commit/491984c4e60c0f0de9dd00dc1a19e90a7b3535eb DIFF: https://github.com/llvm/llvm-project/commit/491984c4e60c0f0de9dd00dc1a19e90a7b3535eb.d

[PATCH] D116598: Document __builtin_trap and __builtin_debugtrap

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG491984c4e60c: Document __builtin_trap and __builtin_debugtrap (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscrib

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 397469. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Fix issue in RISCVISAInfo.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D116638: [ClangFormat] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

MyDeveloperDay added a comment. Thank you for the patch, could you just handle the documentation, but otherwise pretty good Comment at: clang/docs/ClangFormatStyleOptions.rst:2820 +**JavaScriptWrapImports** (``Boolean``) :versionbadge:`clang-format 3.9` + Whether to wrap Ja

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Thanks for working on this! Apart from other reviewer's comments, it looks pretty much ok, but the tests are a bit messy IMO. I'd like to see something that tests 4 cases (false +

[PATCH] D116592: [clang-format] Missing space after cast in a macro

MyDeveloperDay updated this revision to Diff 397473. MyDeveloperDay added a comment. Fix nit and add a few more tests just to be sure CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116592/new/ https://reviews.llvm.org/D116592 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittest

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTestJS.cpp:1948 + Style.JavaScriptWrapImports = false; verifyFormat("import {VeryLongImportsAreAnnoying, VeryLongImportsAreAnnoying," " VeryLongImportsAreAnnoying, VeryLongImportsA

[PATCH] D116314: [clang-format] Add style to separate definition blocks

MyDeveloperDay added a comment. @ksyx Did you see this issue https://github.com/llvm/llvm-project/issues/52976 In its current form, this patch causes huge amounts of flux in projects that document code like (anyone using doxygen likely, + most normal people ;-) ) ... } // My function -

[PATCH] D116503: [clang] Add arguments for silencing unused argument warnings for some but not all arguments

mstorsjo added a comment. In D116503#3221083 , @MaskRay wrote: > A more searchable subject (mentioning the new option in the subject is useful > for archaeology) may be `Add > --start-no-unused-arguments/--end-no-unused-arguments to silence some unused

[PATCH] D116503: [clang] Add arguments for silencing unused argument warnings for some but not all arguments

mstorsjo updated this revision to Diff 397476. mstorsjo added a comment. Regenerated ClangCommandLineReference.rst (with the relevant changes), removed NoXarchOption. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116503/new/ https://reviews.llvm.o

[PATCH] D116643: [clangd] Don't rename on symbols from system headers.

hokein created this revision. hokein added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes https://github.com/clangd/clangd/is

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2021 + // fields imported) at that time without multiple AST import passes. + To->setCompleteDefinition(true); // Complete the definition even if error is returned. shafik wrote: > So

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2021 + // fields imported) at that time without multiple AST import passes. + To->setCompleteDefinition(true); // Complete the definition even if error is returned. balazske wrote: > s

[PATCH] D116583: Change the default optimisation level of PTXAS from -O0 to -O3. This makes the optimisation levels of PTXAS and the ptxjitcompiler equal (ptxjitcompiler defaults to -O3).

hdelan added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:433 } else { -// If no -O was passed, pass -O0 to ptxas -- no opt flag should correspond -// to no optimizations, but ptxas's default is -O3. -CmdArgs.push_back("-O0"); +// If no -O

[clang] 015e08c - [clang][scandeps] Update Module Cache Path in Test

Author: Archibald Elliott Date: 2022-01-05T10:42:38Z New Revision: 015e08c6badad6b27404d6f94569e25c18d79049 URL: https://github.com/llvm/llvm-project/commit/015e08c6badad6b27404d6f94569e25c18d79049 DIFF: https://github.com/llvm/llvm-project/commit/015e08c6badad6b27404d6f94569e25c18d79049.diff

[PATCH] D116611: [clang][scandeps] Update Module Cache Path in Test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG015e08c6bada: [clang][scandeps] Update Module Cache Path in Test (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D116647: [clang-format] Simplify raw string regex. NFC.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introduced in https://reviews.llvm.org/D115168. Repository: rG LLVM Github M

[PATCH] D116643: [clangd] Don't rename on symbols from system headers.

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:163 +// By default, we exclude symbols from system headers and protobuf symbols as +// rename these symbols would change system/generated files which are unlikely +// to be modified.

[PATCH] D116643: [clangd] Don't rename on symbols from system headers.

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:1202 +TEST(RenameTest, NoRenameOnSymbolsFromSystemHeaders) { + // filter out references not from main file. + llvm::StringRef Test = Nit: capitalization. Repository

[clang] 35493b4 - [clang-format][NFC] Replace deque with vector

Author: Björn Schäpers Date: 2022-01-05T12:31:34+01:00 New Revision: 35493b45603fc897280cfba60866075888d9a790 URL: https://github.com/llvm/llvm-project/commit/35493b45603fc897280cfba60866075888d9a790 DIFF: https://github.com/llvm/llvm-project/commit/35493b45603fc897280cfba60866075888d9a790.diff

[clang] c2257fe - [clang-format] Fix SeparateDefinitionBlocks docs and ...

Author: Björn Schäpers Date: 2022-01-05T12:31:34+01:00 New Revision: c2257fe236726ed46f1ec3d68633f1b6663d2513 URL: https://github.com/llvm/llvm-project/commit/c2257fe236726ed46f1ec3d68633f1b6663d2513 DIFF: https://github.com/llvm/llvm-project/commit/c2257fe236726ed46f1ec3d68633f1b6663d2513.diff

[clang] a1db435 - [clang-format][NFC] Don't pass member by argument

Author: Björn Schäpers Date: 2022-01-05T12:31:34+01:00 New Revision: a1db43539027898cbd200798c4549115d261ed86 URL: https://github.com/llvm/llvm-project/commit/a1db43539027898cbd200798c4549115d261ed86 DIFF: https://github.com/llvm/llvm-project/commit/a1db43539027898cbd200798c4549115d261ed86.diff

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35493b45603f: [clang-format][NFC] Replace deque with vector (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 918c977 - [clang-format][NFC] Early return in TokenAnnotator::next

Author: Björn Schäpers Date: 2022-01-05T12:31:35+01:00 New Revision: 918c977dc1c8905086443e13c172a492247d4709 URL: https://github.com/llvm/llvm-project/commit/918c977dc1c8905086443e13c172a492247d4709 DIFF: https://github.com/llvm/llvm-project/commit/918c977dc1c8905086443e13c172a492247d4709.diff

[clang] 29d8535 - [clang-format][NFC] TokenAnnotator: Use range based for

Author: Björn Schäpers Date: 2022-01-05T12:31:35+01:00 New Revision: 29d8535e2b86d27a3c1363646f04ddf1835c30d2 URL: https://github.com/llvm/llvm-project/commit/29d8535e2b86d27a3c1363646f04ddf1835c30d2 DIFF: https://github.com/llvm/llvm-project/commit/29d8535e2b86d27a3c1363646f04ddf1835c30d2.diff

[clang] 2ab5d29 - [clang-format][NFC] Use Prev instead of Current->Previous

Author: Björn Schäpers Date: 2022-01-05T12:31:35+01:00 New Revision: 2ab5d29f556bc3b5510ae495e5bb54b8b5921d1f URL: https://github.com/llvm/llvm-project/commit/2ab5d29f556bc3b5510ae495e5bb54b8b5921d1f DIFF: https://github.com/llvm/llvm-project/commit/2ab5d29f556bc3b5510ae495e5bb54b8b5921d1f.diff

[clang] 8f6af1d - [clang-format][NFC] Put all state change into the for statement

Author: Björn Schäpers Date: 2022-01-05T12:31:36+01:00 New Revision: 8f6af1d4688904fda730d0fea78d2df11252bf40 URL: https://github.com/llvm/llvm-project/commit/8f6af1d4688904fda730d0fea78d2df11252bf40 DIFF: https://github.com/llvm/llvm-project/commit/8f6af1d4688904fda730d0fea78d2df11252bf40.diff

[clang] 1da96f7 - [clang-format][NFC] Right.Previous is Left

Author: Björn Schäpers Date: 2022-01-05T12:31:36+01:00 New Revision: 1da96f744951b54f7a3f9bf799fb8e75a31d291b URL: https://github.com/llvm/llvm-project/commit/1da96f744951b54f7a3f9bf799fb8e75a31d291b DIFF: https://github.com/llvm/llvm-project/commit/1da96f744951b54f7a3f9bf799fb8e75a31d291b.diff

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2257fe23672: [clang-format] Fix SeparateDefinitionBlocks docs and ... (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D116558: [clang-format][NFC] Don't pass member by argument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1db43539027: [clang-format][NFC] Don't pass member by argument (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D116559: [clang-format][NFC] Early return in TokenAnnotator::next

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG918c977dc1c8: [clang-format][NFC] Early return in TokenAnnotator::next (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D116560: [clang-format][NFC] TokenAnnotator: Use range based for

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29d8535e2b86: [clang-format][NFC] TokenAnnotator: Use range based for (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D116561: [clang-format][NFC] Use Prev instead of Current->Previous

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ab5d29f556b: [clang-format][NFC] Use Prev instead of Current->Previous (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHA

[PATCH] D116562: [clang-format][NFC] Right.Previous is Left

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1da96f744951: [clang-format][NFC] Right.Previous is Left (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116563: [clang-format][NFC] Put all state change into the for statement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f6af1d46889: [clang-format][NFC] Put all state change into the for statement (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorep

[PATCH] D116596: [clang][dataflow] Add transfer functions for assignment

sgatev updated this revision to Diff 397508. sgatev marked 3 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116596/new/ https://reviews.llvm.org/D116596 Files: clang/in

[PATCH] D116596: [clang][dataflow] Add transfer functions for assignment

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:34 +/// storage locations or values. +enum class SkipPast { + /// No indirections should be skipped past. xazax.hun wrote: > I am just wondering if this is

[clang] 3dc1907 - [ConstantFold] Use ConstantFoldLoadFromUniformValue() in more places

Author: Nikita Popov Date: 2022-01-05T12:47:50+01:00 New Revision: 3dc1907d063c1fb1617a0043d5fdb89104e7f7a3 URL: https://github.com/llvm/llvm-project/commit/3dc1907d063c1fb1617a0043d5fdb89104e7f7a3 DIFF: https://github.com/llvm/llvm-project/commit/3dc1907d063c1fb1617a0043d5fdb89104e7f7a3.diff

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks reopened this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D115060#3219116 , @curdeius wrote: > @HazardyKnusperkeks, it *seems* as if this commit (or one of others indicated > on Cha

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

lenary added a comment. @Bigcheese have you got a fix for the vfs issue with `.` and `..`? Looking closely at your comment, I'm surprised you landed this without an llvm-lit xfail for windows, given your comment above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu added a comment. @asl hi, do you feel good with this revision? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang and mlir

MaskRay added a comment. Early heads-up: we see a failure with `llvm/lib/Transforms/Coroutines/CoroEarly.cpp:186 in bool (anonymous namespace)::Lowerer::lowerEarlyIntrinsics(llvm::Function &): F.hasFnAttribute(CORO_PRESPLIT_ATTR) && F.getFnAttribute(CORO_PRESPLIT_ATTR).getValueAsString() == UN

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang and mlir

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc75cedc237f9: [Coroutines] Set presplit attribute in Clang and mlir (authored by ChuanqiXu). Changed prior to commit: https://reviews.llvm.org/D11

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang and mlir

ChuanqiXu added a comment. In D115790#3221307 , @MaskRay wrote: > Early heads-up: we see a failure with > `llvm/lib/Transforms/Coroutines/CoroEarly.cpp:186 in bool (anonymous > namespace)::Lowerer::lowerEarlyIntrinsics(llvm::Function &): > F.hasFnAttri

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

serge-sans-paille updated this revision to Diff 397486. serge-sans-paille added a comment. Take advice into account CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116599/new/ https://reviews.llvm.org/D116599 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBuiltin.cpp cla

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LG from my side, but I'd like a second opinion for the "require LLVMContext in AttrBuilder" part of the change, as that's the main API impact. Comment at: llvm/lib/AsmParser/L

[clang] ea83517 - Revert "[Clang][ScanDeps] Use the virtual path for module maps"

Author: Archibald Elliott Date: 2022-01-05T12:17:06Z New Revision: ea835171389aa356b865bf9cb72ca8f4f84b64fd URL: https://github.com/llvm/llvm-project/commit/ea835171389aa356b865bf9cb72ca8f4f84b64fd DIFF: https://github.com/llvm/llvm-project/commit/ea835171389aa356b865bf9cb72ca8f4f84b64fd.diff

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

lenary reopened this revision. lenary added a comment. This revision is now accepted and ready to land. Update: I'm going to revert this on main. This patch was accepted conditionally on you fixing the windows crash, which you have not done, so this was landed without being accepted. Revert is

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

mprobst added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2827 -**JavaScriptWrapImports** (``Boolean``) :versionbadge:`clang-format 3.9` - Whether to wrap JavaScript import/export statements. + * If ``ColumnWidth`` is 0 (no limit on the number of colum

[PATCH] D116518: [ast-matchers] Add hasSubstatementSequence matcher

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5435-5442 +/// Matches two consecutive statements within a compound statement. +/// +/// Given +/// \code +/// { if (x > 0) return true; return false; } +/// \endcode +/// compoundStm

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

zero9178 updated this revision to Diff 397524. zero9178 added a comment. Update test according to reviewers comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116020/new/ https://reviews.llvm.org/D116020 Files: clang/lib/AST/Mangle.cpp clang/test/CodeGen/pr52782-stdcall-func-dec

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

Bigcheese added a comment. In D114206#3221893 , @lenary wrote: > Update: I'm going to revert this on main. This patch was accepted > conditionally on you fixing the windows crash, which you have not done, so > this was landed without being accepted. > >

[clang] 46db030 - [clang-format] Simplify raw string regex. NFC.

Author: Marek Kurdej Date: 2022-01-05T13:39:28+01:00 New Revision: 46db030188e562c02a3ef2bb83360691bad26caf URL: https://github.com/llvm/llvm-project/commit/46db030188e562c02a3ef2bb83360691bad26caf DIFF: https://github.com/llvm/llvm-project/commit/46db030188e562c02a3ef2bb83360691bad26caf.diff

[PATCH] D116647: [clang-format] Simplify raw string regex. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46db030188e5: [clang-format] Simplify raw string regex. NFC. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks updated this revision to Diff 397531. HazardyKnusperkeks added a comment. Option 3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115060/new/ https://reviews.llvm.org/D115060 Files: clang/lib/Format/UnwrappedLineFormatter.cpp Index: clang/lib/Format/UnwrappedLineFo

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

lenary added a comment. In D114206#3221950 , @Bigcheese wrote: > In D114206#3221893 , @lenary wrote: > >> Update: I'm going to revert this on main. This patch was accepted >> conditionally on you fixing the windo

[clang] 5109737 - [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

Author: Marek Kurdej Date: 2022-01-05T13:52:45+01:00 New Revision: 5109737c924d68323b1982949a3e28ef26bc289e URL: https://github.com/llvm/llvm-project/commit/5109737c924d68323b1982949a3e28ef26bc289e DIFF: https://github.com/llvm/llvm-project/commit/5109737c924d68323b1982949a3e28ef26bc289e.diff

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5109737c924d: [clang-format] Fix indentation for array variables with alignment of… (authored by curdeius). Repository: rG LLVM Github Monorepo C

[PATCH] D116328: [ast-matchers] Add hasSubstatement() traversal matcher for caseStmt(), defaultStmt(), labelStmt()

aaron.ballman added a comment. > Previously if you wanted to match the statement associated with a case, > default, or labelled statement, you had to use hasDescendant. This isn't true. You can use `has()` to do direct substatemematching, and I'm wondering whether we need this new matcher at al

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2827 -**JavaScriptWrapImports** (``Boolean``) :versionbadge:`clang-format 3.9` - Whether to wrap JavaScript import/export statements. + * If ``ColumnWidth`` is 0 (no limit on the numb

[clang] afc14a0 - Retire llvm::make_reverse_iterator in favor of std::make_reverse_iterator

Author: Benjamin Kramer Date: 2022-01-05T14:07:08+01:00 New Revision: afc14a0d1767d9f9dc1b9d81a2f76916ba2bab61 URL: https://github.com/llvm/llvm-project/commit/afc14a0d1767d9f9dc1b9d81a2f76916ba2bab61 DIFF: https://github.com/llvm/llvm-project/commit/afc14a0d1767d9f9dc1b9d81a2f76916ba2bab61.dif

[PATCH] D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS

egorzhdan updated this revision to Diff 397541. egorzhdan added a comment. Add a test to verify that `iOS_tvOS` mapping is parsed correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116615/new/ https://reviews.llvm.org/D116615 Files: clang/

[PATCH] D116630: [clangd] Handle declarators more consistently in Selection.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks better! Comment at: clang-tools-extra/clangd/Selection.cpp:756 +claimRange( +SourceRange(FTL.getParensRange().getBegin(), FTL.getEndLoc

[PATCH] D115429: [Clang] Implement the rest of __builtin_elementwise_* functions.

junaire added a comment. In D115429#3219563 , @fhahn wrote: > LGTM, thanks! May I ask you to help me to land this patch? I plan to request commit access after this one. Thanks a lot! ;D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116535: [clang-tidy] Fix false positive in modernize-pass-by-value

courbet marked 2 inline comments as done. courbet added a comment. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116535/new/ https://reviews.llvm.org/D116535 ___ cfe-commits mailing list cfe-comm

[PATCH] D116535: [clang-tidy] Fix false positive in modernize-pass-by-value

courbet updated this revision to Diff 397543. courbet added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116535/new/ https://reviews.llvm.org/D116535 Files: clang-tools-extra/clang-tidy/modernize/PassByValueC

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

curdeius accepted this revision. curdeius added a comment. That's look good. And it's a nice clean up with all those repeated checks removed. Don't forget to reformat before landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115060/new/ https://reviews.llvm.org/D115060 ___

[clang-tools-extra] ed8ff29 - [clang-tidy] Fix false positive in modernize-pass-by-value

Author: Clement Courbet Date: 2022-01-05T14:33:40+01:00 New Revision: ed8ff29aa6835187f3d5e7b64de022fe6b33a131 URL: https://github.com/llvm/llvm-project/commit/ed8ff29aa6835187f3d5e7b64de022fe6b33a131 DIFF: https://github.com/llvm/llvm-project/commit/ed8ff29aa6835187f3d5e7b64de022fe6b33a131.dif

[PATCH] D116535: [clang-tidy] Fix false positive in modernize-pass-by-value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed8ff29aa683: [clang-tidy] Fix false positive in modernize-pass-by-value (authored by courbet). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D116351: Update Bug report URL to Github Issues

jhenderson added inline comments. Comment at: llvm/docs/CommandGuide/llvm-install-name-tool.rst:79 -To report bugs, please visit . +To report bugs, please visit . I believe llvm-install-nam

[clang] 32c2ea5 - [clang][lex] NFC: Simplify loop

Author: Jan Svoboda Date: 2022-01-05T14:40:47+01:00 New Revision: 32c2ea5c33a710cb1497bbd903039d8a9641e98a URL: https://github.com/llvm/llvm-project/commit/32c2ea5c33a710cb1497bbd903039d8a9641e98a DIFF: https://github.com/llvm/llvm-project/commit/32c2ea5c33a710cb1497bbd903039d8a9641e98a.diff L

[PATCH] D116659: [llvm][clang][vfs] NFC: Extract directory iteration boilerplate into macro

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. Herald added subscribers: kerbowa, nhaehnle, jvesely. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The iter

[PATCH] D116550: [clang-tidy] Recognize transformer checks as providing fixits

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116550/new/ https://reviews.llvm.org/D116550 _

[PATCH] D116596: [clang][dataflow] Add transfer functions for assignment

ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:36 +/// FIXME: Consider replacing this with a model that is more aligned with C++ +/// value categories. +enum class SkipPast { I'm not sure that value cat

[PATCH] D116478: [clang-tidy] A comma-separated list of the names of functions or methods to be considered as not having side-effects

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.h:37-48 + using FunctionExceptionType = llvm::SmallSet; AssertSideEffectCheck(StringRef Name, ClangTidyContext *Context); void storeOptions(ClangTidyOptions::Option

[PATCH] D113676: WIP: [clang][lex] Fix search path usage remark with modules

jansvoboda11 added a comment. In D113676#3168219 , @Bigcheese wrote: > Can we not consider a modulemap used when we load an AST that depends on that > modulemap? It's possible this breaks if the module only includes textual > headers though. I don't th

[PATCH] D114787: [clang][PR51931] Enable `-Wdeclaration-after-statement` for all C versions

aaron.ballman added a comment. In D114787#3218382 , @zero9178 wrote: > In D114787#3188735 , @aaron.ballman > wrote: > >> https://reviews.llvm.org/D115094 is a review for doing effectively the same >> fix. Can yo

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat/CreateShuffleVector use poison as placeholder

aqjune added a comment. In D93793#3221414 , @Allen wrote: > I have a babyism question, why poison is preferred to the undef in the > pattern ConstantVector::getSplat ? Hi Allen, It is because folding poison is easier than folding undef. :) For example, a

[PATCH] D116630: [clangd] Handle declarators more consistently in Selection.

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:757 if (const auto *TL = N.get()) { - // e.g. EltType Foo[OuterSize][InnerSize]; - // ~ ArrayTypeLoc

[clang-tools-extra] 96f5cc1 - [clangd] Handle declarators more consistently in Selection.

Author: Sam McCall Date: 2022-01-05T15:40:47+01:00 New Revision: 96f5cc1ee417f863f85756d1e56b1bed1bd76a7e URL: https://github.com/llvm/llvm-project/commit/96f5cc1ee417f863f85756d1e56b1bed1bd76a7e DIFF: https://github.com/llvm/llvm-project/commit/96f5cc1ee417f863f85756d1e56b1bed1bd76a7e.diff LO

[PATCH] D116630: [clangd] Handle declarators more consistently in Selection.

This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rG96f5cc1ee417: [clangd] Handle declarators more consistently in Selection. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D116630?v

[PATCH] D116512: [clang-tidy] Limit non-Strict mode to public functions

aaron.ballman requested changes to this revision. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp:188 // (constructor initializer counts for non-empty body). -if (

[clang-tools-extra] 7632d19 - [clangd] Fix typos in the SelectionTree comment.

Author: Haojian Wu Date: 2022-01-05T15:50:07+01:00 New Revision: 7632d19ada4a1feebc4a06067490ee1c77cd4dc1 URL: https://github.com/llvm/llvm-project/commit/7632d19ada4a1feebc4a06067490ee1c77cd4dc1 DIFF: https://github.com/llvm/llvm-project/commit/7632d19ada4a1feebc4a06067490ee1c77cd4dc1.diff LO

[PATCH] D116513: [clang-tidy] Fix bugs in misc-unused-parameters for Constructors calls site

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-unused-parameters.cpp:157-159 // CHECK-FIXES: C() {} C(int i) {} // CHECK-MESSAGES: :[[@LINE-1]]:9: warning I think this fix is incorrect and should not be appl

[clang-tools-extra] bb10e03 - [clangd] Refine comment on declarator ranges

Author: Sam McCall Date: 2022-01-05T16:00:13+01:00 New Revision: bb10e03fba7106e51d2e64269d10c3ba95055b26 URL: https://github.com/llvm/llvm-project/commit/bb10e03fba7106e51d2e64269d10c3ba95055b26 DIFF: https://github.com/llvm/llvm-project/commit/bb10e03fba7106e51d2e64269d10c3ba95055b26.diff LO

[PATCH] D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS

egorzhdan updated this revision to Diff 397565. egorzhdan added a comment. Fix lint warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116615/new/ https://reviews.llvm.org/D116615 Files: clang/lib/Basic/DarwinSDKInfo.cpp clang/unittests/Bas

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

estan added a comment. @lebedev.ri @aaron.ballman I think the opt-in sounds good too. Are we waiting for @fiesh to implement this, or is the patch abandoned? Would be sad if it was stranded the way https://reviews.llvm.org/D31130 was, since I think many people are skipping this check due to dia

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx added a comment. In D116314#3221488 , @MyDeveloperDay wrote: > @ksyx > > Did you see this issue https://github.com/llvm/llvm-project/issues/52976 > > In its current form, this patch causes huge amounts of flux in projects > that document code like (

[PATCH] D115301: [clangd] Don't index __reserved_names in headers.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.h:334 +/// Returns true if Name is reserved, like _Foo or __Vector_base. +inline bool isReservedName(llvm::StringRef Name) { + // This doesn't catch all c

[clang-tools-extra] 055d809 - [clangd] Don't index __reserved_names in headers.

Author: Sam McCall Date: 2022-01-05T16:34:04+01:00 New Revision: 055d8090d1d5137dab88533995e0c5d9b5390c28 URL: https://github.com/llvm/llvm-project/commit/055d8090d1d5137dab88533995e0c5d9b5390c28 DIFF: https://github.com/llvm/llvm-project/commit/055d8090d1d5137dab88533995e0c5d9b5390c28.diff LO

[PATCH] D115301: [clangd] Don't index __reserved_names in headers.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG055d8090d1d5: [clangd] Don't index __reserved_names in headers. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D115301?vs=392579&i

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

rnk accepted this revision. rnk added a comment. lgtm Comment at: clang/test/CodeGen/pr52782-stdcall-func-decl.cpp:10 +class nsICanvasRenderingContextInternal { + NS_IMETHOD_(nsresult) InitializeWithDrawTarget(NotNull); +} nsTBaseHashSet; rnk wrote: > Please c

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

andmis updated this revision to Diff 397579. andmis added a comment. - Move source code for option documentation to `Format.h`, from which the RST is autogenerated. - Clean up tests in response to review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116638/new/ https://review

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

andmis added a comment. Thanks all for the reviews. I've updated the patch and added responses to your comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2820 +**JavaScriptWrapImports** (``Boolean``) :versionbadge:`clang-format 3.9` + Whether to wrap JavaScript im

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

mprobst added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2827 -**JavaScriptWrapImports** (``Boolean``) :versionbadge:`clang-format 3.9` - Whether to wrap JavaScript import/export statements. + * If ``ColumnWidth`` is 0 (no limit on the number of colum

[PATCH] D116658: [clang-format][NFC] Fix typo in comment

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. You need someone to land it for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116658/new/ https://reviews.llvm.org/D116658 _

[PATCH] D116627: [Clang] Initial support for linking offloading code in tool

jhuber6 updated this revision to Diff 397589. jhuber6 added a comment. Small changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116627/new/ https://reviews.llvm.org/D116627 Files: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp Inde

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

jhuber6 updated this revision to Diff 397590. jhuber6 added a comment. Clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116542/new/ https://reviews.llvm.org/D116542 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clan

[PATCH] D116658: [clang-format][NFC] Fix typo in comment

pjessesco added a comment. Yes please, this is my first contribution in this project. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116658/new/ https://reviews.llvm.org/D116658 ___ cfe-commits mailing li

  1   2   3   >