ChuanqiXu added a comment.

In D115790#3221307 <https://reviews.llvm.org/D115790#3221307>, @MaskRay wrote:

> Early heads-up: we see a failure with 
> `llvm/lib/Transforms/Coroutines/CoroEarly.cpp:186 in bool (anonymous 
> namespace)::Lowerer::lowerEarlyIntrinsics(llvm::Function &): 
> F.hasFnAttribute(CORO_PRESPLIT_ATTR) && 
> F.getFnAttribute(CORO_PRESPLIT_ATTR).getValueAsString() == 
> UNPREPARED_FOR_SPLIT && "The frontend uses Swtich-Resumed ABI should emit " 
> "\"coroutine.presplit\" attribute with value \"0\" for the " "coroutine."`
>
> A colleague may follow up with the issue or request a revert.

Thanks for reporting this. I have tested this locally with our workloads. I 
guess there are 3 reasons to hit this:
(1) The frontend (clang or mlir) is updated.
(2) The input IR is generated by an old frontend.
(3) The tested frontend uses switched-resume ABI coroutine intrinsics and the 
frontend isn't clang nor mlir.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115790/new/

https://reviews.llvm.org/D115790

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to