[clang] 80e20f9 - [clang-format] [docs] Fix Mozilla coding style URL.

Author: Marek Kurdej Date: 2022-01-03T09:10:37+01:00 New Revision: 80e20f9cbdd534b49785f24aa6fd05b70a6bd79d URL: https://github.com/llvm/llvm-project/commit/80e20f9cbdd534b49785f24aa6fd05b70a6bd79d DIFF: https://github.com/llvm/llvm-project/commit/80e20f9cbdd534b49785f24aa6fd05b70a6bd79d.diff

[PATCH] D116521: [llvm][clang][cmake] Factor out config prefix finding logic

Ericson2314 updated this revision to Diff 397015. Ericson2314 added a comment. Herald added a reviewer: sscalpone. Herald added a project: Flang. Oh, Flang and LLD are the same. Just do them now then Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116

[clang] ab0bfbd - [clang-format] Use get*StyleWithColumns helper. NFC.

Author: Marek Kurdej Date: 2022-01-03T09:45:33+01:00 New Revision: ab0bfbdaaa5189377a605e0584d9ba9b1fc49e75 URL: https://github.com/llvm/llvm-project/commit/ab0bfbdaaa5189377a605e0584d9ba9b1fc49e75 DIFF: https://github.com/llvm/llvm-project/commit/ab0bfbdaaa5189377a605e0584d9ba9b1fc49e75.diff

[PATCH] D116502: [clangd] Helper for determining member insertion point.

kadircet added a comment. We have some logic in AddUsing tweak to determine insertion point based on AST. i think it makes sense to migrate it to these helpers too. There's some more logic in extract variable/function too. Extract variable seems too elaborate as it actually looks at statements,

[PATCH] D116271: [Docs] Document C++ for OpenCL 2021 support in clang

Topotuna accepted this revision. Topotuna added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116271/new/ https://reviews.llvm.org/D116271 ___ cfe-commits mailing list cfe-comm

[PATCH] D116502: [clangd] Helper for determining member insertion point.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/InsertionPoint.cpp:51 +} else { + assert(A.Direction == Anchor::Below); + if (LastMatched && !Matches) nit: use a switch? Comment at: clang-tools-extra/

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/52914. Repository: rG LLVM

[PATCH] D116478: [clang-tidy] A comma-separated list of the names of functions or methods to be considered as not having side-effects

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:141 ^^ +- Added a setting ``bugprone-assert-side-effect.FunctionExceptions`` for + a comma-separated list of the names of functions or methods to be considered -

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

curdeius added a comment. I know I changed existing tests. I'm not sure what we really want here. If you have ideas, I'm open to suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116527/new/ https://reviews.llvm.org/D116527 __

[PATCH] D116478: [clang-tidy] A comma-separated list of the names of functions or methods to be considered as not having side-effects

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:141 ^^ +- Added a setting ``bugprone-assert-side-effect.FunctionExceptions`` for + a comma-separated list of the names of functions or methods to be considered -

[PATCH] D116218: [clangd] Fix selection on multi-dimensional array.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:526 + // the traversal order of SizeExpr and ElementTypeLoc, which gives a chance + // for the SizeExpr to claim its tokens. + bool TraverseConstantArrayTypeLoc(ConstantArrayTypeLoc X) { -

[PATCH] D116352: [CodeCompletion] Signature help for template argument lists

kadircet added a comment. thanks this looks great! just a question around rendering of the result type chunk. feel free to leave a fixme if there's no easy way of doing that. Comment at: clang/lib/Parse/ParseTemplate.cpp:1237 +/// +/// \param NameHint is not required, and mere

[PATCH] D115355: Fix build failure with GCC 11 in C++20 mode

Godin added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115355/new/ https://reviews.llvm.org/D115355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] 0090cd4 - [clang-format] Support inheriting from more than 1 parents in the fallback case

Author: Zhao Wei Liew Date: 2022-01-03T11:36:00+01:00 New Revision: 0090cd4e7a24bedeb24dfe5b3b55167ad74e231e URL: https://github.com/llvm/llvm-project/commit/0090cd4e7a24bedeb24dfe5b3b55167ad74e231e DIFF: https://github.com/llvm/llvm-project/commit/0090cd4e7a24bedeb24dfe5b3b55167ad74e231e.diff

[PATCH] D116371: [clang-format] Support inheriting from more than 1 parents in the fallback case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0090cd4e7a24: [clang-format] Support inheriting from more than 1 parents in the fallback case (authored by zwliew, committed by curdeius). Repositor

[clang] b9e173f - [clang-format] Add option to explicitly specify a config file

Author: Zhao Wei Liew Date: 2022-01-03T11:43:25+01:00 New Revision: b9e173fcd46b336b5589f577a74de9472d4deae3 URL: https://github.com/llvm/llvm-project/commit/b9e173fcd46b336b5589f577a74de9472d4deae3 DIFF: https://github.com/llvm/llvm-project/commit/b9e173fcd46b336b5589f577a74de9472d4deae3.diff

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3760 + true: false: + void operator++ (int a);vs.void operator++(int a); + Please add operator call as well to the example

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

curdeius added a comment. @GPery, do you need help landing this? If so, please indicate the name and email you'd like to be used for the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170 ___

[clang] 694e6bc - [clang-format][NFC] Correct comment about checking merging of blocks

Author: Gabriel Smith Date: 2022-01-03T11:51:13+01:00 New Revision: 694e6bcd525f9ceae6f377faa43115e22e839244 URL: https://github.com/llvm/llvm-project/commit/694e6bcd525f9ceae6f377faa43115e22e839244 DIFF: https://github.com/llvm/llvm-project/commit/694e6bcd525f9ceae6f377faa43115e22e839244.diff

[PATCH] D116189: [clang-format][NFC] Correct comment about checking merging of blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG694e6bcd525f: [clang-format][NFC] Correct comment about checking merging of blocks (authored by yodaldevoid, committed by curdeius). Changed prior t

[PATCH] D106349: [clang-format] respect AfterEnum for enums

curdeius accepted this revision. curdeius added a comment. LGTM. If nobody objects, I'll land this today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106349/new/ https://reviews.llvm.org/D106349 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations.

MyDeveloperDay added a comment. The fix looks ok, butr I don't understand the cause of the side effect? is it explicitly aligning to the v of `auto v`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116527/new/ https://reviews.llvm.org/D116527 ___

[PATCH] D106349: [clang-format] respect AfterEnum for enums

MyDeveloperDay added a comment. no objection from me, we need to clean up the non landed accepted reviews or it wastes our time in the first place. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106349/new/ https://reviews.llvm.org/D106349 __

[clang] cd2b050 - [clang-format] spacesRequiredBetween is not honouring clang-format off/on

Author: mydeveloperday Date: 2022-01-03T11:19:02Z New Revision: cd2b050fa4995b75b9c36fae16c0d9f105b67585 URL: https://github.com/llvm/llvm-project/commit/cd2b050fa4995b75b9c36fae16c0d9f105b67585 DIFF: https://github.com/llvm/llvm-project/commit/cd2b050fa4995b75b9c36fae16c0d9f105b67585.diff LOG

[PATCH] D116494: [clang-format] spacesRequiredBetween is not honouring clang-format off/on

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd2b050fa499: [clang-format] spacesRequiredBetween is not honouring clang-format off/on (authored by MyDeveloperDay). Repository: rG LLVM Github M

[PATCH] D116314: [clang-format] Add style to separate definition blocks

curdeius accepted this revision. curdeius added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D116502: [clangd] Helper for determining member insertion point.

sammccall updated this revision to Diff 397037. sammccall added a comment. Fix access protection bug, add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116502/new/ https://reviews.llvm.org/D116502 Files: clang-tools-extra/clangd/CMake

[PATCH] D116502: [clangd] Helper for determining member insertion point.

sammccall marked 2 inline comments as done. sammccall added a comment. In D116502#3217084 , @kadircet wrote: > We have some logic in AddUsing tweak to determine insertion point based on > AST. i think it makes sense to migrate it to these helpers too. T

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396972. Ericson2314 added a comment. Remove off topic bits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: llvm/CMakeLists.txt llvm/cmake/modules/AddLL

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 marked 4 inline comments as done. Ericson2314 added inline comments. Comment at: llvm/CMakeLists.txt:75 set(LLVM_ENABLE_PROJECTS "" CACHE STRING - "Semicolon-separated list of projects to build (${LLVM_KNOWN_PROJECTS}), or \"all\".") + "Semicolon-separated l

[PATCH] D116352: [CodeCompletion] Signature help for template argument lists

sammccall added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3785 + if (const auto *FTD = dyn_cast(TD)) +return FTD->getTemplatedDecl()->getType().getAsString(Policy); + if (isa(TD)) kadircet wrote: > the rendering looks a little bit sur

[PATCH] D116326: [CodeCompletion] Signature help for aggregate initialization.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1184 - auto Name = Ident->getName(); - if (!Name.empty()) -ParamNames.insert(Name.str()); we were never recording unnamed params before, now they'll be surface

[PATCH] D116159: [ARM][AArch64] clang support for Armv9.3-A

tmatheson updated this revision to Diff 397044. tmatheson added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116159/new/ https://reviews.llvm.org/D116159 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/AAr

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a comment. Ping @Quuxplusone for feedback on the `_CLANG_DISABLE_CRT_DEPRECATION_WARNINGS` macro that was added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews.llvm.org/D112221 ___ cfe-commits m

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115253/new/ https://reviews.llvm.org/D115253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D116502: [clangd] Helper for determining member insertion point.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! In D116502#3217270 , @sammccall wrote: > In D116502#3217084 , @kadircet > wrote: > >> We

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

GPery added a comment. In D116170#3217198 , @curdeius wrote: > @GPery, do you need help landing this? > If so, please indicate the name and email you'd like to be used for the > commit. Oh, sure, I didn't realise this part wasn't automatic. It's "gpery"

[PATCH] D116459: [Clang][Sema] Adjust formatting (NFC)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116459/new/ https://reviews.llvm.org/D116459

[PATCH] D112718: Add intrinsics and builtins for PTX atomics with semantic orders

t4c1 updated this revision to Diff 397047. t4c1 added a comment. Updated to the latest version that was merged into intel/llvm repo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112718/new/ https://reviews.llvm.org/D112718 Files: clang/include/

[PATCH] D116352: [CodeCompletion] Signature help for template argument lists

sammccall updated this revision to Diff 397049. sammccall added a comment. Change ResultType handling for template functions. Given: template string getName(int count) const & We return the signature: {ResultType=string} getName<{placeholder=typename T}>() Clangd renders this as: getNa

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

rajatbajpai added a comment. In D116283#3216235 , @MyDeveloperDay wrote: > LGTM, could you add a release note into docs/ReleaseNotes.rst? Sure, will do. Comment at: clang/docs/ClangFormatStyleOptions.rst:3760 + true:

[PATCH] D116535: [clang-tidy] Fix false positive in modernize-pass-by-value

courbet created this revision. courbet added reviewers: alexfh, flx, aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun. courbet requested review of this revision. Herald added a project: clang-tools-extra. The check should not trigger on lvalue/rvalue overload pairs: struct S {

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

hans added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:54 +#endif #include "MSVCSetupApi.h" +#ifdef __clang__ Since it's in our repository, would it be possible to fix clang/lib/Driver/ToolChains/MSVCSetupApi.h to be warning free? If it's

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

Quuxplusone added a comment. TLDR on `_CLANG_DISABLE_CRT_DEPRECATION_WARNINGS`: I'm neutral. :) Comment at: clang/docs/ReleaseNotes.rst:159-164 + - The ``ATOMIC_VAR_INIT`` macro from is now diagnosed as + deprecated in both C (C17 and later) and C++ (C++20 and later), an

[PATCH] D116536: [clangd] Fix selection on multi-dimensional array. (alternate version)

sammccall created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. based on D116218 Rep

[PATCH] D116224: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

ldionne commandeered this revision. ldionne added a reviewer: david-salinas. ldionne added a comment. Yeah, I think you messed something up with your git commands. I'm going to commandeer and abandon this revision to get it out of the libc++ review queue since it's been 10 days since this has be

[PATCH] D115521: [Templight] Don't display empty strings for names of unnamed template parameters

Szelethus updated this revision to Diff 397054. Szelethus added a comment. Add a default text, if another, unhandled unnamed identifier pops up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115521/new/ https://reviews.llvm.org/D115521 Files: clang/lib/Frontend/FrontendActions.cpp

[PATCH] D114425: [clang] Add __builtin_bswap128

Quuxplusone added a comment. In D114425#3216802 , @majnemer wrote: > OOC, how hard would it be to generalize this builtin a little? It is nice > that we have builtins like `__builtin_add_overflow` which do the right thing > regardless of their input. >

[PATCH] D116352: [CodeCompletion] Signature help for template argument lists

kadircet accepted this revision. kadircet added a comment. thanks! as discussed offline i think it's better to ignore function parameters for now. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3781 +// If the template is for a function `bool foo(int)`, then returns +// `bool

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:159-164 + - The ``ATOMIC_VAR_INIT`` macro from is now diagnosed as + deprecated in both C (C17 and later) and C++ (C++20 and later), and + ``ATOMI

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman updated this revision to Diff 397061. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updated release notes and user's manual based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews.llvm.org/D112221

[PATCH] D116536: [clangd] Fix selection on multi-dimensional array.

sammccall updated this revision to Diff 397062. sammccall retitled this revision from "[clangd] Fix selection on multi-dimensional array. (alternate version)" to "[clangd] Fix selection on multi-dimensional array.". sammccall edited the summary of this revision. sammccall added a comment. cleane

[PATCH] D116511: [clang-cl] Support the /HOTPATCH flag

aganea updated this revision to Diff 397063. aganea added a subscriber: saudi. aganea added a comment. Fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116511/new/ https://reviews.llvm.org/D116511 Files: clang/include/clang/Basic/CodeGen

[clang] cd45e8c - [CodeCompletion] Signature help for template argument lists

Author: Sam McCall Date: 2022-01-03T16:28:16+01:00 New Revision: cd45e8c7bc16dec2eeec9cc71eb3ba87d1bd6bab URL: https://github.com/llvm/llvm-project/commit/cd45e8c7bc16dec2eeec9cc71eb3ba87d1bd6bab DIFF: https://github.com/llvm/llvm-project/commit/cd45e8c7bc16dec2eeec9cc71eb3ba87d1bd6bab.diff LO

[PATCH] D116352: [CodeCompletion] Signature help for template argument lists

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd45e8c7bc16: [CodeCompletion] Signature help for template argument lists (authored by sammccall). Changed prior to commit: https://reviews.llvm.o

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

aaron.ballman added a comment. Mostly just minor nits at this point. Please be sure to update the documentation and add a release note about the changes. Comment at: clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:1 + //===--- UseDefaultMemberInitCheck.c

[PATCH] D116147: [clangd] Respect .clang-tidy ExtraArgs (-Wfoo only) when producing diagnostics

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/ParsedAST.cpp:270 +// We don't want this, so keep track of them to fix afterwards. +llvm::DenseSet NeedsWerrorE

[PATCH] D115936: [Clang] Add isInNamespace() to check if a Decl in a specific namespace

aaron.ballman added a comment. These changes lack test coverage or uses of the new API, so it's a bit hard to tell whether it's being used correctly or not. Comment at: clang/include/clang/AST/DeclBase.h:466 bool isInStdNamespace() const; + bool isInNamespace(llvm::StringR

[clang] 4435d18 - [ARM][AArch64] clang support for Armv9.3-A

Author: Tomas Matheson Date: 2022-01-03T16:02:36Z New Revision: 4435d1819efec06e11461799fe83d6f148b098f4 URL: https://github.com/llvm/llvm-project/commit/4435d1819efec06e11461799fe83d6f148b098f4 DIFF: https://github.com/llvm/llvm-project/commit/4435d1819efec06e11461799fe83d6f148b098f4.diff LOG

[PATCH] D116159: [ARM][AArch64] clang support for Armv9.3-A

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4435d1819efe: [ARM][AArch64] clang support for Armv9.3-A (authored by tmatheson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7505aee - [clang] Pacify GCC warning. NFC.

Author: Michael Liao Date: 2022-01-03T11:05:36-05:00 New Revision: 7505aeefc4e615520e2c822b9647dad4a48276b9 URL: https://github.com/llvm/llvm-project/commit/7505aeefc4e615520e2c822b9647dad4a48276b9 DIFF: https://github.com/llvm/llvm-project/commit/7505aeefc4e615520e2c822b9647dad4a48276b9.diff

[PATCH] D116488: Add a misc-unused-parameters.CommentOutUnusedParameters to clang-tidy

Mogball added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp:157 // will clean this up afterwards. -MyDiag << FixItHint::CreateReplacement( -RemovalRange, (Twine(" /*") + Param->getName() + "*/").str()); +if (Options.

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

aganea updated this revision to Diff 397069. aganea marked 2 inline comments as done. aganea added a comment. Herald added subscribers: hiraditya, mgorny. As suggested by @hans Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116313/new/ https://revie

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

aganea added inline comments. Comment at: llvm/include/llvm/DebugInfo/PDB/DIA/DIASupport.h:34 +#endif #include +#ifdef __clang__ hans wrote: > I thought this warning should be suppressed for system headers. Isn't that > working here? Good point, because it was

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

momo5502 added a comment. In D115456#3216811 , @majnemer wrote: > This is looking great! Just a few more questions. > > What is the behavior with something like: > > thread_local int x = 2; > int f() { > return x; > } > > I'm wondering if we nee

[PATCH] D116154: [ARM] Adding macros for coprocessor intrinsics as per ACLE

tmatheson updated this revision to Diff 397071. tmatheson added a comment. Add 8.8 and 9.3; patches adding these were merged first in the end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116154/new/ https://reviews.llvm.org/D116154 Files: clan

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

saiislam updated this revision to Diff 397073. saiislam added a comment. Updated comments as per suggestion. Apologies for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111545/new/ https://reviews.llvm.org/D111545 Files: clang/lib/Dri

[PATCH] D116326: [CodeCompletion] Signature help for aggregate initialization.

sammccall updated this revision to Diff 397075. sammccall marked an inline comment as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116326/new/ https://reviews.llvm.org/D116326 Files: clang-tools

[PATCH] D116326: [CodeCompletion] Signature help for aggregate initialization.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1184 - auto Name = Ident->getName(); - if (!Name.empty()) -ParamNames.insert(Name.str()); kadircet wrote: > we wer

[clang-tools-extra] 9e6f88b - [clangd] Respect .clang-tidy ExtraArgs (-Wfoo only) when producing diagnostics

Author: Sam McCall Date: 2022-01-03T17:58:41+01:00 New Revision: 9e6f88b31a7f7957a850d3541ffa759f2993ffc1 URL: https://github.com/llvm/llvm-project/commit/9e6f88b31a7f7957a850d3541ffa759f2993ffc1 DIFF: https://github.com/llvm/llvm-project/commit/9e6f88b31a7f7957a850d3541ffa759f2993ffc1.diff LO

[PATCH] D116147: [clangd] Respect .clang-tidy ExtraArgs (-Wfoo only) when producing diagnostics

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG9e6f88b31a7f: [clangd] Respect .clang-tidy ExtraArgs (-Wfoo only) when producing diagnostics (authored by sammccall). Changed prior to commit: https://reviews

[clang-tools-extra] fe68088 - [clangd] Helper for determining member insertion point.

Author: Sam McCall Date: 2022-01-03T17:59:45+01:00 New Revision: fe68088d44f760c7d3d8ee6735d396d97cb55478 URL: https://github.com/llvm/llvm-project/commit/fe68088d44f760c7d3d8ee6735d396d97cb55478 DIFF: https://github.com/llvm/llvm-project/commit/fe68088d44f760c7d3d8ee6735d396d97cb55478.diff LO

[PATCH] D116502: [clangd] Helper for determining member insertion point.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGfe68088d44f7: [clangd] Helper for determining member insertion point. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 478863e - [clangd] Basic IncludeCleaner support for c/c++ standard library

Author: Sam McCall Date: 2022-01-03T18:19:56+01:00 New Revision: 478863ef58c7f7314e0669d332a90d6e233d44fb URL: https://github.com/llvm/llvm-project/commit/478863ef58c7f7314e0669d332a90d6e233d44fb DIFF: https://github.com/llvm/llvm-project/commit/478863ef58c7f7314e0669d332a90d6e233d44fb.diff LO

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

This revision was automatically updated to reflect the committed changes. sammccall marked 4 inline comments as done. Closed by commit rG478863ef58c7: [clangd] Basic IncludeCleaner support for c/c++ standard library (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D114

[PATCH] D111100: enable plugins for clang-tidy

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:428 +of our new checks. + +.. code-block:: console We should also document our expectations explicitly regarding things like ABI and API stability. e.g., remind u

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added subscribers: ormris, dexonsmith, dang, guansong, hiraditya, yaxunl, mgorny. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky updated this revision to Diff 397086. oleg.smolsky marked 2 inline comments as done. oleg.smolsky added a comment. Addressed review comments: explicit types and doc changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114995/new/ htt

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

oleg.smolsky added a comment. Done with review changes. Comment at: clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:1 + //===--- UseDefaultMemberInitCheck.cpp - clang-tidy===// aaron.ballman wrote: > Spurious newl

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 updated this revision to Diff 397089. jhuber6 added a comment. Updating to only contain this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116541/new/ https://reviews.llvm.org/D116541 Files: clang/include/clang/Driver/Driver.h

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added subscribers: ormris, dexonsmith, dang, guansong, hiraditya, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald

[PATCH] D116543: [OpenMP] Embed device files into the host IR

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds support f

[PATCH] D115716: [Analyzer][BugReporter] Replace the example bug report with the one used to generate PathDiagnostic

Szelethus added a comment. First off, your patch is great, and I'm pretty sure we want it! I remember working around here, and I either have never quite understood what makes `exampleReport` an example, or have long forgotten. Can we not just rename it to `chosenReport`, or simply `report`?

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

beanz added inline comments. Comment at: clang/CMakeLists.txt:26 "--src-root" - "--cmakedir") + "--cmakedir" + "--bindir" I assume these are re-arranged to match what you're doing in lld. Is that correct? Generally it is preferred to do th

[PATCH] D116544: [Clang] Introduce Clang Linker Wrapper Tool

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added a subscriber: mgorny. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch introduces a linker wra

[PATCH] D116545: [OpenMP] Add support for extracting device code in linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added subscribers: guansong, yaxunl, mgorny. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patchs add s

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 added inline comments. Comment at: clang/CMakeLists.txt:26 "--src-root" - "--cmakedir") + "--cmakedir" + "--bindir" beanz wrote: > I assume these are re-arranged to match what you're doing in lld. Is that > correct? > > General

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

beanz added inline comments. Comment at: clang/CMakeLists.txt:26 "--src-root" - "--cmakedir") + "--cmakedir" + "--bindir" Ericson2314 wrote: > beanz wrote: > > I assume these are re-arranged to match what you're doing in lld. Is that > > co

[PATCH] D114425: [clang] Add __builtin_bswap128

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2930 + } + [[fallthrough]]; case Builtin::BI__builtin_bswap16: Quuxplusone wrote: > Re clang-format's complaint: I would either move `[[fallthrough]];` inside > the curly braces

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116313/new/ https://reviews.llvm.org/D116313 ___ cfe

[PATCH] D115106: [clang-tidy] Fix `readability-static-accessed-through-instance` false negative for static methods

aaron.ballman added reviewers: sammccall, klimek, hokein. aaron.ballman added a comment. Adding some more reviewers, as this is starting to touch on AST matcher design more deeply and needs a wider audience. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6017 +/// c

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

aganea added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116313/new/ https://reviews.llvm.org/D116313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

majnemer added a comment. In D115456#3217595 , @momo5502 wrote: > In D115456#3216811 , @majnemer > wrote: > >> This is looking great! Just a few more questions. >> >> What is the behavior with something like: >>

[PATCH] D114425: [clang] Add __builtin_bswap128

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2930 + } + [[fallthrough]]; case Builtin::BI__builtin_bswap16: craig.topper wrote: > Quuxplusone wrote: > > Re clang-format's complaint: I would either move `[[fallthrough]];` in

[PATCH] D116547: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

david-salinas created this revision. Herald added subscribers: luke957, abrachet, ormris, foad, dang, jdoerfert, phosek, kerbowa, usaxena95, pengfei, s.egerton, asbirlea, mstorsjo, lebedev.ri, kadircet, rupprecht, arphaman, steven_wu, mgrang, simoncook, fedor.sergeev, hiraditya, krytarowski, ari

[PATCH] D116548: [clang][cmake] Rearrange top-level CMakeLists.txt for D116492

Ericson2314 created this revision. Ericson2314 added reviewers: beanz, tstellar. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In that revision, I make LLD match Clang in deprecating `llvm-co

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 updated this revision to Diff 397100. Ericson2314 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Split out Clang changes into separate commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116492/n

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 marked 2 inline comments as done. Ericson2314 added inline comments. Comment at: clang/CMakeLists.txt:26 "--src-root" - "--cmakedir") + "--cmakedir" + "--bindir" beanz wrote: > Ericson2314 wrote: > > beanz wrote: > > > I assume t

[PATCH] D114425: [clang] Add __builtin_bswap128

majnemer added a comment. In D114425#3217478 , @Quuxplusone wrote: > In D114425#3216802 , @majnemer > wrote: > >> OOC, how hard would it be to generalize this builtin a little? It is nice >> that we have builti

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: clang/CMakeLists.txt:26 "--src-root" - "--cmakedir") + "--cmakedir" + "--bindir" Ericson2314 wrote: > beanz wrote: > > Ericson2314 wrote: > > > bean

  1   2   3   >