beanz added inline comments.
================
Comment at: clang/CMakeLists.txt:26
"--src-root"
- "--cmakedir")
+ "--cmakedir"
+ "--bindir"
----------------
I assume these are re-arranged to match what you're doing in lld. Is that
correct?
Generally it is preferred to do this kind of non-functional restructuring in a
separate commit from the commit with a functional change to make it easier to
review the functional changes.
This patch as-is seems to have cleanup to clang, and a functional change for
lld. Those should likely be two separate commits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116492/new/
https://reviews.llvm.org/D116492
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
