[PATCH] D115355: Fix build failure with GCC 11 in C++20 mode

Godin added a comment. Can someone please commit this on my behalf since I do not have commit rights? Comment at: clang/lib/AST/ASTImporter.cpp:8400-8403 + AttrArgImporter(const AttrArgImporter &) = delete; + AttrArgImporter(AttrArgImporter &&) = default; AttrArgImporter &

[PATCH] D115576: [clang-tidy][#51939] Exempt placement-new expressions from 'bugprone-throw-keyword-missing'

zero9178 created this revision. zero9178 added reviewers: Szelethus, aaron.ballman, alexfh, hokein, whisperity. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun. zero9178 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

jeroen.dobbelaere added a comment. We're almost there. But the testcase is now not testing what it should be testing. Also the unused `CHECK:` must be adapted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320 _

[PATCH] D115094: Fix -Wdeclaration-after-statement doesn't work when used with -std=c99

xgupta added subscribers: zero9178, xgupta. xgupta added a comment. In D115094#3174635 , @dblaikie wrote: > This'll at least need a test case added - though the specifics of how the > warning should work I'll leave up to @aaron.ballman - unless he wants

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

pengfei added a comment. > I seem to recall assuming that Windows long double was 64-bits in many, many > places. Unfortunately, I have no idea where that could've happened. Is it because MSDN explicitly declares it? https://docs.microsoft.com/en-us/previous-versions/9cx8xs15(v=vs.140)?redirect

[PATCH] D115521: [Templight] Don't display empty strings for names of unnamed template parameters

sabel83 added inline comments. Comment at: clang/lib/Frontend/FrontendActions.cpp:554 + +llvm_unreachable("Failed to retrieve a name for this entry!"); + } Have you considered generating some default text here? In case a new, uncovered case does not get cov

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

xbolva00 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:157 ABI stability. +- When using ``asm goto`` with outputs whose constraint modifier is ``"+"``, we + now change the numbering of the labels to occur after hidden tied inputs for there is

[PATCH] D115580: [clang] [unitttests] Fix linking Basic test to LLVMTestingSupport

mgorny created this revision. mgorny added a reviewer: dexonsmith. mgorny requested review of this revision. Link BasicTests via explicit target_link_libraries() rather than clang_target_link_libraries() in order to fix linking when building clang against libclang. The latter requires all listed

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 added a comment. I tried again without lld in the list of enable projects, in case it that made a difference to force it to use ld64 more, but it still worked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.l

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

mib added a comment. In D100810#3186066 , @Ericson2314 wrote: > I tried again without lld in the list of enable projects, in case it that > made a difference to force it to use ld64 more, but it still worked. Hi @Ericson2314, I tried reproducing the fa

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 393575. Ericson2314 added a comment. Herald added a subscriber: sdasgup3. Rebase after landing parent diff again, take 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99

[PATCH] D115566: Quote some more destination paths with variables

Ericson2314 created this revision. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added projects: clang, libc++, OpenMP. Herald added subscribers: openmp-commits, libcxx-commits, cfe-commits. Herald added a reviewer: libc++. Just defensive CMake-ing. I pul

[PATCH] D115566: Quote some more destination paths with variables

Ericson2314 updated this revision to Diff 393645. Ericson2314 added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, lldb-commits, sstefan1, jvesely. Herald added projects: LLDB, LLVM. 1. Updating D115566 : Quote some more

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. I split out D115568 D115569 D115570 from this. I think it is better to start from the outside and work back inward, so the LLVM-only commit that previously came

[clang] c2bb963 - Use llvm::any_of and llvm::all_of (NFC)

Author: Kazu Hirata Date: 2021-12-11T11:54:37-08:00 New Revision: c2bb9637d97029d4c97c256718ed1f771d02c232 URL: https://github.com/llvm/llvm-project/commit/c2bb9637d97029d4c97c256718ed1f771d02c232 DIFF: https://github.com/llvm/llvm-project/commit/c2bb9637d97029d4c97c256718ed1f771d02c232.diff L

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

foutrelis accepted this revision. foutrelis added a comment. No issues with default PIE and SSP on Arch for over 4 years now. It's nice to see this being upstreamed; thanks for doing it. This patch worked fine. Based on my own hack

[PATCH] D115573: [Clang][OpenMP] Return error ahead of time if there are multiple mutex clauses in atomic directive

tianshilei1992 updated this revision to Diff 393702. tianshilei1992 added a comment. add another error return for memory order clauses Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115573/new/ https://reviews.llvm.org/D115573 Files: clang/lib/Se

[PATCH] D115586: [NFC][Clang][OpenMP] Use switch-case statement to process clauses of atomic directive

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch makes the process of cl

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

ymandel updated this revision to Diff 393705. ymandel added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115341/new/ https://reviews.llvm.org/D115341 Files: clang/include/clang/Analysis/FlowSensitive/TypeErasedDataflowAnalysis

[PATCH] D115586: [NFC][Clang][OpenMP] Use switch-case statement to process clauses of atomic directive

tianshilei1992 updated this revision to Diff 393706. tianshilei1992 added a comment. add missing `break` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115586/new/ https://reviews.llvm.org/D115586 Files: clang/lib/Sema/SemaOpenMP.cpp Index: cla

[clang] 93fbaa4 - Revert "Revert "[clang][dataflow] Add framework for testing analyses.""

Author: Yitzhak Mandelbaum Date: 2021-12-11T23:16:59Z New Revision: 93fbaa46c82abd2d54bce9a7c3b39b01c30220d6 URL: https://github.com/llvm/llvm-project/commit/93fbaa46c82abd2d54bce9a7c3b39b01c30220d6 DIFF: https://github.com/llvm/llvm-project/commit/93fbaa46c82abd2d54bce9a7c3b39b01c30220d6.diff

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93fbaa46c82a: Revert "Revert "[clang][dataflow] Add framework for testing analyses."" (authored by ymandel). Repository: rG LLVM Github Monorepo

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

joerg added inline comments. Comment at: clang/CMakeLists.txt:230 +option(CLANG_DEFAULT_PIE "Default to -fPIE and -pie (Linux only)" OFF) +if(CLANG_DEFAULT_PIE) This option should really be called something like CLANG_DEFAULT_PIE_ON_LINUX or so. It should be e

[clang] ea68ce2 - [AST] Remove isWhitespace in favor of clang::isWhitespace (NFC)

Author: Kazu Hirata Date: 2021-12-11T22:52:00-08:00 New Revision: ea68ce2a9be0f7c4b41fbf3f8dc86b683ba7727e URL: https://github.com/llvm/llvm-project/commit/ea68ce2a9be0f7c4b41fbf3f8dc86b683ba7727e DIFF: https://github.com/llvm/llvm-project/commit/ea68ce2a9be0f7c4b41fbf3f8dc86b683ba7727e.diff L

[clang] 474e1bc - [AST] Remove an unnecessary continue (NFC)

Author: Kazu Hirata Date: 2021-12-11T23:04:08-08:00 New Revision: 474e1bc96d0c7b8da85b5ba1a52ebfc5f4a6835f URL: https://github.com/llvm/llvm-project/commit/474e1bc96d0c7b8da85b5ba1a52ebfc5f4a6835f DIFF: https://github.com/llvm/llvm-project/commit/474e1bc96d0c7b8da85b5ba1a52ebfc5f4a6835f.diff L