Godin added a comment.

Can someone please commit this on my behalf since I do not have commit rights?



================
Comment at: clang/lib/AST/ASTImporter.cpp:8400-8403
+  AttrArgImporter(const AttrArgImporter<T> &) = delete;
+  AttrArgImporter(AttrArgImporter<T> &&) = default;
   AttrArgImporter<T> &operator=(const AttrArgImporter<T> &) = delete;
   AttrArgImporter<T> &operator=(AttrArgImporter<T> &&) = default;
----------------
dexonsmith wrote:
> Might be nice to remove the implied `<T>`s in the parameters/returns (here 
> and elsewhere) as a follow up; a bit noisy to read those, even if it doesn't 
> cause a build failure (probably separately from this patch).
Thank you for the review @dexonsmith !

I will also prefer such cleanup to be done separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115355/new/

https://reviews.llvm.org/D115355

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to