[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

carlosgalvezp added a comment. Kind ping to reviewers, I mostly want to know if you agree with the general direction so I can go ahead and implement the rest of the patch. It's a big change (replace all check registrations with the macro) so I'd like to avoid extra work if you are strongly agai

[PATCH] D114949: [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls when definition is available

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:127 +// declared multiple times. The most common two cases are: +// - Definition available in TU,

[PATCH] D112453: [Sema] When dereferencing a pointer of dependent type, infer the result type.

courbet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112453/new/ https://reviews.llvm.org/D112453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D114949: [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls when definition is available

kbobyrev added a comment. In D114949#3169074 , @kadircet wrote: > thanks! Aww, sorry, I capitalized/reformatted parts of them but missed the rest :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114949/new

[PATCH] D114949: [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls when definition is available

kbobyrev updated this revision to Diff 391566. kbobyrev added a comment. Fix typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114949/new/ https://reviews.llvm.org/D114949 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tools-extra

[PATCH] D114949: [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls when definition is available

kbobyrev updated this revision to Diff 391567. kbobyrev marked an inline comment as done. kbobyrev added a comment. Improve wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114949/new/ https://reviews.llvm.org/D114949 Files: clang-tools-ex

[clang-tools-extra] bab7a30 - [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls when definition is available

Author: Kirill Bobyrev Date: 2021-12-03T09:36:50+01:00 New Revision: bab7a30ab692059e5e9dc867a59b9ead47efd35c URL: https://github.com/llvm/llvm-project/commit/bab7a30ab692059e5e9dc867a59b9ead47efd35c DIFF: https://github.com/llvm/llvm-project/commit/bab7a30ab692059e5e9dc867a59b9ead47efd35c.diff

[PATCH] D114949: [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls when definition is available

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbab7a30ab692: [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls… (authored by kbobyrev). Repository: rG LLVM Github Mono

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:372 QualType resultTy) { NonLoc InputLHS = lhs; NonLoc InputRHS = rhs; steakhal wrote: > @martong, you simplified the operands

[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Thanks for confirming! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114968/new/ https://reviews.llvm.org/D114968 ___ cfe-commits maili

[PATCH] D114938: [Analyzer] SValBuilder: Simlify a SymExpr to the absolute simplest form

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:51 + // sub-trees and if a value is a constant we do the constant folding. + SVal simplifySValImpl(ProgramStateRef State, SVal V); + steakhal wrote: > What about call

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire updated this revision to Diff 391574. junaire added a comment. No more lambdas CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114688/new/ https://reviews.llvm.org/D114688 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/DiagnosticSemaKinds.td clang/i

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray created this revision. lichray requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. C++20 NTTP (non-type template parameter) prints `MyType<{{116, 104, 105, 115}}>` when the code is as simple as `MyType<"this">`. Of course, due to the

[PATCH] D114116: [clang][ARM] relax -mtp=cp15 for non-thumb cases

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. LGTM, thanks for the update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114116/new/ https://reviews.llvm.org/D114116 _

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:372 QualType resultTy) { NonLoc InputLHS = lhs; NonLoc InputRHS = rhs; martong wrote: > steakhal wrote: > > @martong, you sim

[clang] 4f94c02 - [Clang] Mutate bulitin names under IEEE128 on PPC64

Author: Qiu Chaofan Date: 2021-12-03T17:50:18+08:00 New Revision: 4f94c02616025ace168899b6fbdc8c3ba240062b URL: https://github.com/llvm/llvm-project/commit/4f94c02616025ace168899b6fbdc8c3ba240062b DIFF: https://github.com/llvm/llvm-project/commit/4f94c02616025ace168899b6fbdc8c3ba240062b.diff L

[PATCH] D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f94c0261602: [Clang] Mutate bulitin names under IEEE128 on PPC64 (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/D112401?v

[PATCH] D115032: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

foad created this revision. foad added reviewers: arsenm, rampitec, yaxunl, critson, b-sumner. Herald added subscribers: kerbowa, hiraditya, t-tye, Anastasia, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. foad requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, w

[PATCH] D115032: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

foad added a comment. This is an alternative to D114957 that does not update the API of the OpenCL builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115032/new/ https://reviews.llvm.org/D115032 ___

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

foad added a comment. In D114957#3167700 , @arsenm wrote: > I think this macro is purely terrible and should not be added (and at least > should be all caps?). If we can't just hard break users, I would rather just > leave the builtin signatures broken

[clang] b9adaa1 - [PowerPC] [Clang] Fix alignment adjustment of single-elemented float128

Author: Qiu Chaofan Date: 2021-12-03T18:07:34+08:00 New Revision: b9adaa1782db727df08b8138e12c1e60964885d3 URL: https://github.com/llvm/llvm-project/commit/b9adaa1782db727df08b8138e12c1e60964885d3 DIFF: https://github.com/llvm/llvm-project/commit/b9adaa1782db727df08b8138e12c1e60964885d3.diff L

[PATCH] D114937: [PowerPC] [Clang] Fix alignment adjustment of single-elemented float128

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9adaa1782db: [PowerPC] [Clang] Fix alignment adjustment of single-elemented float128 (authored by qiucf). Changed prior to commit: https://review

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen updated this revision to Diff 391588. steffenlarsen edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/ https://reviews.llvm.org/D114439 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen added a comment. Thank you both for the reviews! Consensus seems to be having support for pack expansion at argument level for now and let more complicated logic be added when there is an actual need. I have applied these changes as I understood them and have added/adjusted the re

[PATCH] D115014: [clang] RFC: NFC: simplify macro tokens assignment

simon_tatham added a comment. I don't think so, I'm afraid. If you look at the definition of `MacroInfo::tokens_begin()` in `clang/include/clang/Lex/MacroInfo.h`, you see that it doesn't return a raw `Token *`: it returns a C++ iterator object. using tokens_iterator = SmallVectorImpl::const_i

[PATCH] D25844: [Sema][ObjC] Warn about implicitly autoreleasing indirect parameters that are captured by blocks

Cy-4AH added a comment. Hello! What compiler do when call doStuff: NSString * __strong fillMe; NSString * __autoreleasing autorelesingFillMe = fillMe; doStuff(&fillMe); fillMe = autoreleasingFillMe; Why it's not making the same thing in doStuff body? Compiler generated code for yours ex

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau updated this revision to Diff 391595. MattDevereau added a comment. updated SVEMAP2 types added overloadable intrinsics updated BUILTIN function signatures CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/ https://reviews.llvm.org/D114713 Files: clang/include/cla

[PATCH] D115014: [clang] RFC: NFC: simplify macro tokens assignment

zhouyizhou added a comment. In D115014#3169400 , @simon_tatham wrote: > I don't think so, I'm afraid. If you look at the definition of > `MacroInfo::tokens_begin()` in `clang/include/clang/Lex/MacroInfo.h`, you see > that it doesn't return a raw `Token

[PATCH] D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions

ebrevnov added a comment. While -Bsymbolic-funtions brings nice performance improvements it also changes symbol resolution order. That means we effectively disabled preemption for functions and all references from inside libLLVM*.so will be resolved locally. But references to global data can

[PATCH] D115014: [clang] RFC: NFC: simplify macro tokens assignment

simon_tatham added a comment. Ah, now I see what you mean – I didn't look far enough! I don't know this code well (in fact I'm not sure why you picked me as a reviewer), but off the top of my head: the question is not just whether `tokens_iterator` happens to be the same thing as `const Token *

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 391600. lichray added a comment. Fix failed assertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/lib/AST/APValue.cpp Index: clang/lib/AST/APValue

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 391602. lichray added a comment. Restore deleted comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/lib/AST/APValue.cpp Index: clang/lib/AST/APVa

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely updated this revision to Diff 391604. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000 Files: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp clang-tools-extra/clang-tidy/cert/CMakeLists.txt clang-tools-extra/clang-tidy/cert/

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely marked an inline comment as done. futogergely added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/ObsolescentFunctionsCheck.cpp:48 + // Matching functions with safe replacements in annex K. + auto FunctionNamesWithAnnexKReplacementMatcher = hasAnyNa

[PATCH] D106585: Fix clang debug info irgen of i128 enums

glandium added a comment. So far, what I've found is that in some cases, DIEnumerator::get returns the same node for similar enumerator values in different enums that happen to have the same name and value (even if their bitwidth differs), but sometimes not. For example, in one compilation I see

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely marked an inline comment as done. futogergely added a comment. In D91000#3161296 , @whisperity wrote: > Should/does this work in C++ mode for `std::whatever`? Right now the checker finds the functions in the global namespace only. The recomme

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki added a comment. Thanks, @Anastasia. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki added a comment. The patch is ready to land. @Anastasia, @bader, could you commit this patch to the LLVM for us? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/ https://reviews.llvm.org/D109818

[PATCH] D115014: [clang] RFC: NFC: simplify macro tokens assignment

zhouyizhou added a comment. In D115014#3169444 , @simon_tatham wrote: > Ah, now I see what you mean – I didn't look far enough! > > I don't know this code well (in fact I'm not sure why you picked me as a > reviewer), but off the top of my head: the que

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

steakhal added a comment. L129 and L135 are uncovered by tests. The rest of the lines are covered by tests, according to `lcov`. The checker produced in total 15 reports on these 18 projects: `memcached,tmux,curl,twin,vim,openssl,sqlite,ffmpeg,postgres,tinyxml2,libwebm,xerces,bitcoin,protobuf,qt

[PATCH] D106585: Fix clang debug info irgen of i128 enums

glandium added a comment. Reduced testcase: enum FrameIID { nsBox_id, nsIFrame_id, nsHTMLFramesetBlankFrame_id, nsHTMLFramesetBorderFrame_id, }; enum class ClassID : unsigned char { nsBox_id, nsIFrame_id, nsHTMLFramesetBlankFrame_id, nsHTMLFramesetBorderFr

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau updated this revision to Diff 391616. MattDevereau added a comment. run clang format to fix test macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/ https://reviews.llvm.org/D114713 Files: clang/include/clang/Basic/Built

[PATCH] D115015: CodeGen: Strip exception specifications from function types in CFI type names.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115015/new/ https://reviews.llvm.org/D115015 ___ c

[PATCH] D115039: [HIP] Fix -fgpu-rdc for Windows

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. This patch fixes issues for -fgpu-rdc for Windows MSVC toolchain: Fix COFF specific section flags and remove section types in llvm-mc input file for Windows. Escape fatbin path in llvm-mc input

[clang] f627956 - [OPENMP]Fix PR52117: Crash caused by target region inside of task construct.

Author: Alexey Bataev Date: 2021-12-03T07:01:00-08:00 New Revision: f6279562dae456f6c58d5f7484ba4bae5c2071fa URL: https://github.com/llvm/llvm-project/commit/f6279562dae456f6c58d5f7484ba4bae5c2071fa DIFF: https://github.com/llvm/llvm-project/commit/f6279562dae456f6c58d5f7484ba4bae5c2071fa.diff

[PATCH] D114546: [OPENMP]Fix PR52117: Crash caused by target region inside of task construct.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6279562dae4: [OPENMP]Fix PR52117: Crash caused by target region inside of task construct. (authored by ABataev). Repository: rG LLVM Github Monor

[PATCH] D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions

rnk added a comment. In D102090#3169439 , @ebrevnov wrote: > While -Bsymbolic-funtions brings nice performance improvements it also > changes symbol resolution order. That means we effectively disabled > preemption for functions and all references from

[PATCH] D114602: [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new

balazske updated this revision to Diff 391640. balazske marked 2 inline comments as done. balazske added a comment. Applied the text changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114602/new/ https://reviews.llvm.org/D114602 Files: clan

[PATCH] D114602: [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1cefe91d40ae: [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception… (authored by balazske). Repository: rG LLVM Github Mo

[clang-tools-extra] 1cefe91 - [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new

Author: Balázs Kéri Date: 2021-12-03T16:53:08+01:00 New Revision: 1cefe91d40aef043ec949c6ddb053b47b4d5b8e6 URL: https://github.com/llvm/llvm-project/commit/1cefe91d40aef043ec949c6ddb053b47b4d5b8e6 DIFF: https://github.com/llvm/llvm-project/commit/1cefe91d40aef043ec949c6ddb053b47b4d5b8e6.diff L

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch avoids unnecessarily copying `mmap`-ed memory into

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 added inline comments. Comment at: llvm/include/llvm/Support/SmallVectorMemoryBuffer.h:54 + /// and invoke the given function right after the move. + SmallVectorMemoryBuffer( + SmallVectorImpl &&SV, I'm not happy with introducing new (hacky) c

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

simoll created this revision. simoll added reviewers: kaz7, MaskRay, phosek. simoll requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before, the CLANG_DEFAULT_LINKER cmake option was a global override for the linker that shall be used on all

[PATCH] D106585: Fix clang debug info irgen of i128 enums

rnk added a subscriber: aeubanks. rnk added a comment. Thanks for the reduction, it sounds like there is something wrong with the way DIEnumerator is uniqued in the LLVMContext. I probably don't have time to follow up on this, but maybe @dblaikie and @aeubanks can help out. Repository: rG LL

[PATCH] D106585: Fix clang debug info irgen of i128 enums

rnk added a comment. This usage of isSameValue seems suspicious: https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/LLVMContextImpl.h#L389 It seems to allow the possibility that APInts of differing bitwidth compare equal, but the hash value incorporates the bitwidth, so they may be inse

[clang] 7b54de5 - [funcattrs] Fix a bug in recently introduced writeonly argument inference

Author: Philip Reames Date: 2021-12-03T08:57:15-08:00 New Revision: 7b54de5feffedfc08e5a02d6c9e27c54e3b7f119 URL: https://github.com/llvm/llvm-project/commit/7b54de5feffedfc08e5a02d6c9e27c54e3b7f119 DIFF: https://github.com/llvm/llvm-project/commit/7b54de5feffedfc08e5a02d6c9e27c54e3b7f119.diff

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

collinbaker created this revision. Herald added subscribers: abrachet, danielkiss, kristof.beyls. collinbaker requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang searches for runtimes (e.g. libclang_rt*) first in a subdirectory named for

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

paulwalker-arm requested changes to this revision. paulwalker-arm added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/Targets/AArch64.cpp:476-484 + assert(LangOpts.VScaleMin && "vscale min must be greater than 0!"); + + if (LangOpts

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

bader added a comment. In D109818#3169531 , @linjamaki wrote: > The patch is ready to land. @Anastasia, @bader, could you commit this patch > to the LLVM for us? Thanks. Could you rebase on the tip of the main branch, please? I see a couple of conflict

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

collinbaker updated this revision to Diff 391661. collinbaker added a comment. Fix variable name style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115049/new/ https://reviews.llvm.org/D115049 Files: clang/include/clang/Driver/ToolChain.h cla

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:476-484 + assert(LangOpts.VScaleMin && "vscale min must be greater than 0!"); + + if (LangOpts.VScaleMax) return std::pair(LangOpts.VScaleMin, LangOpts

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

paulwalker-arm added a comment. I agree, it's the change to VScaleMin that has caused the issue. If the LangOpts default can remain as 0 and you can still achieve what you're after then that would be perfect. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113294/new/ https://reviews.l

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=48916 Left and Right Alignment inside a loop is misaligne

[PATCH] D106585: Fix clang debug info irgen of i128 enums

aeubanks added a comment. In D106585#3169898 , @rnk wrote: > This usage of isSameValue seems suspicious: > https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/LLVMContextImpl.h#L389 > > It seems to allow the possibility that APInts of differing bi

[PATCH] D115032: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115032/new/ https://reviews.llvm.org/D115032 ___

[PATCH] D115032: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

yaxunl accepted this revision. yaxunl added a comment. Ideally, we could let the builtins accept both vec3 and vec4. But I am OK with this for now. I think the overhead may be minimal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115032/new/ http

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3052 +// & 1 +if (Right.Tok.isLiteral()) + return true; Is this valid code? Or did we just wrongly assign PointerOrReference? I'd say after that there can not

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov added a comment. @martong > Nice, assiduous work! Many thanks for your time! Your work is not less assiduous! > (LHS, RHS) swaps it doesn't really matter, as the operation is comutative, but, yes, it does matter to depict the particular test case. I'll revise twise LHS-RHS's. >

[PATCH] D115003: [funcattrs] Infer writeonly argument attribute [part 2]

reames planned changes to this revision. reames added a comment. Has the same propagation bug fixed in 7b54de5f , need to rework. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D115021: [funcatts] Rewrite callsite operand handling in memory access inference

reames planned changes to this revision. reames added a comment. Needs reworked over previous patch in stack. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115021/new/ https://reviews.llvm.org/D115021 __

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3052 +// & 1 +if (Right.Tok.isLiteral()) + return true; HazardyKnusperkeks wrote: > Is this valid code? Or did we just wrongly assign PointerOrReference? I'd say >

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes updated this revision to Diff 391668. c-rhodes added a comment. Revert to previous behaviour where both the min/max Clang flags override SVE. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113294/new/ https://reviews.llvm.org/D113294 Files: clang/include/clang/Basic/Diagnosti

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes marked an inline comment as done. c-rhodes added a comment. In D113294#3170007 , @paulwalker-arm wrote: > I agree, it's the change to VScaleMin that has caused the issue. If the > LangOpts default can remain as 0 and you can still achieve what

[PATCH] D106585: Fix clang debug info irgen of i128 enums

aeubanks added a comment. In D106585#3170019 , @aeubanks wrote: > In D106585#3169898 , @rnk wrote: > >> This usage of isSameValue seems suspicious: >> https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/LL

[PATCH] D113917: Add infrastructure to support matcher names.

jcking1034 added a comment. @hokein @aaron.ballman Following up on this, let me know if there are any other action items to address! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113917/new/ https://reviews.llvm.org/D113917 __

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

paulwalker-arm added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:476-484 + assert(LangOpts.VScaleMin && "vscale min must be greater than 0!"); + + if (LangOpts.VScaleMax) return std::pair(LangOpts.VScaleMin, La

[libunwind] f178a05 - [libunwind] Fix unwind_leaffunction test

Author: Leonard Chan Date: 2021-12-03T11:21:20-08:00 New Revision: f178a05f220403f2a9d73c7640bfcc7dc2d7be72 URL: https://github.com/llvm/llvm-project/commit/f178a05f220403f2a9d73c7640bfcc7dc2d7be72 DIFF: https://github.com/llvm/llvm-project/commit/f178a05f220403f2a9d73c7640bfcc7dc2d7be72.diff

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Give I[1

[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[clang] 0a14674 - CodeGen: Strip exception specifications from function types in CFI type names.

Author: Peter Collingbourne Date: 2021-12-03T14:50:52-05:00 New Revision: 0a14674f276b598d23353290635fc62f93e9ab30 URL: https://github.com/llvm/llvm-project/commit/0a14674f276b598d23353290635fc62f93e9ab30 DIFF: https://github.com/llvm/llvm-project/commit/0a14674f276b598d23353290635fc62f93e9ab30

[PATCH] D115063: [clang-format][NFC] Rename variable so no shadowing happens

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, owenpan, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the loo

[PATCH] D115015: CodeGen: Strip exception specifications from function types in CFI type names.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a14674f276b: CodeGen: Strip exception specifications from function types in CFI type names. (authored by pcc, committed by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D115015: CodeGen: Strip exception specifications from function types in CFI type names.

thakis added a comment. I patched this in and verified that it fixes the make_top_domain_list_variables issue in https://bugs.chromium.org/p/chromium/issues/detail?id=1273966 and went ahead and landed this. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I think th

[PATCH] D115065: [clang-format][NFC] Merge two calls of isOneOf

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D115066: [clang-format][NFC] Reorder conditions

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prefer to

[PATCH] D115067: [clang-format][NFC] Use range based for

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. That's muc

[PATCH] D115068: [clang-format][NFC] Move static variable in scope

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Let only t

[PATCH] D115069: [clang-format][NFC] Merge another two calls to isOneOf

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D115070: [clang-format][NFC] Early return when nothing to do

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, owenpan, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Do not com

[PATCH] D115071: [clang-format][NFC] Use range based for for fake l parens

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D115072: [clang-format][NFC] Use member directly

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead of

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. Delayed until D113319 is resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks updated this revision to Diff 391708. HazardyKnusperkeks retitled this revision from "[clang-format] Improve require handling" to "[clang-format] Improve require and concept handling". HazardyKnusperkeks edited the summary of this revision. HazardyKnusperkeks added reviewers: go

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks added a comment. Still WIP, not marking as changes planned, so that it pops up on your list and you can give me feedback. :) Comment at: clang/lib/Format/Format.cpp:1213 + // This is open for discussions! When will LLVM adapt C++20? + LLVMStyle.RequiresCla

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3052 +// & 1 +if (Right.Tok.isLiteral()) + return true; MyDeveloperDay wrote: > HazardyKnusperkeks wrote: > > Is this valid code? Or did we just wrongly assign

[PATCH] D115072: [clang-format][NFC] Use member directly

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM if CI is happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115072/new/ https://reviews.llvm.org/D115072 ___

[PATCH] D115071: [clang-format][NFC] Use range based for for fake l parens

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115071/new/ https://reviews.llvm.org/D115071 __

[PATCH] D115070: [clang-format][NFC] Early return when nothing to do

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115070/new/ https://reviews.llvm.org/D115070 __

[PATCH] D115069: [clang-format][NFC] Merge another two calls to isOneOf

curdeius added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1294-1296 + Previous->isOneOf(tok::l_paren, tok::comma, tok::colon, TT_BinaryOperator, +TT_ConditionalExpr) && !Previous->isOneOf(TT_DictLiteral, TT_ObjCMeth

  1   2   >