[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 390149. lh123 marked 13 inline comments as done. lh123 added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clan

[PATCH] D114665: [clangd] Add a way to enable a.k.a print through config

lh123 created this revision. lh123 added reviewers: sammccall, kadircet. lh123 added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lh123 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Currently, a.k.a printing is clo

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 390153. lh123 added a comment. format code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 390154. lh123 added a comment. format again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hove

[PATCH] D114576: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET

zero9178 updated this revision to Diff 390156. zero9178 added a comment. Alternative implementation of the original patch. Moves the defining macro from being added to the cc1 command line by the driver, to being a builtin macro. This should avoid the issues with clang-tidy. CHANGES SINCE LAST

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

lh123 updated this revision to Diff 390158. lh123 retitled this revision from "[clangd] Add a way to enable a.k.a print through config" to "[clangd] Make a.k.a printing configurable.". lh123 added a comment. fix testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

carlosgalvezp updated this revision to Diff 390165. carlosgalvezp marked 5 inline comments as done. carlosgalvezp added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114427/new/ https://reviews.llvm.org/D114427 Files: clang-tools-extra/clang-tidy/google

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/google/AvoidCStyleCastsCheck.cpp:99-106 + CharSourceRange ReplaceRange; + if (isa(CastExpr)) +ReplaceRange = CharSourceRange::getCharRange( +CastExpr->getLParenLoc(), +CastExpr->ge

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/google/AvoidCStyleCastsCheck.cpp:122 + ? getReplaceRange(dyn_cast(CastExpr)) + : getReplaceRange(dyn_cast(CastExpr)); One problem I see here is in the future someone

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

loladiro added a comment. @jrtc27 is correct. This absolutely must not apply to non-integral address spaces. It is not legal for LLVM to introduce additional ptrtoint instructions for non-integral address spaces that were not present in the original input IR. That doesn't change if the spelling

[PATCH] D114667: [clangd] Add fixes for clang "include " diagnostics

sammccall created this revision. sammccall added a reviewer: nridge. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay, ilya-biryukov. Herald added a reviewer: jdoerfert. Herald added a proj

[PATCH] D105177: [clangd] Implemented indexing of standard library

sammccall added a comment. In D105177#3156597 , @nridge wrote: > What is the status of this -- is it ready to be merged? This works as far as it goes, but it needs someone to wire it up completely: build these indexes somewhere that's less blocking than

[PATCH] D114213: Compilation Database: Point Bazel users to a solution

cpsauer added a comment. @sammccall (or others), could I ask for your help landing the change now that it's approved? (I think I need to ask someone with commit access to do so, per https://llvm.org/docs/Phabricator.html#committing-a-change) Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

salman-javed-nz accepted this revision. salman-javed-nz added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/test/clang-tidy/checkers/google-readability-casting.cpp:335 + const char *str = "foo"; + auto s = S(str); +}

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

Quuxplusone added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/google-readability-casting.cpp:342 + auto w = new int(x); +} What about ``` template T foo(int i) { return T(i); } int main() { foo>(); // valid, OK(!) foo(); // v