carlosgalvezp added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/google/AvoidCStyleCastsCheck.cpp:122 + ? getReplaceRange(dyn_cast<const CStyleCastExpr>(CastExpr)) + : getReplaceRange(dyn_cast<const CXXFunctionalCastExpr>(CastExpr)); ---------------- One problem I see here is in the future someone adds a 3rd class of casts - then this should become an if-else. That's why I had it like that before, but perhaps it's too "defensive" at this point. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114427/new/ https://reviews.llvm.org/D114427 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
