[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

lebedev.ri added a comment. In D114317#3150615 , @carlosgalvezp wrote: >> it is likely that the options were tuned, but most likely only for a single >> check. > > Yes, if the alias check has a different configuration than the primary check > then they

[PATCH] D114418: [clang][ASTImporter] Update lookup table correctly at deduction guides.

balazske added a comment. If the test is changed to print AST: TEST_P(ASTImporterOptionSpecificTestBase, ImportDeductionGuide) { TranslationUnitDecl *FromTU = getTuDecl( R"( template class A { }; template class B { template> B(T1); }; temp

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

carlosgalvezp added a comment. > this still seems like a half a solution I see, thanks for the input! I took configuration into account due to the concerns raised in previous patch attempts and in the RFC. I believe both use cases are valid so it makes sense to me to support both as independent

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

brunodf added a comment. In D111639#3081504 , @brunodf wrote: > With regard to OO_Subscript, OO_Arrow and OO_Amp, I have tried a number of > things, but I have not succeeded in triggering that an CXXOperatorCallExpr is > created for these operators (t

[clang] 93fc916 - [clang-format] NFC - recent changes caused clang-format to no longer be clang-formatted.

Author: mydeveloperday Date: 2021-11-24T09:45:32Z New Revision: 93fc91610f427f42b77fa36a65a70b9b86225c37 URL: https://github.com/llvm/llvm-project/commit/93fc91610f427f42b77fa36a65a70b9b86225c37 DIFF: https://github.com/llvm/llvm-project/commit/93fc91610f427f42b77fa36a65a70b9b86225c37.diff LOG

[PATCH] D114430: [clang-format] NFC - recent changes caused clang-format to no longer be clang-formatted.

This revision was automatically updated to reflect the committed changes. Closed by commit rG93fc91610f42: [clang-format] NFC - recent changes caused clang-format to no longer be clang… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D114519: [clang-format] [PR52595]

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius, owenpan. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=52595 missing space between `T (&&)` but not bet

[PATCH] D114519: [clang-format] [PR52595] clang-format does not recognize rvalue references to array

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:21879 verifyFormat("Foo::operator&&();", Style); - verifyFormat("operator&&(int(&&)(), class Foo);", Style); + verifyFormat("operator&&(int (&&)(), class Foo);", Style); verifyFormat("

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

steakhal added a comment. Thanks for fixing this @stevewan! I think disabling a test is worse than actually fixing it, although I can see the frustration it causes. Yet, I would propose something else. This is just a static analyzer checker doing its own thing. What if we were pinning the targ

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; tra wrote

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

steakhal added reviewers: jlebar, chandlerc. steakhal added subscribers: jlebar, chandlerc. steakhal added a comment. I think D21810 (commit ) was related to a triple issue in

[PATCH] D114519: [clang-format] [PR52595] clang-format does not recognize rvalue references to array

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:9662 +TEST_F(FormatTest, AmpAmpOperator) { + verifyFormat("int operator()(T (&&)[N]) { return 1; }"); Nit: these are not &/&& operators but references so the test name seems inc

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille updated this revision to Diff 389437. serge-sans-paille marked 6 inline comments as done. serge-sans-paille added a comment. Use CachedHashStringRef as suggested by @MaskRay CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114394/new/ https://reviews.llvm.org/D114394 Fil

[PATCH] D114326: Update the list of CUDA versions up to 11.5

carlosgalvezp added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; m

[PATCH] D114519: [clang-format] [PR52595] clang-format does not recognize rvalue references to array

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:9662 +TEST_F(FormatTest, AmpAmpOperator) { + verifyFormat("int operator()(T (&&)[N]) { return 1; }"); curdeius wrote: > Nit: these are not &/&& operators but references so

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, owenpan, curdeius, jaafar, KyrBoh. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=47936 Using the MultiLine setti

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 created this revision. lh123 added reviewers: kadircet, sammccall. lh123 added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lh123 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Add canonical type to hover when

[PATCH] D114430: [clang-format] NFC - recent changes caused clang-format to no longer be clang-formatted.

klimek added a comment. Thanks for cleaning up after me, and sorry for the mess - do y'all have clang-format set up as a presubmit or do you just remember to format manually? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114430/new/ https://review

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay added a comment. @tnorth Are you planning on working on this or do you mind if one of us fixes the issues enough to get it over the line. (this was previously accepted and landed but the unit tests fail, for what looks like a fairly minor issue) Repository: rC Clang CHANGES S

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 updated this revision to Diff 389452. lh123 added a comment. add testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover

[PATCH] D114430: [clang-format] NFC - recent changes caused clang-format to no longer be clang-formatted.

MyDeveloperDay added a comment. In D114430#3151082 , @klimek wrote: > Thanks for cleaning up after me, and sorry for the mess - do y'all have > clang-format set up as a presubmit or do you just remember to format manually? Its never a problem to clean u

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 389454. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Herald added a project: clang. Resolve review comments. This turned into a rather large refactoring change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang] 1b5a43a - Clean up clang-format tech debt.

Author: Manuel Klimek Date: 2021-11-24T12:58:35+01:00 New Revision: 1b5a43ac3f1113cd0512752e021fc70740726698 URL: https://github.com/llvm/llvm-project/commit/1b5a43ac3f1113cd0512752e021fc70740726698 DIFF: https://github.com/llvm/llvm-project/commit/1b5a43ac3f1113cd0512752e021fc70740726698.diff

[PATCH] D112913: Misleading bidirectional detection

upsuper added a comment. I'm not familiar with LLVM / Clang codebase. I was asked by @MaskRay to help review the bidi-related part of this patch. Generally I believe the algorithm here is too naive that it produces both false positives and false negatives. I'm not sure how important those edge

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 389457. kbobyrev added a comment. Untangle BeforeExecute call ordering change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new/ https://reviews.llvm.org/D114370 Files: clang-tools-extra/clangd/Code

[PATCH] D114525: [clang] Change ordering of PreableCallbacks to make sure PP can be referenced in them

kbobyrev created this revision. kbobyrev added reviewers: kadircet, sammccall. kbobyrev requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, BeforeExecute is called before BeginSourceFile which does not allow using PP in the callbacks

[PATCH] D114394: Compile-time computation of string attribute hashes

Nuu added inline comments. Comment at: llvm/include/llvm/IR/Attributes.h:54 +size_(HashedS.size()) { +assert(hash_ == hasher(s.data(), s.size()) && "consistent hashing"); + } CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114394/new/ h

[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

mstorsjo added a comment. Looks overall ok, without diving in very deep, except for this one change that seemed unrelated. Comment at: libunwind/src/Unwind-EHABI.cpp:312 uint8_t registers = getByte(data, offset++); - if (registers & 0xf0 || !registe

[clang] b7bf937 - [PowerPC] Provide XL-compatible vec_round implementation

Author: Nemanja Ivanovic Date: 2021-11-24T06:43:56-06:00 New Revision: b7bf937bbee38c2db0c0640176ef618d9c746538 URL: https://github.com/llvm/llvm-project/commit/b7bf937bbee38c2db0c0640176ef618d9c746538 DIFF: https://github.com/llvm/llvm-project/commit/b7bf937bbee38c2db0c0640176ef618d9c746538.di

[PATCH] D113642: [PowerPC] Provide XL-compatible vec_round implementation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7bf937bbee3: [PowerPC] Provide XL-compatible vec_round implementation (authored by nemanjai). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

chill added inline comments. Comment at: libunwind/src/Unwind-EHABI.cpp:312 uint8_t registers = getByte(data, offset++); - if (registers & 0xf0 || !registers) + if (registers & 0xf0) return _URC_FAILURE; m

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille updated this revision to Diff 389463. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114394/new/ https://reviews.llvm.org/D114394 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CodeGenFunction.cpp llvm/include/llvm/Ana

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille marked an inline comment as done. serge-sans-paille added inline comments. Comment at: llvm/include/llvm/IR/Attributes.h:79 + bool operator<(AttributeKey const &other) const { +return strcmp(value_, other.value_) < 0; + } JonChesterfield w

[PATCH] D114527: [VE] Support multiple architectures installation

kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. kaz7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change C++ header files placement to support multiple LLVM_RUNTIME_TARGETS build. Als

[PATCH] D114525: [clang] Change ordering of PreableCallbacks to make sure PP can be referenced in them

kadircet added a comment. As discussed offline this definitely LGTM, let me summarize the reasoning here. The original review was in https://reviews.llvm.org/D41365. It's unclear why they went with before `BeginSourceFile`. In theory having the callback issued before `BeginSourceFile` allows se

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; carlosgal

[PATCH] D114530: [clang][scan-build] Use cc/c++ instead of gcc/g++ on FreeBSD.

fcambus created this revision. fcambus added reviewers: emaste, mgorny. Herald added subscribers: krytarowski, arichardson. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. All supported FreeBSD platforms do not have GCC in base anym

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

djtodoro added a comment. Thanks for doing this! Can you please update the summary, since it hard to read with the format like this (at least, just try to reformat the debugger output properly with the Phabricator formatters)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114527: [VE] Support multiple architectures installation

kaz7 updated this revision to Diff 389479. kaz7 added a comment. Update ve-toolchain.c and ve-toolchain.cpp using -ccc-install-dir option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114527/new/ https://reviews.llvm.org/D114527 Files: clang/li

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

skc7 created this revision. skc7 added reviewers: sameerds, arsenm. Herald added subscribers: dexonsmith, lxfind, jdoerfert, zzheng, hiraditya. skc7 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wdng. Herald added projects: clang, LLVM. When the addrspacec

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

lebedev.ri added a comment. Is there an RFC? This quite seems like asking for problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114533/new/ https://reviews.llvm.org/D114533 ___ cfe-commits mailing

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 389298. mizvekov edited the summary of this revision. mizvekov added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. - Avoid using any storage for an empty ElaboratedTYpeLoc. - But we still require pointer alignm

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 389352. mizvekov added a comment. - fix IntrospectionTests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeN

[PATCH] D114502: File Reorganization changes

raramakr created this revision. raramakr added reviewers: yaxunl, msearles. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, kerbowa, liufengdb, aartbik, lucyrfox, mgester, arpith

[PATCH] D114502: File Reorganization changes

mehdi_amini added inline comments. Comment at: mlir/lib/ExecutionEngine/CMakeLists.txt:153 + set(CMAKE_MODULE_PATH "${HIP_PATH}/lib/cmake/hip" ${CMAKE_MODULE_PATH}) find_package(HIP) if (NOT HIP_FOUND) Is MLIR really coupled to Clang here? That seems suspi

[PATCH] D114502: File Reorganization changes

yaxunl added a comment. could you please include a complete diff context in the patch? You can do that by using git diff -U Comment at: mlir/lib/ExecutionEngine/CMakeLists.txt:153 + set(CMAKE_MODULE_PATH "${HIP_PATH}/lib/cmake/hip" ${CMAKE_MODULE_PATH}) find_package(HI

[PATCH] D114502: File Reorganization changes

mehdi_amini added inline comments. Comment at: mlir/lib/ExecutionEngine/CMakeLists.txt:153 + set(CMAKE_MODULE_PATH "${HIP_PATH}/lib/cmake/hip" ${CMAKE_MODULE_PATH}) find_package(HIP) if (NOT HIP_FOUND) mehdi_amini wrote: > Is MLIR really coupled to Clang h

[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

stuij updated this revision to Diff 389481. stuij added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112430/new/ https://reviews.llvm.org/D112430 Files: clang/lib/Headers/unwind.h libunwind/include/libunwind

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay added a comment. After rebasing these tests seem to work (on Windows) -- Testing: 24 tests, 16 workers -- PASS: Clang :: Format/dry-run-alias.cpp (1 of 24) PASS: Clang :: Format/remove-duplicate-includes.cpp (2 of 24) PASS: Clang :: Format/disable-format.cpp (3 of 24) PAS

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

arsenm added a comment. Patch description should include this avoids a need to introduce ptrtoint/inttoptr pairs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114533/new/ https://reviews.llvm.org/D114533 __

[PATCH] D114088: [PowerPC] Add BCD add/sub/cmp builtins

bmahjour added a comment. @nemanjai how come the changes in `altivec.h` and `clang/test/CodeGen/builtins-ppc-p8vector.c` have been removed in the latest diff and the commit above? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114088/new/ https://

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

curdeius added a comment. LGTM, but I have one question. You mentioned in the bug ticket comment that "this exposes a greater issue in AllowShortXXX". Have you found other cases that misbehave? If so, then it would probably be good to add them. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

alok added a comment. In D114504#3151332 , @djtodoro wrote: > Thanks for doing this! Can you please update the summary, since it hard to > read with the format like this (at least, just try to reformat the debugger > output properly with the Phabricator

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay updated this revision to Diff 389488. MyDeveloperDay added a comment. Rebasing previously landed but reverted commit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files: clang/docs/ClangFormat.rst clang/docs/ClangFormatStyle

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

lebedev.ri added a comment. In D114533#3151423 , @arsenm wrote: > Patch description should include this avoids a need to introduce > ptrtoint/inttoptr pairs That is a good point, but all the motivational cases seem to be about chaining the address spac

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

KyrBoh added a comment. In D114521#3151431 , @curdeius wrote: > LGTM, but I have one question. You mentioned in the bug ticket comment that > "this exposes a greater issue in AllowShortXXX". Have you found other cases > that misbehave? If so, then it wo

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

arsenm added a comment. In D114533#3151482 , @lebedev.ri wrote: > In D114533#3151423 , @arsenm wrote: > >> Patch description should include this avoids a need to introduce >> ptrtoint/inttoptr pairs > > That is

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

Anastasia added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9554 + +const auto &OpenCLFeaturesMap = +Info.Ctx.getTargetInfo().getSupportedOpenCLOpts(); azabaznov wrote: > azabaznov wrote: > > Anastasia wrote: > > > What test case cover

[PATCH] D114539: [clang-tidy] performance-unnecessary-copy-initialization: handle pointer containers.

courbet created this revision. courbet added reviewers: flx, aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. courbet requested review of this revision. Herald added a project: clang-tools-extra. This includes modifying `DeclRefExprUtils` to handle more cases. Repositor

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

MyDeveloperDay added a comment. In D114521#3151431 , @curdeius wrote: > LGTM, but I have one question. You mentioned in the bug ticket comment that > "this exposes a greater issue in AllowShortXXX". Have you found other cases > that misbehave? If so, th

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. @KyrBoh, could you create a bug report for the problem you described, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114521/new/

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

steakhal updated this revision to Diff 389496. steakhal edited the summary of this revision. steakhal added a comment. Bitshifts have nothing to do with this issue, thus I'm simply matching for bitfield -> `int` implicit casts due to promotions. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

steakhal added a comment. I think it's in pretty good shape, please have a look to help me move this forward. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114105/new/ https://reviews.llvm.org/D114105 ___ cfe-commits mailing list cfe-commits

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

MyDeveloperDay added a comment. However if we add AllowShortBlocksOnASingleLine : Always then it will be class Foo { foo() { if (x) bar(); if (x) { bar(); } } }; but if we set BasedOnStyle: LLVM AllowShortIfStatementsOnASingleLine: Never ColumnLimit: 80 Allow

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

KyrBoh added a comment. @MyDeveloperDay > What it seems is "AllowShortIfStatementsOnASingleLine" ONLY seems to work > when there are no {} AFAIR, there are 2 settings (in case of control statements): - AllowShortBlocksOnASingleLine --> whether to treat (curly-)braced blocks as a single statem

[clang-tools-extra] 3b72448 - [clang-tidy] Add unit tests for `DeclRefExprUtils`.

Author: Clement Courbet Date: 2021-11-24T16:47:55+01:00 New Revision: 3b72448084052785b79566fa5bd374feb8ae3907 URL: https://github.com/llvm/llvm-project/commit/3b72448084052785b79566fa5bd374feb8ae3907 DIFF: https://github.com/llvm/llvm-project/commit/3b72448084052785b79566fa5bd374feb8ae3907.dif

[PATCH] D114540: Big-endian version of vpermxor

tislam created this revision. tislam added a reviewer: nemanjai. Herald added subscribers: kbarton, hiraditya. tislam requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. A big-endian version of `vpermxor`, named `vpermxor_be`,

[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, with minor nit. Comment at: clang/test/ClangScanDeps/modules-pch-common-submodule.c:1 +// UNSUPPORTED: aix + Let's add a comment, to let folks know

[PATCH] D114539: [clang-tidy] performance-unnecessary-copy-initialization: handle pointer containers.

courbet updated this revision to Diff 389504. courbet added a comment. Rebase on submitted unit tests so that we can see the changes better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114539/new/ https://reviews.llvm.org/D114539 Files: clang-

[PATCH] D114539: [clang-tidy] performance-unnecessary-copy-initialization: handle pointer containers.

flx added a comment. This looks great, but goes past my knowledge of the AST API :) While the existing and new test coverage provides good confidence, one other reviewer taking look would be good. Comment at: clang-tools-extra/clang-tidy/utils/DeclRefExprUtils.cpp:112 +

[clang] 6b96b2a - [clang][AST] Check context of record in structural equivalence.

Author: Balázs Kéri Date: 2021-11-24T17:36:15+01:00 New Revision: 6b96b2a0bf65ff838d4dbf909a5120d4d1083e29 URL: https://github.com/llvm/llvm-project/commit/6b96b2a0bf65ff838d4dbf909a5120d4d1083e29 DIFF: https://github.com/llvm/llvm-project/commit/6b96b2a0bf65ff838d4dbf909a5120d4d1083e29.diff L

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b96b2a0bf65: [clang][AST] Check context of record in structural equivalence. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

MyDeveloperDay added a comment. > @curdeius > Alright, I'll create a report https://bugs.llvm.org/show_bug.cgi?id=52598 That is related. But I'd rather handle it separately because the fix for the function and the fix for a while or if will need to be different. It really comes down to this

[PATCH] D114540: Big-endian version of vpermxor

nemanjai added a comment. Please also add a test for this builtin to the front end test `clang/test/CodeGen/builtins-ppc-crypto.c` Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:2499 (COPY_TO_REGCLASS $c, VSRC>; + def : Pa

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

MyDeveloperDay added a comment. I think the problem here is encapsulated by adding the following tests Style.BraceWrapping.AfterFunction = true; Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All; Style.AllowShortIfStatementsOnASingleLine = FormatStyle::SIS_AllIfsAndElse; S

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

jessesna added a comment. In D114320#3148046 , @MyDeveloperDay wrote: > Ok now I'm a little puzzled, shouldn't this be covered by > `AllowShortIfStatementsOnASingleLine`? That's exactly what i thought when i first stumbled over the behavior :D But I t

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

edward-jones updated this revision to Diff 389520. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109372/new/ https://reviews.llvm.org/D109372 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticDriverKinds.td clang/in

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 389522. sgatev marked an inline comment as done. sgatev added a comment. Document the role of the "Dynamic" suffix in the name of DataflowAnalysisDynamic and its members. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

jlebar added a comment. > Let me summon them. *I have no memory of this place.* Sorry to disappoint. That blame was four years ago, not counting covid-related time dilation. I do agree that disabling a test just to please a static analyzer is probably not the best way to go. Repository:

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

samitolvanen planned changes to this revision. samitolvanen added a comment. In D108479#3150298 , @rjmccall wrote: > Your builtin is using custom type-checking (`t`), which suppresses all the > normal conversions that happen on expressions. Specifically

[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX

stevewan updated this revision to Diff 389535. stevewan added a comment. Explain the rationale Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114481/new/ https://reviews.llvm.org/D114481 Files: clang/test/ClangScanDeps/modules-pch-common-submodul

[clang] 06d4a76 - [NFC][AIX]Disable precompiled module file tests on AIX

Author: Steven Wan Date: 2021-11-24T13:22:09-05:00 New Revision: 06d4a76309cd97e25859770b3da29006ccac421a URL: https://github.com/llvm/llvm-project/commit/06d4a76309cd97e25859770b3da29006ccac421a DIFF: https://github.com/llvm/llvm-project/commit/06d4a76309cd97e25859770b3da29006ccac421a.diff LO

[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06d4a76309cd: [NFC][AIX]Disable precompiled module file tests on AIX (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D114100: [NFC][clang-tools-extra] Inclusive language: replace master with main

quinnp added a comment. @sammccall could you take a look at the other changes when you have time? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114100/new/ https://reviews.llvm.org/D114100 ___ c

[PATCH] D114546: [OPENMP]Fix PR52117: Crash caused by target region inside of task construct.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to do the analysis of the captured expressions in the clauses

[PATCH] D114326: Update the list of CUDA versions up to 11.5

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; tra wrote:

[clang] dc1aa8e - [PowerPC] Add missed clang portion of c933c2eb3346

Author: Nemanja Ivanovic Date: 2021-11-24T12:42:58-06:00 New Revision: dc1aa8eacd1e0e554f206cc15d730f37ea90c4ea URL: https://github.com/llvm/llvm-project/commit/dc1aa8eacd1e0e554f206cc15d730f37ea90c4ea DIFF: https://github.com/llvm/llvm-project/commit/dc1aa8eacd1e0e554f206cc15d730f37ea90c4ea.di

[clang] c79345f - [NFC][Clang][test] Inclusive language: Remove and rephrase uses of sanity test/check in clang/test

Author: Zarko Todorovski Date: 2021-11-24T14:03:49-05:00 New Revision: c79345fb7b149d9c952f8506c9e6c6317a5b4cd8 URL: https://github.com/llvm/llvm-project/commit/c79345fb7b149d9c952f8506c9e6c6317a5b4cd8 DIFF: https://github.com/llvm/llvm-project/commit/c79345fb7b149d9c952f8506c9e6c6317a5b4cd8.di

[PATCH] D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang

gandhi21299 created this revision. gandhi21299 added reviewers: yaxunl, b-sumner, t-tye, tra, rjmccall. gandhi21299 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introduce __hip_atomic_load, __hip_atomic_store and __hip_atomic_compare_ex

[clang] d42a643 - [NFC][clang]Inclusive language: remove remaining uses of sanity

Author: Zarko Todorovski Date: 2021-11-24T14:20:13-05:00 New Revision: d42a6432aa37a6b9aa7e4f5209e9679c8a4c2fbb URL: https://github.com/llvm/llvm-project/commit/d42a6432aa37a6b9aa7e4f5209e9679c8a4c2fbb DIFF: https://github.com/llvm/llvm-project/commit/d42a6432aa37a6b9aa7e4f5209e9679c8a4c2fbb.di

[PATCH] D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang

gandhi21299 updated this revision to Diff 389577. gandhi21299 added a comment. removed changes in atomic-ops.cl, CUDA test may be sufficient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114553/new/ https://reviews.llvm.org/D114553 Files: clang

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. In D114320#3151741 , @jessesna wrote: > In D114320#3148046 , > @MyDeveloperDay wrote: > >> O

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/49558/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113118/new/ https://reviews.ll

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; tra wrote

[PATCH] D114559: [clang] ASTMatchers: Fix out-of-bounds access in foreachArgumentWithParamType.

flx created this revision. flx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The matcher crashes when a variadic function pointer is invoked because the FunctionProtoType has fewer parameters than arguments. Matching of non-variadic argu

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

craig.topper added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:511 +RISCVPragmaHandler = std::make_unique(Actions); +PP.AddPragmaHandler(RISCVPragmaHandler.get()); + } Since this is a clang specific pragma should it be `#pragma clang ris

[PATCH] D114560: [OPENMP]Fix PR51327: Range based for loop not working if range's type is a template.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to postpone anlysis of the ranged for loops till the actual i

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:69 {"zfh", RISCVExtensionVersion{0, 1}}, +{"zfinx", RISCVExtensionVersion{1, 0}}, +{"zdinx", RISCVExtensionVersion{1, 0}}, Do we need to enforce that these can't be mix

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoD.td:489 +let Predicates = [HasStdExtZdinx] in { +def : InstAlias<"fabs.d $rd, $rs", (FSGNJX_D_INX GPRF64Op:$rd, GPRF64Op:$rs, GPRF64Op:$rs)>; Aren't these aliases only valid f

[PATCH] D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang

yaxunl added a comment. we also need a sema test like clang/test/SemaOpenCL/atomic-ops.cl Comment at: clang/test/CodeGenCUDA/atomic-ops.cu:30-32 + val = __hip_atomic_load(ptr, __HIP_MEMORY_SCOPE_SINGLETHREAD); + __hip_atomic_store(ptr, ptr2, 5); + flag = __hip_atomic_compare

  1   2   >