Author: Zarko Todorovski Date: 2021-11-24T14:20:13-05:00 New Revision: d42a6432aa37a6b9aa7e4f5209e9679c8a4c2fbb
URL: https://github.com/llvm/llvm-project/commit/d42a6432aa37a6b9aa7e4f5209e9679c8a4c2fbb DIFF: https://github.com/llvm/llvm-project/commit/d42a6432aa37a6b9aa7e4f5209e9679c8a4c2fbb.diff LOG: [NFC][clang]Inclusive language: remove remaining uses of sanity Missed some uses of sanity check in previous commits. Added: Modified: clang/lib/AST/ExprConstant.cpp clang/lib/StaticAnalyzer/Core/CoreEngine.cpp clang/utils/TableGen/ASTTableGen.cpp clang/utils/check_cfc/check_cfc.py Removed: ################################################################################ diff --git a/clang/lib/AST/ExprConstant.cpp b/clang/lib/AST/ExprConstant.cpp index fe96db9ca918e..99babd58b0276 100644 --- a/clang/lib/AST/ExprConstant.cpp +++ b/clang/lib/AST/ExprConstant.cpp @@ -7483,7 +7483,7 @@ class ExprEvaluatorBase const Expr *Source = E->getSourceExpr(); if (!Source) return Error(E); - if (Source == E) { // sanity checking. + if (Source == E) { assert(0 && "OpaqueValueExpr recursively refers to itself"); return Error(E); } diff --git a/clang/lib/StaticAnalyzer/Core/CoreEngine.cpp b/clang/lib/StaticAnalyzer/Core/CoreEngine.cpp index bc939d2528002..d57bab154b617 100644 --- a/clang/lib/StaticAnalyzer/Core/CoreEngine.cpp +++ b/clang/lib/StaticAnalyzer/Core/CoreEngine.cpp @@ -686,8 +686,8 @@ SwitchNodeBuilder::generateDefaultCaseNode(ProgramStateRef St, assert(Src->succ_rbegin() != Src->succ_rend()); CFGBlock *DefaultBlock = *Src->succ_rbegin(); - // Sanity check for default blocks that are unreachable and not caught - // by earlier stages. + // Basic correctness check for default blocks that are unreachable and not + // caught by earlier stages. if (!DefaultBlock) return nullptr; diff --git a/clang/utils/TableGen/ASTTableGen.cpp b/clang/utils/TableGen/ASTTableGen.cpp index 3f6da40964e0b..6aa8b28a942f3 100644 --- a/clang/utils/TableGen/ASTTableGen.cpp +++ b/clang/utils/TableGen/ASTTableGen.cpp @@ -107,7 +107,7 @@ static void visitASTNodeRecursive(ASTNode node, ASTNode base, static void visitHierarchy(RecordKeeper &records, StringRef nodeClassName, ASTNodeHierarchyVisitor<ASTNode> visit) { - // Check for the node class, just as a sanity check. + // Check for the node class, just as a basic correctness check. if (!records.getClass(nodeClassName)) { PrintFatalError(Twine("cannot find definition for node class ") + nodeClassName); diff --git a/clang/utils/check_cfc/check_cfc.py b/clang/utils/check_cfc/check_cfc.py index 311f502f800b3..cab33b41c1ca0 100755 --- a/clang/utils/check_cfc/check_cfc.py +++ b/clang/utils/check_cfc/check_cfc.py @@ -339,7 +339,7 @@ def perform_check(self, arguments, my_env): # Prevent infinite loop if called with absolute path. arguments_a[0] = os.path.basename(arguments_a[0]) - # Sanity check + # Basic correctness check enabled_checks = [check_name for check_name in checks if config.getboolean('Checks', check_name)] _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
