[PATCH] D112720: [clang-tidy] Use globs in HeaderFilter

carlosgalvezp added a comment. So after some thoughts, I came up with the following plan: - This patch adds: `HeaderFilter`, `HeaderFilterMode`. `HeaderFilter` is intended to replace `HeaderFilterRegex` and we inform that `HeaderFilterRegex` is deprecated and will be removed in 2 releases. Howe

[PATCH] D109215: [RISCV] Fix arch string parsing for multi-character extensions

eopXD updated this revision to Diff 383732. eopXD added a comment. rebase.` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109215/new/ https://reviews.llvm.org/D109215 Files: clang/test/Driver/riscv-arch.c llvm/lib/Support/RISCVISAInfo.cpp In

[PATCH] D112088: [clang][deps] Keep #pragma push_macro, pop_macro and include_alias when minimizing source code.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112088/new/ https://reviews.llvm.org/D112088 __

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 383733. eopXD added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c clang/test/CodeGen/RISCV/ris

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay updated this revision to Diff 383744. MyDeveloperDay added a reviewer: HazardyKnusperkeks. MyDeveloperDay added a comment. I'd like to carry the mantle for this, before making any further changes I'd like to address some of the review comments 1. Add documentation warning about a

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille created this revision. Herald added subscribers: carlosgalvezp, mgorny. serge-sans-paille requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This patch implements detection of incomplete bidirectional sequence wit

[PATCH] D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64

qiucf added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:100 + static SmallDenseMap F128Builtins{ + {Builtin::BI__builtin_printf, "__printfieee128"}, + {Builtin::BI__builtin_vsnprintf, "__vsnprintfieee128"}, jsji wrote: > Why only these

[PATCH] D112914: Misleading identifier detection

serge-sans-paille created this revision. Herald added subscribers: carlosgalvezp, mgorny. serge-sans-paille requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detect identifiers with right-to-left ordering through clang-tidy. It de

[PATCH] D112915: WIP: [clang][modules] Granular tracking of includes

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, vsapsai, rsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When building a module consisting of submodules, the preprocessor keeps a

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille created this revision. Herald added subscribers: carlosgalvezp, mgrang, mgorny. serge-sans-paille requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This patch implements detection of confusable identifiers within

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

ASDenysPetrov updated this revision to Diff 383751. ASDenysPetrov added a comment. Changed test to fix a buildbot failure. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111654/new/ https://reviews.llvm.org/D111654 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/Anal

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

uabelho added a comment. In D107049#3096807 , @v.g.vassilev wrote: > Can you share your cmake config line, the target triple and architecture? CC='/mycompiler/compiler-clang/bin/clang -march=corei7' CXX='/mycompiler/compiler-clang/bin/clang++ -march=co

[PATCH] D112915: WIP: [clang][modules] Granular tracking of includes

jansvoboda11 added a comment. I'm interested in hearing some feedback whether the direction I'm taking here makes sense. There are a couple of TODOs (mostly on optimizing away unnecessary maps) and a few modules-ts tests are failing. @rsmith left a suggestion on D104344

[PATCH] D112001: [Clang] Add min/max reduction builtins.

fhahn updated this revision to Diff 383756. fhahn added a comment. rebase on top of recent changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112001/new/ https://reviews.llvm.org/D112001 Files: clang/include/clang/Basic/Builtins.def clang/

[PATCH] D95168: [clang-format] Add InsertBraces option

HazardyKnusperkeks added a comment. In D95168#3099739 , @MyDeveloperDay wrote: > I'd like to carry the mantle for this, before making any further changes I'd > like to address some of the review comments > > 1. Add documentation warning about a modifying

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

uabelho added a comment. If we run without z3 it still fails, but in another way: [ RUN ] InterpreterTest.CatchException JIT session error: Symbols not found: [ __gxx_personality_v0, _ZSt9terminatev, _ZTVN10__cxxabiv117__class_type_infoE, __cxa_allocate_exception, __cxa_begin_catch, __

[PATCH] D95168: [clang-format] Add InsertBraces option

owenpan added a comment. In D95168#3099739 , @MyDeveloperDay wrote: > - Look further into possible Removal (I have an idea for how this might be > possible, and super useful for LLVM where we don't like single if {} ), I'd > like to round out on this be

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 383602. Ericson2314 added a comment. Simple rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists.txt libclc/CMakeLi

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 383603. Ericson2314 added a comment. Rebase, and catch two more `DESTINATION bin` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-d

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews.llvm.org/D112221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added a comment. In D107049#3099816 , @uabelho wrote: > In D107049#3096807 , @v.g.vassilev > wrote: > >> Can you share your cmake config line, the target triple and architecture? > > CC='/mycompiler/

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

edward-jones added a comment. Herald added subscribers: VincentWu, luke957. I reverted some of the previous changes I made so that this patch matches the spec as currently written - this means it's two attributes again, and the diagnostic messages have been updated a bit too. The two Clang attri

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

aaron.ballman added a comment. In D112773#3097730 , @beccadax wrote: > In D112773#3096185 , @aaron.ballman > wrote: > >> `swift_attr` has no subjects, so this will attempt to spray the attribute >> onto literall

[PATCH] D112001: [Clang] Add min/max reduction builtins.

aaron.ballman added a comment. Precommit CI looks to be failing. /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/builtins-reduction-math.c:13:9: error: initializing 'float' with an expression of incompatible type 'float4' (vector of 4 'float' values) float r1 = __built

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

jrtc27 added a comment. In D109372#3099947 , @edward-jones wrote: > I reverted some of the previous changes I made so that this patch matches the > spec as currently written - this means it's two attributes again, and the > diagnostic messages have bee

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead created this revision. Herald added subscribers: lxfind, dang. pcwang-thead requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since C++14 has been released for about seven years and most standard libraries have implemented sized

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

aaron.ballman added a comment. In D99#3097692 , @dblaikie wrote: > In D99#3096124 , @aaron.ballman > wrote: > >> In D99#3095623 , >> @yonghong-song wrote: >>

[PATCH] D112491: Add `LambdaCapture`-related matchers.

aaron.ballman added a comment. In D112491#3096935 , @sammccall wrote: > This looks really sensible to me too. Some naming bikeshedding, but my main > question is migration. > > Supporting two things is indeed annoying and confusing. I agree it's not > w

[PATCH] D109215: [RISCV] Fix arch string parsing for multi-character extensions

eopXD updated this revision to Diff 383773. eopXD added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109215/new/ https://reviews.llvm.org/D109215 Files: clang/test/Driver/riscv-arch.c llvm/lib/Support/RISCVISAInfo.cpp Inde

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 383775. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c clang/test/CodeGen/RISCV/ris

[PATCH] D112923: [clang][deps] Reset some benign codegen options

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some command-line codegen arguments are likely to differ between identical modules discov

[clang] 0b83a18 - [AArch64] Enablement of Cortex-X2

Author: Mubashar Ahmad Date: 2021-11-01T11:55:24Z New Revision: 0b83a18a2b9db9c23082e8751c3a66ef37fc626f URL: https://github.com/llvm/llvm-project/commit/0b83a18a2b9db9c23082e8751c3a66ef37fc626f DIFF: https://github.com/llvm/llvm-project/commit/0b83a18a2b9db9c23082e8751c3a66ef37fc626f.diff LOG

[PATCH] D112459: [AArch64] Enablement of Cortex-X2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b83a18a2b9d: [AArch64] Enablement of Cortex-X2 (authored by mubashar_, committed by dmgreen). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

uabelho added a comment. In D107049#3099941 , @v.g.vassilev wrote: > Can you also paste the configure output of cmake? Attached in file.txt F20006228: file.txt CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead updated this revision to Diff 383781. pcwang-thead added a comment. Herald added a project: clang-tools-extra. Fix errors in clang-tools-extra\test\clang-tidy\checkers\misc-new-delete-overloads.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

aaron.ballman added reviewers: rsmith, rjmccall, erichkeane, aaron.ballman. aaron.ballman added a comment. Adding some reviewers for visibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 ___

[PATCH] D112903: [C++20] [Module] Fix front end crashes when trying to export a type out of a module

aaron.ballman added a reviewer: erichkeane. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7784-7785 "because namespace %1 does not enclose namespace %2">; +def err_invalid_declarator_in_export : Error<"cannot export %0 here "

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

aaron.ballman added a comment. There are still unhandled comments in the patch, btw. Comment at: clang/include/clang/Basic/Attr.td:1797 +def RISCVOverlayCall : InheritableAttr { + let Spellings = [GCC<"overlaycall">]; + let Subjects = SubjectList<[Function]>;

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. These look fine, I was hoping that someone else from library would take a look, but it looks right ot me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://re

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead updated this revision to Diff 383789. pcwang-thead added a comment. Herald added subscribers: usaxena95, kadircet, arphaman. Add `-fno-sized-allocation` to: - `clang\test\AST\ast-dump-expr-json.cpp` - `clang\test\AST\ast-dump-stmt-json.cpp` - `clang\test\CodeGenCXX\dllimport.cpp` - `

[PATCH] D112491: Add `LambdaCapture`-related matchers.

ymandel added a comment. +1 to removing the old versions of these matchers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112491/new/ https://reviews.llvm.org/D112491 ___ cfe-commits mailing list cfe-com

[PATCH] D112491: Add `LambdaCapture`-related matchers.

ymandel added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4630-4632 +/// lambdaExpr(hasAnyCapture(lambdaCapture(refersToVarDecl(hasName("x", +/// refersToVarDecl(hasName("x")) matches `int x` and `x = 1`. +AST_MATCHER_P(LambdaCapture, capturesVa

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

jsji added inline comments. Comment at: clang/test/Driver/ppc-float-abi-warning.cpp:2 +// REQUIRES: powerpc-registered-target +// RUN: %clang -### -x c++ -target powerpc64le-unknown-linux-gnu %s -mabi=ieeelongdouble + Can we add RUN line to test when we are usin

[clang] 838d8d1 - [AIX][NFC] Unsupported object-c test

Author: Jinsong Ji Date: 2021-11-01T13:44:23Z New Revision: 838d8d1e2b93ae89d4edfdc5da58f7622f1b1c71 URL: https://github.com/llvm/llvm-project/commit/838d8d1e2b93ae89d4edfdc5da58f7622f1b1c71 DIFF: https://github.com/llvm/llvm-project/commit/838d8d1e2b93ae89d4edfdc5da58f7622f1b1c71.diff LOG: [A

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

asavonic added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1936 +if (LangOpts.SYCLIsDevice || (LangOpts.OpenMP && LangOpts.OpenMPIsDevice)) + CheckDeviceType(Ty); + erichkeane wrote: > Should this be a return, or do we still intend the device in

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

asavonic updated this revision to Diff 383794. asavonic added a comment. - Added a test for SYCL. - Excluded functions marked with C++ `delete` from the check. - Moved the check function from `ActOnFunctionDeclarator` to `ActOnFinishFunctionBody`, because the deleted/defaulted property is not yet

[PATCH] D112645: [OpenMP] Fix: opposite attributes could be set by -fno-inline

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5370 if (CGM.getCodeGenOpts().OptimizationLevel != 0) Fn->addFnAttr(llvm::Attribute::AlwaysInline); return F

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. I checked the reason for failure in address sanitizer tests on the 2-stage aarch64 buildbots. The buildbot failure was occured because the `internal_clone` function of the `compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp` file is being compiled incorrectly. The

[PATCH] D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Please hold a few days to see whether there are inputs from other reviewers. Thanks. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:100 + static SmallDenseMap F128B

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

Eugene.Zelenko added a comment. Please mention improvement in Release Notes, in `Changes in existing checks` section. See example . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

rzurob requested changes to this revision. rzurob added a comment. This revision now requires changes to proceed. Please change to "IBM XL C/C++ for AIX 16.1.0". i.e. No ", V". Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112847/new/ htt

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

yaxunl added a comment. ping. I have made changes so that the diagnostics about sanitizer args are only emitted once. Any further changes or concerns? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111443/new/ https://reviews.llvm.org/D111443 ___

[PATCH] D112492: [HIP] Do not use kernel handle for MSVC target

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112492/new/ https://reviews.llvm.org/D112492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D112929: [Clang] For VFE, emit vtable ranges in !vcall_visibility metadata

kubamracek created this revision. kubamracek added reviewers: rjmccall, pcc, fhahn. kubamracek added a project: clang. kubamracek requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112929 Files: clang/lib/CodeGen/CGVTables.cpp clang/test/CodeGe

[PATCH] D112647: [clang-apply-replacements] Correctly handle relative paths

ymandel added a comment. Overall, this looks ok, but I don't feel like I'm qualified to approve this patch, since I'm not really familiar w/ how this tool is used in practice. Some comments nonetheless: > Those relative paths are meant to be resolved relative to the corresponding > build direc

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

ZarkoCA updated this revision to Diff 383804. ZarkoCA added a comment. - Remove V from version number Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112847/new/ https://reviews.llvm.org/D112847 Files: clang/include/clang/Basic/DiagnosticSemaKinds

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

ZarkoCA updated this revision to Diff 383805. ZarkoCA added a comment. - Remove comma from product name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112847/new/ https://reviews.llvm.org/D112847 Files: clang/include/clang/Basic/DiagnosticSemaKin

[PATCH] D95168: [clang-format] Add InsertBraces option

HazardyKnusperkeks added a comment. In D95168#3099920 , @owenpan wrote: > In D95168#3099739 , @MyDeveloperDay > wrote: > >> - Look further into possible Removal (I have an idea for how this might be >> possible, a

[PATCH] D112932: [WIP] Use llvm.is_fpclass to implement FP classification functions

sepavloff created this revision. sepavloff requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Builtin floating-point number classification functions: - __builtin_isnan, - __builtin_isinf, - __builtin_finite, and - __builtin_isnormal now are

[PATCH] D112850: [clang] 'unused-but-set-variable' warning should not apply to __block objective-c pointers

mbenfield added a comment. This seems reasonable to me, but I don't know Objective C. Presumably someone who does should accept. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112850/new/ https://reviews.llvm.org/D112850 __

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

ASDenysPetrov updated this revision to Diff 383812. ASDenysPetrov added a comment. Updated according to comments. TODO: make the feature `-fno-strict-aliasing` dependent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110927/new/ https://reviews.llvm.org/D110927 Files: clang/lib/Stati

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov updated this revision to Diff 383819. kstoimenov added a comment. Fixed remaing 2 tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/includ

[PATCH] D112491: Add `LambdaCapture`-related matchers.

jcking1034 updated this revision to Diff 383823. jcking1034 marked 4 inline comments as done. jcking1034 added a comment. Update missed names; remove original implementations of `hasAnyCapture`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112491/n

[clang] 5a8c173 - [clang] Fortify warning for scanf calls with field width too big.

Author: Michael Benfield Date: 2021-11-01T17:17:37Z New Revision: 5a8c1736289f2b1df10df38e7a9e4d208a7586a6 URL: https://github.com/llvm/llvm-project/commit/5a8c1736289f2b1df10df38e7a9e4d208a7586a6 DIFF: https://github.com/llvm/llvm-project/commit/5a8c1736289f2b1df10df38e7a9e4d208a7586a6.diff L

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a8c1736289f: [clang] Fortify warning for scanf calls with field width too big. (authored by mbenfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111833

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

rnk added a comment. Please add a note to clang/docs/ReleaseNotes.rst about the behavior change. The clangd test failure seems related to this change, and the other ones could be as well. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6405 + // by default. + if (Arg *A =

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

rnk added a subscriber: dblaikie. rnk added a comment. So, to back up a bit, do I understand correctly that this change adds tests to the check-clang test suite that JIT compiles C++ code for the host and throws C++ exceptions? Can we reconsider that? We have a policy of not running execution t

[PATCH] D112890: headers: optionalise some generated resource headers

rnk added a comment. I think this seems reasonable. Generally speaking, we have tests in clang that generate IR for targets that are not enabled in LLVM. It is kind of nice: you don't have to mark the IRGen tests with `REQUIRES: foo-registered-target`. If we want to test these ARM and RISCV in

[PATCH] D112491: Add `LambdaCapture`-related matchers.

fowles added a comment. This is great! Comment at: clang/docs/LibASTMatchersReference.html:8368 +lambdaExpr(hasAnyCapture(lambdaCapture(capturesVar(hasName("x", +capturesVar(hasName("x")) matches `int x` and `x = 1`. I think this should be "matches `x` an

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

rzurob accepted this revision. rzurob added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112847/new/ https://reviews.llvm.org/D112847 ___

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

lhames accepted this revision. lhames added a comment. @joerg @dim @emaste Any further comments on this? I'd like @housel to be able to land this this week if possible. It will significantly improve the usability of libunwind for JIT clients by giving us an API with behavior that is consistent

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

rnk added inline comments. Comment at: utils/bazel/.bazelrc:81 +build:windows --copt=/Oi --host_copt=/Oi +build:windows --cxxopt=/Zc:rvalueCast --host_cxxopt=/Zc:rvalueCast + Try adding `/permissive-` to get more conforming behavior from clang-cl. If that doesn'

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

ab created this revision. ab added reviewers: rjmccall, ahatanak, bruno, pcc, apazos, kristof.beyls, t.p.northover, pbarrio, chill, danielkiss, psmith. ab added a project: clang. Herald added subscribers: dexonsmith, zzheng, dang, mgorny. ab requested review of this revision. Building on D90868 <

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

vitalybuka added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:92 -struct AddressSanitizerOptions { - AddressSanitizerOptions() Why do we need to remove AddressSanitizerOptions? Comment at: llvm

[clang] dfa0981 - Remove an unused parameter; NFC

Author: Aaron Ballman Date: 2021-11-01T14:42:00-04:00 New Revision: dfa098140716cc41cfc8b83f3f083008e7219bf9 URL: https://github.com/llvm/llvm-project/commit/dfa098140716cc41cfc8b83f3f083008e7219bf9 DIFF: https://github.com/llvm/llvm-project/commit/dfa098140716cc41cfc8b83f3f083008e7219bf9.diff

[PATCH] D112645: [OpenMP] Fix: opposite attributes could be set by -fno-inline

igor.kirillov added inline comments. Comment at: clang/test/OpenMP/parallel_for_noinline.cpp:1 +// RUN: %clang -O0 -fopenmp -fno-inline %s -S -emit-llvm -o - | FileCheck %s --check-prefixes=CHECK,CHECK-O0 +// RUN: %clang -O1 -fopenmp -fno-inline %s -S -emit-llvm -o - | FileCheck

[PATCH] D112645: [OpenMP] Fix: opposite attributes could be set by -fno-inline

jhuber6 added inline comments. Comment at: clang/test/OpenMP/parallel_for_noinline.cpp:1 +// RUN: %clang -O0 -fopenmp -fno-inline %s -S -emit-llvm -o - | FileCheck %s --check-prefixes=CHECK,CHECK-O0 +// RUN: %clang -O1 -fopenmp -fno-inline %s -S -emit-llvm -o - | FileCheck %s -

[clang] d51a829 - Revert "[clang] Fortify warning for scanf calls with field width too big."

Author: Michael Benfield Date: 2021-11-01T19:36:45Z New Revision: d51a8296d374122c937df708f5fa1500218baa5c URL: https://github.com/llvm/llvm-project/commit/d51a8296d374122c937df708f5fa1500218baa5c DIFF: https://github.com/llvm/llvm-project/commit/d51a8296d374122c937df708f5fa1500218baa5c.diff L

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

dblaikie added a comment. In D99#3099988 , @aaron.ballman wrote: > In D99#3097692 , @dblaikie > wrote: > >> In D99#3096124 , >> @aaron.ballman wrote: >> >>>

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

lhames added a comment. In D107049#3096727 , @uabelho wrote: > Hi, > > We're seeing a problem with this patch in our downstream (not public) > buildbots. With an asan-built compiler we see the following: > > ... > 10:08:55 [ RUN ] InterpreterTes

[PATCH] D112088: [clang][deps] Keep #pragma push_macro, pop_macro and include_alias when minimizing source code.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa82a844961a5: [clang][deps] Keep #pragma push_macro, pop_macro and include_alias when… (authored by saudi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112

[clang] a82a844 - [clang][deps] Keep #pragma push_macro, pop_macro and include_alias when minimizing source code.

Author: Sylvain Audi Date: 2021-11-01T16:04:52-04:00 New Revision: a82a844961a55c8a5879453ce0e78774b33bf06a URL: https://github.com/llvm/llvm-project/commit/a82a844961a55c8a5879453ce0e78774b33bf06a DIFF: https://github.com/llvm/llvm-project/commit/a82a844961a55c8a5879453ce0e78774b33bf06a.diff

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added a comment. In D95168#3099920 , @owenpan wrote: > In D95168#3099739 , @MyDeveloperDay > wrote: > >> - Look further into possible Removal (I have an idea for how this might be >> possible, and s

Re: r307232 - [modules ts] Do not emit strong function definitions from the module interface unit in every user.

Ping On Tue, Sep 21, 2021 at 7:58 PM David Blaikie wrote: > Ping > > On Sun, Sep 5, 2021 at 11:28 AM David Blaikie wrote: > >> Hey Richard - was just going back over some of the modular codegen code >> (due to a discussion on the EWG mailing list about file extensions that >> ended up touching

[PATCH] D112492: [HIP] Do not use kernel handle for MSVC target

tra added a comment. As phrased the summary would likely be rather confusing for anyone other than you and me. > Currently Visual Studio 2019 has a linker issue which causes linking error > when a template kernel is instantiated in different compilation units. It's not clear what exactly is the

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

craig.topper added a comment. Herald added subscribers: VincentWu, luke957. This patch as committed, deleted 5 test files instead of renaming them. I'm working on restoring them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105690/new/ https://re

[PATCH] D112664: [clang-format][docs] fix indentation of rst code block

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. This should be Format.h, didn't we recently fix this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112664/new/ https:

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

GMNGeoffrey accepted this revision. GMNGeoffrey added inline comments. This revision is now accepted and ready to land. Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:364 +# Clang-specific define on non-Windows platforms. +"CLANG_HAVE_RLIMI

[PATCH] D112645: [OpenMP] Fix: opposite attributes could be set by -fno-inline

igor.kirillov updated this revision to Diff 383890. igor.kirillov marked an inline comment as not done. igor.kirillov added a comment. Update test, remove redundant code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112645/new/ https://reviews.llvm

[clang] 670c72f - [RISCV] Restore tests for vf(w)redusum.

Author: Craig Topper Date: 2021-11-01T14:35:22-07:00 New Revision: 670c72f6f70434500d1475e1524a7088814fbc73 URL: https://github.com/llvm/llvm-project/commit/670c72f6f70434500d1475e1524a7088814fbc73 DIFF: https://github.com/llvm/llvm-project/commit/670c72f6f70434500d1475e1524a7088814fbc73.diff

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. :( LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112883/new/ https://reviews.llvm.org/D112883 ___ cfe-commits mailing list cfe-commit

[PATCH] D112645: [OpenMP] Fix: opposite attributes could be set by -fno-inline

igor.kirillov updated this revision to Diff 383892. igor.kirillov added a comment. Remove my old test for the change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112645/new/ https://reviews.llvm.org/D112645 Files: clang/lib/CodeGen/CGStmtOpenMP

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

craig.topper added a comment. In D105690#3101129 , @craig.topper wrote: > This patch as committed, deleted 5 test files instead of renaming them. I'm > working on restoring them. Deleted tests have been restored by 670c72f6f70434500d1475e1524a7088814fb

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin updated this revision to Diff 383893. paulaltin added a comment. Fix pre-merge tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp clang-tools-

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin updated this revision to Diff 383898. paulaltin added a comment. Updated release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp clang-too

[PATCH] D112001: [Clang] Add min/max reduction builtins.

fhahn updated this revision to Diff 383900. fhahn added a comment. In D112001#3099965 , @aaron.ballman wrote: > Precommit CI looks to be failing. > > > /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/builtins-reduction-math.c:13:9: >

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin updated this revision to Diff 383901. paulaltin added a comment. Fix pre-merge tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp clang-tools

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin updated this revision to Diff 383904. paulaltin added a comment. Attempting to fix failed patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin updated this revision to Diff 383905. paulaltin added a comment. Attempting to fix failed patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp

[PATCH] D112916: Confusable identifiers detection

rsmith added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/CMakeLists.txt:9 +add_custom_command( +OUTPUT confusables.h +COMMAND make_confusable_table ${CMAKE_CURRENT_SOURCE_DIR}/ConfusableTable/confusables.txt ${CMAKE_CURRENT_BINARY_DIR}/confusables.h -

  1   2   >