asavonic added inline comments.
================ Comment at: clang/lib/Sema/Sema.cpp:1936 + if (LangOpts.SYCLIsDevice || (LangOpts.OpenMP && LangOpts.OpenMPIsDevice)) + CheckDeviceType(Ty); + ---------------- erichkeane wrote: > Should this be a return, or do we still intend the device invocations to go > through the below checks too? > > If so, please write a test for that. It should be fine either way. New diagnostics are disabled if `TI.hasLongDoubleType` and `TI.hasFPReturn` return "true", as expected for SYCL and OpenMP device targets. Added a test for SYCL, OpenMP already has tests with `long double` type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98895/new/ https://reviews.llvm.org/D98895 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
