[PATCH] D111952: [clang] [MinGW] Guess the right ix86 arch name spelling as sysroot

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/MinGW.h:63 + static void FixTripleArch(const Driver &D, llvm::Triple &Triple, +const llvm::opt::ArgList &Args); Use `functionName` for newer functions. (It's unf

[PATCH] D112600: [ARM] Use hardware TLS register in Thumb2 mode when -mtp=cp15 is passed

ardb updated this revision to Diff 382839. ardb added a comment. Add another test suggested by Nick. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112600/new/ https://reviews.llvm.org/D112600 Files: llvm/lib/Target/ARM/ARMInstrThumb.td llvm/lib/Target/ARM/ARMInstrThumb2.td llvm/t

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

mbenfield updated this revision to Diff 382840. mbenfield added a comment. fix function_ref use-after-free Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111833/new/ https://reviews.llvm.org/D111833 Files: clang/include/clang/Basic/DiagnosticSema

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

ASDenysPetrov updated this revision to Diff 382823. ASDenysPetrov added a comment. Added doc comment to `getSValFromStringLiteral` function. Fixed minor code defects. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107339/new/ https://reviews.llvm.org/D107339 Files: clang/lib/StaticAna

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

mbenfield updated this revision to Diff 382845. mbenfield added a comment. const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111833/new/ https://reviews.llvm.org/D111833 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/

[PATCH] D111400: [Clang] Implement P2242R3

hubert.reinterpretcast added a comment. A different "ouch" (and, yes, this is a regression from this patch): auto f = [](bool b) { if (b) return 42; static int x = 0; return x; }; constexpr int x = f(true); const int *p = &x; Generates no diagnostics with this patch even with

[PATCH] D112600: [ARM] Use hardware TLS register in Thumb2 mode when -mtp=cp15 is passed

ardb added a comment. Thanks all. Could someone with commit access please merge this? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112600/new/ https://reviews.llvm.org/D112600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D112600: [ARM] Use hardware TLS register in Thumb2 mode when -mtp=cp15 is passed

nickdesaulniers added a comment. In D112600#3091959 , @ardb wrote: > Thanks all. Could someone with commit access please merge this? Thanks. Sure thing; I'll pick it up. Thanks again for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 33427fd - [libomptarget] Build DeviceRTL for amdgpu

Author: Jon Chesterfield Date: 2021-10-28T00:41:45+01:00 New Revision: 33427fdb7b52b79ce5e25b7e14e0f1a44d876bd2 URL: https://github.com/llvm/llvm-project/commit/33427fdb7b52b79ce5e25b7e14e0f1a44d876bd2 DIFF: https://github.com/llvm/llvm-project/commit/33427fdb7b52b79ce5e25b7e14e0f1a44d876bd2.di

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

This revision was automatically updated to reflect the committed changes. Closed by commit rG33427fdb7b52: [libomptarget] Build DeviceRTL for amdgpu (authored by JonChesterfield). Changed prior to commit: https://reviews.llvm.org/D112227?vs=382446&id=382853#toc Repository: rG LLVM Github Mon

[PATCH] D112600: [ARM] Use hardware TLS register in Thumb2 mode when -mtp=cp15 is passed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7e089f2d6a5: [ARM] Use hardware TLS register in Thumb2 mode when -mtp=cp15 is passed (authored by ardb, committed by nickdesaulniers). Repository:

[clang] 6c7b203 - Revert "[libomptarget] Build DeviceRTL for amdgpu"

Author: Jon Chesterfield Date: 2021-10-28T01:01:53+01:00 New Revision: 6c7b203d1d7000269215ab5b3d329ab03dc85e42 URL: https://github.com/llvm/llvm-project/commit/6c7b203d1d7000269215ab5b3d329ab03dc85e42 DIFF: https://github.com/llvm/llvm-project/commit/6c7b203d1d7000269215ab5b3d329ab03dc85e42.di

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield reopened this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Didn't fare very well under CI, investigating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/APValue.cpp:133 +void APValue::LValueBase::setNoCFIValue(bool NoCFI) { + if (is()) { +Local.NoCFIValue = NoCFI; Remove braces

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

eugenis added inline comments. Comment at: llvm/include/llvm/Analysis/StackSafetyAnalysis.h:93 + bool invalidate(Module &, const PreservedAnalyses &, + ModuleAnalysisManager::Invalidator &) { +return false; vitalybuka wrote: > vitalybuka wro

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Synchronization.cpp:196 -void syncThreadsAligned() { syncThreads(); } - -void fenceTeam(int Ordering) { __builtin_amdgcn_fence(Ordering, "workgroup"); } - -void fenceKernel(int Ordering) { __bu

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield updated this revision to Diff 382864. JonChesterfield added a comment. - Reintroduce syncThreadsAligned, dropped in git merge conflict Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D112227 Files

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield updated this revision to Diff 382866. JonChesterfield added a comment. - fix new+old test enabling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D112227 Files: clang/lib/Driver/ToolChains/AMDG

Maintenance works at llvm lab today

Hello everyone, LLVM lab and build bot will be unavailable for about 3 hours starting from 6:00 PM PST today for lab maintenance work. Thank you for understanding. Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, tianshilei1992, jhuber6, ye-luo, ronlieb, pdhaliwal. Herald added subscribers: asavonic, kerbowa, guansong, tpr, yaxunl, mgorny, nhaehnle, jvesely. JonChesterfield requested review of this revision. Herald added su

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield added a comment. Makes more sense with D112227 landed, but probably worthwhile just for the old runtime as it removes the link failure from all the tests that use printf. Comment at: clang/lib/CodeGen/CGGPUBuiltin.cpp:94 +std

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield added a reviewer: ronlieb. JonChesterfield added a comment. Tagging Ron as this is current stuck on the mystery of passing locally and failing CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D1

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield updated this revision to Diff 382873. JonChesterfield added a comment. - rebase to not require new runtime, stubs now return error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112680/new/ https://reviews.llvm.org/D112680 Files:

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield added a comment. New runtime failing CI suggests it may take some iteration to land, so reworked this to make sense with or without it. Doesn't make much difference to nvptx - printf still ultimately resolves to the same vprintf function as before - but a lot of tests that were

[PATCH] D112682: [openmp][nfc] Subset of D112680, landing would clean up diff

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, tianshilei1992, jhuber6, ye-luo, ronlieb, pdhaliwal. Herald added subscribers: guansong, yaxunl. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a pro

[PATCH] D112682: [openmp][nfc] Subset of D112680

JonChesterfield added a comment. Change takes the bulk of EmitNVPTXDevicePrintfCallExpr into a helper function, and adjusts it to also return the size of the alloca for use in D112680 . NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD updated this revision to Diff 382879. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-arch.c

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD updated this revision to Diff 382880. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-arch.c

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:112 return 0; - assert(RVVVectorBitsMax >= 128 && RVVVectorBitsMax <= 65536 && + assert(RVVVectorBitsMax >= 32 && RVVVectorBitsMax <= 65536 && isPowerOf2_32(RVVVectorBitsMax) && ---

[clang] 6cf6fa6 - [OpenMP] Declare variants for templates need to match # template args

Author: Johannes Doerfert Date: 2021-10-27T21:04:32-05:00 New Revision: 6cf6fa6ef1c28de0d553a38defa719342774f104 URL: https://github.com/llvm/llvm-project/commit/6cf6fa6ef1c28de0d553a38defa719342774f104 DIFF: https://github.com/llvm/llvm-project/commit/6cf6fa6ef1c28de0d553a38defa719342774f104.d

[PATCH] D109770: [OpenMP] Declare variants for templates need to match # template args

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6cf6fa6ef1c2: [OpenMP] Declare variants for templates need to match # template args (authored by jdoerfert). Repository: rG LLVM Github Monorepo

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

housel updated this revision to Diff 382884. housel added a comment. Added additional comments to `CFI_Parser::decodeFDE`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111863/new/ https://reviews.llvm.org/D111863 Files: libunwind/src/DwarfParse

[clang] 6ea2431 - [clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support `__atomic_fetch_nand` libcall

Author: Kai Luo Date: 2021-10-28T02:18:43Z New Revision: 6ea2431d3f109aefa31cd4d520cc234a5aa5484a URL: https://github.com/llvm/llvm-project/commit/6ea2431d3f109aefa31cd4d520cc234a5aa5484a DIFF: https://github.com/llvm/llvm-project/commit/6ea2431d3f109aefa31cd4d520cc234a5aa5484a.diff LOG: [clan

[PATCH] D112400: [clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support `__atomic_fetch_nand` libcall

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ea2431d3f10: [clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support… (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 15e3d39 - [clang] Fortify warning for scanf calls with field width too big.

Author: Michael Benfield Date: 2021-10-28T02:52:03Z New Revision: 15e3d39110fa4449be4f56196af3bc81b623f3ab URL: https://github.com/llvm/llvm-project/commit/15e3d39110fa4449be4f56196af3bc81b623f3ab DIFF: https://github.com/llvm/llvm-project/commit/15e3d39110fa4449be4f56196af3bc81b623f3ab.diff L

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

This revision was automatically updated to reflect the committed changes. Closed by commit rG15e3d39110fa: [clang] Fortify warning for scanf calls with field width too big. (authored by mbenfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111833

[PATCH] D112652: [clangd] Avoid expensive checks of buffer names in IncludeCleaner

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112652/new/ https://reviews.llvm.org/D112652 __

[PATCH] D112481: [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType

weiwang added a comment. This issue has been blocking our internal module re-enablement for some time now, and we really appreciate any feedback. We also wonder if only `DeducedTemplateSpecializationType` is affected or it could also happen to other types. Repository: rG LLVM Github Monorep

[PATCH] D111400: [Clang] Implement P2242R3

hubert.reinterpretcast added a comment. Lambda capture semantics mean that extensions or inconsistencies in constexpr evaluation result in binary-compatibility issues. struct NonLit { NonLit(); }; template constexpr int foo() { return 42; T t; } extern int g(void *); i

[clang-tools-extra] 73453e7 - [clangd] Avoid expensive checks of buffer names in IncludeCleaner

Author: Sam McCall Date: 2021-10-28T08:00:57+02:00 New Revision: 73453e7adecbcc7208ceb70d5e55086ffbd1de3a URL: https://github.com/llvm/llvm-project/commit/73453e7adecbcc7208ceb70d5e55086ffbd1de3a DIFF: https://github.com/llvm/llvm-project/commit/73453e7adecbcc7208ceb70d5e55086ffbd1de3a.diff LO

[PATCH] D112652: [clangd] Avoid expensive checks of buffer names in IncludeCleaner

This revision was automatically updated to reflect the committed changes. Closed by commit rG73453e7adecb: [clangd] Avoid expensive checks of buffer names in IncludeCleaner (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112652

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki marked an inline comment as done. linjamaki added inline comments. Comment at: clang/include/clang/Driver/Options.td:1534 +HelpText<"Specify maximum SPIR-V version which can be emitted">; +def spirv_ext_EQ : CommaJoined<["--"], "spirv-ext">, +HelpText<"Specify c

[PATCH] D112410: [SPIR-V] Add a tool chain for SPIR-V (incomplete)

linjamaki added a comment. > Do I read it correctly that you would have no objections for others to rework > this patch if needed? :) Yes, anyone can work on this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112410/new/ https://reviews.ll

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki updated this revision to Diff 382931. linjamaki marked an inline comment as done. linjamaki added a comment. Remove `--spirv-ext` and `--spirv-max-version`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://reviews.llvm.or

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 382932. linjamaki added a comment. Update for changes in D112404 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/

[PATCH] D112398: [RISCV] Add ABI testing for Float16.

rogfer01 added a comment. I'm curious about how we handle `_Float16` here. My understanding from the psabi and the Zfh draft

<    1   2   3