eugenis added inline comments.
================
Comment at: llvm/include/llvm/Analysis/StackSafetyAnalysis.h:93
+ bool invalidate(Module &, const PreservedAnalyses &,
+ ModuleAnalysisManager::Invalidator &) {
+ return false;
----------------
vitalybuka wrote:
> vitalybuka wrote:
> > we still can't do that, some passes can make results irrelevant
> Looks like only immutable analysis can be used through proxy, and this
> analysis cannot be immutable.
> Maybe we have to convert Asan into ModulePass, like HWAsan.
> Any other ideas? @eugenis @pcc @morehouse
Is the problem here that an invalidated analysis needs to be rerun, and the
module-to-function proxy does not know how to do that?
TBH, I'm not sure how big the performance benefits of a function pass are. With
the amount of time we've sunk in working around function pass requirements and
I'd say just go for it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112098/new/
https://reviews.llvm.org/D112098
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
