[PATCH] D111760: [clang] Support __float128 on DragonFlyBSD.

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Ok then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111760/new/ https://reviews.llvm.org/D111760 ___

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

HsiangKai added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vmerge-rv32.ll:1358 +; CHECK-NEXT:vsetvli zero, a0, e16, mf4, ta, mu +; CHECK-NEXT:vmerge.vvm v8, v8, v9, v0 +; CHECK-NEXT:ret vmerge.vvm is for integer vectors, doesn't it? Why

[clang] 5e96912 - [clang-format] git-clang-format throws an assertion when removing files as part of the commit

Author: mydeveloperday Date: 2021-10-20T09:07:12+01:00 New Revision: 5e969125c6094b909493bcd8360497adcdf8f6f5 URL: https://github.com/llvm/llvm-project/commit/5e969125c6094b909493bcd8360497adcdf8f6f5 DIFF: https://github.com/llvm/llvm-project/commit/5e969125c6094b909493bcd8360497adcdf8f6f5.diff

[PATCH] D112056: [clang-format] git-clang-format throws an assertion when removing files as part of the commit

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e969125c609: [clang-format] git-clang-format throws an assertion when removing files as part… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D112020: [RISCV] Use clang_builtin_alias for all RISCV vector intrinsics.

HsiangKai added a comment. After preprocessing, macro definitions will disappear, but function declarations will not. This is the benefit of using macro. After applying D112102 , we could still use #define vadd_vv_i8m1(op0, op1, op2) \ __builtin_rvv_vadd_vv

[clang] 57e0081 - [clang-format] [PR52015] clang-format should put __attribute__((foo)) on its own line before @interface / @implementation / @protocol

Author: mydeveloperday Date: 2021-10-20T09:09:31+01:00 New Revision: 57e00810edd7c4359e3de9242bcbd8874d58dc64 URL: https://github.com/llvm/llvm-project/commit/57e00810edd7c4359e3de9242bcbd8874d58dc64 DIFF: https://github.com/llvm/llvm-project/commit/57e00810edd7c4359e3de9242bcbd8874d58dc64.diff

[PATCH] D111975: [clang-format] [PR52015] clang-format should put __attribute__((foo)) on its own line before @interface / @implementation / @protocol

This revision was automatically updated to reflect the committed changes. Closed by commit rG57e00810edd7: [clang-format] [PR52015] clang-format should put __attribute__((foo)) on its… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm updated this revision to Diff 380871. hsmhsm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D112020: [RISCV] Use clang_builtin_alias for all RISCV vector intrinsics.

HsiangKai added a comment. In D112020#3074557 , @HsiangKai wrote: > After preprocessing, macro definitions will disappear, but function > declarations will not. This is the benefit of using macro. > > After applying D112102

[clang] 6d0c7bc - [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR

Author: Paulo Matos Date: 2021-10-20T10:31:31+02:00 New Revision: 6d0c7bc17de85807c286f78571235b6658999faf URL: https://github.com/llvm/llvm-project/commit/6d0c7bc17de85807c286f78571235b6658999faf DIFF: https://github.com/llvm/llvm-project/commit/6d0c7bc17de85807c286f78571235b6658999faf.diff L

[PATCH] D111154: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d0c7bc17de8: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR (authored by pmatos). Changed prior to commit: https://reviews.llvm.org/D54?vs=380337&id=380872#toc Repository:

[PATCH] D111154: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR

pmatos added a comment. In D54#3074221 , @tlively wrote: > Nice! Just a couple nits but I think this is good to go. Perfect, thanks for the comments. Fixed nits and landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D106681: [analyzer][NFC] Move a block from `getBindingForElement` to separate functions

ASDenysPetrov added a comment. @steakhal All your comments are fair in terms of NFC. I also tried to improve some places. I think I should requalificate the revision to non-NFC, that I can be more untied to bring some improvements. Comment at: clang/lib/StaticAnalyzer/Core/Re

[PATCH] D106681: [analyzer][NFC] Move a block from `getBindingForElement` to separate functions

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1686-1689 + // Array's declaration should have an initializer. + const Expr *Init = VD->getAnyInitializer(); + if (!Init) +return None; steakhal wrote: > This sh

[PATCH] D106681: [analyzer][NFC] Move a block from `getBindingForElement` to separate functions

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1686-1689 + // Array's declaration should have an initializer. + const Expr *Init = VD->getAnyInitializer(); + if (!Init) +return None; ASDenysPetrov wrote: > st

[PATCH] D112020: [RISCV] Use clang_builtin_alias for all RISCV vector intrinsics.

HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. I ran tests under `clang/test/CodeGen/RISCV/rvv-intrinsics/`. It spent a little more time to run the tests. (previous: 84.01s; apply this patch: 96.43s in my local environment.) We could

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

frasercrmck added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vmerge-rv32.ll:1358 +; CHECK-NEXT:vsetvli zero, a0, e16, mf4, ta, mu +; CHECK-NEXT:vmerge.vvm v8, v8, v9, v0 +; CHECK-NEXT:ret HsiangKai wrote: > vmerge.vvm is for integer vect

[clang] f45d740 - [docs] Fix hyperlink

Author: Sven van Haastregt Date: 2021-10-20T10:20:17+01:00 New Revision: f45d7407168d08c4d80216ca13feb1e1c21ad6bb URL: https://github.com/llvm/llvm-project/commit/f45d7407168d08c4d80216ca13feb1e1c21ad6bb DIFF: https://github.com/llvm/llvm-project/commit/f45d7407168d08c4d80216ca13feb1e1c21ad6bb.

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

frasercrmck added a comment. Minor typo in the description: `differnet` Does this help with compile times, binary sizes, etc? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112102/new/ https://reviews.llvm.org/D112102 _

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:149 + +RangeSet RangeSet::Factory::unite(RangeSet Original, llvm::APSInt Point) { + return unite(Original, Range(ValueFactory.getValue(Point))); ASDenysPetrov wro

[PATCH] D106681: [analyzer][NFC] Move a block from `getBindingForElement` to separate functions

steakhal added a comment. I think it's fine, maybe `NFCi` is would be slightly more accurate, while stating the minor behavior change and the reason for doing so in the patch summary could further improve the visibility of this issue. That being said, since it actually changes some behavior, I'

[PATCH] D112020: [RISCV] Use clang_builtin_alias for all RISCV vector intrinsics.

khchen accepted this revision. khchen added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112020/new/ https://reviews.llvm.org/D112020 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

brunodf updated this revision to Diff 380885. brunodf edited the summary of this revision. brunodf added a reviewer: akyrtzi. brunodf added a subscriber: akyrtzi. brunodf added a comment. @rnk raises the remark that TreeTransform::RebuildCXXOperatorCallExpr already contains code to handle ObjC ps

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

khchen added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:120 // type transformer (say "vv") each of the types is separated with an // underscore as in "__builtin_rvv_foo_i32m1_i32m1". // nit: we need to update this comment. Reposit

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

ASDenysPetrov added a comment. In D107339#3060812 , @martong wrote: > I am close to accepting this. However, D111542 > should be its parent patch. I think > similar issues could arise here as well, so, redecl chain tes

[PATCH] D112130: [clangd] Fix use-after-free in HeaderIncluderCache

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman, javed.absar. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Includer cache cou

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

kiranchandramohan added a comment. The patch looks OK. I just wanted to discuss the syntax also. Would any of the following be better? %8 = omp.atomic.read %addr : memref -> i32 hint(speculative, contended) memory_order(seq_cst) %8 = omp.atomic.read %addr hint(speculative, contended) memo

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

shraiysh added a comment. Hi @kiranchandramohan. Thanks for the review. > %8 = omp.atomic.read %addr : memref -> i32 hint(speculative, > contended) memory_order(seq_cst) This cannot be done because the statement ends at optional clauses. This is dangerous in the following situation where par

[PATCH] D106681: [analyzer][NFC] Move a block from `getBindingForElement` to separate functions

ASDenysPetrov added a comment. In D106681#3074678 , @steakhal wrote: > I think it's fine, maybe `NFCi` is would be slightly more accurate, while > stating the minor behavior change and the reason for doing so in the patch > summary could further improve

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

HsiangKai added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vmerge-rv32.ll:1358 +; CHECK-NEXT:vsetvli zero, a0, e16, mf4, ta, mu +; CHECK-NEXT:vmerge.vvm v8, v8, v9, v0 +; CHECK-NEXT:ret frasercrmck wrote: > HsiangKai wrote: > > vmerge.vv

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

HsiangKai added a comment. In D112102#3074656 , @frasercrmck wrote: > Minor typo in the description: `differnet` > > Does this help with compile times, binary sizes, etc? After this patch, we may be able to consider removing all type ending C APIs. Oth

[clang] ab2ca84 - consteval if does not form a discarded statement

Author: Aaron Ballman Date: 2021-10-20T07:24:55-04:00 New Revision: ab2ca8496d54573de1c8bec204009567ba2b4086 URL: https://github.com/llvm/llvm-project/commit/ab2ca8496d54573de1c8bec204009567ba2b4086 DIFF: https://github.com/llvm/llvm-project/commit/ab2ca8496d54573de1c8bec204009567ba2b4086.diff

[PATCH] D112089: consteval if does not form a discarded statement

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in ab2ca8496d54573de1c8bec204009567ba2b4086 and filed https://bugs.llvm.org/show_bug.cgi?id=52231 as the bug for the remaining bits, thanks for th

[PATCH] D112130: [clangd] Fix use-after-free in HeaderIncluderCache

kadircet updated this revision to Diff 380895. kadircet added a comment. - Rather than dropping the entry, perform an extra check during invalidate. As the entry actually backs the data for main file strings in associations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D106681: [analyzer][NFC] Move a block from `getBindingForElement` to separate functions

ASDenysPetrov updated this revision to Diff 380897. ASDenysPetrov added a comment. Make changes according to comments. Thanks to @steakhal CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106681/new/ https://reviews.llvm.org/D106681 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp

[PATCH] D112081: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

aaron.ballman accepted this revision. aaron.ballman added a comment. In D112081#3073291 , @rjmccall wrote: > The standard answer is that compilers are designed to work with a specific > set of system headers. In the Clang-on-Windows case, that's complic

[PATCH] D106681: [analyzer][NFC] Move a block from `getBindingForElement` to separate functions

ASDenysPetrov updated this revision to Diff 380906. ASDenysPetrov added a comment. Minor comment update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106681/new/ https://reviews.llvm.org/D106681 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/Analysis/initializatio

[PATCH] D106681: [analyzer][NFCI] Move a block from `getBindingForElement` to separate functions

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1666 + if (!OffsetVal.hasValue()) +return UnknownVal(); + Item 2 from the Summary. This was borrowed from `RegionStoreManager::getBindingForFieldOrElementCommon`

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

ASDenysPetrov updated this revision to Diff 380910. ASDenysPetrov added a comment. Updated according to the latest suggestions. @martong I think now this patch is way more simple and clear than before. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111542/new/ https://reviews.llvm.org/D1

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

ASDenysPetrov added a comment. In D111542#3073709 , @NoQ wrote: > Amazing, thanks a lot! Thank you, @NoQ, for the acceptance. I got some fresher update. And, of course in order to load it, we should accept a parent revision D106681

[libunwind] 5a8ad80 - [libunwind] Use the from-scratch testing configuration by default

Author: Louis Dionne Date: 2021-10-20T08:45:58-04:00 New Revision: 5a8ad80b6fa5cbad58b78384f534b78fca863e7f URL: https://github.com/llvm/llvm-project/commit/5a8ad80b6fa5cbad58b78384f534b78fca863e7f DIFF: https://github.com/llvm/llvm-project/commit/5a8ad80b6fa5cbad58b78384f534b78fca863e7f.diff

[PATCH] D112135: [ARM] Fix inline assembly referencing floating point registers on soft-float targets

kpdev42 created this revision. kpdev42 added reviewers: dmgreen, thakis, dcandler, nickdesaulniers, LukeGeeson. kpdev42 added a project: LLVM. Herald added a subscriber: kristof.beyls. kpdev42 requested review of this revision. Herald added a project: clang. Fixes PR: https://bugs.llvm.org/show_bu

[PATCH] D112137: [clangd] Only publish preamble after rebuilds

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman, javed.absar. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Don't invoke parsi

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

thakis added a comment. Thanks for this warning! I just finished turning it on in Chromium. Here's a short report on the things it fired on in case it's interesting to anyone. (I'm not suggesting any changes to the warning, I think it works very well as-is). The warning fired in 21 different fi

[PATCH] D106681: [analyzer][NFCI] Move a block from `getBindingForElement` to separate functions

ASDenysPetrov updated this revision to Diff 380934. ASDenysPetrov added a comment. Fixed redefinition in test file //initialization.cpp//. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106681/new/ https://reviews.llvm.org/D106681 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp

[PATCH] D112130: [clangd] Fix use-after-free in HeaderIncluderCache

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:294 invalidate(First); +// MainToFirst entry should stay alive, as Associations might be pointing a

[PATCH] D112137: [clangd] Only publish preamble after rebuilds

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:904 const ParseInputs &Inputs = Req.Inputs; + bool RebuiltPreamble = true; I think it wo

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

ASDenysPetrov updated this revision to Diff 380936. ASDenysPetrov added a comment. Fixed redefinition in test file initialization.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111542/new/ https://reviews.llvm.org/D111542 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp cla

[PATCH] D111985: [Clang] Add elementwise min/max builtins.

fhahn updated this revision to Diff 380946. fhahn added a comment. Move type checking to helper function checkMathBuiltinElementType to be reused in D111986 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111985/ne

[PATCH] D111986: [Clang] Add elementwise abs builtin.

fhahn updated this revision to Diff 380947. fhahn added a comment. Use checkMathBuiltinElementType helper added in D111985 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111986/new/ https://reviews.llvm.org/D1119

[PATCH] D112001: [Clang] Add min/max reduction builtins.

fhahn updated this revision to Diff 380948. fhahn marked an inline comment as done. fhahn added a comment. rebase on top of recently updated patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112001/new/ https://reviews.llvm.org/D112001 Files:

[PATCH] D112050: [clang] NFC: return void in an alternative expression after call to void function.

zhouyizhou added a comment. I create this patch because I am also a Linux hobbyist, in Linux kernel, return statement in a void function is always standalone. For example in kernel/event/core.c: static void perf_event_exit_event(struct perf_event *child_event, struct perf_event_context *chi

[clang-tools-extra] c959da9 - [clangd] Only publish preamble after rebuilds

Author: Kadir Cetinkaya Date: 2021-10-20T16:32:32+02:00 New Revision: c959da9ef344a22e3753e2e62af46a63a33cd80f URL: https://github.com/llvm/llvm-project/commit/c959da9ef344a22e3753e2e62af46a63a33cd80f DIFF: https://github.com/llvm/llvm-project/commit/c959da9ef344a22e3753e2e62af46a63a33cd80f.dif

[PATCH] D112137: [clangd] Only publish preamble after rebuilds

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rGc959da9ef344: [clangd] Only publish preamble after rebuilds (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D112137?vs=380931&id=3809

[PATCH] D111986: [Clang] Add elementwise abs builtin.

fhahn marked 2 inline comments as done. fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16667 + + if (!TyA->getAs() && !ConstantMatrixType::isValidElementType(TyA)) +return Diag(A->getBeginLoc(), diag::err_elementwise_math_invalid_arg_type)

[PATCH] D112130: [clangd] Fix use-after-free in HeaderIncluderCache

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:294 invalidate(First); +// MainToFirst entry should stay alive, as Associations might be pointing at +// its key. sammc

[clang-tools-extra] 60e19f6 - [clangd] Fix use-after-free in HeaderIncluderCache

Author: Kadir Cetinkaya Date: 2021-10-20T16:36:07+02:00 New Revision: 60e19f6752b7f19b022d8bdca0937c59b49811f9 URL: https://github.com/llvm/llvm-project/commit/60e19f6752b7f19b022d8bdca0937c59b49811f9 DIFF: https://github.com/llvm/llvm-project/commit/60e19f6752b7f19b022d8bdca0937c59b49811f9.dif

[PATCH] D112130: [clangd] Fix use-after-free in HeaderIncluderCache

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG60e19f6752b7: [clangd] Fix use-after-free in HeaderIncluderCache (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D112130?vs=380895&id

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. Any updates? I do not have commit permissions. @ahatanak CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110068/new/ https://reviews.llvm.org/D110068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

yaxunl marked an inline comment as done. yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111443/new/ https://reviews.llvm.org/D111443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

mbenfield updated this revision to Diff 380956. mbenfield added a comment. respond to comments: null to NUL, remove stray space, use function_ref Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111833/new/ https://reviews.llvm.org/D111833 Files: c

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 380958. gAlfonso-bit added a comment. Rebased to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110068/new/ https://reviews.llvm.org/D110068 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp ==

[clang] 0abb5d2 - [Sema, StaticAnalyzer] Use StringRef::contains (NFC)

Author: Kazu Hirata Date: 2021-10-20T08:02:36-07:00 New Revision: 0abb5d293cf7289780542fd9c5f0d84e5aadbdc8 URL: https://github.com/llvm/llvm-project/commit/0abb5d293cf7289780542fd9c5f0d84e5aadbdc8 DIFF: https://github.com/llvm/llvm-project/commit/0abb5d293cf7289780542fd9c5f0d84e5aadbdc8.diff L

[PATCH] D112013: [clang][ASTImporter] Fix for importing functions with EST_Unevaluated prototype.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks! The fix makes sense and looks good to me. Though, it would be nice if you could provide a test without the hand crafting of the setTypeSourceInfo, but I think that could be done in a

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

steakhal added a comment. Why does `glob_invalid_index7()` and `glob_invalid_index8()` differ in behavior? I would expect that the analyzer produces the same `Loc` symbolic value for both cases thus, the array access should result in the same behavior regardless if `glob_arr6` is used, or acquir

[PATCH] D112143: [X86][ABI] Do not return float/double from x87 registers when x87 is disabled

pengfei created this revision. pengfei added reviewers: aturetsk, echristo, RKSimon, LuoYuanke, craig.topper. Herald added subscribers: dang, hiraditya. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is align

[PATCH] D106681: [analyzer][NFCI] Move a block from `getBindingForElement` to separate functions

steakhal added a comment. In D106681#3074779 , @ASDenysPetrov wrote: > In D106681#3074678 , @steakhal > wrote: > >> I think it's fine, maybe `NFCi` is would be slightly more accurate, while >> stating the minor

[clang] 16be17a - [analyzer][NFC] Refactor llvm::isa<> usages in the StaticAnalyzer

Author: Balazs Benics Date: 2021-10-20T17:43:31+02:00 New Revision: 16be17ad4b13deb23c893c3c668076e70b07f289 URL: https://github.com/llvm/llvm-project/commit/16be17ad4b13deb23c893c3c668076e70b07f289 DIFF: https://github.com/llvm/llvm-project/commit/16be17ad4b13deb23c893c3c668076e70b07f289.diff

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111566/new/ https://reviews.llvm.org/D111566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D111982: [analyzer][NFC] Refactor llvm::isa<> usages in the StaticAnalyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rG16be17ad4b13: [analyzer][NFC] Refactor llvm::isa<> usages in the StaticAnalyzer (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: ht

[clang] a29dfc0 - [RISCV] Use clang_builtin_alias for all RISCV vector intrinsics.

Author: Craig Topper Date: 2021-10-20T08:50:42-07:00 New Revision: a29dfc089d18b542694cd26a06bee822ab90fb56 URL: https://github.com/llvm/llvm-project/commit/a29dfc089d18b542694cd26a06bee822ab90fb56 DIFF: https://github.com/llvm/llvm-project/commit/a29dfc089d18b542694cd26a06bee822ab90fb56.diff

[PATCH] D112020: [RISCV] Use clang_builtin_alias for all RISCV vector intrinsics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa29dfc089d18: [RISCV] Use clang_builtin_alias for all RISCV vector intrinsics. (authored by craig.topper). Changed prior to commit: https://review

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:149 + +RangeSet RangeSet::Factory::unite(RangeSet Original, llvm::APSInt Point) { + return unite(Original, Range(ValueFactory.getValue(Point))); martong wrote: >

[PATCH] D111566: [SYCL] Fix function pointer address space

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. @vlastik, your commit fixes function pointers on AVR - https://github.com/llvm/llvm-project/commit/57fd86de879cf2b4c7001b6d0a09df60877ce24d. I suppose this change is required for fixing lvalue r

[clang] fe66433 - [clang] Add plugin ActionType to run command line plugin before main action

Author: Arthur Eubanks Date: 2021-10-20T08:58:20-07:00 New Revision: fe66433fe119819a033827610f7eae4cdd8b1470 URL: https://github.com/llvm/llvm-project/commit/fe66433fe119819a033827610f7eae4cdd8b1470 DIFF: https://github.com/llvm/llvm-project/commit/fe66433fe119819a033827610f7eae4cdd8b1470.diff

[PATCH] D112096: [clang] Add plugin ActionType to run command line plugin before main action

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe66433fe119: [clang] Add plugin ActionType to run command line plugin before main action (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

craig.topper added a comment. In D112102#3074656 , @frasercrmck wrote: > Minor typo in the description: `differnet` > > Does this help with compile times, binary sizes, etc? This reduces the clang binary size by 2.34 megabytes according to my local rel

[PATCH] D112146: [WebAssembly] Add prototype relaxed float min max instructions

ngzhian created this revision. ngzhian added a reviewer: tlively. Herald added subscribers: ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. ngzhian requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang, LLVM.

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. @dexonsmith Could you please commit this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110068/new/ https://reviews.llvm.org/D110068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

craig.topper updated this revision to Diff 380982. craig.topper added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112102/new/ https://reviews.llvm.org/D112102 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sema/

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1649-1653 + // NOTE: `VD` is always non-null if `Init` is non-null, so we can check for + // null only one of them. + const Expr *Init = VD->getAnyInitializer(VD); if (!Init) retu

[PATCH] D106681: [analyzer][NFCI] Move a block from `getBindingForElement` to separate functions

ASDenysPetrov added a comment. In D106681#3075337 , @steakhal wrote: > I just wanted you to think about these cases. > BTW this should work for **L1646**: > > extern const int arr[]; // Incomplete array type > void top() { > (void)arr[42]; > }

[PATCH] D106681: [analyzer][NFCI] Move a block from `getBindingForElement` to separate functions

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me! But, please wait for an approve from @steakhal as well. Comment at: clang/test/Analysis/initialization.c:103 +void glob_arr_index4() { + cl

[PATCH] D106681: [analyzer][NFCI] Move a block from `getBindingForElement` to separate functions

steakhal added inline comments. Comment at: clang/test/Analysis/initialization.c:103 +void glob_arr_index4() { + clang_analyzer_eval(glob_arr_no_init[2]); // expected-warning{{UNKNOWN}} +} martong wrote: > ASDenysPetrov wrote: > > steakhal wrote: > > > I'm prett

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

martong accepted this revision. martong added a comment. In D111542#3074926 , @ASDenysPetrov wrote: > Updated according to the latest suggestions. > @martong I think now this patch is way more simple and clear than before. Thanks, indeed! LGTM (with nit

[PATCH] D112146: [WebAssembly] Add prototype relaxed float min max instructions

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112146/new/ https://reviews.llvm.org/D112146

[PATCH] D110287: [modules] While merging ObjCInterfaceDecl definitions, merge them as decl contexts too.

dblaikie added a comment. In D110287#3074175 , @vsapsai wrote: > In D110287#3074082 , @dblaikie > wrote: > >> In D110287#3073804 , @vsapsai >> wrote: >> >>> Pre-merge ch

[clang] e1fb134 - [WebAssembly] Add prototype relaxed float min max instructions

Author: Zhi An Ng Date: 2021-10-20T09:41:51-07:00 New Revision: e1fb13401e1b90a912ba83c6d1a82794cfdb8aec URL: https://github.com/llvm/llvm-project/commit/e1fb13401e1b90a912ba83c6d1a82794cfdb8aec DIFF: https://github.com/llvm/llvm-project/commit/e1fb13401e1b90a912ba83c6d1a82794cfdb8aec.diff LOG

[PATCH] D112146: [WebAssembly] Add prototype relaxed float min max instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1fb13401e1b: [WebAssembly] Add prototype relaxed float min max instructions (authored by ngzhian, committed by tlively). Repository: rG LLVM Gith

[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

RKSimon added inline comments. Comment at: llvm/lib/LTO/LTOBackend.cpp:234 + if (TM) +TM->setPGOOption(PGOOpt); @xur Why does TM need a null check - afaict it's already been dereferenced in the call tree, and will be again below. Noticed in a scan-build

[PATCH] D112157: [clang] Disallow mixing SEH and Objective-C exceptions

thakis created this revision. thakis added a reviewer: rnk. thakis requested review of this revision. We already disallow mixing SEH and C++ exceptions, and mixing SEH and Objective-C exceptions seems to not work (see PR52233). Emitting an error is friendlier than crashing. https://reviews.llvm.

[clang] 7562f3d - InvalidPtrChecker - don't dereference a dyn_cast<> - use cast<> instead.

Author: Simon Pilgrim Date: 2021-10-20T18:06:00+01:00 New Revision: 7562f3df89066ab92a816dc23005c45fd642bdf9 URL: https://github.com/llvm/llvm-project/commit/7562f3df89066ab92a816dc23005c45fd642bdf9 DIFF: https://github.com/llvm/llvm-project/commit/7562f3df89066ab92a816dc23005c45fd642bdf9.diff

[PATCH] D112158: mips: fix search path for multilib o32

wzssyqa created this revision. wzssyqa added a reviewer: atanasyan. Herald added subscribers: arichardson, sdardis. wzssyqa requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the situation of multilib, the gcc objects are in a /32 directory

[PATCH] D112159: Relax assert in ExprConstant to a return None.

JonChesterfield created this revision. JonChesterfield added reviewers: gribozavr, rsmith, ABataev, dblaikie, aaron.ballman, jdoerfert. JonChesterfield requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes a compiler assert on passing a co

[PATCH] D111993: [libomptarget][WIP] Patch amdgpu DeviceRTL until it compiles

JonChesterfield added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Synchronization.cpp:92 +} +// clang/lib/AST/ExprConstant.cpp:14739: bool clang::Expr::EvaluateAsInt(clang::Expr::EvalResult&, const clang::ASTContext&, clang::Expr::SideEffectsKind, bool) const

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille updated this revision to Diff 381011. serge-sans-paille added a comment. Reduce the number of time we would walk redecls. Simplify test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059 Files: clang/lib/CodeGen/CodeGenFu

[PATCH] D112159: Relax assert in ExprConstant to a return None.

jdoerfert added a comment. This makes sense, any reason we don't remove the check at the call sites right away? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112159/new/ https://reviews.llvm.org/D112159 ___

[PATCH] D108872: [IR] Refactor GlobalIFunc to inherit from GlobalObject, Remove GlobalIndirectSymbol

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08ed216000b6: [IR] Refactor GlobalIFunc to inherit from GlobalObject, Remove… (authored by ibookstein, committed by MaskRay). Herald added a project:

[clang] 08ed216 - [IR] Refactor GlobalIFunc to inherit from GlobalObject, Remove GlobalIndirectSymbol

Author: Itay Bookstein Date: 2021-10-20T10:29:47-07:00 New Revision: 08ed216000b6503a4a4be52f18394d008d5fb8f4 URL: https://github.com/llvm/llvm-project/commit/08ed216000b6503a4a4be52f18394d008d5fb8f4 DIFF: https://github.com/llvm/llvm-project/commit/08ed216000b6503a4a4be52f18394d008d5fb8f4.diff

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille updated this revision to Diff 381014. serge-sans-paille added a comment. Avoid walking redecls CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGen/strlen-inline-

  1   2   >