JonChesterfield added inline comments.

================
Comment at: openmp/libomptarget/DeviceRTL/src/Synchronization.cpp:92
+}
+// clang/lib/AST/ExprConstant.cpp:14739: bool 
clang::Expr::EvaluateAsInt(clang::Expr::EvalResult&, const clang::ASTContext&, 
clang::Expr::SideEffectsKind, bool) const: Assertion `!isValueDependent() && 
"Expression evaluator can't be called on a dependent expression."' failed.
+
----------------
The assert in clang was unrelated to amdgpu, posted a diff at D112159 with a 
fix.

The other atomic builtins codegen with a switch on order when passed a 
variable. That seems like the right thing to do for the amdgpu-specific atomic 
builtins.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111993/new/

https://reviews.llvm.org/D111993

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to