[PATCH] D110482: [clang] Implement if consteval (P1938)

2021-09-29 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Stmt.h:164 -/// True if this if statement is a constexpr if. -unsigned IsConstexpr : 1; +/// Whether this is an if constexpr if or a consteval if or neither. +IfStatementKind Kind : 3;

[PATCH] D110482: [clang] Implement if consteval (P1938)

2021-09-29 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 375974. cor3ntin marked 15 inline comments as done. cor3ntin added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/include/clan

[PATCH] D110750: [clang] Fix sentence in the usage section of ThinLTO docs.

2021-09-29 Thread Frederic Cambus via Phabricator via cfe-commits
fcambus created this revision. fcambus added reviewers: tejohnson, xgupta. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo htt

[PATCH] D110750: [clang] Fix sentence in the usage section of ThinLTO docs.

2021-09-29 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110750/new/ https://reviews.llvm.org/D110750 _

[PATCH] D110665: [clang] Don't use the AST to display backend diagnostics

2021-09-29 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:129 SmallVector LinkModules; +std::vector> +ManglingFullSourceLocs; As David says, this could be a plain hash map, maybe hash_code isn't hashable, but it must have some w

[PATCH] D110670: [Sema] Allow comparisons between different ms ptr size address space types.

2021-09-29 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added reviewers: rnk, majnemer. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:6682 + isPtrSizeAddressSpace(Q2.getAddressSpace())) +MaybeQ1 = true; + else I'm pretty sure this is cor

[PATCH] D110655: [OpenMP] Apply OpenMP assumptions to applicable call sites

2021-09-29 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, once we can propagate assumptions we can remove this again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110655/new/ https://reviews.

[clang] fb4e44c - [PowerPC] The builtins load8r and store8r are Power 7 plus.

2021-09-29 Thread Stefan Pintilie via cfe-commits
Author: Stefan Pintilie Date: 2021-09-29T14:34:40-05:00 New Revision: fb4e44c4e7d1d2776e76d43566b0db264f30 URL: https://github.com/llvm/llvm-project/commit/fb4e44c4e7d1d2776e76d43566b0db264f30 DIFF: https://github.com/llvm/llvm-project/commit/fb4e44c4e7d1d2776e76d43566b0db264f30.dif

[PATCH] D110653: [PowerPC] The builtins load8r and store8r are Power 7 plus.

2021-09-29 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb4e44c4e7da: [PowerPC] The builtins load8r and store8r are Power 7 plus. (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

2021-09-29 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. Thanks, this is very exciting, and the diagnostic changes in the test suite look great! Comment at: clang-tools-extra/clangd/unittests/ASTTests.cpp:180 )cpp", - // FIXME: it'd be nice if this resolved to the alias instead -

[clang] 9866078 - [NFC][clang] Add newline to end of 2005-01-02-ConstantInits.c

2021-09-29 Thread via cfe-commits
Author: Jessica Clarke Date: 2021-09-29T20:47:31+01:00 New Revision: 986607896fcf720a6422dd26cfacde29ecf1a835 URL: https://github.com/llvm/llvm-project/commit/986607896fcf720a6422dd26cfacde29ecf1a835 DIFF: https://github.com/llvm/llvm-project/commit/986607896fcf720a6422dd26cfacde29ecf1a835.diff

[PATCH] D110482: [clang] Implement if consteval (P1938)

2021-09-29 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 376004. cor3ntin marked 3 inline comments as done. cor3ntin added a comment. Adress Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/i

[PATCH] D110482: [clang] Implement if consteval (P1938)

2021-09-29 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1520-1525 + if (IsConsteval) { +if (!isa_and_nonnull(ThenStmt.get())) { + Diag(ConstevalLoc, diag::err_expected_after) << "consteval" + << "{

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

2021-09-29 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3233 + + ``QualifierAlignment`` COULD lead to incorrect code generation. + simon.giesecke wrote: > This is pretty unclear, for a number of reasons: > * First, this prob

[PATCH] D110482: [clang] Implement if consteval (P1938)

2021-09-29 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1520-1525 + if (IsConsteval) { +if (!isa_and_nonnull(ThenStmt.get())) { + Diag(ConstevalLoc, diag::err_expected_after) << "consteval" + << "{"; +

[PATCH] D110727: [clang] don't instantiate templates with injected arguments

2021-09-29 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. I think it's almost always true that we don't substitute into a template unless we've already substituted into all enclosing templates. The only exception I can think of is alias templates, wh

[PATCH] D110726: [clang] NFC: remove duplicated code around type constraint and templ arg subst

2021-09-29 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110726/new/ https://reviews.llvm.org/D110726 __

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

2021-09-29 Thread James Nagurne via Phabricator via cfe-commits
JamesNagurne added a comment. The trigger for the remark I'm seeing is llvm::shouldInline in InlineAdvisor.cpp ((https://github.com/llvm/llvm-project/blob/2240deb9766cc080b351016b0d7f975d7249b113/llvm/lib/Transforms/IPO/Inliner.cpp#L425) which is called in a top-level AlwaysInlinerLegacyPass C

[PATCH] D110763: [clang] Update Clang version from 13 to 14 in scan-build.1.

2021-09-29 Thread Frederic Cambus via Phabricator via cfe-commits
fcambus created this revision. fcambus added a reviewer: xgupta. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110763 Files: clang/tools/scan-build/man/scan-build

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

2021-09-29 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. In D109625#3029581 , @phosek wrote: > I'm still unsure if this is the right strategy because it creates a > dependency cycle. Specifically, you have the LLVM build trigger the build of > runtimes, and that build would invoke

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

2021-09-29 Thread James Nagurne via Phabricator via cfe-commits
JamesNagurne added a comment. Perhaps you could reproduce my error -round-trip-args on the -cc1 command line? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110673/new/ https://reviews.llvm.org/D110673 __

[clang] d12502a - [OpenMP] Apply OpenMP assumptions to applicable call sites

2021-09-29 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2021-09-29T16:08:21-04:00 New Revision: d12502a3abae41c106b715cd29281a4de05efef2 URL: https://github.com/llvm/llvm-project/commit/d12502a3abae41c106b715cd29281a4de05efef2 DIFF: https://github.com/llvm/llvm-project/commit/d12502a3abae41c106b715cd29281a4de05efef2.diff

[PATCH] D110655: [OpenMP] Apply OpenMP assumptions to applicable call sites

2021-09-29 Thread Joseph Huber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd12502a3abae: [OpenMP] Apply OpenMP assumptions to applicable call sites (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

2021-09-29 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/www/cxx_status.html:817 https://wg21.link/p0522r0";>P0522R0 - Partial (10) + Clang 14 We should list this as implemented in Clang 4, with a footnote saying that until Clang 14 you need to pas

[PATCH] D110770: [clang] Remove duplication in types::getCompilationPhases()

2021-09-29 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: hans. thakis added a project: clang. thakis requested review of this revision. Call Driver::getFinalPhase() instead of duplicating it. https://reviews.llvm.org/D65993 added the duplication, then 02e35832c301e

[PATCH] D110771: [PowerPC] Fix __builtin_ppc_load2r to return short instead of int.

2021-09-29 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp created this revision. stefanp added reviewers: lei, nemanjai. Herald added subscribers: shchenz, kbarton, hiraditya. stefanp requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. This patch fixes the return value of the builtin __bu

[PATCH] D110665: [clang] Don't use the AST to display backend diagnostics

2021-09-29 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 376024. aeubanks added a comment. add comments (including why it's a vector and not an actual map) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110665/new/ https://reviews.llvm.org/D110665 Files: clang/inc

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

2021-09-29 Thread William Woodruff via Phabricator via cfe-commits
woodruffw added a comment. Another gentle ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108441/new/ https://reviews.llvm.org/D108441 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] 1f6458c - [clang] NFC: remove duplicated code around type constraint and templ arg subst

2021-09-29 Thread Matheus Izvekov via cfe-commits
Author: Matheus Izvekov Date: 2021-09-29T23:05:46+02:00 New Revision: 1f6458cb1944b69f052db463e5f2c6304f16b256 URL: https://github.com/llvm/llvm-project/commit/1f6458cb1944b69f052db463e5f2c6304f16b256 DIFF: https://github.com/llvm/llvm-project/commit/1f6458cb1944b69f052db463e5f2c6304f16b256.dif

[PATCH] D110726: [clang] NFC: remove duplicated code around type constraint and templ arg subst

2021-09-29 Thread Matheus Izvekov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f6458cb1944: [clang] NFC: remove duplicated code around type constraint and templ arg subst (authored by mizvekov). Repository: rG LLVM Github Mo

[clang] af10d6f - [clang] don't instantiate templates with injected arguments

2021-09-29 Thread Matheus Izvekov via cfe-commits
Author: Matheus Izvekov Date: 2021-09-29T23:19:13+02:00 New Revision: af10d6f350ff3e92c6ffae66cc9dac36884cdd55 URL: https://github.com/llvm/llvm-project/commit/af10d6f350ff3e92c6ffae66cc9dac36884cdd55 DIFF: https://github.com/llvm/llvm-project/commit/af10d6f350ff3e92c6ffae66cc9dac36884cdd55.dif

[PATCH] D110727: [clang] don't instantiate templates with injected arguments

2021-09-29 Thread Matheus Izvekov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf10d6f350ff: [clang] don't instantiate templates with injected arguments (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

2021-09-29 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 376034. aeubanks added a comment. forcing the legacy PM plus -round-trip-args repros the issue. added a new PM equivalent RUN line (that does fail without this patch) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

2021-09-29 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. Thanks for investigating! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110673/new/ https://reviews.llvm.org/D110673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

2021-09-29 Thread Manas Gupta via Phabricator via cfe-commits
manas added a comment. In D106102#3029633 , @martong wrote: > In D106102#3028584 , @manas wrote: > >> The pre-merge checks fail due to the patch being unable to get applied. The >> troubleshooting >>

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

2021-09-29 Thread Manas Gupta via Phabricator via cfe-commits
manas updated this revision to Diff 376035. manas added a comment. Apply mentioned edits in testcases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106102/new/ https://reviews.llvm.org/D106102 Files: clang/lib/StaticAnalyzer/Core/RangeConstraint

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

2021-09-29 Thread James Nagurne via Phabricator via cfe-commits
JamesNagurne added a comment. You're welcome! Surprising that no downstream clang was running with the old PM and assertions... I guess we better get on the new PM soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110673/new/ https://reviews.ll

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

2021-09-29 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 376042. leonardchan edited the summary of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109625/new/ https://reviews.llvm.o

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

2021-09-29 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM thanks for debugging this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109625/new/ https://reviews.llvm.org/D109625

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

2021-09-29 Thread Leonard Chan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79b422080612: [runtimes] Ensure required deps for tests targets are actually built (authored by leonardchan). Repository: rG LLVM Github Monorepo

[PATCH] D110778: [clang][Fuchsia] Re-enable compiler-rt tests in runtimes build

2021-09-29 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added a reviewer: phosek. Herald added subscribers: mgorny, dberris. leonardchan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D106409: [PowerPC] Truncate results for out of range values for vec_cts,vec_ctf

2021-09-29 Thread Zarko Todorovski via Phabricator via cfe-commits
ZarkoCA added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106409/new/ https://reviews.llvm.org/D106409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

2021-09-29 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov updated this revision to Diff 376046. mizvekov added a comment. - Clarify that P0522 was implemented in Clang 4, explain in footnote. - Add DR link. - C++17 section goes all green, so we fold it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D110780: [clang] do not emit note for bad conversion when destination type qualifiers are not compatibly include source type qualifiers

2021-09-29 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu created this revision. zequanwu added reviewers: rsmith, hans. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. llvm.org/PR52014 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110780 Files: clang/lib/

[PATCH] D85390: [Clang] Add note for bad conversion error when expression is of forward-declared type

2021-09-29 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu added a comment. In D85390#3031104 , @rsmith wrote: > Please see llvm.org/PR52014 -- this patch is not properly handling > cv-qualifiers. We should not produce the new note if the destination type has > qualifiers that the source type does not p

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

2021-09-29 Thread Haowei Wu via Phabricator via cfe-commits
haowei added a comment. We are seeing a series of weird errors in our windows clang builder after this patch landed: [1/828] Building CXX object compiler-rt\lib\sanitizer_common\CMakeFiles\RTSanitizerCommonNoTermination.x86_64.dir\sanitizer_solaris.cpp.obj FAILED: compiler-rt/lib/sanitizer

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

2021-09-29 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3233 + + ``QualifierAlignment`` COULD lead to incorrect code generation. + HazardyKnusperkeks wrote: > simon.giesecke wrote

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

2021-09-29 Thread Artem Belevich via Phabricator via cfe-commits
tra created this revision. tra added a reviewer: jdoerfert. Herald added subscribers: bixia, yaxunl. tra requested review of this revision. Herald added a project: clang. Otherwise we may end up with an inconsistent redeclarations of the standard library functions if _FORTIFY_SOURCE is in effect.

[PATCH] D110670: [Sema] Allow comparisons between different ms ptr size address space types.

2021-09-29 Thread Amy Huang via Phabricator via cfe-commits
akhuang added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:6682 + isPtrSizeAddressSpace(Q2.getAddressSpace())) +MaybeQ1 = true; + else aaron.ballman wrote: > I'm pretty sure this is correct based on my inspection o

[PATCH] D110778: [clang][Fuchsia] Re-enable compiler-rt tests in runtimes build

2021-09-29 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110778/new/ https://reviews.llvm.org/D110778 ___

[PATCH] D110783: [clang] Make crash reproducer work with clang-cl

2021-09-29 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: hans. thakis added a project: clang. thakis requested review of this revision. When clang crashes, it writes a standalone source file and shell script to reproduce the crash. The Driver used to set `Mode = CPPMode` in generateCompilationDiagn

[PATCH] D110780: [clang] do not emit note for bad conversion when destination type qualifiers don't compatibly include source type qualifiers

2021-09-29 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Would it be worth also including a testcase where the from and to types are different classes but the qualifications are incompatible, to ensure we're handling that case too? Reposit

[PATCH] D110123: [Proof of concept] Serialize fewer transitive methods in `METHOD_POOL`.

2021-09-29 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai updated this revision to Diff 376084. vsapsai added a comment. Visit all required modules and don't serialize methods from other modules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110123/new/ https://reviews.llvm.org/D110123 Files: c

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

2021-09-29 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. @ldionne @Quuxplusone gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108696/new/ https://reviews.llvm.org/D108696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D109632: [clang] de-duplicate methods from AST files

2021-09-29 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. I've updated D110123 to be the way I was planning it to be and I was testing locally with it. So far, with this change the speedup over a baseline is ~20%, though measurements aren't super rigorous. I.e., no multiple runs to warm up th

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

2021-09-29 Thread Amy Huang via Phabricator via cfe-commits
akhuang added a comment. Seems like there are also errors in chrome builds and the llvm compiler-rt build, will just revert it for now -- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110668/new/ https://reviews.llvm.org/D110668 _

[clang] 0cd9d8a - Revert "[clang-cl] Accept `#pragma warning(disable : N)` for some N"

2021-09-29 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2021-09-29T18:46:55-07:00 New Revision: 0cd9d8a48bdddb17de2c6388f9d775353f9acab9 URL: https://github.com/llvm/llvm-project/commit/0cd9d8a48bdddb17de2c6388f9d775353f9acab9 DIFF: https://github.com/llvm/llvm-project/commit/0cd9d8a48bdddb17de2c6388f9d775353f9acab9.diff LOG

[clang] 01641f6 - [clang] Fix sentence in the usage section of ThinLTO docs.

2021-09-29 Thread Shivam Gupta via cfe-commits
Author: Frederic Cambus Date: 2021-09-30T07:26:19+05:30 New Revision: 01641f665f5a3f94fc9e2bba598b5a65a6a7bd01 URL: https://github.com/llvm/llvm-project/commit/01641f665f5a3f94fc9e2bba598b5a65a6a7bd01 DIFF: https://github.com/llvm/llvm-project/commit/01641f665f5a3f94fc9e2bba598b5a65a6a7bd01.dif

[PATCH] D110750: [clang] Fix sentence in the usage section of ThinLTO docs.

2021-09-29 Thread Shivam Gupta via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01641f665f5a: [clang] Fix sentence in the usage section of ThinLTO docs. (authored by fcambus, committed by xgupta). Repository: rG LLVM Github Mo

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

2021-09-29 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe created this revision. Herald added subscribers: s.egerton, simoncook, fedor.sergeev. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110798 Files: clang/

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

2021-09-29 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe added a comment. I found the old way cannot verify if there are some extra outputs between two different CHECK-SAME. So I changed to CHECK-NEXT. But it will introduce bad format issue. Anyway, the old way has broken clang-format already. So I would prefer the CHECK-NEXT. WDYT? Reposi

[clang] b55a964 - Second attempt to fix Windows failures from test changes

2021-09-29 Thread Teresa Johnson via cfe-commits
Author: Teresa Johnson Date: 2021-09-29T19:24:35-07:00 New Revision: b55a964197bdc651533377bbd0b46fa58edf9196 URL: https://github.com/llvm/llvm-project/commit/b55a964197bdc651533377bbd0b46fa58edf9196 DIFF: https://github.com/llvm/llvm-project/commit/b55a964197bdc651533377bbd0b46fa58edf9196.diff

[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

2021-09-29 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In D110276#3031133 , @thakis wrote: > It's my personal bot. It doesn't send email. IMHO the problem of how to make > bots send emails hasn't been solved (they either send too much or too > little), so I'm not pretending that i

[PATCH] D110763: [clang] Update Clang version from 13 to 14 in scan-build.1.

2021-09-29 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110763/new/ https://reviews.llvm.org/D110763 ___ cf

[PATCH] D110210: [clang] NFC: include non friendly types and missing sugar in test expectations

2021-09-29 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added subscribers: rsmith, v.g.vassilev. v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a comment. These changes will enable progress on https://reviews.llvm.org/D110216 They lgtm but let's hear from @rsmith. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] 97a0ba4 - [clang] Update Clang version from 13 to 14 in scan-build.1.

2021-09-29 Thread Shivam Gupta via cfe-commits
Author: Frederic Cambus Date: 2021-09-30T11:23:25+05:30 New Revision: 97a0ba475d105838bd9bb7ed8506f599210995c7 URL: https://github.com/llvm/llvm-project/commit/97a0ba475d105838bd9bb7ed8506f599210995c7 DIFF: https://github.com/llvm/llvm-project/commit/97a0ba475d105838bd9bb7ed8506f599210995c7.dif

[PATCH] D110763: [clang] Update Clang version from 13 to 14 in scan-build.1.

2021-09-29 Thread Shivam Gupta via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97a0ba475d10: [clang] Update Clang version from 13 to 14 in scan-build.1. (authored by fcambus, committed by xgupta). Repository: rG LLVM Github M

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

2021-09-29 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. Thanks @aaron.ballman Let me think about how to deal with the typedef situation you mentioned and get back to you once I got some possible idea for discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110127/new/

[clang-tools-extra] dd13f45 - [clangd] Reland D110386

2021-09-29 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2021-09-30T08:25:31+02:00 New Revision: dd13f45e04366cc4f648b57ec87d20a5569e27c3 URL: https://github.com/llvm/llvm-project/commit/dd13f45e04366cc4f648b57ec87d20a5569e27c3 DIFF: https://github.com/llvm/llvm-project/commit/dd13f45e04366cc4f648b57ec87d20a5569e27c3.diff

<    1   2