[clang-tools-extra] 7394d3b - Investigate D110386 Windows failures

Author: Kirill Bobyrev Date: 2021-09-28T09:53:01+02:00 New Revision: 7394d3ba276adeb1527428b2355a920129a2b9b1 URL: https://github.com/llvm/llvm-project/commit/7394d3ba276adeb1527428b2355a920129a2b9b1 DIFF: https://github.com/llvm/llvm-project/commit/7394d3ba276adeb1527428b2355a920129a2b9b1.diff

[PATCH] D110525: [docs] fix docs for bugprone-virtual-near-miss & performance-type-promotion-in-math-fn

bakinovsky-m added a comment. In D110525#3025314 , @aaron.ballman wrote: > I'm not certain how, but somehow this review is set to be uneditable, so I > cannot mark it as accepted (or close it later once it lands). > >> bakinovsky-m created this object w

[PATCH] D110612: [Utils] Use common substs in update_cc_test_checks

sebastian-ne created this revision. sebastian-ne added reviewers: foad, arichardson. sebastian-ne requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Use substitution methods from common.py in update_cc_test_checks.py. Follow

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 375487. cor3ntin added a comment. - Add IfStmt::isNegatedConsteval to track whether the if consteval statement was negated - Add json/text AST dumps tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki created this revision. Herald added subscribers: yaxunl, mgorny. linjamaki edited the summary of this revision. linjamaki updated this revision to Diff 375488. linjamaki added a comment. linjamaki edited the summary of this revision. linjamaki added a reviewer: yaxunl. linjamaki published

[PATCH] D110528: [clang][ASTImporter] Add import of thread safety attributes.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. I agree with @steakhal , that perhaps we could come up with a somewhat more compact and elegant implementation in the future. Nevertheless, I think this patch in its current form is already

[PATCH] D110614: [clang-tidy] Fix false positive in cppcoreguidelines-virtual-class-destructor

carlosgalvezp created this revision. carlosgalvezp added reviewers: mgartmann, aaron.ballman, alexfh, alexfh_. carlosgalvezp added a project: clang-tools-extra. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. carlosgalvezp requested review of this revision. Incorrectly triggers fo

[PATCH] D110612: [Utils] Use common substs in update_cc_test_checks

arichardson added reviewers: jdoerfert, ggeorgakoudis. arichardson added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:223 def exec_run_line(exe): popen = subprocess.Popen(exe, stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True) std

[PATCH] D110398: [clang][ASTImporter] Import ConstructorUsingShadowDecl correctly.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Nice work! Thanks for the assiduous tests! Comment at: clang/unittests/AST/ASTImporterTest.cpp:6827-6828 +FirstDeclMatcher().match( +TU, usingShadowDecl

[PATCH] D110395: [clang][ASTImporter] Import InheritedConstructor and ConstructorUsingShadowDecl.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: steakhal. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110395/new/ https://reviews.llvm.org/D110395 ___

[PATCH] D110528: [clang][ASTImporter] Add import of thread safety attributes.

balazske added a comment. If the `ASTImporter` and parts of `ASTNodeImporter` are made public API then it can be possible to add generation of import code to the **.td** files, this should be the best solution. In similar way, import of `Stmt` and `Expr` nodes can be generated if possible. Thes

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

martong added a comment. In D106102#3019921 , @manas wrote: > I haven't tried specializing that `VisitBinaryOperator` method which converts > Ranges from RangeSets (as @vsavchenko mentioned). Should this case for NE > stay here in the switch or move? P

[clang-tools-extra] d1c6e54 - Investigate D110386 failures even further

Author: Kirill Bobyrev Date: 2021-09-28T12:02:13+02:00 New Revision: d1c6e54930f200c40820868c086e114cee1ec693 URL: https://github.com/llvm/llvm-project/commit/d1c6e54930f200c40820868c086e114cee1ec693 DIFF: https://github.com/llvm/llvm-project/commit/d1c6e54930f200c40820868c086e114cee1ec693.diff

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

martong added a reviewer: steakhal. martong added a comment. Adding @steakhal as reviewer because of other reviewers inactivity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106102/new/ https://reviews.llvm.org/D106102 ___

[PATCH] D110528: [clang][ASTImporter] Add import of thread safety attributes.

martong added a comment. In D110528#3026921 , @balazske wrote: > If the `ASTImporter` and parts of `ASTNodeImporter` are made public API then > it can be possible to add generation of import code to the **.td** files, > this should be the best solution.

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz updated this revision to Diff 375512. salman-javed-nz marked 4 inline comments as done. salman-javed-nz retitled this revision from "[clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines" to "[clang-tidy] Add support fo

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:400-401 + bool SuppressionIsSpecific; + for (const auto &Line : Lines) { +if (isNOLINTFound("NOLINTBEGIN", CheckName, Line, &NolintIndex, + &

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz added a comment. Also, the pre-merge build failure is confirmed to be a problem with the build system and not the contents of my patch. https://github.com/google/llvm-premerge-checks/issues/353 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] 23a5090 - [clang-format][docs] mark new clang-format configuration options based on which version they would GA

Author: mydeveloperday Date: 2021-09-28T11:42:19+01:00 New Revision: 23a5090c6ac7a207f49a11bf868a7c3fae2aeea2 URL: https://github.com/llvm/llvm-project/commit/23a5090c6ac7a207f49a11bf868a7c3fae2aeea2 DIFF: https://github.com/llvm/llvm-project/commit/23a5090c6ac7a207f49a11bf868a7c3fae2aeea2.diff

[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23a5090c6ac7: [clang-format][docs] mark new clang-format configuration options based on which… (authored by MyDeveloperDay). Repository: rG LLVM G

[clang-tools-extra] 4f01a02 - Fix documentation typos; NFC

Author: M Bakinovsky Date: 2021-09-28T06:56:49-04:00 New Revision: 4f01a02d738b033c10bfed5b47014fc197509a4f URL: https://github.com/llvm/llvm-project/commit/4f01a02d738b033c10bfed5b47014fc197509a4f DIFF: https://github.com/llvm/llvm-project/commit/4f01a02d738b033c10bfed5b47014fc197509a4f.diff

[PATCH] D110525: [docs] fix docs for bugprone-virtual-near-miss & performance-type-promotion-in-math-fn

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D110525#3026757 , @bakinovsky-m wrote: > In D110525#3025300 , @aaron.ballman > wrote: > >>

[PATCH] D110525: [docs] fix docs for bugprone-virtual-near-miss & performance-type-promotion-in-math-fn

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in 4f01a02d738b033c10bfed5b47014fc197509a4f . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110525/new

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! Do you need me to commit on your behalf? If so, what name and email address would you like me to use for patch attribution in git? Repository: rG LLV

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with some minor corrections in comments, thank you for the fix! Comment at: clang/lib/Sema/SemaStmt.cpp:381-382 - DiagRuntimeBehavior(Loc, nullptr, PDia

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz added a comment. Yes, I will need your help to commit. Salman Javed m...@salmanjaved.org Thank you very much for the review. Looking back at my initial initial submission a few weeks ago, I can see all the valuable improvements the review process has made. Hopefully people find

[clang] 3d6f49a - Simplify handling of builtin with inline redefinition

Author: serge-sans-paille Date: 2021-09-28T13:24:25+02:00 New Revision: 3d6f49a56995b845c40be5827ded5d1e3f692cec URL: https://github.com/llvm/llvm-project/commit/3d6f49a56995b845c40be5827ded5d1e3f692cec DIFF: https://github.com/llvm/llvm-project/commit/3d6f49a56995b845c40be5827ded5d1e3f692cec.d

[PATCH] D109967: Simplify handling of builtin with inline redefinition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d6f49a56995: Simplify handling of builtin with inline redefinition (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @kees great, thanks for confirming - I just landed the patch. Can you share a pointer to the missing pieces? I'm interested in implemented the missing parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/ne

[clang-tools-extra] e7a5347 - Revert "[clangd] Refactor IncludeStructure: use File (unsigned) for most computations"

Author: Kirill Bobyrev Date: 2021-09-28T13:34:42+02:00 New Revision: e7a5347b55e6050106bb61fa9a54920720806e07 URL: https://github.com/llvm/llvm-project/commit/e7a5347b55e6050106bb61fa9a54920720806e07 DIFF: https://github.com/llvm/llvm-project/commit/e7a5347b55e6050106bb61fa9a54920720806e07.diff

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1838-1841 def BTFTag : DeclOrTypeAttr { let Spellings = [Clang<"btf_tag">]; let Args = [StringArgument<"BTFTag">]; + let Subjects = SubjectList<[Var, Function, Record, Field, TypedefName],

[clang-tools-extra] c0687e1 - Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

Author: Salman Javed Date: 2021-09-28T07:53:23-04:00 New Revision: c0687e1984a82925918c874b7bb68ad34c32aed0 URL: https://github.com/llvm/llvm-project/commit/c0687e1984a82925918c874b7bb68ad34c32aed0 DIFF: https://github.com/llvm/llvm-project/commit/c0687e1984a82925918c874b7bb68ad34c32aed0.diff

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

aaron.ballman closed this revision. aaron.ballman added a comment. In D108560#3027105 , @salman-javed-nz wrote: > Yes, I will need your help to commit. > > Salman Javed > m...@salmanjaved.org > > Thank you very much for the review. Looking back at my ini

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki created this revision. Herald added subscribers: dang, kerbowa, yaxunl, mgorny, nhaehnle, jvesely. linjamaki updated this revision to Diff 375526. linjamaki added a comment. linjamaki published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. I cannot tell without context whether the codegen changes for the `f32->i32` convert + insert case (for example `@test2` in `test/CodeGen/PowerPC/test-vector-insert.ll`) but it s

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1603-1604 + template + bool handleRem(const SymT *Sym, RangeSet Constraint) { +// a % b != 0 implies that a != 0. steakhal wrote: > Why is this not

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

ASDenysPetrov added inline comments. Comment at: clang/test/Analysis/constraint-assignor.c:18 + clang_analyzer_warnIfReached(); // no-warning + (void)x; // keep the constraints alive. +} steakhal wrote: > It's still mindboggling that we need to do this. This i

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

feg208 updated this revision to Diff 375544. feg208 added a comment. Gets rid of the crash for the second added case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110481/new/ https://reviews.llvm.org/D110481 Files: clang/lib/Format/WhitespaceMan

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

feg208 added a comment. So I added in the second case but commented it out as it gets misformatted. However it doesn't assert which was the alarming outcome. I have one other bug to clean up here and I am going to open a bug to fix the line breaking after initial { in certain cases since the co

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

feg208 added a comment. By one other bug I mean an entirely separate bug that I will handle in a separate PR. Sorry if that was confusing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110481/new/ https://reviews.llvm.org/D110481

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

carlosgalvezp updated this revision to Diff 375545. carlosgalvezp retitled this revision from "[clang-tidy] Fix false positive in cppcoreguidelines-virtual-class-destructor " to "[clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor ". carlosgalvezp edited the sum

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

carlosgalvezp updated this revision to Diff 375546. carlosgalvezp added a comment. Rename Class to Struct CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110614/new/ https://reviews.llvm.org/D110614 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/VirtualClassDestructorCheck.cpp

[clang] 45e75d9 - Update the message for template-template param keyword for C++17

Author: Erich Keane Date: 2021-09-28T06:02:29-07:00 New Revision: 45e75d93821f7e4f04d9f42cb19f729b346e7c0c URL: https://github.com/llvm/llvm-project/commit/45e75d93821f7e4f04d9f42cb19f729b346e7c0c DIFF: https://github.com/llvm/llvm-project/commit/45e75d93821f7e4f04d9f42cb19f729b346e7c0c.diff L

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

carlosgalvezp updated this revision to Diff 375549. carlosgalvezp added a comment. -Remove "public" when checking for base virtual destructor, it's not relevant. -More consistent naming. -Fix formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110614/new/ https://reviews.llvm.or

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

erichkeane added a comment. A couple of small things, otherwise I'm happy; but Aaron has some bigger opens above, plus clang-format, plus the modules from Richard. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:257 + +def err_unevaluated_string_prefix : Error< +

[PATCH] D110482: [clang] Implement if consteval (P1938)

erichkeane added a comment. So I have some heartburn about `IsNegatedConsteval`. A part of me wants to suggest ditching the `ConstexprKind` and creating a new scoped-enum `IfStmtKind` (perhaps in the same file) that has just `None,Constexpr,Consteval,NotConsteval`. Its already a bit hinky tha

[clang] 9324cc2 - Change __builtin_sycl_unique_stable_name to just use an Itanium mangling

Author: Erich Keane Date: 2021-09-28T06:41:03-07:00 New Revision: 9324cc2ca951fe5fe11c85470cb08e699c59499c URL: https://github.com/llvm/llvm-project/commit/9324cc2ca951fe5fe11c85470cb08e699c59499c DIFF: https://github.com/llvm/llvm-project/commit/9324cc2ca951fe5fe11c85470cb08e699c59499c.diff L

[PATCH] D110281: Change __builtin_sycl_unique_stable_name to just use an Itanium mangling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9324cc2ca951: Change __builtin_sycl_unique_stable_name to just use an Itanium mangling (authored by erichkeane). Herald added a project: clang. Repo

[PATCH] D107899: [PowerPC] Implement builtin for vbpermd

bmahjour added inline comments. Comment at: clang/lib/Headers/altivec.h:17337 static __inline__ vector long long __ATTRS_o_ai vec_vbpermq(vector unsigned char __a, vector unsigned char __b) { return __builtin_altivec_vbpermq(__a, __b); lei wrote: > bmahjour

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1609-1612 + const SymExpr *LHS = Sym->getLHS(); + const llvm::APSInt &Zero = + Builder.getBasicValueFactory().getValue(0, LHS->getType()); + State = RCM->a

[PATCH] D107899: [PowerPC] Implement builtin for vbpermd

bmahjour added inline comments. Comment at: clang/lib/Headers/altivec.h:17349 +static __inline__ vector unsigned char __ATTRS_o_ai +vec_bperm(vector unsigned char __a, vector unsigned char __b) { + return __builtin_altivec_vbpermq(__a, __b); bmahjour wrote: > `v

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers created this revision. vabridgers added reviewers: steakhal, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. vabridgers requested review of this revision. He

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers added a comment. Just an initial push to get this patch out there for review. I think this is pretty close. Thanks @steakhal and @martong for the debug session! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.l

[clang] bd37991 - Refine the constraint for isInlineBuiltinDeclaration

Author: serge-sans-paille Date: 2021-09-28T16:07:33+02:00 New Revision: bd379915de38a9af3d65e19075a6a64ebbb8d6db URL: https://github.com/llvm/llvm-project/commit/bd379915de38a9af3d65e19075a6a64ebbb8d6db DIFF: https://github.com/llvm/llvm-project/commit/bd379915de38a9af3d65e19075a6a64ebbb8d6db.d

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 375569. cor3ntin added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang-tools-extra/test/clang-tidy/checkers/modernize-unary-stat

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added a comment. In D108643#3026550 , @rjmccall wrote: > I think it would be better to provide a generic ABI specification that is > designed to "lower" `_BitInt` types into more basic concepts that ABIs > typically already have rules for. I

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. for the record: I had to apply that extra patch: bd379915de38a9af3d65e19075a6a64ebbb8d6db which enforces the `always_inline` attribute Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 1cd3ae0 - Fix missing return from 9324cc2ca951fe5fe11c85470cb08e699c59499c

Author: Erich Keane Date: 2021-09-28T07:30:06-07:00 New Revision: 1cd3ae019892c81a8a81daf4e2baffa3be6270db URL: https://github.com/llvm/llvm-project/commit/1cd3ae019892c81a8a81daf4e2baffa3be6270db DIFF: https://github.com/llvm/llvm-project/commit/1cd3ae019892c81a8a81daf4e2baffa3be6270db.diff L

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 375576. cor3ntin added a comment. Get rid of the extra loop by using a lambda Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang-tools-extra/test/clang-t

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added a comment. @yaxunl / @jdoerfert / @tra Can I expect your further comment/decision on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

xgupta added a comment. nice work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1541 + if (IsConsteval && NotLocation.isValid()) { +if (ElseStmt.isUnset()) + ElseStmt = Actions.ActOnNullStmt(ThenStmtLoc); aaron.ballman wrote: > cor3ntin wrote: > > aaron.ballm

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

jdoerfert added a comment. While I understand people are eager to receive feedback on their patches, it is not helpful to ping/remind the reviewers constantly. This does generate noise for them and can consequently also reduce their interest in a patch. The recommendation for time without review

[PATCH] D110635: [clang] Let PPCallbacks::PragmaWarning() pass specifier as enum instead of string

thakis created this revision. thakis added a reviewer: hans. thakis added a project: clang. Herald added subscribers: shchenz, kbarton, nemanjai. thakis requested review of this revision. Herald added a project: clang-tools-extra. https://reviews.llvm.org/D110635 Files: clang-tools-extra/clang-

[clang] 70391b3 - [PowerPC] FP compare and test XL compat builtins.

Author: Quinn Pham Date: 2021-09-28T11:01:51-05:00 New Revision: 70391b3468b8a4a07b49df88d7fa88c9644cda77 URL: https://github.com/llvm/llvm-project/commit/70391b3468b8a4a07b49df88d7fa88c9644cda77 DIFF: https://github.com/llvm/llvm-project/commit/70391b3468b8a4a07b49df88d7fa88c9644cda77.diff LO

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70391b3468b8: [PowerPC] FP compare and test XL compat builtins. (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D110636: [OpenCL][NFC] Refactor vloada_half and vstorea_half decls

stuart created this revision. stuart added reviewers: svenvh, Anastasia, airlied, yaxunl. Herald added a subscriber: ldrumm. stuart requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Group them together with the vload_half and vstore_half decl

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 375615. cor3ntin added a comment. - Use a dedicated enums - Add more tests - Improve CodeGen tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/inc

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added a comment. In D110257#3027633 , @jdoerfert wrote: > While I understand people are eager to receive feedback on their patches, it > is not helpful to ping/remind the reviewers constantly. > This does generate noise for them and can consequent

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei marked 4 inline comments as done. masoud.ataei added a comment. Sorry that it took me so long to reply reviews. Thank you for reviewing this patch. Comment at: clang/include/clang/Driver/Options.td:1732-1733 NegFlag>; -def fapprox_func : Flag<["-"], "fapprox-fu

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:151 + // allocas. + Builder.CreateStore(Init, Var); } hsmhsm wrote: > jdoerfert wrote: > > I'm not even sure this is necessarily correct. > > > > How do we know the new store is not in

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers planned changes to this revision. vabridgers added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 ___ cfe-commits mailing list cfe-commi

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

ychen updated this revision to Diff 375619. ychen marked an inline comment as done. ychen added a comment. - Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 Files: clang/include/clang/

[clang] d5631d4 - Drop REQUIRES: arm-registered-target from an IR-only test

Author: Alex Richardson Date: 2021-09-28T17:57:36+01:00 New Revision: d5631d49d070116ba2e23baad1ecf5f4cc08e6d1 URL: https://github.com/llvm/llvm-project/commit/d5631d49d070116ba2e23baad1ecf5f4cc08e6d1 DIFF: https://github.com/llvm/llvm-project/commit/d5631d49d070116ba2e23baad1ecf5f4cc08e6d1.dif

[clang] 90179f2 - [NFC] Add a comment to member-function-pointer-calls.cpp

Author: Alex Richardson Date: 2021-09-28T17:57:36+01:00 New Revision: 90179f2323ac4ca0ed28ee94b9a61b565c1b61b6 URL: https://github.com/llvm/llvm-project/commit/90179f2323ac4ca0ed28ee94b9a61b565c1b61b6 DIFF: https://github.com/llvm/llvm-project/commit/90179f2323ac4ca0ed28ee94b9a61b565c1b61b6.dif

[clang] a181819 - [NFC][clang] Add a CHECK lines to tests checking offsetof-like expressions

Author: Alex Richardson Date: 2021-09-28T17:57:36+01:00 New Revision: a18181931f991b04caea297e723db415756f09a0 URL: https://github.com/llvm/llvm-project/commit/a18181931f991b04caea297e723db415756f09a0 DIFF: https://github.com/llvm/llvm-project/commit/a18181931f991b04caea297e723db415756f09a0.dif

[clang] 27a972a - Diagnose -Wunused-value based on CFG reachability

Author: Yuanfang Chen Date: 2021-09-28T10:00:15-07:00 New Revision: 27a972a699cd875c7fa9114dc0888015cd724f31 URL: https://github.com/llvm/llvm-project/commit/27a972a699cd875c7fa9114dc0888015cd724f31 DIFF: https://github.com/llvm/llvm-project/commit/27a972a699cd875c7fa9114dc0888015cd724f31.diff

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27a972a699cd: Diagnose -Wunused-value based on CFG reachability (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers

saghir updated this revision to Diff 375629. saghir added a comment. Stripped RV qualifiers for Sema checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106550/new/ https://reviews.llvm.org/D106550 Files: clang/lib/Sema/SemaChecking.cpp cl

[PATCH] D110635: [clang] Let PPCallbacks::PragmaWarning() pass specifier as enum instead of string

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110635/new/ https://reviews.llvm.org/D110635 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

aaron.ballman added a comment. Some naming nits. There are two open questions also: one about module behavior and one about a TODO comment in the patch. If we don't hear back about the modules question, I think that can be handled in a follow-up. Comment at: clang/include/cla

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:151 + // allocas. + Builder.CreateStore(Init, Var); } jdoerfert wrote: > hsmhsm wrote: > > jdoerfert wrote: > > > I'm not even sure this is necessarily correct. > > > > > > How do we know

[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

scott.linder added a comment. Is it possible to use soft links instead of copies? It would still be good to clean up afterwards, but if the host won't allow that cleanup in some cases at least we aren't leaving a big file around. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

tejohnson added a comment. In D110276#3027955 , @scott.linder wrote: > Is it possible to use soft links instead of copies? It would still be good to > clean up afterwards, but if the host won't allow that cleanup in some cases > at least we aren't leav

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 375634. ggeorgakoudis added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Update memory allocation for aggregate argument. Introduce runtime interface to allocate from local memory, when in SPMD mode, or heap, when i

[PATCH] D110596: [CUDA] Move CUDA SDK include path further down the include search path.

tra added a comment. @tambre I've tested the patch on experimental debian docker and it appears to work with a symlink `/usr/lib/cuda/include` ->`/usr/include`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110596/new/ https://reviews.llvm.org/D11

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. @pdhaliwal @JonChesterfield @ronlieb I updated the aggregate argument memory allocation to use an alloca instead of malloc'ing in SPMD mode, which should resolve your issue. Could someone please test the updated patch and give me feedback before landing? Reposit

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane created this revision. erichkeane added reviewers: rsmith, hubert.reinterpretcast, saar.raz, arthur.j.odwyer. erichkeane requested review of this revision. P0857R0 part-b allows a 'requires' clause on template-template parameters. This patch adds this in. However, no part of the stand

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:151 + // allocas. + Builder.CreateStore(Init, Var); } hsmhsm wrote: > jdoerfert wrote: > > hsmhsm wrote: > > > jdoerfert wrote: > > > > I'm not even sure this is necessarily correct. >

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers updated this revision to Diff 375640. vabridgers added a comment. update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 Files: clang/lib/StaticAnalyzer/Core/Store.cpp clang/test/

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

aaron.ballman edited reviewers, added: hokein, njames93; removed: aaron.ballman, alexfh_. aaron.ballman edited subscribers, added: aaron.ballman; removed: llvm-commits. aaron.ballman added a comment. Removing myself as a reviewer (I've generally been stepping back from reviewing C++ Core Guideli

[clang] 85f612e - DebugInfo: Use sugared function type when emitting function declarations for call sites

Author: David Blaikie Date: 2021-09-28T10:44:35-07:00 New Revision: 85f612efeb352e759f120ee183bf31b1fd7e801a URL: https://github.com/llvm/llvm-project/commit/85f612efeb352e759f120ee183bf31b1fd7e801a DIFF: https://github.com/llvm/llvm-project/commit/85f612efeb352e759f120ee183bf31b1fd7e801a.diff

[PATCH] D110482: [clang] Implement if consteval (P1938)

erichkeane added a comment. A handful of 'nits' (at best), and a wish for the `if consteval` vs `consteval if` to be consistent, but otherwise LGTM. Hopefully @aaron.ballman can come and do a final pass. Comment at: clang/include/clang/AST/Stmt.h:164 -/// True if this

[PATCH] D108299: [MSP430][Clang] Remove support for -mmcu=msp430

asl accepted this revision. asl added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108299/new/ https://reviews.llvm.org/D108299

[clang] be61093 - [MSP430][Clang] Remove support for -mmcu=msp430

Author: Jozef Lawrynowicz Date: 2021-09-28T20:47:26+03:00 New Revision: be610932fa068ed2228b0f694ae80c9294f0293f URL: https://github.com/llvm/llvm-project/commit/be610932fa068ed2228b0f694ae80c9294f0293f DIFF: https://github.com/llvm/llvm-project/commit/be610932fa068ed2228b0f694ae80c9294f0293f.d

[PATCH] D108299: [MSP430][Clang] Remove support for -mmcu=msp430

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe610932fa06: [MSP430][Clang] Remove support for -mmcu=msp430 (authored by jozefl, committed by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108299/ne

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

asl requested changes to this revision. asl added a comment. This revision now requires changes to proceed. Please see comments inline Comment at: clang/lib/Driver/ToolChains/MSP430.cpp:43 +/// std::lower_bound is used to perform an efficient binary search on the data. +static

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 375645. cor3ntin added a comment. Address Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang-tools-extra/test/clang-tidy/checkers/modern

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1821-1823 +<< UDSuffixBuf << UDSuffix +<< SourceRange(UDSuffixTokLoc, UDSuffixTokLoc) +<< SourceRange(TokLoc, TokLoc); aaron.ballman wrote

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:108 + unsigned CharWidth, DiagnosticsEngine *Diags, + const LangOptions &Features, bool Unevaluated) { const char *EscapeBegin = ThisTokBuf; cor3ntin

  1   2   3   >