cor3ntin added inline comments.
================
Comment at: clang/lib/Lex/LiteralSupport.cpp:1821-1823
+ << UDSuffixBuf << UDSuffix
+ << SourceRange(UDSuffixTokLoc, UDSuffixTokLoc)
+ << SourceRange(TokLoc, TokLoc);
----------------
aaron.ballman wrote:
>
This are actually used by `err_string_concat_mixed_suffix`
================
Comment at: clang/lib/Lex/LiteralSupport.cpp:108
+ unsigned CharWidth, DiagnosticsEngine *Diags,
+ const LangOptions &Features, bool Unevaluated) {
const char *EscapeBegin = ThisTokBuf;
----------------
erichkeane wrote:
> This is like the 3rd time we're using 'Unevaluated' as a bool parameter. I
> have a pretty strong preference for making it a scoped-enum in 'Basic'
> somewhere.
Any suggestion for where to
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105759/new/
https://reviews.llvm.org/D105759
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
