[clang] 6b20ea6 - [CUDA] Pass ExecConfig through BuildCallToMemberFunction

2021-09-16 Thread Artem Belevich via cfe-commits
Author: Artem Belevich Date: 2021-09-16T11:18:12-07:00 New Revision: 6b20ea6963561f2c91490c0993390b7f2ff8f71c URL: https://github.com/llvm/llvm-project/commit/6b20ea6963561f2c91490c0993390b7f2ff8f71c DIFF: https://github.com/llvm/llvm-project/commit/6b20ea6963561f2c91490c0993390b7f2ff8f71c.diff

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

2021-09-16 Thread Artem Belevich via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b20ea696356: [CUDA] Pass ExecConfig through BuildCallToMemberFunction (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

2021-09-16 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D109707#3004108 , @gandhi21299 wrote: > @yaxunl Under what criteria should an alias not be removed? If the linkage of the alias is not internal, then it should not be removed. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

2021-09-16 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. In D92257#3003281 , @byronhe wrote: > Hi guys,i found `SpacesInLineCommentPrefix` does not support other encoding > such as utf8 , > I am curious why there is a `isAlphanumeric` limit in > `BreakableLineCommentSection:

[PATCH] D109557: Adds a BreakBeforeClosingParen option

2021-09-16 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22414 + + EXPECT_EQ("int a = (int)b;", format("int a = (\n" + "int\n" can't this just be verifyFormat but with 3 arguments? Reposit

[clang] 45a8608 - [OpenMP] Fix -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off build after D109635

2021-09-16 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2021-09-16T12:36:45-07:00 New Revision: 45a8608d7ba4519ce890b74db20087ba22343c50 URL: https://github.com/llvm/llvm-project/commit/45a8608d7ba4519ce890b74db20087ba22343c50 DIFF: https://github.com/llvm/llvm-project/commit/45a8608d7ba4519ce890b74db20087ba22343c50.diff

[PATCH] D109894: [clangd] Bail-out when an empty compile flag is encountered

2021-09-16 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I do half wonder whether we're going to get 3 steps further and then crash again when we call `Command.front()` :-) This change looks good. It also seems tempting to inject an empty che

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

2021-09-16 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

2021-09-16 Thread Albion Fung via Phabricator via cfe-commits
Conanap updated this revision to Diff 373045. Conanap edited the summary of this revision. Conanap added a comment. Removed complexity and restored a test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 Files: llvm/lib/Target/PowerPC/PP

[PATCH] D106876: Remove non-affecting module maps from PCM files.

2021-09-16 Thread Ilya Kuteev via Phabricator via cfe-commits
ilyakuteev updated this revision to Diff 373048. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

2021-09-16 Thread Anshil Gandhi via Phabricator via cfe-commits
gandhi21299 added a comment. Internal linkage detection works great for our purposes but it causes a failure in llvm/test/CodeGen/AMDGPU/inline-calls.ll due to `@func_alias` unable to be casted into a `Function`. If we pass through that, the `@kernel3` causes the error: `scalar registers (98) e

[PATCH] D109925: [AST] add warnings for out-of-bounds FP values when using relaxed FP math compile flags

2021-09-16 Thread Sanjay Patel via Phabricator via cfe-commits
spatel created this revision. spatel added reviewers: sepavloff, jyknight, efriedma, dim, kparzysz, rsmith. Herald added a subscriber: mcrosier. spatel requested review of this revision. There's currently ongoing discussion on the dev lists about how to handle related cases with isnan() / isinf()

[clang] e6020b2 - [clang][NFC] refactor GlobalMethodPool to encapsulate its map

2021-09-16 Thread Daniel Rodríguez Troitiño via cfe-commits
Author: Richard Howell Date: 2021-09-16T14:02:14-07:00 New Revision: e6020b2a42245d888e941eba66fbce9d0c4ab0a8 URL: https://github.com/llvm/llvm-project/commit/e6020b2a42245d888e941eba66fbce9d0c4ab0a8 DIFF: https://github.com/llvm/llvm-project/commit/e6020b2a42245d888e941eba66fbce9d0c4ab0a8.diff

[PATCH] D109847: [DFSan] Add force_zero_label abilist option to DFSan. This can be used as a work-around for overtainting.

2021-09-16 Thread Andrew via Phabricator via cfe-commits
browneee updated this revision to Diff 373065. browneee added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109847/new/ https://reviews.llvm.org/D109847 Files:

[PATCH] D109898: [clang][NFC] refactor GlobalMethodPool to encapsulate its map

2021-09-16 Thread Daniel Rodríguez Troitiño via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe6020b2a4224: [clang][NFC] refactor GlobalMethodPool to encapsulate its map (authored by rmaz, committed by drodriguez). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D109862: Don't diagnose unused but set when the Cleanup attribute is used.

2021-09-16 Thread Michael Benfield via Phabricator via cfe-commits
mbenfield updated this revision to Diff 373069. mbenfield added a comment. Added a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109862/new/ https://reviews.llvm.org/D109862 Files: clang/lib/Sema/SemaDecl.cpp clang/test/Sema/warn-un

[PATCH] D109632: [clang] de-duplicate methods from AST files

2021-09-16 Thread Richard Howell via Phabricator via cfe-commits
rmaz updated this revision to Diff 373072. rmaz added a comment. Update with single DenseSet per GlobalMethodPool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109632/new/ https://reviews.llvm.org/D109632 Files: clang/include/clang/Sema/Sema.h

[PATCH] D106876: Remove non-affecting module maps from PCM files.

2021-09-16 Thread Ilya Kuteev via Phabricator via cfe-commits
ilyakuteev updated this revision to Diff 373076. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D109632: [clang] de-duplicate methods from AST files

2021-09-16 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1434-1436 +bool addMethod(ObjCMethodDecl *Method) { + return AddedMethods.insert(Method).second; +} Hmm, I was imagining that the set would be more encapsulated than this,

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

2021-09-16 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. Ok thanks. I need to go through the propagation code and tests again more closely now, but one question/suggestion below in the meantime. Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:580 +// If there are calls to unknown targets (e.g. in

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

2021-09-16 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
ggeorgakoudis updated this revision to Diff 373105. ggeorgakoudis added a comment. Add previous, upper bound to aggregate for combined distributed directives. Update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.l

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

2021-09-16 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
ggeorgakoudis updated this revision to Diff 373107. ggeorgakoudis added a comment. Remove unnecessary comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/lib/CodeGen/CGOpenMPRuntime.c

[PATCH] D91944: OpenMP 5.0 metadirective

2021-09-16 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 373109. cchen added a comment. Fix ast errors and add some tiny fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h clang/inclu

[PATCH] D109625: [compiler-rt] Ensure LIT_TEST_DEP targets are actually built

2021-09-16 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109625/new/ https://reviews.llvm.org/D109625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

2021-09-16 Thread Di Mo via Phabricator via cfe-commits
modimo added a comment. In D36850#3005254 , @tejohnson wrote: > Ok thanks. I need to go through the propagation code and tests again more > closely now, but one question/suggestion below in the meantime. Thanks! Comment at: llvm/inclu

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

2021-09-16 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added inline comments. Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:580 +// If there are calls to unknown targets (e.g. indirect) +unsigned hasUnknownCall : 1; + modimo wrote: > tejohnson wrote: > > Now that we have MayThrow, can we avo

[PATCH] D91944: OpenMP 5.0 metadirective

2021-09-16 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 373125. cchen added a comment. Rebase and fix warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h clang/include/clang/AST/Rec

[clang] e9e1d47 - [X86] Refactor GetSSETypeAtOffset to fix pr51813

2021-09-16 Thread via cfe-commits
Author: Wang, Pengfei Date: 2021-09-17T10:51:59+08:00 New Revision: e9e1d4751b54126743ed72b1a9178ee51200acf6 URL: https://github.com/llvm/llvm-project/commit/e9e1d4751b54126743ed72b1a9178ee51200acf6 DIFF: https://github.com/llvm/llvm-project/commit/e9e1d4751b54126743ed72b1a9178ee51200acf6.diff

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

2021-09-16 Thread Pengfei Wang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe9e1d4751b54: [X86] Refactor GetSSETypeAtOffset to fix pr51813 (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109607/new/ https://revi

[PATCH] D109943: [Clang] Fix long double availability check

2021-09-16 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf created this revision. Herald added subscribers: steven.zhang, mstorsjo, jvesely. qiucf requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. fae0dfa

[PATCH] D109799: [RISCV] add Half-precision test for load/store

2021-09-16 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 373129. achieveartificialintelligence added a comment. add Half-precision test for segment load/store Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109799/new/ https://reviews.llvm.org/D10

[PATCH] D109632: [clang] de-duplicate methods from AST files

2021-09-16 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. In D109632#3000709 , @rmaz wrote: > The speedup is coming from reducing the number of times > `Sema::addMethodToGlobalList` is called when looking up methods loaded from > modules. From what I can see each serialized module will

[PATCH] D91944: OpenMP 5.0 metadirective

2021-09-16 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 373139. cchen added a comment. Fix flang issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h clang/include/clang/AST/RecursiveA

[clang] b588f5d - [clang][scan-build] Use cc/c++ instead of gcc/g++ on OpenBSD.

2021-09-16 Thread Brad Smith via cfe-commits
Author: Frederic Cambus Date: 2021-09-17T00:45:11-04:00 New Revision: b588f5d665aa01fe88921fe2ffb7256fdedfbfb0 URL: https://github.com/llvm/llvm-project/commit/b588f5d665aa01fe88921fe2ffb7256fdedfbfb0 DIFF: https://github.com/llvm/llvm-project/commit/b588f5d665aa01fe88921fe2ffb7256fdedfbfb0.dif

[PATCH] D109349: [clang][scan-build] Use cc/c++ instead of gcc/g++ on OpenBSD.

2021-09-16 Thread Brad Smith via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb588f5d665aa: [clang][scan-build] Use cc/c++ instead of gcc/g++ on OpenBSD. (authored by fcambus, committed by brad). Rep

[PATCH] D109625: [compiler-rt] Ensure LIT_TEST_DEP targets are actually built

2021-09-16 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: compiler-rt/test/CMakeLists.txt:48 + if (NOT TARGET ${dep}) +llvm_ExternalProject_BuildCmd(build_${dep} ${dep} ${BINARY_DIR}) +add_custom_target(${dep} This is going to run Ninja in the LLVM build onc

[PATCH] D109948: [Clang] Enable _Complex __ibm128 type

2021-09-16 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf created this revision. qiucf added reviewers: hubert.reinterpretcast, nemanjai, PowerPC, rjmccall. Herald added a subscriber: kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As a follow-up to fae0dfa

<    1   2