modimo added a comment. In D36850#3005254 <https://reviews.llvm.org/D36850#3005254>, @tejohnson wrote:
> Ok thanks. I need to go through the propagation code and tests again more > closely now, but one question/suggestion below in the meantime. Thanks! ================ Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:580 + // If there are calls to unknown targets (e.g. indirect) + unsigned hasUnknownCall : 1; + ---------------- tejohnson wrote: > Now that we have MayThrow, can we avoid a separate hasUnknownCall bool and > just conservatively set MayThrow true in that case? hasUnknownCall is used for norecurse and other future flags as well to stop propagation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36850/new/ https://reviews.llvm.org/D36850 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
