[PATCH] D105756: [clang] C++98 implicit moves are back with a vengeance

mizvekov added a comment. In D105756#3001045 , @NoQ wrote: > I guess I'm confused about the exact meaning of the AST. I'm not sure whether > it's actively incorrect or just changed meaning. I'll definitely be debugging > this further. > > My backstory h

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

thakis added a comment. Is it possible that this disabled this for Objective-C++ too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109654/new/ https://reviews.llvm.org/D109654 ___ cfe-commits mailing li

[PATCH] D109854: Support Unicode 14 identifiers This update the UAX tables to support new Unicode 14 identifiers

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109854 Files: clang/lib/Lex/UnicodeCharSets.h Index: clang/lib/Lex/UnicodeCharSets

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

mizvekov added a comment. In D109654#3002632 , @thakis wrote: > Is it possible that this disabled this for Objective-C++ too? As far as I understand, CPlusPLus will be set on ObjectiveC++ as well, and I think we do have test coverage there, but I haven'

[PATCH] D109752: [clang-format] Top-level unwrapped lines don't follow a left brace

owenpan added a comment. It will prevent them from even being checked in `parseStructuralElement` as `IsTopLevel` is now `false`: case tok::l_paren: { parseParens(); // Break the unwrapped line if a K&R C function definition has a parameter // declaration. if (!IsTopLevel || !S

[PATCH] D109841: Fix vtbl field addr space

rjmccall accepted this revision. rjmccall added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109841/new/ https://reviews.llvm.org/D109841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] 8025c03 - [clang-format] Top-level unwrapped lines don't follow a left brace

Author: owenca Date: 2021-09-15T14:52:07-07:00 New Revision: 8025c03f70ee9b92e8599519b5ee34b54c9a80da URL: https://github.com/llvm/llvm-project/commit/8025c03f70ee9b92e8599519b5ee34b54c9a80da DIFF: https://github.com/llvm/llvm-project/commit/8025c03f70ee9b92e8599519b5ee34b54c9a80da.diff LOG: [

[PATCH] D109752: [clang-format] Top-level unwrapped lines don't follow a left brace

This revision was automatically updated to reflect the committed changes. Closed by commit rG8025c03f70ee: [clang-format] Top-level unwrapped lines don't follow a left brace (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109752/

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris created this revision. ormris added reviewers: cor3ntin, aaron.ballman. ormris requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Specify the C and C++ standards explicitly for this test. This avoids failures for drivers that default t

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

cor3ntin added a comment. Thanks! For which platforms did you had issue? This is suppose to work in all language modes (we might want to use C99/C++98 to make sure that's the case) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/new/ https:/

[PATCH] D109836: [Analyzer] ConversionChecker: track back the cast expression

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this. Should this checker remain in alpha in its current form? WDYT? @all Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris added a comment. We saw this failure for our internal SIE (PlayStation) platform. I just tested on x86_64-unknown-linux-gnu using C99 and C++98, though, and the test fails. It looks like this feature is restricted to more recent standard versions somehow. Repository: rG LLVM Github Mo

[clang] 699da98 - PR51874: Fix diagnostics for defaulted, implicitly deleted 'operator!='.

Author: Richard Smith Date: 2021-09-15T15:43:02-07:00 New Revision: 699da98739b0f88c27f75adbe8295c7e1dfd0188 URL: https://github.com/llvm/llvm-project/commit/699da98739b0f88c27f75adbe8295c7e1dfd0188 DIFF: https://github.com/llvm/llvm-project/commit/699da98739b0f88c27f75adbe8295c7e1dfd0188.diff

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

cor3ntin added a comment. Okay, what's happening is that utf literals are only available for c++11 onward and the tests do not account for that. Would you mind dropping the minimum version to C++11 and C11? I think that would be reasonable. I could do a more extensive fix but I don't know how u

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

thakis added a comment. Yes, https://bugs.chromium.org/p/chromium/issues/detail?id=1250052 I haven't yet verified it's definitely due to this change, but it's the most related-looking change in the regression range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 372827. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cpp clang/unittests/AST/TypePrinterTest.cpp Index:

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern updated this revision to Diff 372829. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Conti

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern marked an inline comment as done. csmulhern added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22301 + auto Style = getLLVMStyle(); + Style.BreakBeforeClosingParen = true; + HazardyKnusperkeks wrote: > Could you also add tests fo

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

mizvekov added a comment. In D109654#3002862 , @thakis wrote: > Yes, https://bugs.chromium.org/p/chromium/issues/detail?id=1250052 I haven't > yet verified it's definitely due to this change, but it's the most > related-looking change in the regression

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

thakis added a comment. I bet my issue is due to D108243 and not this change. Sorry for the noise! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109654/new/ https://reviews.llvm.org/D109654 _

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

mizvekov created this revision. mizvekov updated this revision to Diff 372616. mizvekov added a comment. mizvekov updated this revision to Diff 372828. mizvekov retitled this revision from "test commit." to "[clang] don't mark as Elidable CXXConstruct expressions used in NRVO". mizvekov edited the

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 372834. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cpp clang/unittests/AST/TypePrinterTest.cpp Index:

[PATCH] D109862: Don't diagnose unused but set when the Cleanup attribute is used.

mbenfield created this revision. mbenfield added a reviewer: dblaikie. mbenfield requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This applies to -Wunused-but-set-variable and -Wunused-but-set-parameter. This addresses bug 51865. Reposito

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris updated this revision to Diff 372839. ormris added a comment. - Downgrade to C11 and C++11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/new/ https://reviews.llvm.org/D109857 Files: clang/test/Lexer/char-escapes-delimited.c Index

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris added a comment. I think the test fix is all that's needed for now. This is somewhat urgent for us. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/new/ https://reviews.llvm.org/D109857 ___

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

mizvekov updated this revision to Diff 372841. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109800/new/ https://reviews.llvm.org/D109800 Files: clang/include/clang/Sema/Initialization.h clang/lib/CodeGen/CGExprCXX.

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen updated this revision to Diff 372843. cchen added a comment. Add tests and fix coding style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635 Files: clang/include/clang/AST/OpenMPClause.h clang/li

<    1   2