[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

mnadeem added a comment. In D108881#2973516 , @steven_wu wrote: > I will do a cleanup of `parseLTOMode` function since we don't need a `OptPos` > parameter anymore. There are few minor places references `OPT_flto` or > `OPT_foffload_lto` can be cleaned

[PATCH] D107290: [PoC][RISCV] Add support for the vscale_range attribute

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVTargetMachine.cpp:101 + } else { +RVVBitsMin = RVVVectorBitsMinOpt; +RVVBitsMax = RVVVectorBitsMaxOpt; If clang always emits the attribute, are these options effectively dead for

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

steven_wu added a comment. In D108881#2973719 , @mnadeem wrote: > In D108881#2973516 , @steven_wu > wrote: > >> I will do a cleanup of `parseLTOMode` function since we don't need a >> `OptPos` parameter anymore.

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

rjmccall added a comment. Thanks, Richard. Fangrui, I think we can't do anything on this patch without a CWG decision about the right semantics, so this will have to sit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108905/new/ https://reviews.l

[PATCH] D108958: [OpenMP] Make CUDA math library functions SPMD amenable

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108958/new/ https://reviews.llvm.org/D108958 ___

[PATCH] D101935: [clang] Search runtimes build tree for openmp runtime

ye-luo added a comment. It seems that this path is baked in to clang executable even after make install. I'm not convinced this is the right direction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101935/new/ https://reviews.llvm.org/D101935 ___

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

ye-luo added a comment. In D101960#2961133 , @jdoerfert wrote: > There are 3 problems here (ignoring our test setup which should be discussed > separately): > > 1. make sure clang finds libomp.so > 2. make sure libomp.so (or clang?) finds libomptarget.so

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

Jim added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:387 +ExtensionInfoIterator->Version.Minor); + if (ExtName == "e") +HasE = true; Does this need to check it is invalid if XLen is 64? ==

[PATCH] D108818: [clang] Add a -canonical-prefixes option

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm +@jansvoboda11 for lack of a better alternative owner for Driver patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108818/new/ https://reviews.llvm.org/D108818 _

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

tstellar added inline comments. Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24 +# Windows: llvm-lit.py, Linux: llvm-lit +llvm_lit = glob.glob(os.path.join(config.llvm_tools_dir, 'llvm-lit*'))[0] +lit = config.llvm_external_lit if config.llvm_external_lit else

[clang] 4f3a92c - DebugInfo: Refactor/deduplicate various template argument list emission

Author: David Blaikie Date: 2021-08-30T22:39:46-07:00 New Revision: 4f3a92ca0aff115ee17649610c46d8705e550a03 URL: https://github.com/llvm/llvm-project/commit/4f3a92ca0aff115ee17649610c46d8705e550a03 DIFF: https://github.com/llvm/llvm-project/commit/4f3a92ca0aff115ee17649610c46d8705e550a03.diff

[PATCH] D101935: [clang] Search runtimes build tree for openmp runtime

JonChesterfield planned changes to this revision. JonChesterfield added a comment. Yeah, we probably can't leave the installed program with a search path only used for testing. I'm planning to revisit this to use libomptarget_amdgcn_bc_path instead of LIBRARY_PATH for testing, then drop the LIB

[PATCH] D108886: Add RISC-V sifive-s51 cpu

apivovarov updated this revision to Diff 369635. apivovarov added a comment. update the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108886/new/ https://reviews.llvm.org/D108886 Files: clang/test/Driver/riscv-cpus.c llvm/include/llvm/Su

[PATCH] D91311: Add new 'preferred_name' attribute.

dblaikie added a comment. @rsmith - would it make sense to disable preferred names use when `PrintingPolicy::PrintCanonicalTypes` is used? It's used in `CGDebugInfo`, but also in `Sema::findFailedBooleanCondition` - so maybe we need another `PrintingPolicy` flag for this so `CGDebugInfo` can us

[PATCH] D102836: [clang] Fix Typo in AST Matcher Reference

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102836/new/ https://reviews.llvm.org/D102836 ___

[clang] 4a6d8a1 - [clang] Fix Typo in AST Matcher Reference

Author: Shivam Gupta Date: 2021-08-31T12:21:47+05:30 New Revision: 4a6d8a11f89b9eae984e1b9608c1c010dc6a037b URL: https://github.com/llvm/llvm-project/commit/4a6d8a11f89b9eae984e1b9608c1c010dc6a037b DIFF: https://github.com/llvm/llvm-project/commit/4a6d8a11f89b9eae984e1b9608c1c010dc6a037b.diff

[PATCH] D102836: [clang] Fix Typo in AST Matcher Reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a6d8a11f89b: [clang] Fix Typo in AST Matcher Reference (authored by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102836/new/ https://reviews.llvm

[PATCH] D98254: Fix typo in two files in Clang

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98254/new/ https://reviews.llvm.org/D98254

<    1   2