[PATCH] D108482: [Clang] Fixes instantiation of OpaqueValueExprs (Bug #45964)

tambre requested changes to this revision. tambre added a comment. This revision now requires changes to proceed. Please: - Add a test case based on the one in the bug. Hopefully you'll be able to reduce it further now that you understand the bug. - Use imperative style for the commit message, i

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui updated this revision to Diff 367953. kamleshbhalui added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. updated test and make changes local to auto generated global vars for lock. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui updated this revision to Diff 367954. kamleshbhalui added a comment. assume dso local if relocation model static Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108421/new/ https://reviews.llvm.org/D108421 Files: llvm/lib/Target/Targ

[PATCH] D108421: Mark openmp internal global dso_local

lebedev.ri added a comment. In D108421#2958742 , @kamleshbhalui wrote: > assume dso local if relocation model static I think these are two separate fixes. `TargetMachine::shouldAssumeDSOLocal()` change might make sense, but as the comment there notes,

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

RKSimon added a comment. In D108422#2958591 , @LuoYuanke wrote: > In D108422#2957541 , @erichkeane > wrote: > >> In D108422#2957528 , @RKSimon >> wrote: >> >>> There's n

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

LuoYuanke added a comment. >> Thanks for reminding. We've supported -march=${CPU}, but forgot to update >> this table. We will update it. > > Shall we get this patch committed first before making any changes? Yes, committing the patch first looks good to me. Repository: rG LLVM Github Monore

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

lebedev.ri added a comment. This should be autogenerated from the main `X86.td`, otherwise this is, unfortunately only partially, duplicates that. E.g. there isn't a single AMD CPU in there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108422/new/

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108422/new/ https://reviews.llvm.org/D108422

[PATCH] D108509: [X86][AMX] Add missing inline attributes in AMX intrinsics. NFCI

pengfei created this revision. pengfei added reviewers: LuoYuanke, yubing, craig.topper. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This should fix unused warning reported in https://lists.llvm.org/pipermail/llvm-dev/2021-Augu

[PATCH] D108509: [X86][AMX] Add missing inline attributes in AMX intrinsics. NFCI

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108509/new/ https://reviews.llvm.org/D108509

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui added a comment. In D108421#2958745 , @lebedev.ri wrote: > In D108421#2958742 , @kamleshbhalui > wrote: > >> assume dso local if relocation model static > > I think these are two separate fixes. `T

[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

pengfei updated this revision to Diff 367957. pengfei marked 8 inline comments as done. pengfei added a comment. Address Yuanke's comments. Thanks Yuanke and Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105268/new/ https://reviews.llvm.org/

[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

pengfei added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:2010 +TARGET_BUILTIN(__builtin_ia32_vfmaddph, "V8xV8xV8xV8x", "ncV:128:", "avx512fp16,avx512vl") +TARGET_BUILTIN(__builtin_ia32_vfmaddph256, "V16xV16xV16xV16x", "ncV:256:", "avx512fp16,avx512vl

[PATCH] D108456: [CUDA] Fix static device variables with -fgpu-rdc

Hahnfeld added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6450 llvm::raw_ostream &OS) const { - OS << ".static." << getContext().getCUIDHash(); + OS << "__static__" << getContext().getCUIDHash(); } tra wrote: > I would expect NVPTXA

[PATCH] D108509: [X86][AMX] Add missing inline attributes in AMX intrinsics. NFCI

pengfei abandoned this revision. pengfei added a comment. Didn't notice Craig fixed it. Thanks Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108509/new/ https://reviews.llvm.org/D108509 ___ cfe-co

[PATCH] D108421: Mark openmp internal global dso_local

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. If you read the comment in TargetMachine::shouldAssumeDSOLocal: this is the wrong direction. dso_local is assumed to marked by the frontend. Direct accesses and GOT accesses are tr

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

Quuxplusone added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-move-const-arg.cpp:262-263 + int a = 10; + forwardToShowInt(std::move(a)); + // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: std::move of the variable 'a' of the trivially-copy

[clang] 612048a - [clang] Fix typos in documentation (NFC)

Author: Kazu Hirata Date: 2021-08-21T12:17:58-07:00 New Revision: 612048aec1b516d9b686d4c67ffcf047186d20d7 URL: https://github.com/llvm/llvm-project/commit/612048aec1b516d9b686d4c67ffcf047186d20d7 DIFF: https://github.com/llvm/llvm-project/commit/612048aec1b516d9b686d4c67ffcf047186d20d7.diff L

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. Passed every test in check-all! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, may wait 1 or 2 days for comments from others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105268/new/ https://reviews.llvm.org/D1