MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

If you read the comment in TargetMachine::shouldAssumeDSOLocal: this is the 
wrong direction. dso_local is assumed to marked by the frontend.

Direct accesses and GOT accesses are trade-offs. Direct accesses are not always 
preferred. The MachO special case is an unfortunate case for their xnu kernel, 
not a good example here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108421/new/

https://reviews.llvm.org/D108421

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to