[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

JDevlieghere accepted this revision. JDevlieghere added a comment. Adrian said "Let's do it!" on the mailing list so LGTM for Darin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/ https://reviews.llvm.org/D106084 ___

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

Conanap created this revision. Herald added subscribers: steven.zhang, shchenz, kbarton, hiraditya, nemanjai. Conanap requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Implemented builtins for mtmsr, mfspr, mtspr on PowerPC;

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

Conanap updated this revision to Diff 359236. Conanap added a comment. Added sema checking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106130/new/ https://reviews.llvm.org/D106130 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Ba

[clang-tools-extra] 8d051d8 - Revert "Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer"

Author: Mehdi Amini Date: 2021-07-16T07:35:13Z New Revision: 8d051d854619956de633047409149cdab1e3319a URL: https://github.com/llvm/llvm-project/commit/8d051d854619956de633047409149cdab1e3319a DIFF: https://github.com/llvm/llvm-project/commit/8d051d854619956de633047409149cdab1e3319a.diff LOG: R

[clang-tools-extra] 7637457 - Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

Author: Mehdi Amini Date: 2021-07-16T07:38:16Z New Revision: 76374573ce829b083b95b74937a11e9b91f8f45f URL: https://github.com/llvm/llvm-project/commit/76374573ce829b083b95b74937a11e9b91f8f45f DIFF: https://github.com/llvm/llvm-project/commit/76374573ce829b083b95b74937a11e9b91f8f45f.diff LOG: U

[clang] 918bda1 - [analyzer] Do not assume that all pointers have the same bitwidth as void*

Author: Vince Bridgers Date: 2021-07-16T03:22:57-05:00 New Revision: 918bda1241202d0480c6d94ec8f72c483d77a06c URL: https://github.com/llvm/llvm-project/commit/918bda1241202d0480c6d94ec8f72c483d77a06c DIFF: https://github.com/llvm/llvm-project/commit/918bda1241202d0480c6d94ec8f72c483d77a06c.diff

[PATCH] D105974: [analyzer] Do not assume that all pointers have the same bitwidth as void*

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG918bda124120: [analyzer] Do not assume that all pointers have the same bitwidth as void* (authored by vabridgers, committed by einvbri

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

tmatheson added a comment. @dexonsmith I don't think they need upgraded. Most of the places I can see referencing `!srcloc` are copying it around and will preserve the i32 type. Cases which actually read the value are already reading it as 64 bit via `getZExtValue` and have been updated here, e

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/HWAddressSanitizer.h:32 + Triple TargetTriple = {}); PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM); static bool isRequired() { return true;

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1223-1225 +template <> +RangeSet SymbolicRangeInferrer::VisitBinaryOperator(Range LHS, Range RHS, + QualType T) {

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Topotuna updated this revision to Diff 359256. Topotuna added a comment. Patch made compatible with changes to D105988 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105987/new/ https://reviews.llvm.org/D105987 Files: clang/lib/Headers/opencl-c-base.

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Topotuna marked an inline comment as done. Topotuna added inline comments. Comment at: clang/test/SemaOpenCL/null_literal.cl:13 +#if defined(__OPENCL_CPP_VERSION__) +// expected-error@+2{{cannot initialize a variable of type '__global int *__private' with an rvalue of type '__gl

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Taking this off the review queue until `lharx/lbarx` are changed to emit inline asm in line with `lwarx/ldarx`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 359258. pmatos added a comment. Remove hunks touching LLTs accidentally added before Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llvm.org/D104797 Files: clang/lib/Basic/Targets/W

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap updated this revision to Diff 359259. Conanap added a comment. Updated lharx and lbarx to inline asm implementation, implemented stfiw. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105946/new/ https://reviews.llvm.org/D105946 Files: cla

[PATCH] D105495: [clang] Make negative getLocWithOffset widening-safe.

tmatheson added a comment. I'm not a huge fan of this as an API; it is not obvious what the function and parameters do without reading the comment or implementation (e.g. whether `Offset` is ignored if `NegOffset` is given, and what it means to pass offsets to both). It moves the subtraction lo

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359263. fmayer added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasan-stack-saf

[PATCH] D106136: [Analyzer][solver] Fix equivalence class invariant violation in removeDeadBindings

martong created this revision. martong added reviewers: vsavchenko, NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus.

[PATCH] D106136: [Analyzer][solver] Fix equivalence class invariant violation in removeDeadBindings

martong added a subscriber: vabridgers. martong added a comment. Note1: This issue is not related to and does not fix https://bugs.llvm.org/show_bug.cgi?id=51109 Note2: I am about to measure any performance penalty induced by the extra bookkeeping we must do. Repository: rG LLVM Github Monor

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

tmatheson added inline comments. Comment at: clang/lib/AST/DeclObjC.cpp:880-882 - unsigned Size = sizeof(ParmVarDecl *) * NumParams + - sizeof(SourceLocation) * SelLocs.size(); ParamsAndSelLocs = C.Allocate(Size); Since we know the number of

[PATCH] D106136: [Analyzer][solver] Fix equivalence class invariant violation in removeDeadBindings

vsavchenko added a comment. Thanks for working on it, but it is a quite large change that I don't get the motivation for (it doesn't even fix the recently found bug). Summary explains what the patch does, but for why it is done, it talks about an invariant that is not specified anywhere in the

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

stuartellis created this revision. Herald added subscribers: dang, mgorny. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. stuartellis requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introducing a plugin API and a s

[PATCH] D98709: [clang-tidy] New feature --skip-headers, (tested as default)

chh updated this revision to Diff 359271. chh retitled this revision from "[clang-tidy] Add --skip-headers, part 1" to "[clang-tidy] New feature --skip-headers, (tested as default)". chh edited the summary of this revision. chh added a comment. sync with latest source, update more tests to test s

[PATCH] D105959: Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

bondhugula added a comment. This is a really welcome change! Multiple registration issues were really an inconvenience - I had no clue this was the pattern to use to fix it. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105959/new/ https:/

[PATCH] D105959: Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

mehdi_amini updated this revision to Diff 359191. mehdi_amini marked 7 inline comments as done. mehdi_amini added a comment. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added projects: clang, clang-tools-extra. Address comment and fix build errors Repository: r

[PATCH] D105959: Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

mehdi_amini updated this revision to Diff 359196. mehdi_amini added a comment. Fix windows build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105959/new/ https://reviews.llvm.org/D105959 Files: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp

[PATCH] D105959: Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

mehdi_amini added a comment. In D105959#2882099 , @bondhugula wrote: > This is a really welcome change! Multiple registration issues were really an > inconvenience - I had no clue this was the pattern to use to fix it. Thanks! To be fair: we can do it

[PATCH] D105959: Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42f588f39c5c: Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it… (authored by mehdi_amini). Changed prior to commit: h

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. This is getting close to approval. The newly added `__stfiw` needs to be fixed and some nits need to be addressed. Comment at: clang/lib/Sema/SemaChecking.cpp:

[PATCH] D106120: [PowerPC] Implement vector bool/pixel initialization under -faltivec-src-compat=xl

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Why are `vector-scalar-altivec-init.c` and `vector-scalar-altivec-init2.c` added? There is no initialization of `vector bool` or `vector pixel` in them so I don't really see the

[PATCH] D106112: [clang-format] Break an unwrapped line at a K&R C parameter decl

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for this, LGTM, maybe give the others some time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106112/new/ https://reviews

[PATCH] D106065: [Clang] Add an empty builtins.h file.

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106065/new/ https://reviews.llvm.org/D106065 __

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105984/new/ https://reviews.llvm.org/D105984 __

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3255-3256 +def warn_not_xl_compatible +: Warning<"requested alignment of arguments 16 bytes or greater is not" + " compatible with previous versions of the AIX XL compiler

[clang] 66225db - [PowerPC][AIX] Add warning when alignment is incompatible with XL

Author: Zarko Todorovski Date: 2021-07-16T07:52:47-04:00 New Revision: 66225db98d832bec75ffb96298107c015b0035f0 URL: https://github.com/llvm/llvm-project/commit/66225db98d832bec75ffb96298107c015b0035f0 DIFF: https://github.com/llvm/llvm-project/commit/66225db98d832bec75ffb96298107c015b0035f0.di

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66225db98d83: [PowerPC][AIX] Add warning when alignment is incompatible with XL (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D106093: SubstTemplateTypeParmType can contain an 'auto' type in their replacement type

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a style nit, thanks for the fix! Comment at: clang/lib/AST/Type.cpp:1804 // Only these types can contain the desired 'auto' type. +Type

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Why does this review have no reviewers listed? Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15586 + case PPC::BI__builtin_ppc_mfspr: { +llvm::Type *RetType

[PATCH] D106093: SubstTemplateTypeParmType can contain an 'auto' type in their replacement type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ada884cbc2f: SubstTemplateTypeParmType can contain an 'auto' type in their replacement type (authored by serge-sans-paille). Changed prior to commi

[clang] 8ada884 - SubstTemplateTypeParmType can contain an 'auto' type in their replacement type

Author: serge-sans-paille Date: 2021-07-16T14:35:55+02:00 New Revision: 8ada884cbc2f02863cd71bddd97c7ff206ad3256 URL: https://github.com/llvm/llvm-project/commit/8ada884cbc2f02863cd71bddd97c7ff206ad3256 DIFF: https://github.com/llvm/llvm-project/commit/8ada884cbc2f02863cd71bddd97c7ff206ad3256.d

[PATCH] D106146: [clang][deps] Separate filesystem caches for minimized and original files

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 added a project: clang. Herald added a subscriber: mgorny. jansvoboda11 requested review of this revision. This patch separates the local and global caches of `DependencyScanningFilesys

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

probinson added a reviewer: jmorse. probinson added a subscriber: jmorse. probinson added a comment. + @jmorse who is better placed than I am to say whether this is what Sony would prefer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/

[PATCH] D104536: [clang][deps] Avoid minimizing PCH input files

jansvoboda11 updated this revision to Diff 359299. jansvoboda11 added a comment. Rebase on top of D106146 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104536/new/ https://reviews.llvm.org/D104536 Files: clang/lib/Tooling/DependencyScanning/Depende

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov updated this revision to Diff 359305. ASDenysPetrov added a comment. Adapted solution to ConstraintAssignor API. Added tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103096/new/ https://reviews.llvm.org/D103096 Files: clang/include/clang/StaticAnalyzer/Checkers/SV

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1908-1912 +// Handle SymbolCast before actual assignment. +std::tie(Sym, NewConstraint) = +modifySymbolAndConstraints(Sym, NewConstraint); +if (!State) +

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

lei added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:3087 // RM should be set. +let hasSideEffects = 1 in { def MTFSB0 : XForm_43<63, 70, (outs), (ins u5imm:$FM), nemanjai wrote: > nemanjai wrote: > > I think we should conservatively s

[PATCH] D106150: [PowerPC] swdiv_nochk Builtins for XL Compat

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is in a series of patches to provide builtins for compatibility with the XL compiler. This

[PATCH] D105869: [Driver] fix PowerPC SPE musl dynamic linker name

nemanjai added a subscriber: jhibbits. nemanjai added a comment. I personally don't see anything wrong with this, but then again I am not really familiar with SPE. I'll defer to @jhibbits for the approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D106150: [PowerPC] swdiv_nochk Builtins for XL Compat

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM other than a couple of nits. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15627 +Builder.getFastMathFlags().setFast(); +Value *fdiv = Builder.CreateFDiv(Ops[0

[PATCH] D105869: [Driver] fix PowerPC SPE musl dynamic linker name

jhibbits accepted this revision. jhibbits added a comment. This revision is now accepted and ready to land. Looks fine to me. @nemanjai this one is more Musl, less SPE :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105869/new/ https://reviews.ll

[PATCH] D106150: [PowerPC] swdiv_nochk Builtins for XL Compat

quinnp updated this revision to Diff 359310. quinnp added a comment. Adressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106150/new/ https://reviews.llvm.org/D106150 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/l

[PATCH] D106136: [Analyzer][solver] Fix equivalence class invariant violation in removeDeadBindings

martong added a comment. Thanks for taking your time to take a look. And I accept your statements. Nevertheless, let me explain my motivation. I thought that a class is trivial if it has only one member. And it seemed perfectly logical to not store equivalence classes with one member. I.e `a`

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

Szelethus added a comment. The bug reports speak for themselves, they are awesome. Nice work! Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:28-30 +//===--===// +// Definition of state data str

[PATCH] D106152: [analyzer] Remove test file as duplicated.

ASDenysPetrov created this revision. ASDenysPetrov added a reviewer: NoQ. ASDenysPetrov added a project: clang. Herald added subscribers: manas, steakhal, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. ASDenysPetrov requested review of this revisi

[PATCH] D105003: [Analyzer] Improve report of "indeterminate file position" condition (alpha.unix.Stream).

Szelethus added a comment. I suppose the counter is outdated, similarly to D104925#2850420 ? Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:101-109 /// Indicate if the file has an "indeterminate file position indica

[PATCH] D105898: [OpenMP] Rework OpenMP remarks

jhuber6 updated this revision to Diff 359319. jhuber6 added a comment. Small changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105898/new/ https://reviews.llvm.org/D105898 Files: clang/test/OpenMP/remarks_parallel_in_multiple_target_state_m

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap updated this revision to Diff 359322. Conanap marked 5 inline comments as done. Conanap added a comment. Added non-vsx pattern for stfiw, extra testline for that pattern, some nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105946/new/ h

[PATCH] D106150: [PowerPC] swdiv_nochk Builtins for XL Compat

quinnp updated this revision to Diff 359325. quinnp added a comment. Fixing a syntax error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106150/new/ https://reviews.llvm.org/D106150 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/B

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359326. fmayer added a comment. add llvm test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasan-st

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer marked 3 inline comments as done. fmayer added inline comments. Comment at: llvm/test/CodeGen/hwasan-stack-safety-analysis-asm.c:1 +// RUN: %clang -fsanitize=hwaddress -target aarch64-linux-gnu -S -mllvm -hwasan-use-stack-safety=true -mllvm -hwasan-generate-tags-with-call

[PATCH] D105957: [PowerPC] Implement intrinsics for mtfsf[i]

nemanjai added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1589 [IntrNoMem, IntrHasSideEffects]>; def int_ppc_mtfsfi : GCCBuiltin<"__builtin_ppc_mtfsfi">, qiucf wrote: > If `mtfsf` was changed, `mtfsfi` `mt

[PATCH] D106150: [PowerPC] swdiv_nochk Builtins for XL Compat

quinnp updated this revision to Diff 359327. quinnp added a comment. Removing entry checks from front end test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106150/new/ https://reviews.llvm.org/D106150 Files: clang/include/clang/Basic/BuiltinsP

[PATCH] D106112: [clang-format] Break an unwrapped line at a K&R C parameter decl

curdeius added a comment. Looks okay, but I was wondering if we don't want to guard all K&R-related changes behind e.g. ```Standard: Cpp78``, so as not to possibly introduce strange bugs in newer modes. It may be an overkill if there are 2 patches like this, but if there are more, that might be

[PATCH] D105003: [Analyzer] Improve report of "indeterminate file position" condition (alpha.unix.Stream).

balazske added a comment. This will be rebased on D104925 when that is finished. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:101-109 /// Indicate if the file has an "indeterminate file position indicator". /// This c

[PATCH] D104420: thread_local support for AIX

jamieschmeiser updated this revision to Diff 359336. jamieschmeiser added a comment. Respond to review comments: Change parameter name and tighten up conditions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104420/new/ https://reviews.llvm.org/D104420 Files: clang/lib/CodeGen/CGDec

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

quinnp updated this revision to Diff 359338. quinnp added a comment. Removing entry checks from front end test and renaming a variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105984/new/ https://reviews.llvm.org/D105984 Files: clang/lib/C

[PATCH] D106030: [Clang] add support for error+warning fn attrs

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3816 + +def Error : Attr { + let Spellings = [GCC<"error">]; I think this should be an inheritable attribute (same below) so that redeclarations get the marking as well. However

[PATCH] D106120: [PowerPC] Implement vector bool/pixel initialization under -faltivec-src-compat=xl

amyk updated this revision to Diff 359358. amyk added a comment. Update patch and touched base with Nemanja. - Removed the scalar vector test files that we already test for. - Update CHECKs in LIT tests accordingly. - Remove unnecessary `Sema` parameter in added function. - Keep two test files fo

[PATCH] D105703: [hwasan] Use stack safety analysis.

eugenis added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:407 bool Recover; + bool DisableOptimization; }; No need to pass this down, just look at OptimizeNone function attribute. Repository: rG LLVM Github Mon

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/null_literal.cl:26 #ifdef CL20 // Accept explicitly pointer to generic address space in OpenCL v2.0. while we are at it, do you mind changing this check into `__OPENCL_CPP_VERSION__ == 200`

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

awarzynski added a comment. @stuartellis , thank you for working on this! I've left a few comments - mostly nits. Comment at: flang/examples/HelloWorld/CMakeLists.txt:1-5 +add_llvm_library( +flangHelloWorldPlugin +MODULE +HelloWorldPlugin.cpp +) I

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer marked 2 inline comments as done. fmayer added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:407 bool Recover; + bool DisableOptimization; }; eugenis wrote: > No need to pass this down, just look at OptimizeNo

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:407 bool Recover; + bool DisableOptimization; }; fmayer wrote: > eugenis wrote: > > No need to pass this down, just look at OptimizeNone function attribute.

[PATCH] D106112: [clang-format] Break an unwrapped line at a K&R C parameter decl

MyDeveloperDay added a comment. In D106112#2883301 , @curdeius wrote: > Looks okay, but I was wondering if we don't want to guard all K&R-related > changes behind e.g. ```Standard: Cpp78``, so as not to possibly introduce > strange bugs in newer modes.

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359373. fmayer added a comment. don't use stack analysis for opt null Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clan

[PATCH] D105703: [hwasan] Use stack safety analysis.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/BackendUtil.cpp:1174 +CompileKernel, Recover, +/*IsOptNull=*/CodeGenOpts.OptimizationLevel == 0)); } -

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 359376. fmayer marked 3 inline comments as done. fmayer added a comment. fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/Backen

[PATCH] D105703: [hwasan] Use stack safety analysis.

eugenis added a comment. Btw Vitaly, will this work with LTO out of the box? I think we used to add pre-LTO StackSafety pass explicitly for memtag only, but it looks like that code is gone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/

[PATCH] D106136: [Analyzer][solver] Fix equivalence class invariant violation in removeDeadBindings

vsavchenko added a comment. In D106136#2883100 , @martong wrote: > Thanks for taking your time to take a look. And I accept your statements. > Nevertheless, let me explain my motivation. > > I thought that a class is trivial if it has only one member. An

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap updated this revision to Diff 359380. Conanap added a comment. Updated a test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105946/new/ https://reviews.llvm.org/D105946 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Ba

[clang] 0bf4b81 - [Clang] Add an empty builtins.h file.

Author: Stefan Pintilie Date: 2021-07-16T12:50:04-05:00 New Revision: 0bf4b81d57b0b4d1ecc2752be3e4ad1504ee1eb3 URL: https://github.com/llvm/llvm-project/commit/0bf4b81d57b0b4d1ecc2752be3e4ad1504ee1eb3 DIFF: https://github.com/llvm/llvm-project/commit/0bf4b81d57b0b4d1ecc2752be3e4ad1504ee1eb3.dif

[PATCH] D106065: [Clang] Add an empty builtins.h file.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0bf4b81d57b0: [Clang] Add an empty builtins.h file. (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

nickdesaulniers added a comment. In D104058#2878083 , @samitolvanen wrote: > In D104058#2877631 , > @nickdesaulniers wrote: > >> Change LGTM, but I don't understand why the following tests are modified: >> >> -

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen added a comment. In D104058#2883804 , @nickdesaulniers wrote: > In D104058#2878083 , @samitolvanen > wrote: > >> In D104058#2877631 , >> @nickdesaulniers w

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

masoud.ataei updated this revision to Diff 359385. masoud.ataei added a comment. Removed clang changes from this PR. Removed extra option for MASS pass. Now MASS pass is active with -O3 and approx-func option. Adding another PR for clang changes on approx-func option. Repository: rG LLVM Gith

[clang] eef6601 - [OpenMP] Rework OpenMP remarks

Author: Joseph Huber Date: 2021-07-16T14:07:00-04:00 New Revision: eef6601b0fb6d5fee32627e07be4acbf769e5c0f URL: https://github.com/llvm/llvm-project/commit/eef6601b0fb6d5fee32627e07be4acbf769e5c0f DIFF: https://github.com/llvm/llvm-project/commit/eef6601b0fb6d5fee32627e07be4acbf769e5c0f.diff

[PATCH] D105898: [OpenMP] Rework OpenMP remarks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeef6601b0fb6: [OpenMP] Rework OpenMP remarks (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D105898?vs=359319&id=359390#

[clang] 2c31d5e - [OpenMP] Add IDs to OpenMP remarks

Author: Joseph Huber Date: 2021-07-16T14:07:03-04:00 New Revision: 2c31d5ebfbbb36de37d41b6945d0c45efa512790 URL: https://github.com/llvm/llvm-project/commit/2c31d5ebfbbb36de37d41b6945d0c45efa512790 DIFF: https://github.com/llvm/llvm-project/commit/2c31d5ebfbbb36de37d41b6945d0c45efa512790.diff

[PATCH] D105939: [OpenMP] Add IDs to OpenMP remarks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c31d5ebfbbb: [OpenMP] Add IDs to OpenMP remarks (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D105939?vs=358461&id=359

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

masoud.ataei marked 9 inline comments as done. masoud.ataei added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:1370 + // to be consistent to PPCGenScalarMASSEntries pass + if (TM.Options.PPCGenScalarMASSEntries && TM.Options.ApproxFuncFPMath) { +

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

pcc accepted this revision. pcc added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104058/new/ https://reviews.llvm.org/D104058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D105959: Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

dexonsmith added a comment. In D105959#2882136 , @mehdi_amini wrote: > In D105959#2882099 , @bondhugula > wrote: > >> This is a really welcome change! Multiple registration issues were really an >> inconvenienc

[clang] c8937b6 - [PowerPC] Implement XL compact math builtins

Author: Lei Huang Date: 2021-07-16T13:21:13-05:00 New Revision: c8937b6cb9751807de1e69f0f0f70a9a58f8f5dc URL: https://github.com/llvm/llvm-project/commit/c8937b6cb9751807de1e69f0f0f70a9a58f8f5dc DIFF: https://github.com/llvm/llvm-project/commit/c8937b6cb9751807de1e69f0f0f70a9a58f8f5dc.diff LOG

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8937b6cb975: [PowerPC] Implement XL compact math builtins (authored by lei). Changed prior to commit: https://reviews.llvm.org/D105930?vs=359070&

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

quinnp updated this revision to Diff 359398. quinnp added a comment. Adding a `REQUIRES: powerpc-registered-target` to a testcase and removing checks for `entry:` in front end test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105834/new/ ht

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

Conanap updated this revision to Diff 359400. Conanap marked 4 inline comments as done. Conanap added a comment. Changed `i32` to `timm` for patterns, some nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106130/new/ https://reviews.llvm.org/D106

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

Conanap added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15586 + case PPC::BI__builtin_ppc_mfspr: { +llvm::Type *RetType = CGM.getDataLayout().getTypeSizeInBits(VoidPtrTy) == 32 + ? Int32Ty nemanjai wrote: > Is

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

necipfazil updated this revision to Diff 359401. necipfazil added a comment. Herald added subscribers: dexonsmith, hiraditya. Herald added a project: LLVM. Use operand bundles for callsite type ids - Use (unlossy) operand bundles for propagating indirect callsite type ids - No longer use type met

[PATCH] D106172: [clang][CallGraphSection] Add type id metadata to indirect call and targets

necipfazil created this revision. Herald added subscribers: dexonsmith, hiraditya. necipfazil requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Create and add generalized type identifier metadata to indirect calls, and to fu

[PATCH] D105959: Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

mehdi_amini added a comment. That's interesting! I'm not sure how to get there though: a complete solution should be able to "degrade" to global constructor when the platform-specific logic isn't available (unless we're confident that no such environment can exist?). Repository: rG LLVM Git

  1   2   >