nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land.
LGTM other than a couple of nits. ================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15627 + Builder.getFastMathFlags().setFast(); + Value *fdiv = Builder.CreateFDiv(Ops[0], Ops[1], "swdiv_nochk"); + Builder.getFastMathFlags() &= (FMF); ---------------- Nit: naming convention for variables is that they are capitalized CamelCase. ================ Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-swdiv_nochk.c:3 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -triple powerpc64-unknown-unknown \ +// RUN: -emit-llvm %s -o - -target-cpu pwr7 | FileCheck %s ---------------- One Linux run line and one AIX run line should suffice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106150/new/ https://reviews.llvm.org/D106150 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
