[PATCH] D102361: [OpenMP] Add Module metadata for OpenMP compilation

jhuber6 updated this revision to Diff 354324. jhuber6 added a comment. Addings tests and a module flag for openmp target devices. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102361/new/ https://reviews.llvm.org/D102361 Files: clang/lib/CodeGen

[PATCH] D104847: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX 6.5 and 7.0 WMMA and MMA instructions

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Nice. Thank you for adding support for these missing instructions! LGTM, modulo a few of cosmetic nits. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:762 +// Builtins t

[clang] 8db0dbb - [CodeGen] Don't create fake FunctionDecls when generating block/byref

Author: Akira Hatanaka Date: 2021-06-24T11:45:52-07:00 New Revision: 8db0dbbe2c0544c38f33cf64b4cdd5135d524b23 URL: https://github.com/llvm/llvm-project/commit/8db0dbbe2c0544c38f33cf64b4cdd5135d524b23 DIFF: https://github.com/llvm/llvm-project/commit/8db0dbbe2c0544c38f33cf64b4cdd5135d524b23.diff

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In general, I think this looks good (I did find one minor nit that removes an include, but that can be fixed as you land). There's an open question for @jansvoboda11 and it'd be

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, once @MaskRay is happy. I have a couple of minor comments inline too. (I also see that there are some clang-format suggestions in the unit tests; not sure any of them are actuall

[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

tstellar added a comment. In D104831#2838835 , @hoy wrote: > In D104831#2837712 , @MaskRay wrote: > >>> Adding the platform tripplet x86_64-redhat-linux-gnu the while list of >>> supported x86_64 triplets so that

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

lattner accepted this revision. lattner added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104819/new/ https://reviews.llvm.org/D104819 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

rsmith added a comment. I would prefer to split this into two changes: 1. Stop providing a builtin overload candidate `R operator<=>(P, P)` where `P` is a function pointer type, to be consistent with the behavior of the built-in `<=>` operator. 2. Stop providing `<`/`<=`/`>`/`>=` support for fu

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

mstorsjo added a comment. In D104819#2839263 , @dexonsmith wrote: > LGTM, once @MaskRay is happy. I have a couple of minor comments inline too. > > (I also see that there are some clang-format suggestions in the unit tests; > not sure any of them are ac

[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

hoy added a comment. In D104831#2839301 , @tstellar wrote: > In D104831#2838835 , @hoy wrote: > >> In D104831#2837712 , @MaskRay >> wrote: >> Adding the platform tri

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:301 + const OverloadedOperatorKind OOK = FD->getOverloadedOperator(); + if (!(OOK == OO_Equal || OOK == OO_ExclaimEqual || OOK == OO_Less || +OOK == OO_LessEqual || OOK =

[PATCH] D104550: [analyzer] Implement getType for SVal

Szelethus added a comment. In D104550#2838845 , @vsavchenko wrote: >> Another thing is that we can garantee returning `QualType`. I mean, we can >> replace `Optional` with `QualType` itself. `QualType` has a default ctor and >> `isNull` predicate, whic

[clang] b3ccf4f - [clang-format][NFC] Fix documentation

Author: Björn Schäpers Date: 2021-06-24T21:19:14+02:00 New Revision: b3ccf4fc02cdb12eb0929ad9f9dfdec39b785e6a URL: https://github.com/llvm/llvm-project/commit/b3ccf4fc02cdb12eb0929ad9f9dfdec39b785e6a DIFF: https://github.com/llvm/llvm-project/commit/b3ccf4fc02cdb12eb0929ad9f9dfdec39b785e6a.diff

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2520 + /// readability to have the signature indented two levels and to use + /// ``OuterScope``. The KJ style guide requires ``OuterScope`. + /// `KJ style guide Here is

[PATCH] D104285: [analyzer] Retrieve value by direct index from list initialization of constant array declaration.

chrish_ericsson_atx added a comment. In D104285#2836190 , @ASDenysPetrov wrote: >> I think the presence of the initializer list in the test case is not >> necessary to trigger the spurious warnings > > Could you please provide some test cases that you t

[PATCH] D104774: [clang-format] Fix a bug that indents else-comment-if incorrectly

HazardyKnusperkeks added a comment. In D104774#2838287 , @MyDeveloperDay wrote: > @HazardyKnusperkek Its probably my "bad" I should said "LGTM but maybe wait > for the others to comment", but I'm fundamentally ok I think with the change. > (we'll just

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

dexonsmith added a comment. In D104819#2839315 , @mstorsjo wrote: > In D104819#2839263 , @dexonsmith > wrote: > >> Just be sure to clang-format when you do the mechanical changes in the >> follow up patches.) >

[PATCH] D104871: [Docs] use -fprofile-generate for IR PGO and -fprofile-instr-generate for code coverage

zequanwu created this revision. zequanwu added reviewers: rnk, vsk, davidxl, arphaman. Herald added a subscriber: wenlei. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add docs to specify `-fprofile-generate` for IR PGO and `-fp

[PATCH] D104285: [analyzer] Retrieve value by direct index from list initialization of constant array declaration.

ASDenysPetrov added a comment. @chrish_ericsson_atx > I don't understand -- probably I don't have enough experience with analyzer > state dumps to know what I should find surprising or better in this example. Simply saying, now `ptr[3]` returns value `4` as expected, but `arr[1][1]` still retu

[PATCH] D103612: [flang][driver] Add `-fno-analyzed-objects-for-unparse`

PeteSteinfeld accepted this revision. PeteSteinfeld added a comment. This revision is now accepted and ready to land. All builds, tests, and looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103612/new/ https://reviews.llvm.org/D103612 ___

[clang] a08fa8a - [Clang-Format] Add ReferenceAlignment directive

Author: Seraphime Kirkovski Date: 2021-06-24T22:27:45+02:00 New Revision: a08fa8a508199c6463f5ee5d617e2f360f718067 URL: https://github.com/llvm/llvm-project/commit/a08fa8a508199c6463f5ee5d617e2f360f718067 DIFF: https://github.com/llvm/llvm-project/commit/a08fa8a508199c6463f5ee5d617e2f360f718067

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

This revision was automatically updated to reflect the committed changes. Closed by commit rGa08fa8a50819: [Clang-Format] Add ReferenceAlignment directive (authored by Seraphime Kirkovski , committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

ahatanak added a comment. Thank you for the repro. I added calls to `ApplyDebugLocation::CreateArtificial` and reapplied the patch in https://github.com/llvm/llvm-project/commit/8db0dbbe2c0544c38f33cf64b4cdd5135d524b23. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[clang] e5c7c17 - [clang] Rename StringRef _lower() method calls to _insensitive()

Author: Martin Storsjö Date: 2021-06-25T00:22:01+03:00 New Revision: e5c7c171e5db6af1e3dca1059df4287b0d147eaf URL: https://github.com/llvm/llvm-project/commit/e5c7c171e5db6af1e3dca1059df4287b0d147eaf DIFF: https://github.com/llvm/llvm-project/commit/e5c7c171e5db6af1e3dca1059df4287b0d147eaf.diff

[clang-tools-extra] 86029e4 - [clang-tools-extra] Rename StringRef _lower() method calls to _insensitive()

Author: Martin Storsjö Date: 2021-06-25T00:22:01+03:00 New Revision: 86029e4c220b91be728f6ff6a17cad098821e657 URL: https://github.com/llvm/llvm-project/commit/86029e4c220b91be728f6ff6a17cad098821e657 DIFF: https://github.com/llvm/llvm-project/commit/86029e4c220b91be728f6ff6a17cad098821e657.diff

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3eed57e7ef7d: [ADT] Rename StringRef case insensitive methods for clarity (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.or

[PATCH] D104837: [PowerPC] Add XL compat __compare_and_swap builtins

jsji updated this revision to Diff 354360. jsji added a comment. Add {} to case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104837/new/ https://reviews.llvm.org/D104837 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Target

[PATCH] D102361: [OpenMP] Add Module metadata for OpenMP compilation

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102361/new/ https://reviews.llvm.org/D102361 ___

[PATCH] D102361: [OpenMP] Add Module metadata for OpenMP compilation

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:709 +getModule().addModuleFlag(llvm::Module::Max, "openmp-device", + LangOpts.OpenMP); + Why do we need `OpenMPRuntime` in the conditional? Reposit

[PATCH] D102361: [OpenMP] Add Module metadata for OpenMP compilation

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:709 +getModule().addModuleFlag(llvm::Module::Max, "openmp-device", + LangOpts.OpenMP); + jdoerfert wrote: > Why do we need `OpenMPRuntime` in the condi

[clang] f1e2d58 - [OptTable] Rename PrintHelp to printHelp

Author: Fangrui Song Date: 2021-06-24T14:47:03-07:00 New Revision: f1e2d5851bf869685971d5acb894b39a89ea2d49 URL: https://github.com/llvm/llvm-project/commit/f1e2d5851bf869685971d5acb894b39a89ea2d49 DIFF: https://github.com/llvm/llvm-project/commit/f1e2d5851bf869685971d5acb894b39a89ea2d49.diff

[PATCH] D102361: [OpenMP] Add Module metadata for OpenMP compilation

jhuber6 updated this revision to Diff 354368. jhuber6 added a comment. Removing runtime check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102361/new/ https://reviews.llvm.org/D102361 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/Ope

[PATCH] D104550: [analyzer] Implement getType for SVal

ASDenysPetrov added a comment. > I'm not sure what you mean here. If it is about this particular patch, it > simply adds a non-virtual method to SVal, it shouldn't affect sizeof(SVal) at > all. My fault. For some reason I thought you added a QualType as a member to SVal declaration. > I wante

[PATCH] D104883: [CodeGen] Add ParmVarDecls to FunctionDecls that are created to generate ObjC property getter/setter functions

ahatanak created this revision. ahatanak added reviewers: rjmccall, aprantl, vsk, dblaikie. ahatanak added a project: clang. Herald added a subscriber: kristof.beyls. ahatanak requested review of this revision. This is needed to prevent clang from crashing when we make the changes proposed in htt

[PATCH] D104883: [CodeGen] Add ParmVarDecls to FunctionDecls that are created to generate ObjC property getter/setter functions

ahatanak added a comment. clang crashes if I remove the fake FunctionDecls as I did in https://reviews.llvm.org/D104082. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104883/new/ https://reviews.llvm.org/D104883 __

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

mizvekov added a comment. In D104680#2839309 , @rsmith wrote: > I would prefer to split this into two changes: > ... > Does that sound reasonable? Yeah that is fine, totally understand ;) Comment at: clang/lib/Sema/SemaExpr.cpp:11815

[clang] ef90657 - [PowerPC] Fix vec_add for 64-bit on pre-Power7 subtargets

Author: Nemanja Ivanovic Date: 2021-06-24T18:42:44-05:00 New Revision: ef906573a127cffef7cae75d5155c15a8a2a3a5e URL: https://github.com/llvm/llvm-project/commit/ef906573a127cffef7cae75d5155c15a8a2a3a5e DIFF: https://github.com/llvm/llvm-project/commit/ef906573a127cffef7cae75d5155c15a8a2a3a5e.di

[PATCH] D104883: [CodeGen] Add ParmVarDecls to FunctionDecls that are created to generate ObjC property getter/setter functions

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. If ` args.push_back(Params[1] = SrcDecl);` doesn't trigger a warning, this seems reasonable. Comment at: clang/lib/CodeGen/CGObjC.cpp:3702 + /*DefArg=*/nullptr); + a

[clang] d6a91f6 - Revert "[Clang] XFAIL sanitize-coverage-old-pm.c on 32bit Armv8l"

Author: Muhammad Omair Javaid Date: 2021-06-25T05:00:14+05:00 New Revision: d6a91f6c565179e9b2dac700f9a54e105f748a6d URL: https://github.com/llvm/llvm-project/commit/d6a91f6c565179e9b2dac700f9a54e105f748a6d DIFF: https://github.com/llvm/llvm-project/commit/d6a91f6c565179e9b2dac700f9a54e105f748a

[PATCH] D104883: [CodeGen] Add ParmVarDecls to FunctionDecls that are created to generate ObjC property getter/setter functions

dblaikie added a comment. Ah - this is an alternative to D104082 ? OK. Yeah, looks like it'd address the thing we were discussing in D98799 . But do you have some more details on why D104082 wa

[PATCH] D104887: [clang] Evaluate strlen of strcpy argument for -Wfortify-source.

mbenfield created this revision. mbenfield added reviewers: george.burgess.iv, cjdb, rsmith. mbenfield requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also introduce Expr::tryEvaluateStrLen. Repository: rG LLVM Github Monorepo https://

[PATCH] D104837: [PowerPC] Add XL compat __compare_and_swap builtins

w2yehia accepted this revision. w2yehia added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-cas.c:19 +// CHECK-NEXT:[[TMP2:%.*]] = cmpxchg weak volatile i32* [[A]], i32 [[TMP1]], i32 [[TMP0]] monotonic

[clang] e8cded5 - Unsupported sanitize-coverage-old-pm.c on 32 bit Arm

Author: Muhammad Omair Javaid Date: 2021-06-25T00:57:24Z New Revision: e8cded57fbf7b2b81aefd569b95f38ae97948ef0 URL: https://github.com/llvm/llvm-project/commit/e8cded57fbf7b2b81aefd569b95f38ae97948ef0 DIFF: https://github.com/llvm/llvm-project/commit/e8cded57fbf7b2b81aefd569b95f38ae97948ef0.di

[clang] f225367 - [RISCV] Add vget/vset intrinsics for inserting and extracting between different lmuls.

Author: Craig Topper Date: 2021-06-24T18:06:36-07:00 New Revision: f225367305c82ce391bb470f735b19e924ff7372 URL: https://github.com/llvm/llvm-project/commit/f225367305c82ce391bb470f735b19e924ff7372 DIFF: https://github.com/llvm/llvm-project/commit/f225367305c82ce391bb470f735b19e924ff7372.diff

[PATCH] D104822: [RISCV] Add vget/vset intrinsics for inserting and extracting between different lmuls.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf225367305c8: [RISCV] Add vget/vset intrinsics for inserting and extracting between different… (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D104837: [PowerPC] Add XL compat __compare_and_swap builtins

jsji updated this revision to Diff 354410. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104837/new/ https://reviews.llvm.org/D104837 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Targ

[PATCH] D104837: [PowerPC] Add XL compat __compare_and_swap builtins

jsji added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-cas.c:19 +// CHECK-NEXT:[[TMP2:%.*]] = cmpxchg weak volatile i32* [[A]], i32 [[TMP1]], i32 [[TMP0]] monotonic monotonic, align 4 +// CHECK-NEXT:[[TMP3:%.*]] = extractvalue { i32, i1 } [[TMP2

[clang] f3ef4f5 - [PowerPC] Add XL compat __compare_and_swap builtins

Author: Jinsong Ji Date: 2021-06-25T01:08:48Z New Revision: f3ef4f5bff26ac4196a15dad7773a03b9d6df21d URL: https://github.com/llvm/llvm-project/commit/f3ef4f5bff26ac4196a15dad7773a03b9d6df21d DIFF: https://github.com/llvm/llvm-project/commit/f3ef4f5bff26ac4196a15dad7773a03b9d6df21d.diff LOG: [P

[PATCH] D104837: [PowerPC] Add XL compat __compare_and_swap builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3ef4f5bff26: [PowerPC] Add XL compat __compare_and_swap builtins (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D104892: [clang] Stop providing builtin overload candidate for relational function pointer comparisons

mizvekov created this revision. mizvekov requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Word on the grapevine was that the committee had some discussion that ended with unanimous agreement on eliminating relational fu

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

mizvekov added a comment. First part of the split implemented at: https://reviews.llvm.org/D104892 I will reuse this DR for the second part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104680/new/ https://reviews.llvm.org/D104680 ___

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

stefanp updated this revision to Diff 354422. stefanp added a comment. Updated the name of the option to cover all of the inconsistencies for vector pixel/bool. Future patches will continue to use this option to define the behaviour of these two types. Reworded the warning message. Added InGroup<

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas updated this revision to Diff 354424. manas added a comment. Fix issues involving usage of `uadd_ov` and family of functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103440/new/ https://reviews.llvm.org/D103440 Files: clang/lib/Static

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. During a trial phase while compiling everything twice with ccache I got the following results. Only unify_mode:: $ ccache -d . -s cache directory . primary config ./ccache.conf secondary config (readonly) /hom

[PATCH] D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant.

junparser updated this revision to Diff 354427. junparser added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. update clang test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104852/new/ https://reviews.llvm.org/

[PATCH] D104550: [analyzer] Implement getType for SVal

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SVals.cpp:154 + Optional VisitLocGotoLabel(loc::GotoLabel GL) { +return QualType{Context.VoidPtrTy}; + } ASDenysPetrov wrote: > vsavchenko wrote: > > ASDenysPetrov wrote: > > > I'm not sur

[PATCH] D104892: [clang] Stop providing builtin overload candidate for relational function pointer comparisons

rsmith added a comment. Thanks, the summary gave me a chuckle :) Comment at: clang/lib/Sema/SemaExpr.cpp:11809-11812 +Diag(Loc, IsError + ? diag::err_typecheck_ordered_comparison_of_function_pointers + : diag::ext_typecheck_ordered_compari

[PATCH] D104896: [DFSan] Change shadow and origin memory layouts to match MSan.

browneee created this revision. browneee added reviewers: stephan.yichao.zhao, gbalats. Herald added subscribers: pengfei, hiraditya. browneee requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Previou

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan added a comment. I reported bugs of using clang-cl and lld to test https://github.com/microsoft/compiler-tests/tree/master/seh 2. clang-cl.exe + lld linker a. x4ptcu.c: build error https://bugs.llvm.org/show_bug.cgi?id=50859 b. seh0015.c, seh0017.c: build crash https://bugs.llvm.

[PATCH] D104898: [clang-repl] Allow passing in code as positional arguments.

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, teemperor, aprantl, sgraenitz. v.g.vassilev requested review of this revision. Now we can do things like: clang-repl "int i = 1;" "int j = 2;". https://reviews.llvm.org/D104898 Files: clang/test/Interpreter/execute.cpp

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

vsavchenko added inline comments. Comment at: clang/test/Analysis/constant-folding.c:264-266 + if (a == UINT_MAX && b == UINT_MAX) { +clang_analyzer_eval((a + b) == UINT_MAX - 1); // expected-warning{{TRUE}} + } We need a test with ranges and unsigned overf

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas updated this revision to Diff 354441. manas added a comment. Add tests for overflows on both ends Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103440/new/ https://reviews.llvm.org/D103440 Files: clang/lib/StaticAnalyzer/Core/RangeConstrai

<    1   2