[PATCH] D104500: [clang] Apply P1825 as Defect Report for all C++ standards up to C++20.

mizvekov updated this revision to Diff 353132. mizvekov added a comment. lint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104500/new/ https://reviews.llvm.org/D104500 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/cla

[PATCH] D104500: [clang] Apply P1825 as Defect Report for all C++ standards up to C++20.

mizvekov added inline comments. Comment at: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp:58-60 A1 test1(A1 &&a) { - return a; // cxx11_17-error {{call to deleted constructor of 'test_implicitly_movable_rvalue_ref::A1'}} + return a; } mizvekov wr

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

thakis added a comment. FWIW https://lab.llvm.org/buildbot/#/builders/123 has been red for several days after this landed too (eg https://lab.llvm.org/buildbot/#/builders/123/builds/4545) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88666/new/ h

[PATCH] D99810: [ifs] Prepare llvm-ifs for elfabi/ifs merging.

phosek accepted this revision. phosek added a comment. LGTM Comment at: llvm/lib/InterfaceStub/IFSStub.cpp:70 + } + llvm_unreachable("unknown bitwidth"); +} This shouldn't be needed. Comment at: llvm/lib/InterfaceStub/IFSStub.cpp:82 + } +

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich added a comment. I think you can go ahead & commit it for me. I don't know when I'll get commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102706/new/ https://reviews.llvm.org/D102706 ___ cfe-commits mailing list cfe-commi

[PATCH] D102730: [clang-format] Support custom If macros

vlovich updated this revision to Diff 353150. vlovich marked an inline comment as done. vlovich added a comment. Fix clang-format issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102730/new/ https://reviews.llvm.org/D102730 Files: clang/docs/

[PATCH] D104500: [clang] Apply P1825 as Defect Report for all C++ standards from C++11 up to C++20.

mizvekov updated this revision to Diff 353151. mizvekov added a comment. Don't apply implicit moves to C++98, and add tests which demonstrate incompatibilities this would cause. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104500/new/ https://rev

[PATCH] D103855: [clang] Exclude function pointers on DefaultedComparisonAnalyzer

lhames added a comment. Disregard 80f30a6b855b : I messed up a copy-paste of a commit message. That was for https://reviews.llvm.org/D104480. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D104500: [clang] Apply P1825 as Defect Report for all C++ standards from C++11 up to C++20.

mizvekov updated this revision to Diff 353155. mizvekov added a comment. format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104500/new/ https://reviews.llvm.org/D104500 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/c

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

NoQ added a comment. In D103750#2827566 , @RedDocMD wrote: > Do you want the new failing test to be marked //expected to fail//? The line of thinking here is that tests are just something that gives us a signal when the behavior changes. They don't nece

[PATCH] D104550: [analyzer] Implement getType for SVal

NoQ added a comment. Excellent! This utility is the first step on a lot of paths such as: - Asserting that all expressions' values are of the right type. I expect this to uncover a lot of ridiculous mutually cancelling bugs. - Modeling extents of RegionStore bindings - they're simply widths of t

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas updated this revision to Diff 353168. manas added a comment. Reason about cases where Min > Max Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103440/new/ https://reviews.llvm.org/D103440 Files: clang/lib/StaticAnalyzer/Core/RangeConstraint

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added a comment. The diff fixes all invalid assertion issues and also reasons about the cases where Min > Max. One thing which is stuck for me is the case where Min <= Max but it overflows. I could reason about that in this way: 1. If one of Min/Max overflows while the other doesn't then

<    1   2