[PATCH] D103678: [Format] Fix incorrect pointer/reference detection

Nuu added a comment. In D103678#2811302 , @HazardyKnusperkeks wrote: > Do you need some one to commit this? If yes please state name and email, some > one will chime in to commit it. Yes, please someone help commit this. Name: Yilong Guo Email: yi

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

RedDocMD updated this revision to Diff 352627. RedDocMD added a comment. Marking and un-marking interestingness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104300/new/ https://reviews.llvm.org/D104300 Files: clang/include/clang/StaticAnalyzer/

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

Szelethus added a comment. Aha, alright! So the tracker tracked back to where the tracked expression got computed to node `N`, which is the return value of some identity function. Unless its explicitly told that there is a link in between the return value and the parameter, the tracker can't fi

[PATCH] D103387: [clangd] Fix feature modules to drop diagnostics

kadircet updated this revision to Diff 352628. kadircet marked 2 inline comments as done. kadircet added a comment. - Bail out early before filling in diag info - Move isExcluded check into handleDiagnostics, rather than handling it during flushing Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D103527: [Clang][RISCV] Implement vlseg and vlsegff.

rogfer01 added a comment. Do you think you can split `vlseg` and `vlseg_ff` tests in two different files? So we (potentially) reduce the test latency by half in multicore systems. Other than this, LGTM. We're a bit split in https://github.com/riscv/rvv-intrinsic-doc/issues/95 However there are

[clang-tools-extra] b662651 - [clangd] Use command line adjusters for inserting compile flags

Author: Kadir Cetinkaya Date: 2021-06-17T09:24:53+02:00 New Revision: b662651586bedd5350914f64463fe415105785c8 URL: https://github.com/llvm/llvm-project/commit/b662651586bedd5350914f64463fe415105785c8 DIFF: https://github.com/llvm/llvm-project/commit/b662651586bedd5350914f64463fe415105785c8.dif

[PATCH] D99523: [clangd] Use command line adjusters for inserting compile flags

This revision was automatically updated to reflect the committed changes. Closed by commit rGb662651586be: [clangd] Use command line adjusters for inserting compile flags (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99523/new

[PATCH] D103387: [clangd] Fix feature modules to drop diagnostics

sammccall accepted this revision. sammccall added a comment. LG, I'm a bit sad to see we're not able to skip much work in the diagnostics-outside-main-file case but that's a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103387/new/

[clang-tools-extra] 204014e - [clangd] Fix feature modules to drop diagnostics

Author: Kadir Cetinkaya Date: 2021-06-17T09:29:29+02:00 New Revision: 204014ec7557cde214ee8aae1927bf9976f2 URL: https://github.com/llvm/llvm-project/commit/204014ec7557cde214ee8aae1927bf9976f2 DIFF: https://github.com/llvm/llvm-project/commit/204014ec7557cde214ee8aae1927bf9976f2.dif

[PATCH] D103387: [clangd] Fix feature modules to drop diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG204014ec7557: [clangd] Fix feature modules to drop diagnostics (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

vsavchenko added a comment. In D104136#2823834 , @Szelethus wrote: > Aha, alright! So the tracker tracked back to where the tracked expression got > computed in node `N`, which is the return value of some identity function. > Unless its explicitly told

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2506-2520 + for (auto It = NTL.findByWidth(C.getIntWidth(T)) - 1; It >= NTL.begin(); + --It) { +SymbolRef S = State->getSymbolManager().getCastSymbol( +RootSy

[PATCH] D104442: [libclang] Fix error handler in translateSourceLocation.

simon_tatham created this revision. simon_tatham added reviewers: akyrtzi, rsmith. simon_tatham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Given an invalid SourceLocation, translateSourceLocation will call clang_getNullLocation, and th

[clang] 9cca5c1 - [analyzer] Make checker silencing work for non-pathsensitive bug reports

Author: Kirstóf Umann Date: 2021-06-17T10:27:34+02:00 New Revision: 9cca5c1391d637b5500ada646cf136ddb38254a3 URL: https://github.com/llvm/llvm-project/commit/9cca5c1391d637b5500ada646cf136ddb38254a3 DIFF: https://github.com/llvm/llvm-project/commit/9cca5c1391d637b5500ada646cf136ddb38254a3.diff

[PATCH] D102914: [analyzer] Make checker silencing work for non-pathsensitive bug reports

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9cca5c1391d6: [analyzer] Make checker silencing work for non-pathsensitive bug reports (authored by Szelethus). Repository: rG LLVM Github Monorep

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

sberg added a comment. For the record, the one other breakage of a LibreOffice build with this is the handful of places that needed https://git.libreoffice.org/core/+/433ab39b2175bdadb4916373cd2dc8e1aabc08a5%5E%21 "Adapt implicit OString return value construction to C++23 P2266R1": In a nutsh

[clang] 873308f - [Format] Fix incorrect pointer/reference detection

Author: Yilong Guo Date: 2021-06-17T09:34:06+01:00 New Revision: 873308fd8c96a54f0024251425daac1b78f70119 URL: https://github.com/llvm/llvm-project/commit/873308fd8c96a54f0024251425daac1b78f70119 DIFF: https://github.com/llvm/llvm-project/commit/873308fd8c96a54f0024251425daac1b78f70119.diff LO

[PATCH] D103678: [Format] Fix incorrect pointer/reference detection

This revision was automatically updated to reflect the committed changes. Closed by commit rG873308fd8c96: [Format] Fix incorrect pointer/reference detection (authored by Nuu, committed by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

vsavchenko added a comment. I agree with @NoQ that notes are pretty much straightforward and we shouldn't abandon them altogether. Refinements about what is null or non-null pointer are purely cosmetic and we definitely can tweak this messaging. Comment at: clang/lib/StaticA

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

MyDeveloperDay added a comment. This patch needs rebasing, please also make comments as "Done" once you have addressed them. Comment at: clang/lib/Format/TokenAnnotator.cpp:4162 +return FormatStyle::PAS_Middle; + } +} you are missing a return value here

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

fhahn added inline comments. Comment at: clang/docs/LanguageExtensions.rst:535 + int d = 12; + a = a + c; + return a * d; Is there any reason we use variables for the scalars? If not, it might be good to keep the examples as compact as possible. U

[clang] 05e95d2 - [clang][AST] Set correct DeclContext in ASTImporter lookup table for template params.

Author: Balázs Kéri Date: 2021-06-17T11:20:27+02:00 New Revision: 05e95d2dd74973dd5163b7d44828fac61e416452 URL: https://github.com/llvm/llvm-project/commit/05e95d2dd74973dd5163b7d44828fac61e416452 DIFF: https://github.com/llvm/llvm-project/commit/05e95d2dd74973dd5163b7d44828fac61e416452.diff L

[PATCH] D103792: [clang][AST] Set correct DeclContext in ASTImporter lookup table for template params.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05e95d2dd749: [clang][AST] Set correct DeclContext in ASTImporter lookup table for template… (authored by balazske). Repository: rG LLVM Github Mo

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

vsavchenko updated this revision to Diff 352652. vsavchenko added a comment. Move IdentityHandler into the anonymous namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104136/new/ https://reviews.llvm.org/D104136 Files: clang/lib/StaticAnal

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

sammccall added a comment. I think the layering can be improved here. The CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98710/new/ https://reviews.llvm.org/D98710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp:945-947 +ExprEngine &Eng = C.getStateManager().getOwningEngine(); +// Let's mark this place with a special tag. +Tag = Eng.getDataTags().make(CE,

[PATCH] D104311: [clang] Fix a race condition in the build of clangInterpreter

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Thanks, @stella.stamenova! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104311/new/ https://reviews.llvm.org/D104311 _

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

HazardyKnusperkeks added a comment. In D102706#2823087 , @vlovich wrote: > I don't think I have permissions. Happy to do it if I'm given permissions > (I'm assuming the instructions are the general LLVM ones). Otherwise: > > Name: Vitali Lovich > E-mail:

[PATCH] D103855: [clang] Exclude function pointers on DefaultedComparisonAnalyzer

mizvekov updated this revision to Diff 352667. mizvekov added a comment. Instead of excluding function pointers from the overload set, just implicitly delete with new diagnostic in case we end up selecting it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

vsavchenko added a comment. I think this iteration is much better, it requires way more description as it has now. You didn't actually describe anywhere how this algorithm actually works. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:200-201 +} + +

[PATCH] D99439: Update @llvm.powi to handle different int sizes for the exponent

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99439/new/ https://reviews.llvm.org/D99439 _

[PATCH] D104291: [Debug-Info] strict dwarf for DW_LANG_C_plus_plus_14

shchenz added a comment. In D104291#2821581 , @stuart wrote: >> There is no `CPlusPlus03` in `LangOptions`, so it is better not to merge >> `DW_LANG_C_plus_plus_03` support with D99250 >> . > > Oh - I see, `c++03` is def

[PATCH] D104291: [Debug-Info] strict dwarf for DW_LANG_C_plus_plus_14

dblaikie added a comment. In D104291#2823594 , @shchenz wrote: > In D104291#2821581 , @stuart wrote: > >>> There is no `CPlusPlus03` in `LangOptions`, so it is better not to merge >>> `DW_LANG_C_plus_plus_03` sup

[PATCH] D99439: Update @llvm.powi to handle different int sizes for the exponent

bjope added a comment. In D99439#2823338 , @efriedma wrote: > LGTM Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99439/new/ https://reviews.llvm.org/D99439

[PATCH] D104040: [OpenCL] Add TableGen emitter for OpenCL builtin header

azabaznov accepted this revision. azabaznov added a comment. This revision is now accepted and ready to land. Thanks for working on this! That's cool, I managed to reproduce something similar to https://reviews.llvm.org/D99577. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

vsavchenko added a comment. OK, about the quadratic algorithm. I can think of one solution that is actually linear asymptotically, but because of the constant factor can be worse in practice (we usually have extremely small range sets). So, while I don't like it, it's probably fine. ==

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

sammccall added a comment. Sorry, previous sent too soon. +hokein as I'll be out next week. I think we should be careful about which layers the filtering logic is added to, and how much surface area it has. The minimal thing seems to be adding the clang-tidy options, and modifying the AST-cons

[PATCH] D102689: [C++] Ignore top-level qualifiers in casts

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! I think the diagnostic wording can be improved separately if it's considered important as it seems this issue already existed. I suggest adding `[Sema]` tag in your final

[PATCH] D104040: [OpenCL] Add TableGen emitter for OpenCL builtin header

Anastasia accepted this revision. Anastasia added a comment. Do you think we could add any test for this yet? Or do we have to wait until we have other pieces in place for diffing to `opencl-c.h`? We could add a test for parsing the header but it is probably going to be very slow test? Reposit

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

azabaznov updated this revision to Diff 352681. azabaznov added a comment. Set SPIR target for added test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103911/new/ https://reviews.llvm.org/D103911 Files: clang/lib/Sema/SemaType.cpp clang/test/

[PATCH] D104376: [clangd] Correct SelectionTree behavior around anonymous field access.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Selection.cpp:71 + // so we reduce its range to match the CXXConstructExpr. + // (It's not clear that changing the clang AST would

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

ASDenysPetrov added a comment. @vsavchenko Repled in inlines. Preparing an update. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:245-246 +/// +/// Complexity: O(N^2) +/// where N = size(What) +RangeSet c

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

ASDenysPetrov added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:245-246 +/// +/// Complexity: O(N^2) +/// where N = size(What) +RangeSet castTo(RangeSet What, APSIntType Ty); ---

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

vsavchenko added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:245-246 +/// +/// Complexity: O(N^2) +/// where N = size(What) +RangeSet castTo(RangeSet What, APSIntType Ty); --

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103911/new/ https://reviews.llvm.org/D103911 __

[PATCH] D104455: [clangd] Explicitly fail if the file passed to --check is not valid.

hokein created this revision. hokein added a reviewer: adamcz. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:692 + ContainerType Result; + ContainerType RHS; + ASDenysPetrov wrote: > vsavchenko wrote: > > We have LHS (left-hand side) and RHS (right-hand side) as a co

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:953-957 + // Let's traverse... + for (const ExplodedNode *N = ExprNode; + // ...all the nodes corresponding to the given expression..

[PATCH] D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003)

hans updated this revision to Diff 352695. hans marked 2 inline comments as done. hans added a comment. Herald added a subscriber: ormris. More tests, add help text for command-line options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104387/new/ https://reviews.llvm.org/D104387 File

[PATCH] D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003)

hans added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:1255 +} + } + thakis wrote: > `/external:env` should happen after winsysroot I think. sysroots try to make > builds hermetic and env vars defeat that. > > I.e. this flag is more l

[PATCH] D104351: [HeaderSearch] Use `isImport` only for imported headers and not for `#pragma once`.

jansvoboda11 added a comment. This seems reasonable on first look. Can you add a test that demonstrates the problem this patch solves? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104351/new/ https://reviews.llvm.org/D104351

[PATCH] D104459: [clang][lex] Ensure minimizer output is never larger than input

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch ensures the output of source minimizer is never larger than the inpu

[PATCH] D104460: [clang][lex] NFC: Extract source variable in minimizer tests

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch extracts the to-be-minimized source strings into variables. This wil

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ABataev added a comment. In D102107#2823706 , @jdoerfert wrote: > In D102107#2821976 , @ABataev wrote: > >> We used this kind of codegen initially but later found out that it causes a >> large overhead when gathe

[PATCH] D103793: [Clang][OpenMP] Monotonic does not apply to SIMD

huntergr added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103793/new/ https://reviews.llvm.org/D103793 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang updated this revision to Diff 352560. NeHuang added a comment. - Add AIX 32&64 bit run line checks (front and back end test cases) - Create builtin-ppc-xlcompat-error.c for arguments related error check, add error test case for `__builtin_ppc_cmprb` - Remove 32 bit linux run line checks -

[PATCH] D103793: [Clang][OpenMP] Monotonic does not apply to SIMD

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103793/new/ https://reviews.llvm.org/D103793 ___

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

lei added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:354 - void defineXLCompatMacros(MacroBuilder &Builder) const { -Builder.defineMacro("__popcntb", "__builtin_ppc_popcntb"); Can you pleases rebase your patch again? The removal of this fu

[PATCH] D104040: [OpenCL] Add TableGen emitter for OpenCL builtin header

svenvh added a comment. In D104040#2824281 , @Anastasia wrote: > Do you think we could add any test for this yet? Or do we have to wait until > we have other pieces in place for diffing to `opencl-c.h`? We could add a > test for parsing the header but i

[PATCH] D104424: [Sema] Fix for PR50741

chrish_ericsson_atx updated this revision to Diff 352711. chrish_ericsson_atx edited the summary of this revision. chrish_ericsson_atx added a comment. Addressed review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104424/new/ https://revi

[PATCH] D104424: [Sema] Fix for PR50741

erichkeane accepted this revision. erichkeane added a comment. Yep, that works, still approved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104424/new/ https://reviews.llvm.org/D104424 ___ cfe-commits

[PATCH] D104424: [Sema] Fix for PR50741

chrish_ericsson_atx marked 2 inline comments as done. chrish_ericsson_atx added a comment. Thanks for the hints, @erichkeane ! Especially thanks for pointing out the root cause early on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104424/new/ h

[clang] fc6ec9b - [Sema] Fix for PR50741

Author: eahcmrh Date: 2021-06-17T16:16:59+02:00 New Revision: fc6ec9b98cf96bca8f68cc65395f861919c06c2f URL: https://github.com/llvm/llvm-project/commit/fc6ec9b98cf96bca8f68cc65395f861919c06c2f DIFF: https://github.com/llvm/llvm-project/commit/fc6ec9b98cf96bca8f68cc65395f861919c06c2f.diff LOG:

[PATCH] D104424: [Sema] Fix for PR50741

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc6ec9b98cf9: [Sema] Fix for PR50741 (authored by chrish_ericsson_atx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D104424: [Sema] Fix for PR50741

chrish_ericsson_atx added a comment. Delivered as rGfc6ec9b98cf9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104424/new/ https://reviews.llvm.org/D104424

[PATCH] D104462: [clang][lex] Add minimizer option to pad the output to the input size

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a configuration point to the source minimizer to pad the output

[PATCH] D104460: [clang][lex] NFC: Extract source variable in minimizer tests

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Found a way to do the thing in a follow up with less churn. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104460/new/ https://reviews.llvm.org/D104460 ___

[clang-tools-extra] 6765b9c - [clangd] Explicitly fail if the file passed to --check is not valid.

Author: Haojian Wu Date: 2021-06-17T16:41:06+02:00 New Revision: 6765b9c3f1192bd63bdcafc92ee8ff5d7b97d90b URL: https://github.com/llvm/llvm-project/commit/6765b9c3f1192bd63bdcafc92ee8ff5d7b97d90b DIFF: https://github.com/llvm/llvm-project/commit/6765b9c3f1192bd63bdcafc92ee8ff5d7b97d90b.diff LO

[PATCH] D104455: [clangd] Explicitly fail if the file passed to --check is not valid.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6765b9c3f119: [clangd] Explicitly fail if the file passed to --check is not valid. (authored by hokein). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

azabaznov updated this revision to Diff 352723. azabaznov added a comment. Restructured test, added comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103191/new/ https://reviews.llvm.org/D103191 Files: clang/include/clang/Basic/OpenCLOption

[PATCH] D104465: [clang][deps] Prevent PCH validation failures by padding minimized files

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes dependency scanning of a TU with prebuilt modular/PCH dependen

[PATCH] D104459: [clang][lex] Ensure minimizer output is never larger than input

jansvoboda11 updated this revision to Diff 352726. jansvoboda11 added a comment. Fix assert wording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104459/new/ https://reviews.llvm.org/D104459 Files: clang/lib/Lex/DependencyDirectivesSourceMinimiz

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

jansvoboda11 added a comment. I don't have any comments regarding header maps. Comment at: clang/test/Modules/implicit-module-header-maps.cpp:17 +// +// RUN: sed -e "s:OUTPUTS_DIR:%t:g" %S/Inputs/implicit-module-header-maps/b.hmap.json > %t/hmap.json +// RUN: %hmaptool write %

[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

predator5047 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103929/new/ https://reviews.llvm.org/D103929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D103962: [C++4OpenCL] Fix qualifiers check on binding references to temporaries

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Yes it seems the only situation where the check would evaluate to a different value with and without your patch is when we have `RefRelationship == Sema::Ref_Related` as false whil

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg updated this revision to Diff 352740. andrewjcg added a comment. fix sed for windows test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp clang/test/Mod

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay updated this revision to Diff 352744. MyDeveloperDay added a comment. I have reworked this patch to utilise the fact that clang-format can format a JSON object in javascript reasonably well. This technique adds for JSON files only a replacement to the front of the JSON transformi

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay updated this revision to Diff 352750. MyDeveloperDay added a comment. Missing new test file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93528/new/ https://reviews.llvm.org/D93528 Files: clang/docs/ClangFormat.rst clang/docs/ClangFormatStyleOptions.rst clang/inclu

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGen/thinlto-cfi-icall-static-inline-asm.c:3 + +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm-bc -flto=thin -fsanitize=cfi-icall -f

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski updated this revision to Diff 352753. skirkovski added a comment. Rebase and fix warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://reviews.llvm.org/D104096 Files: clang/docs/ClangFormatStyleOptions.rst clang/

[PATCH] D104376: [clangd] Correct SelectionTree behavior around anonymous field access.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:71 + // so we reduce its range to match the CXXConstructExpr. + // (It's not clear that changing the clang AST would be correct in general). + if (const auto *ME = N.get()) { h

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski marked 5 inline comments as done. skirkovski added a comment. Rebased and fixed warning. My local compiler was yelling at me for adding a default case to switch which already covers everything. For the commit: Author: Seraphime Kirkovski email: skirkovski at vmware.com Repository:

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay updated this revision to Diff 352773. MyDeveloperDay added a comment. JSON strings can't be split when the line is too long like c++ strings CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93528/new/ https://reviews.llvm.org/D93528 Files: clang/docs/ClangFormat.rst cla

[clang] 734d688 - [clang] Fix a race condition in the build of clangInterpreter

Author: Stella Stamenova Date: 2021-06-17T10:03:33-07:00 New Revision: 734d688fbce8a453aa61764b9b5a43b26455dc0d URL: https://github.com/llvm/llvm-project/commit/734d688fbce8a453aa61764b9b5a43b26455dc0d DIFF: https://github.com/llvm/llvm-project/commit/734d688fbce8a453aa61764b9b5a43b26455dc0d.di

[PATCH] D104311: [clang] Fix a race condition in the build of clangInterpreter

This revision was automatically updated to reflect the committed changes. Closed by commit rG734d688fbce8: [clang] Fix a race condition in the build of clangInterpreter (authored by stella.stamenova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

jdoerfert updated this revision to Diff 352776. jdoerfert added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101976/new/ https://reviews.llvm.org/D101976 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/CodeGen/C

[clang] 4e2aee8 - [AIX] Remove --as-needed passing into aix linker

Author: jasonliu Date: 2021-06-17T17:16:41Z New Revision: 4e2aee8d3bab6010420d9be96480f1d8ae0f35c1 URL: https://github.com/llvm/llvm-project/commit/4e2aee8d3bab6010420d9be96480f1d8ae0f35c1 DIFF: https://github.com/llvm/llvm-project/commit/4e2aee8d3bab6010420d9be96480f1d8ae0f35c1.diff LOG: [AIX

[PATCH] D104314: [AIX] Remove --as-needed passing into aix linker

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e2aee8d3bab: [AIX] Remove --as-needed passing into aix linker (authored by jasonliu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha updated this revision to Diff 352783. SaurabhJha added a comment. Address comment: replace scalar variables by values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D104198 Files: clang/docs/Languag

[PATCH] D104285: [analyzer] Retrieve value by direct index from list initialization of constant array declaration.

chrish_ericsson_atx added a comment. In D104285#2823305 , @chrish_ericsson_atx wrote: > I'm not sure about whether or not this patch would only work for constant > arrays with initializer lists. If it does only work for such arrays, then I > wonder wh

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

dexonsmith added a subscriber: arphaman. dexonsmith added a comment. In D103930#2820725 , @bruno wrote: > Thanks for working on this, comments inline. @vsapsai @jansvoboda11 > @dexonsmith any headermap related concerns on your side? @jansvoboda11, I thi

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99381/new/ https://reviews.llvm.org/D99381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D103544: [compiler-rt][Fuchsia] Disable interceptors while enabling new/delete replacements

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103544/new/ https://reviews.llvm.org/D103544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

leonardchan added a comment. *ping* Anything else that should be updated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103936/new/ https://reviews.llvm.org/D103936 ___ cfe-commits mailing list cfe-commi

[PATCH] D104381: [analyzer] Added a test case for PR46264

NoQ added a comment. Thanks! I guess there might be some value in building an older Clang from around when the bug was reported so that to see if the crash was indeed there and we're not just reproducing it wrong. It would also allow us to understand where we fixed it through bisecting. But I

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

nickdesaulniers created this revision. nickdesaulniers added reviewers: MaskRay, melver, void, davidxl, vsk, phosek. Herald added a reviewer: aaron.ballman. Herald added subscribers: wenlei, jdoerfert. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

NoQ added inline comments. Comment at: clang/test/Analysis/smart-ptr-text-output.cpp:3 +// RUN: -analyzer-checker=core,cplusplus.Move,alpha.cplusplus.SmartPtr\ +// RUN: -analyzer-config cplusplus.SmartPtrModeling:ModelSmartPtrDereference=true\ +// RUN: -analyzer-output=text -

[PATCH] D104459: [clang][lex] Ensure minimizer output is never larger than input

dexonsmith added a comment. > This patch ensures the output of source minimizer is never larger than the > input. This property will be handy in a follow up patch that makes it > possible to pad the minimized output to the size of the original input. I suppose when I wrote first wrote this I wa

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. Jotting down driver to front end flag translations: -fprofile-generate -> -fprofile-instrument=llvm -fprofile-instr-generate -> -fprofile-instrument=clang -fcs-profile-generate -> -fprofile-instrument=csllvm -fprofile-arcs

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

stella.stamenova added a comment. We still occasionally (every couple of runs) see these tests hang on Windows in both Debug and Release. Unfortunately, I don't have access to the machines running the tests to debug the tests while they are hanging and I haven't had a chance to try to reproduce

  1   2   >