svenvh added a comment. In D104040#2824281 <https://reviews.llvm.org/D104040#2824281>, @Anastasia wrote:
> Do you think we could add any test for this yet? Or do we have to wait until > we have other pieces in place for diffing to `opencl-c.h`? We could add a > test for parsing the header but it is probably going to be very slow test? The question is what we actually want to test at this point? I am wondering if it would make more sense to work towards equivalence of `opencl-c.h` and the generated header file. We can prove equivalence offline, as a one-off without needing to commit changes to the AST printer. If they are equivalent, we can commit the generated header file in place of `opencl-c.h`. After that, adding a test for diffing both should be fairly trivial. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104040/new/ https://reviews.llvm.org/D104040 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
