[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:657-667 + // Certain kinds unfortunately need to be side-stepped for canonical type + // matching. + if (LType->getAs() || RType->getAs()) { +// Unfortun

[PATCH] D102822: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1327 + if (Size.isScalable()) +Size = llvm::TypeSize::Fixed(-1); + Instead of updating `Size` here, can you change line 1332 to be: llvm::Value *SizeV = llvm::ConstantInt::get(Int64

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

courbet added inline comments. Comment at: clang/include/clang/Basic/Module.h:98 public: + Module(const Module &) = default; + gchatelet wrote: > gchatelet wrote: > > fhahn wrote: > > > how is this related? > > > how is this related? > > > > I'm glad you ask!

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

mstorsjo added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4364-4365 // MS x64 ABI requirement: "Any argument that doesn't fit in 8 bytes, or is // not 1, 2, 4, or 8 bytes, must be passed by reference." if (isAggregateTypeForABI(Ty) || Ty->isMemberPoi

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

LuoYuanke added a comment. We may add description on the intrinsic in docs/LangRef.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99675/new/ https://reviews.llvm.org/D99675 ___ cfe-commits mailing li

[PATCH] D103434: [analyzer] Allow visitors to run callbacks on completion

balazske added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:95 + /// This method is run once the \ref Stop method is called. + virtual void OnStop(const ExplodedNode *Curr, BugReporterContext &BRC, +

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:737-740 +const auto End = Contexts.rbegin() + 2; +auto Last = Contexts.rbegin(); +unsigned Depth = 0; +for (; Last != End; Last = std::next(Last)) { I actual

[PATCH] D103589: [Format] Fix incorrect pointer detection

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Seems reasonable. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103589/new/ https://reviews.llvm.org/D103589 ___ cfe-comm

[clang] e237168 - Revert "[Fuchsia] Use libc++abi on Windows in Fuchsia toolchain"

Author: Petr Hosek Date: 2021-06-03T01:18:22-07:00 New Revision: e237168341ed9688ee70277465a488b6f4b8ba03 URL: https://github.com/llvm/llvm-project/commit/e237168341ed9688ee70277465a488b6f4b8ba03 DIFF: https://github.com/llvm/llvm-project/commit/e237168341ed9688ee70277465a488b6f4b8ba03.diff LO

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

vsavchenko added a comment. I also would like to see tests where the ranges are not going all the way to either `INT_MIN` or `INT_MAX` (if we talk about `int`), but overflow still might happen, and cases where overflow might happen, but we still can identify the overflowing results precisely (e

[PATCH] D103595: [clang] Correct MarkFunctionReferenced for local class

futogergely created this revision. futogergely added a reviewer: rsmith. futogergely requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Minor correction after commit 4a941e25f2b57f85eef00a9cbfbc2569639570ad. If during the instantiation of a l

[PATCH] D103595: [clang] Correct MarkFunctionReferenced for local class

futogergely updated this revision to Diff 349480. futogergely added a comment. formatting in instantiate-local-class.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103595/new/ https://reviews.llvm.org/D103595 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaTemplate/instantiate

[clang] 178ad93 - [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

Author: Dmitry Polukhin Date: 2021-06-03T01:37:55-07:00 New Revision: 178ad93e3f1f2381f05baea300873ee5998ac288 URL: https://github.com/llvm/llvm-project/commit/178ad93e3f1f2381f05baea300873ee5998ac288 DIFF: https://github.com/llvm/llvm-project/commit/178ad93e3f1f2381f05baea300873ee5998ac288.dif

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rG178ad93e3f1f: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin added a comment. @bruno and @dexonsmith thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103142/new/ https://reviews.llvm.org/D103142 ___ cfe-commits mailing list cf

[PATCH] D103028: [clang][ARM] Remove arm2/3/6/7m CPU names

DavidSpickett updated this revision to Diff 349487. DavidSpickett added a comment. Clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103028/new/ https://reviews.llvm.org/D103028 Files: clang/test/Misc/target-invalid-cpu-note.c llvm/in

[PATCH] D103028: [clang][ARM] Remove arm2/3/6/7m CPU names

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4543dce5db5: [clang][ARM] Remove arm2/3/6/7m CPU names (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] f4543dc - [clang][ARM] Remove arm2/3/6/7m CPU names

Author: David Spickett Date: 2021-06-03T08:55:44Z New Revision: f4543dce5db585f2b37f39145ad3fa34b6c75b0e URL: https://github.com/llvm/llvm-project/commit/f4543dce5db585f2b37f39145ad3fa34b6c75b0e DIFF: https://github.com/llvm/llvm-project/commit/f4543dce5db585f2b37f39145ad3fa34b6c75b0e.diff LOG

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

mstorsjo updated this revision to Diff 349491. mstorsjo added a comment. Updated to not require the types to be either `isAggregateTypeForABI(Ty)` or `Ty->isMemberPointerType()`, just check the size of the type, added a testcase for `__int128` (which I tested against GCC). Repository: rG LLV

[clang] dcd7664 - Add -fno-visibility-inlines-hidden option

Author: Yi Kong Date: 2021-06-03T17:07:53+08:00 New Revision: dcd7664f92d30f93a4c7d48314d653e044093784 URL: https://github.com/llvm/llvm-project/commit/dcd7664f92d30f93a4c7d48314d653e044093784 DIFF: https://github.com/llvm/llvm-project/commit/dcd7664f92d30f93a4c7d48314d653e044093784.diff LOG:

[PATCH] D103537: [clang][driver] Add -fno-visibility-inlines-hidden option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdcd7664f92d3: Add -fno-visibility-inlines-hidden option (authored by kongyi). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D103231: [clang][AST] Set correct DeclContext in ASTImporter lookup table for ParmVarDecl.

balazske updated this revision to Diff 349496. balazske marked an inline comment as done. balazske added a comment. Added `contains` for correct check of `ASTImporterLookupTable` content. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103231/new/ ht

[PATCH] D103386: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++

bjope added inline comments. Comment at: clang/test/CodeGen/ppc-xmmintrin.c:10 // RUN: -fno-discard-value-names -mllvm -disable-llvm-optzns -o - | llvm-cxxfilt -n | FileCheck %s --check-prefixes=CHECK,CHECK-LE +// RUN: %clang -x c++ -fsyntax-only -target powerpc64le-unknown-l

[PATCH] D103603: [Sema][RISCV] Allow ?: to select Typedef BuiltinType in C

arcbbb created this revision. arcbbb added reviewers: rsandifo-arm, efriedma, sdesmalen, rovka, rjmccall, rengolin, HsiangKai, craig.topper. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D103595: [clang] Correct MarkFunctionReferenced for local class

futogergely updated this revision to Diff 349508. futogergely added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103595/new/ https://reviews.llvm.org/D103595 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaTemplate/instantiate-local-class.cpp Index: cla

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D101156: [Clang] Support a user-defined __dso_handle

asavonic added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101156/new/ https://reviews.llvm.org/D101156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D103603: [Sema][RISCV] Allow ?: to select Typedef BuiltinType in C

kito-cheng added a comment. Testcase for AArch64/SVE: #include svint8_t a(); __SVInt8_t b(); svint8_t foo(int cond){ return cond ? a(): b(); } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103603/new/ https://reviews.llvm.org/

[PATCH] D103603: [Sema][RISCV] Allow ?: to select Typedef BuiltinType in C

kito-cheng added a comment. The testcase I provided in last comment could be compile successfully with aarch64-gcc, but failed on clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103603/new/ https://reviews.llvm.org/D103603 __

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

vsavchenko updated this revision to Diff 349511. vsavchenko added a comment. Add docstring for StoreHandler Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103605/new/ https://reviews.llvm.org/D103605 Files: clang/include/clang/StaticAnalyzer/Core

[PATCH] D103603: [Sema][RISCV] Allow ?: to select Typedef BuiltinType in C

rsandifo-arm added a comment. Thanks for the fix. I agree this is the right behaviour FWIW. I held off approving it in case there's another idiom that's preferred when comparing canonical types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1036

[PATCH] D103434: [analyzer] Allow visitors to run callbacks on completion

vsavchenko added a comment. I was thinking a lot about this problem after our last call, and even though `StoppableVisitor` helps to solve the problem that we have, it is extremely unclear when this callback is called and should be called. I decided to restore the balance (and rid of all youngli

[PATCH] D103603: [Sema][RISCV] Allow ?: to select Typedef BuiltinType in C

frasercrmck added a comment. In D103603#2795899 , @kito-cheng wrote: > Testcase for AArch64/SVE: > > #include > > svint8_t a(); > __SVInt8_t b(); > > svint8_t foo(int cond){ > return cond ? a(): b(); > } Could that AArch64 test also

[PATCH] D103434: [analyzer] Allow visitors to run callbacks on completion

RedDocMD added a comment. In D103434#2795940 , @vsavchenko wrote: > I was thinking a lot about this problem after our last call, and even though > `StoppableVisitor` helps to solve the problem that we have, it is extremely > unclear when this callback

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. In D100581#2792854 , @Abpostelnicu wrote: > I think there is a false positive with this @george.burgess.iv: > In this >

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

sberg added a comment. Is it intentional that this warns about volatile variables as in void f(char * p) { volatile char c = 0; c ^= *p; } (I see that GCC warns about volatile too, at least when you replace the `^=` with `=`, so assume the answer is "yes", but would just like to

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

jrtc27 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5216-5220 +if (toolchains::RISCVToolChain::hasGCCToolchain(*this, Args)) + TC = + std::make_unique(*this, Target, Args); +else + TC = std::make_unique(*this, Targ

[PATCH] D103603: [Sema][RISCV] Allow ?: to select Typedef BuiltinType in C

jrtc27 requested changes to this revision. jrtc27 added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Sema/SemaExpr.cpp:8397 + if (LHSTy->isSizelessBuiltinType() && + (Context.getCanonicalType(LHSTy) == Context.getCanonicalType(RHSTy)

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

mstorsjo updated this revision to Diff 349517. mstorsjo added a comment. Updated the CodeGenCXX/ext-int.cpp testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103452/new/ https://reviews.llvm.org/D103452 Files: clang/lib/CodeGen/TargetInfo.

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5216-5220 +if (toolchains::RISCVToolChain::hasGCCToolchain(*this, Args)) + TC = + std::make_unique(*this, Target, Args); +else + TC = std::make_unique(*this, Targe

[PATCH] D103589: [Format] Fix incorrect pointer detection

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this! Do you have commit rights or you need somebody to land it for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

jrtc27 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5216-5220 +if (toolchains::RISCVToolChain::hasGCCToolchain(*this, Args)) + TC = + std::make_unique(*this, Target, Args); +else + TC = std::make_unique(*this, Targ

[PATCH] D103082: [AArch64][SVE] Improve codegen for dupq SVE ACLE intrinsics

bsmith updated this revision to Diff 349525. bsmith added a comment. - Use !isZero() in place of getZExtValue() != 0 - Add end to end tests for ptrue transformation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103082/new/ https://reviews.llvm.org/

[PATCH] D103611: Correct the behavior of va_arg checking in C++

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, eli.friedman, rjmccall. aaron.ballman requested review of this revision. Herald added a project: clang. Clang checks whether the type given to `va_arg` will automatically cause undefined behavior, but this check was issui

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity added a comment. There was a bit of talk on Twitter recently about strong typing which reminded me of this checker! 😁 I'll fix all issues in one go once we're through with all the comments, I'd like to see the full picture of what needs to be done. Repository: rG LLVM Github Monor

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

pengfei added a comment. We found another crush: https://godbolt.org/z/vcbvddEKr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing list cfe-

[PATCH] D103231: [clang][AST] Set correct DeclContext in ASTImporter lookup table for ParmVarDecl.

martong added a comment. In D103231#2795794 , @balazske wrote: > Added `contains` for correct check of `ASTImporterLookupTable` content. Okay, that looks good, but I just realized we should not have "bare" assertions. Could you please add some explanato

[PATCH] D103039: [AST] fully-qualify template args of outer types in getFullyQualifiedType

victordk added a comment. In D103039#2793776 , @saugustine wrote: > This is a long-standing bug that needed to be fixed. Thank you! Could you commit the patch? I don't think I have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

zahiraam added a comment. In D80344#2796066 , @pengfei wrote: > We found another crush: https://godbolt.org/z/vcbvddEKr Even smaller https://godbolt.org/z/dbrGjGbaf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D103612: [flang][driver] Add `-fno-unparse-typed-exprs`

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds new option for the new Flang driver: `-fno-unparse-typed-exprs

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

vsavchenko updated this revision to Diff 349529. vsavchenko added a comment. Tweak some parts of the interface Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103605/new/ https://reviews.llvm.org/D103605 Files: clang/include/clang/StaticAnalyzer/C

[PATCH] D103613: [flang][driver] Add support for `-module-suffix`

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This option is required in order to call `flang-new` from the `flang` bash scr

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

martong added a comment. Great initiative! You haven't mention `markInteresting` functions, but I think it would be really important to incorporate that functionality here as well. IMHO, `markInteresting` shouldn't have been part of the public API ever, Checkers should have been calling only th

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

martong added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:122 #define FB(Name, K) MIX_##Name = (1ull << (K##ull - 1ull)) FB stands for FunnyBitmask? Could you please either describe that in a comment

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

vsavchenko added a comment. In D103605#2796111 , @martong wrote: > Great initiative! You haven't mention `markInteresting` functions, but I > think it would be really important to incorporate that functionality here as > well. IMHO, `markInteresting` sh

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:657-667 + // Certain kinds unfortunately need to be side-stepped for canonical type + // matching. + if (LType->getAs() || RType->getAs()) { +// Unfortun

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:122 #define FB(Name, K) MIX_##Name = (1ull << (K##ull - 1ull)) martong wrote: > FB stands for FunnyBitmask? Could you please either descri

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

stefanp created this revision. stefanp added reviewers: nemanjai, lei, rsmith. Herald added subscribers: dexonsmith, dang. stefanp requested review of this revision. Herald added a project: clang. Added the option -vector-abi-compat=[default,gcc,xl]. The default behavior for clang is for all vecto

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

vsavchenko updated this revision to Diff 349537. vsavchenko added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103605/new/ https://reviews.llvm.org/D103605 Files: clang/include/clang/StaticAnalyzer/Core/BugRep

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:231 + template + void addExpressionHandlerToTheTop(Args &&... ConstructorArgs) { +addExpressionHandlerToThe

[PATCH] D76287: [analysis][analyzer] Introduce the skeleton of a reaching definitions calculator

whisperity resigned from this revision. whisperity added a comment. Herald added a subscriber: manas. What about this patch? I'm removing my reviewer bit just so it doesn't appear in my list anymore, but if there are any updates, I'll keep myself as a subscriber. 🙂 Repository: rG LLVM Github

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D103587: [AIX] Transfer predefined macros

cebowleratibm requested changes to this revision. cebowleratibm added a comment. This revision now requires changes to proceed. Please rework the test update into init-ppc.c Comment at: clang/lib/Basic/Targets/PPC.cpp:95 Builder.defineMacro("_ARCH_PPC"); + Builder.defineMac

[PATCH] D103457: [analyzer] Add forwarding `addVisitor` method

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92d03c20ea71: [analyzer] Add forwarding `addVisitor` method (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] 92d03c2 - [analyzer] Add forwarding `addVisitor` method

Author: Valeriy Savchenko Date: 2021-06-03T17:10:16+03:00 New Revision: 92d03c20ea71479c78a29da09e377e040d37c3a5 URL: https://github.com/llvm/llvm-project/commit/92d03c20ea71479c78a29da09e377e040d37c3a5 DIFF: https://github.com/llvm/llvm-project/commit/92d03c20ea71479c78a29da09e377e040d37c3a5.d

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

vsavchenko updated this revision to Diff 349548. vsavchenko added a comment. Minor change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103605/new/ https://reviews.llvm.org/D103605 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugRe

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

vsavchenko updated this revision to Diff 349549. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103616/new/ https://reviews.llvm.org/D103616 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Index: c

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

vsavchenko updated this revision to Diff 349550. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103618/new/ https://reviews.llvm.org/D103618 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

vsavchenko added a comment. This one is completely wrong though. Visitor can definitely outlive Tracker, unlike handlers. I need to use some reference-counting solution here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103618/new/ https://revi

[PATCH] D103286: [clang-format] Add PPIndentWidth option

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2674 + /// \endcode + signed PPIndentWidth; + I've replaced this with `int`, because `signed` results in an exception from `dump_format_style.py`. Repository: rG LLVM

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

aganea added a comment. In D80344#2792355 , @tentzen wrote: > Thank you for reporting this . From the callstack it does not seem related > to this patch. It was actually `git bisect` which pointed to me to this patch, it could be a side-effect of it.

[PATCH] D103587: [AIX] Transfer predefined macros

Jake-Egan updated this revision to Diff 349557. Jake-Egan edited the summary of this revision. Jake-Egan added a comment. Removed __THW_PPC__ and moved tests to init-ppc.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103587/new/ https://reviews.ll

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

vsavchenko updated this revision to Diff 349563. vsavchenko added a comment. Fix dangling reference problem Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103618/new/ https://reviews.llvm.org/D103618 Files: clang/include/clang/StaticAnalyzer/Core

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. In D100581#2795966 , @sberg wrote: > Is it intentional that this warns about volatile variables as in Yes, volatile was intentional. Alright, I will add a test for this case. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

martong added a comment. In D103605#2796141 , @vsavchenko wrote: > In D103605#2796111 , @martong wrote: > >> Great initiative! You haven't mention `markInteresting` functions, but I >> think it would be really i

[PATCH] D103587: [AIX] Transfer predefined macros

Jake-Egan updated this revision to Diff 349564. Jake-Egan marked an inline comment as done. Jake-Egan added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103587/new/ https://reviews.llvm.org/D103587 Files: clang/lib/Bas

[PATCH] D103516: [clang][deps] Customize PCM path via -build-dir argument

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm with a few minor changes. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:168-169 +"build-dir", +llvm::cl::desc("With '-generate-modules-path-arg

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

vsavchenko added a comment. In D103605#2796425 , @martong wrote: > In D103605#2796141 , @vsavchenko > wrote: > >> In D103605#2796111 , @martong >> wrote: >> >>> Great in

[PATCH] D103623: [Clang] Test case for -Wunused-but-set-variable, warn for volatile.

mbenfield created this revision. mbenfield added a reviewer: sberg. mbenfield requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was requested by sberg. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103623 Files: c

[PATCH] D103563: [HIP] Fix amdgcn builtin for long type

yaxunl updated this revision to Diff 349566. yaxunl edited the summary of this revision. yaxunl added a comment. Herald added a subscriber: Anastasia. fixed regressions with OpenCL. Use fixed length 64 bit int type instead of long long type CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 3e333cc - [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

Author: Gerhard Gappmeier Date: 2021-06-03T17:55:11+02:00 New Revision: 3e333cc82e42e1e2ecc974d896489eebe1a5edc2 URL: https://github.com/llvm/llvm-project/commit/3e333cc82e42e1e2ecc974d896489eebe1a5edc2 DIFF: https://github.com/llvm/llvm-project/commit/3e333cc82e42e1e2ecc974d896489eebe1a5edc2.d

[clang] 6f605b8 - [clang-format] Add PPIndentWidth option

Author: Gerhard Gappmeier Date: 2021-06-03T17:55:11+02:00 New Revision: 6f605b8d0bc1c19dccc7a6c248b4fa60e6f7fde3 URL: https://github.com/llvm/llvm-project/commit/6f605b8d0bc1c19dccc7a6c248b4fa60e6f7fde3 DIFF: https://github.com/llvm/llvm-project/commit/6f605b8d0bc1c19dccc7a6c248b4fa60e6f7fde3.d

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e333cc82e42: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations (authored by gergap, committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D103286: [clang-format] Add PPIndentWidth option

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f605b8d0bc1: [clang-format] Add PPIndentWidth option (authored by gergap, committed by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D103286?vs=348955&id=349569#toc Repository

[PATCH] D103624: [analyzer] Hide and rename FindLastStoreBRVisitor

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D103563: [HIP] Fix amdgcn builtin for long type

yaxunl added a comment. I got regressions in OpenCL tests since long long int is 128 bit in OpenCL. I switched to use `W` as width modifier in builtin definitions since `W` is for fixed-length 64 bit int type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103563/new/ https://reviews.l

[PATCH] D103519: [clang][deps] Support object files

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:161-162 + std::make_unique()); + PCHContainerOps->registerWriter( + std::

[PATCH] D103628: [analyzer] Turn ReturnVisitor into a tracking visitor

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D103231: [clang][AST] Set correct DeclContext in ASTImporter lookup table for ParmVarDecl.

balazske updated this revision to Diff 349583. balazske added a comment. Added assert messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103231/new/ https://reviews.llvm.org/D103231 Files: clang/include/clang/AST/ASTImporterLookupTable.h

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/test/CodeGen/mingw-long-double.c:56-58 + // GNU32: bitcast i8* %argp.cur to x86_fp80* + // GNU64: bitcast i8* %argp.cur to x86_fp80** + // MSC64: bitcast

[PATCH] D103524: [clang][deps] Handle precompiled headers' AST files

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Comment at: clang/test/ClangScanDeps/modules-pch.c:7 // RUN: %clang -x c-header %t/pch.h -fmodules -gmodules -fimplicit-module-maps \ -// RUN: -fmodules-cache

[PATCH] D103630: [analyzer] Refactor trackRValueExpression into ExpressionHandler

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[clang] 983565a - [ADT] Move DenseMapInfo for ArrayRef/StringRef into respective headers (NFC)

Author: Nikita Popov Date: 2021-06-03T18:34:36+02:00 New Revision: 983565a6fe4a9f40c7caf82b65c650c20dbcc104 URL: https://github.com/llvm/llvm-project/commit/983565a6fe4a9f40c7caf82b65c650c20dbcc104 DIFF: https://github.com/llvm/llvm-project/commit/983565a6fe4a9f40c7caf82b65c650c20dbcc104.diff

[PATCH] D103491: [ADT] Move DenseMapInfo for ArrayRef/StringRef into respective headers (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG983565a6fe4a: [ADT] Move DenseMapInfo for ArrayRef/StringRef into respective headers (NFC) (authored by nikic). Changed prior to commit: https://r

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 349589. feg208 marked 2 inline comments as done. feg208 added a comment. Grabs up some review comments and adds lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added a comment. Got both of these Comment at: clang/lib/Format/TokenAnnotator.cpp:737-740 +const auto End = Contexts.rbegin() + 2; +auto Last = Contexts.rbegin(); +unsigned Depth = 0; +for (; Last != End; Last = std::next(Last)) { Hazard

[PATCH] D103631: [analyzer] Turn TrackControlDependencyCond into a tracking visitor

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D103563: [HIP] Fix amdgcn builtin for long type

tra accepted this revision. tra added a comment. Still LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103563/new/ https://reviews.llvm.org/D103563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D103613: [flang][driver] Add support for `-module-suffix`

awarzynski updated this revision to Diff 349595. awarzynski added a comment. Minor tweaks (different suffix in test, updated help text) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103613/new/ https://reviews.llvm.org/D103613 Files: clang/inclu

  1   2   >