[PATCH] D103543: [compiler-rt][Fuchsia] Support HWASan on Fuchsia

2021-06-02 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. I think this may need to be about the last thing to actually land. It shouldn't land before building the runtime reliably works without error, and I think we should land any refactoring o

[PATCH] D103547: Don't delete the module you're inspecting

2021-06-02 Thread Steven Wu via Phabricator via cfe-commits
steven_wu added a comment. Can you create a new test for clang Driver instead of rewrite the cc1 test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103547/new/ https://reviews.llvm.org/D103547 ___ cfe-c

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

2021-06-02 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D98799#2794366 , @ahatanak wrote: > I don't know know why these fake FunctionDecls are needed, but it looks like > it's okay to avoid creating them. I see a few debug info tests failing if > `GlobalDecl()` instead of a fake f

[clang] 8beaca8 - Remove unused function from a previous iteration of unique-stable-name

2021-06-02 Thread Erich Keane via cfe-commits
Author: Erich Keane Date: 2021-06-02T12:15:16-07:00 New Revision: 8beaca8c1493f576431c3687329860e918616cd9 URL: https://github.com/llvm/llvm-project/commit/8beaca8c1493f576431c3687329860e918616cd9 DIFF: https://github.com/llvm/llvm-project/commit/8beaca8c1493f576431c3687329860e918616cd9.diff L

[PATCH] D103549: [POC] Put annotation strings into debuginfo.

2021-06-02 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Generally arbitrary strings are best avoided where possible owing to lack of structure, type safety, semantics, etc. But they might be suitable here since they're opaque to everything from the frontend to the backend. As for supporting it in DWARF, probably with a cust

[PATCH] D103547: Don't delete the module you're inspecting

2021-06-02 Thread Chris Bieneman via Phabricator via cfe-commits
beanz updated this revision to Diff 349350. beanz added a comment. Breaking out a separate test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103547/new/ https://reviews.llvm.org/D103547 Files: clang/lib/Driver/Driver.cpp clang/test/Modu

[PATCH] D103082: [AArch64][SVE] Improve codegen for dupq SVE ACLE intrinsics

2021-06-02 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Can we add a few end-to-end tests of bool svdupq with constant operands to acle_sve_dupq.c? The pattern matching to create ptrue seems a bit fragile, so I want to make sure we don't break it by accident. Comment at: llvm/lib/Target/AArch64/AArch64Ta

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

2021-06-02 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 349352. martong added a comment. I am terribly sorry, but I uploaded an unfinished Diff previously, please disregard that. So these are the changes: - Add isEqualTo and simplify members to EquivalenceClass Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D103549: [POC] Put annotation strings into debuginfo.

2021-06-02 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. > As for supporting it in DWARF, probably with a custom attribute > (DW_AT_BTF_annotation? (or "LLVM" instead of "BTF" perhaps, I'm not sure)) > with a standard form (DW_FORM_strp/strxN/etc - the usual way we emit strings). This is a good idea. Could you give some

[clang] 13659f4 - PR50337, PR50561: Fix determination of whether a template parameter list

2021-06-02 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2021-06-02T13:06:40-07:00 New Revision: 13659f48a1d7814fe893d2383acdc0b0313740a9 URL: https://github.com/llvm/llvm-project/commit/13659f48a1d7814fe893d2383acdc0b0313740a9 DIFF: https://github.com/llvm/llvm-project/commit/13659f48a1d7814fe893d2383acdc0b0313740a9.diff

[PATCH] D103547: Don't delete the module you're inspecting

2021-06-02 Thread Steven Wu via Phabricator via cfe-commits
steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103547/new/ https://reviews.llvm.org/D103547 _

[clang] d8e0ae9 - [SYCL] Fix __builtin_sycl_unique_stable_name to work on windows/spir

2021-06-02 Thread Erich Keane via cfe-commits
Author: Erich Keane Date: 2021-06-02T13:16:14-07:00 New Revision: d8e0ae9a76a62bdc6117630d59bf9967ac9bb4ea URL: https://github.com/llvm/llvm-project/commit/d8e0ae9a76a62bdc6117630d59bf9967ac9bb4ea DIFF: https://github.com/llvm/llvm-project/commit/d8e0ae9a76a62bdc6117630d59bf9967ac9bb4ea.diff L

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

2021-06-02 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. Yes, I think I can fix that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98799/new/ https://reviews.llvm.org/D98799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

2021-06-02 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D98799#2794546 , @ahatanak wrote: > Yes, I think I can fix that. Thanks a lot! If you could follow-up here when that's committed, I can follow-up with a fix/improvement for the debug info mangling issue we've been discussing

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

2021-06-02 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. I've added a few comments, and I would like to hear the opinion of others regarding the left or right alignment of the elements. Comment at

[PATCH] D103547: Don't delete the module you're inspecting

2021-06-02 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103547/new/ https://reviews.llvm.org/D103547 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D103538: [clangd] Run code completion on each token coverd by --check-lines

2021-06-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM. --- A little bit thinking out loud, was there a particular reason to introduce `--check-line` into ClangdMain.cpp rather than Check.cpp? It feels like we should have --chec

[PATCH] D102822: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

2021-06-02 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/riscv-v-lifetime.cpp:3 +// REQUIRES: riscv-registered-target +// RUN: %clang_cc1 -std=c++11 -triple riscv64 -target-feature +experimental-v \ +// RUN: -emit-llvm -O1 -o - %s | FileCheck %s

[PATCH] D103476: [clangd] TUScheduler uses last active file for file-less queries

2021-06-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 349366. kadircet marked an inline comment as done. kadircet added a comment. Keep using `Path` in `runWithSemaphore`, by substituting `LastActiveFile` when empty. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D103179: [clangd] Handle queries without an originating file in ProjectAwareIndex

2021-06-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet abandoned this revision. kadircet added a comment. in favor of D103476 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103179/new/ https://reviews.llvm.org/D103179 _

[PATCH] D103527: [Clang][RISCV] Implement vlseg and vlsegff.

2021-06-02 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:807 + // intrinsic: (ptr, vl) + SmallVector Operands = {Ops[NF], Ops[NF + 1]}; + llvm::Function *F = CGM.getIntrinsic(ID, IntrinsicTypes); This can be a `llvm

[clang-tools-extra] 6c2a4e2 - [clangd] TUScheduler uses last active file for file-less queries

2021-06-02 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2021-06-02T22:50:24+02:00 New Revision: 6c2a4e28f4d1c0f525c53302c08808c1b4f8073b URL: https://github.com/llvm/llvm-project/commit/6c2a4e28f4d1c0f525c53302c08808c1b4f8073b DIFF: https://github.com/llvm/llvm-project/commit/6c2a4e28f4d1c0f525c53302c08808c1b4f8073b.dif

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

2021-06-02 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4364-4365 // MS x64 ABI requirement: "Any argument that doesn't fit in 8 bytes, or is // not 1, 2, 4, or 8 bytes, must be passed by reference." if (isAggregateTypeForABI(Ty) || Ty->isMemberPointerT

[PATCH] D103476: [clangd] TUScheduler uses last active file for file-less queries

2021-06-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c2a4e28f4d1: [clangd] TUScheduler uses last active file for file-less queries (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D103449: [clangd][Protocol] Drop optional from WorkspaceEdit::changes

2021-06-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 349371. kadircet marked an inline comment as done. kadircet added a comment. Get rid of the special case around empty changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103449/new/ https://reviews.llvm.org

[clang-tools-extra] dc10bf1 - [clangd][Protocol] Drop optional from WorkspaceEdit::changes

2021-06-02 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2021-06-02T22:59:18+02:00 New Revision: dc10bf1a4ed0b34b27284b5260ce5c6cc132bd6f URL: https://github.com/llvm/llvm-project/commit/dc10bf1a4ed0b34b27284b5260ce5c6cc132bd6f DIFF: https://github.com/llvm/llvm-project/commit/dc10bf1a4ed0b34b27284b5260ce5c6cc132bd6f.dif

[PATCH] D103449: [clangd][Protocol] Drop optional from WorkspaceEdit::changes

2021-06-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc10bf1a4ed0: [clangd][Protocol] Drop optional from WorkspaceEdit::changes (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

2021-06-02 Thread Fred Grim via Phabricator via cfe-commits
feg208 marked 6 inline comments as done. feg208 added a comment. I rolled up the suggested changes. Comment at: clang/lib/Format/ContinuationIndenter.cpp:603 State.Column + Spaces + PPColumnCorrection); - // If "BreakBeforeInheritanceComma"

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

2021-06-02 Thread Fred Grim via Phabricator via cfe-commits
feg208 updated this revision to Diff 349373. feg208 marked 2 inline comments as done. feg208 added a comment. Captured review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files: clang/docs/C

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

2021-06-02 Thread Fred Grim via Phabricator via cfe-commits
feg208 updated this revision to Diff 349374. feg208 marked an inline comment as done. feg208 added a comment. Missed a request Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files: clang/docs/ClangForm

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

2021-06-02 Thread Fred Grim via Phabricator via cfe-commits
feg208 added a comment. one remaining Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D103544: [compiler-rt][Fuchsia] Disable interceptors while enabling new/delete replacements

2021-06-02 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: compiler-rt/lib/hwasan/CMakeLists.txt:45 +if (NOT FUCHSIA) + append_list_if(COMPILER_RT_HWASAN_WITH_INTERCEPTORS HWASAN_WITH_INTERCEPTORS=1 HWASAN_DEFINITIONS) +else() mcgrathr wrote: > It might be better to force the v

[PATCH] D103495: [static initializers] Don't put ordered dynamic initializers of static variables into global_ctors

2021-06-02 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added a comment. > The LLVM IR langref says that llvm.global_ctors are called in ascending > priority order, and the order between initializers is not defined. That's not > very helpful and often doesn't reflect reality. I wonder if we could do two > things, perhaps separately: > > 1. emi

[PATCH] D103555: [Fuchsia] Use libc++abi on Windows in Fuchsia toolchain

2021-06-02 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added reviewers: mcgrathr, leonardchan, haowei, gulfem. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Don't use vcruntime, this makes our toolchain more hermet

[PATCH] D103495: [static initializers] Don't put ordered dynamic initializers of static variables into global_ctors

2021-06-02 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In D103495#2794667 , @ychen wrote: > Is there anything preventing us from using the existing priority field to > define the order instead of introducing the order among initializers with the > same priority? If we go with 1., there

[PATCH] D100308: [clangd] Drop optional on ExternalIndexSpec

2021-06-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 349378. kadircet marked an inline comment as done. kadircet added a comment. Add comment to IndexFactory about pre-condition of spec never being none. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100308/new/

[PATCH] D100308: [clangd] Drop optional on ExternalIndexSpec

2021-06-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:555 + case Config::ExternalIndexSpec::None: +break; case Config::ExternalIndexSpec::Server: sammccall wrote: > I think you hit llvm_unreachable here - is this an inva

[PATCH] D100308: [clangd] Drop optional on ExternalIndexSpec

2021-06-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 349379. kadircet added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100308/new/ https://reviews.llvm.org/D100308 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/clangd/Config

[clang-tools-extra] 9e9ac41 - [clangd] Drop optional on ExternalIndexSpec

2021-06-02 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2021-06-02T23:26:37+02:00 New Revision: 9e9ac4138890425b92d2196344ab59305caa32d7 URL: https://github.com/llvm/llvm-project/commit/9e9ac4138890425b92d2196344ab59305caa32d7 DIFF: https://github.com/llvm/llvm-project/commit/9e9ac4138890425b92d2196344ab59305caa32d7.dif

[PATCH] D100308: [clangd] Drop optional on ExternalIndexSpec

2021-06-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e9ac4138890: [clangd] Drop optional on ExternalIndexSpec (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103555: [Fuchsia] Use libc++abi on Windows in Fuchsia toolchain

2021-06-02 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr accepted this revision. mcgrathr added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103555/new/ https://reviews.llvm.org/D103555 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D103184: [AArch64] handle -Wa,-march=

2021-06-02 Thread Jian Cai via Phabricator via cfe-commits
jcai19 marked an inline comment as done. jcai19 added a comment. In D103184#2793055 , @DavidSpickett wrote: > $ cat /tmp/test.s > irg x0, x0 > $ aarch64-unknown-linux-gnu-as -march=armv8.5-a+memtag -march=armv8.1-a > /tmp/test.s -o /dev/null > /

[PATCH] D103495: [static initializers] Don't put ordered dynamic initializers of static variables into global_ctors

2021-06-02 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added a comment. In D103495#2794684 , @rnk wrote: > In D103495#2794667 , @ychen wrote: > >> Is there anything preventing us from using the existing priority field to >> define the order instead of introduci

[clang] b5dd421 - [Fuchsia] Use libc++abi on Windows in Fuchsia toolchain

2021-06-02 Thread Petr Hosek via cfe-commits
Author: Petr Hosek Date: 2021-06-02T14:56:27-07:00 New Revision: b5dd421a3afa0290fddf61073274e2a4aa9a URL: https://github.com/llvm/llvm-project/commit/b5dd421a3afa0290fddf61073274e2a4aa9a DIFF: https://github.com/llvm/llvm-project/commit/b5dd421a3afa0290fddf61073274e2a4aa9a.diff LO

[PATCH] D103555: [Fuchsia] Use libc++abi on Windows in Fuchsia toolchain

2021-06-02 Thread Petr Hosek via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5dd421a3afa: [Fuchsia] Use libc++abi on Windows in Fuchsia toolchain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 07a6beb - [Clang][OpenMP] Emit dependent PreInits before directive.

2021-06-02 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2021-06-02T16:59:35-05:00 New Revision: 07a6beb402150d25ec7c93a5747520ac2804731d URL: https://github.com/llvm/llvm-project/commit/07a6beb402150d25ec7c93a5747520ac2804731d DIFF: https://github.com/llvm/llvm-project/commit/07a6beb402150d25ec7c93a5747520ac2804731d.diff

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

2021-06-02 Thread Michael Kruse via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG07a6beb40215: [Clang][OpenMP] Emit dependent PreInits before directive. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

2021-06-02 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4364-4365 // MS x64 ABI requirement: "Any argument that doesn't fit in 8 bytes, or is // not 1, 2, 4, or 8 bytes, must be passed by reference." if (isAggregateTypeForABI(Ty) || Ty->isMemberPoi

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

2021-06-02 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: mcgrathr, phosek, eugenis, vitalybuka. leonardchan added a project: Sanitizers. Herald added a subscriber: dberris. leonardchan requested review of this revision. Herald added a subscriber: Sanitizers. This moves the implementations f

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

2021-06-02 Thread David Stone via Phabricator via cfe-commits
davidstone added a comment. In D69764#2058590 , @rsmith wrote: > I think that if we are reordering `const`, we should be reordering all > //decl-specifier//s -- I'd like to see `int static constexpr unsigned const > long inline` reordered to something li

[PATCH] D103544: [compiler-rt][Fuchsia] Disable interceptors while enabling new/delete replacements

2021-06-02 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 349399. leonardchan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103544/new/ https://reviews.llvm.org/D103544 Files: compiler-rt/CMakeLists.txt compiler-rt/lib/hwasan/C

[PATCH] D103495: [static initializers] Don't put ordered dynamic initializers of static variables into global_ctors

2021-06-02 Thread Wolfgang Pieb via Phabricator via cfe-commits
wolfgangp added a comment. In D103495#2794329 , @rnk wrote: > +@rsmith @hans @aeubanks > >> specifically when init_array is not used > > Can you elaborate on why that is? Here's what I remember, and what I guess is > happening. ELF has two initializer sc

[PATCH] D103563: [HIP] Fix amdgcn builtin for long type

2021-06-02 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, rjmccall, arsenm, rampitec, b-sumner. Herald added subscribers: kerbowa, nhaehnle, jvesely. yaxunl requested review of this revision. Herald added a subscriber: wdng. Currently some amdgcn builtins are defined with long int type, which cau

[PATCH] D103564: [NFC][compiler-rt][hwasan] Wrap vfork interceptor with HWASAN_WITH_INTERCEPTORS

2021-06-02 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, eugenis, vitalybuka. leonardchan added a project: Sanitizers. Herald added a subscriber: dberris. leonardchan requested review of this revision. Herald added a subscriber: Sanitizers. This prevents emitting the vfork

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

2021-06-02 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 349404. leonardchan edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103562/new/ https://reviews.llvm.org/D103562 Files: compiler-rt/lib/hwasan/hwasan.cpp compiler-rt/li

[PATCH] D103495: [static initializers] Don't put ordered dynamic initializers of static variables into global_ctors

2021-06-02 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In D103495#2794870 , @wolfgangp wrote: > For PS4, we use the .ctors scheme, and so the initialization order was > suddenly reversed, which was not noticed for a while until the user had a > dependency on the previous initialization

[PATCH] D103184: [AArch64] handle -Wa,-march=

2021-06-02 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/test/Driver/aarch64-target-as-march.s:20-25 +/// No unused argument warnings when there are multiple values +// RUN: %clang --target=aarch64-linux-gnueabi -### -c -Wa,-march=armv8.1-a -Wa,-march=armv8.2-a %s 2>&1 | \ +// R

[PATCH] D103565: Fix "control reaches end of non-void function" warnings on ppc64le

2021-06-02 Thread Zhaomo Yang via Phabricator via cfe-commits
zhaomo created this revision. zhaomo added reviewers: ymandel, hokein. Herald added a subscriber: shchenz. zhaomo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103565 Files

[PATCH] D103564: [NFC][compiler-rt][hwasan] Wrap vfork interceptor with HWASAN_WITH_INTERCEPTORS

2021-06-02 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis added a comment. s/vfork/fork/ in the description I'm afraid removing the fork interceptor will break Android. This is a pretty uncommon condition, but still. It is interesting to note that ASan does not have this fork protection, see https://github.com/google/sanitizers/issues/774 for

[PATCH] D103549: [POC] Put annotation strings into debuginfo.

2021-06-02 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D103549#2794462 , @yonghong-song wrote: >> As for supporting it in DWARF, probably with a custom attribute >> (DW_AT_BTF_annotation? (or "LLVM" instead of "BTF" perhaps, I'm not sure)) >> with a standard form (DW_FORM_strp/

[PATCH] D103565: Fix "control reaches end of non-void function" warnings on ppc64le

2021-06-02 Thread Zhaomo Yang via Phabricator via cfe-commits
zhaomo added a comment. Warnings can be found here: https://lab.llvm.org/buildbot/#/builders/76/builds/2640 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103565/new/ https://reviews.llvm.org/D103565 ___

[PATCH] D103549: [POC] Put annotation strings into debuginfo.

2021-06-02 Thread Alexei Starovoitov via Phabricator via cfe-commits
ast added a comment. > Yep LLVM does have some custom attributes and such, eg: > https://github.com/llvm/llvm-project/blob/effb87dfa810a28e763f914fe3e6e984782cc846/llvm/include/llvm/BinaryFormat/Dwarf.def#L592 This is great insight! That should work. We need to make sure that DW_AT_LLVM_annotat

[PATCH] D103565: Fix "control reaches end of non-void function" warnings on ppc64le

2021-06-02 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103565/new/ https://reviews.llvm.org/D103565 __

[clang] 9d070b2 - Recommit "Fix tmp files being left on Windows builds." with a fix for

2021-06-02 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2021-06-02T16:50:37-07:00 New Revision: 9d070b2f4889887f9ce497592ef01df7b9601a1c URL: https://github.com/llvm/llvm-project/commit/9d070b2f4889887f9ce497592ef01df7b9601a1c DIFF: https://github.com/llvm/llvm-project/commit/9d070b2f4889887f9ce497592ef01df7b9601a1c.diff LOG

[PATCH] D103565: Fix "control reaches end of non-void function" warnings on ppc64le

2021-06-02 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. Actually, the removal of the default case in the switch gives this warning: ...llvm-project/clang/lib/ASTMatchers/GtestMatchers.cpp:102:11: warning: enumeration value 'Assert' not handled in switch [-Wswitch] I'll reinstate the default case before comitting the patch.

[PATCH] D103549: [POC] Put annotation strings into debuginfo.

2021-06-02 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. @dblaikie Thanks for the pointer! I will work on the new patch, starting with DW_AT_BTF_annotation (to limit the scope where annotations will be processed) and post a new patch soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang-tools-extra] f976b99 - [clangd] Improve resolution of static method calls in HeuristicResolver

2021-06-02 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2021-06-02T20:30:19-04:00 New Revision: f976b9997ee55a130b139efe7b6e6f3b0384016b URL: https://github.com/llvm/llvm-project/commit/f976b9997ee55a130b139efe7b6e6f3b0384016b DIFF: https://github.com/llvm/llvm-project/commit/f976b9997ee55a130b139efe7b6e6f3b0384016b.diff

[PATCH] D101741: [clangd] Improve resolution of static method calls in HeuristicResolver

2021-06-02 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf976b9997ee5: [clangd] Improve resolution of static method calls in HeuristicResolver (authored by nridge). Repository: rG LLVM Github Monorepo C

[PATCH] D103579: [LTO] Fix -fwhole-program-vtables handling after HIP ThinLTO patch

2021-06-02 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson created this revision. tejohnson added reviewers: yaxunl, tra. Herald added a subscriber: inglorion. tejohnson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A recent change (D99683 ) to support T

[PATCH] D103579: [LTO] Fix -fwhole-program-vtables handling after HIP ThinLTO patch

2021-06-02 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added inline comments. Comment at: clang/test/Driver/hip-options.hip:72 +// HIPTHINLTO-NOT: error: invalid argument '-fwhole-program-vtables' only allowed with '-flto' +// HIPTHINLTO-NOT: clang{{.*}} "-triple" "x86_64-unknown-linux-gnu" {{.*}} "-flto-unit" +// HIPTHIN

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

2021-06-02 Thread Fred Grim via Phabricator via cfe-commits
feg208 updated this revision to Diff 349434. feg208 added a comment. Adds a simple lit test for some sanity checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files: clang/docs/ClangFormatStyleOptio

[clang] b2c8bcb - Fix "control reaches end of non-void function" warnings on ppc64le

2021-06-02 Thread Yitzhak Mandelbaum via cfe-commits
Author: Zhaomo Yang Date: 2021-06-03T00:53:53Z New Revision: b2c8bcbab8a44c4582632845697b9425c3200230 URL: https://github.com/llvm/llvm-project/commit/b2c8bcbab8a44c4582632845697b9425c3200230 DIFF: https://github.com/llvm/llvm-project/commit/b2c8bcbab8a44c4582632845697b9425c3200230.diff LOG: F

[PATCH] D103565: Fix "control reaches end of non-void function" warnings on ppc64le

2021-06-02 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2c8bcbab8a4: Fix "control reaches end of non-void function" warnings on ppc64le (authored by zhaomo, committed by ymandel). Changed prior to commit

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

2021-06-02 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. `OpenMP/tile_codegen_tile_for.cpp` is failing on all our bots, would it be possible to revert the change? FAIL: Clang :: OpenMP/tile_codegen_tile_for.cpp (9951 of 28034) TEST 'Clang :: OpenMP/tile_codegen_tile_for.cpp' FAILED

[PATCH] D103564: [NFC][compiler-rt][hwasan] Wrap vfork interceptor with HWASAN_WITH_INTERCEPTORS

2021-06-02 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr added a comment. I think probably the better refactoring here would be to split this file in two: one containing just the allocation functions; and a second with everything else. On Fuchsia, we'll use the allocation functions but none of the rest of it. So the second whole file could

[clang] 64e5a3b - [clang] Fix fail of OpenMP/tile_codegen_tile_for.cpp.

2021-06-02 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2021-06-02T21:02:05-05:00 New Revision: 64e5a3bbdde25af0fd9f2b9b8539e23f36c80601 URL: https://github.com/llvm/llvm-project/commit/64e5a3bbdde25af0fd9f2b9b8539e23f36c80601 DIFF: https://github.com/llvm/llvm-project/commit/64e5a3bbdde25af0fd9f2b9b8539e23f36c80601.diff

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

2021-06-02 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur added a comment. Instead of reverting, I fixed the test in rG64e5a3bbdde2 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180

[PATCH] D103587: Add AIX predefined macros

2021-06-02 Thread Jake Egan via Phabricator via cfe-commits
Jake-Egan created this revision. Herald added subscribers: jfb, kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103587 Files: clang/lib/Basic/T

[PATCH] D103184: [AArch64] handle -Wa,-march=

2021-06-02 Thread Jian Cai via Phabricator via cfe-commits
jcai19 updated this revision to Diff 349450. jcai19 marked an inline comment as done. jcai19 added a comment. Add a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103184/new/ https://reviews.llvm.org/D103184 Files: clang/lib/Driver/Too

[PATCH] D103386: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++

2021-06-02 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added inline comments. Comment at: clang/test/CodeGen/ppc-xmmintrin.c:10 // RUN: -fno-discard-value-names -mllvm -disable-llvm-optzns -o - | llvm-cxxfilt -n | FileCheck %s --check-prefixes=CHECK,CHECK-LE +// RUN: %clang -x c++ -fsyntax-only -target powerpc64le-unknown-l

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

2021-06-02 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D97183#2794256 , @RedDocMD wrote: > Important question from @vsavchenko: > >> I have two major questions about this implementation: >> >> - Why don't we need an actual check for `IfStmt`? Won't it trigger on `bool >> unused = !poin

[PATCH] D103589: [Format] Fix incorrect pointer detection

2021-06-02 Thread Yilong Guo via Phabricator via cfe-commits
Nuu created this revision. Nuu added a project: clang-format. Nuu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before: void foo() { bar(float(1), a *b); } After: void foo() { bar(float(1), a * b); } Signed-off-by: Yil

[PATCH] D103434: [analyzer] Allow visitors to run callbacks on completion

2021-06-02 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. > Tests to verify that ReturnVisitor actually does what we intend it to do > (call the callback at the right place). You mean write a test that demonstrates that? I guess unless we're willing to wait for the checker to catch up, a good approach to this would be to write a

[PATCH] D103589: [Format] Fix incorrect pointer detection

2021-06-02 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Thanks for looking into this, but please add a test case that demonstrates the bug to `FormatTests.cpp` Also, is there, by any chance, an associated bugzilla ticket? Repository

[PATCH] D103589: [Format] Fix incorrect pointer detection

2021-06-02 Thread Yilong Guo via Phabricator via cfe-commits
Nuu updated this revision to Diff 349455. Nuu edited the summary of this revision. Nuu added a comment. Add test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103589/new/ https://reviews.llvm.org/D103589 Files: clang/lib/Format/Toke

[PATCH] D103589: [Format] Fix incorrect pointer detection

2021-06-02 Thread Yilong Guo via Phabricator via cfe-commits
Nuu added a comment. In D103589#2795447 , @curdeius wrote: > Thanks for looking into this, but please add a test case that demonstrates > the bug to `FormatTests.cpp` > Also, is there, by any chance, an associated bugzilla ticket? Thanks for the co

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

2021-06-02 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. Herald added a subscriber: ormris. > Curiously, using ModFlagBehavior::Error doesn't error if one of two modules > being linked together doesn't have such a module level attribute. Yeah, there's a Require behavior, but that only allows you to specify what the value sh

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

2021-06-02 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:192 + +void HandleTagMismatch(AccessInfo ai, uptr pc, uptr frame, + void *uc, uptr *registers_

<    1   2