[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy added a comment. In D102592#2769811 , @eugenis wrote: > I think it is too hit-and-miss to add even under a flag. It's just not the > right approach - but I also don't know what the right approach would be. > > Perhaps adding a small left redzone fo

[clang-tools-extra] 775ca3a - [clang-tidy] Fix a crash for raw-string-literal check.

Author: Haojian Wu Date: 2021-05-20T09:16:43+02:00 New Revision: 775ca3a89cba104d7c0dc762a0c5c5624c1d397c URL: https://github.com/llvm/llvm-project/commit/775ca3a89cba104d7c0dc762a0c5c5624c1d397c DIFF: https://github.com/llvm/llvm-project/commit/775ca3a89cba104d7c0dc762a0c5c5624c1d397c.diff LO

[PATCH] D102770: [clang-tidy] Fix a crash for raw-string-literal check.

This revision was automatically updated to reflect the committed changes. Closed by commit rG775ca3a89cba: [clang-tidy] Fix a crash for raw-string-literal check. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102770/new/ https:/

[PATCH] D102779: [clang-tidy] cppcoreguidelines-explicit-constructor-and-conversion: new alias

mgartmann updated this revision to Diff 346640. mgartmann edited the summary of this revision. mgartmann added a comment. Added `ConstructorWhitelist` option to the `google-explicit-constructor` check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

aheejin added a comment. In D102791#2769892 , @dschuff wrote: > BTW Is there a way to disable this warning? The warning is like test.cpp:3:6: warning: dynamic exception specifications with types are currently ignored in wasm [-Wwasm-exception-spec]

[PATCH] D102822: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

HsiangKai updated this revision to Diff 346656. HsiangKai added a comment. Update the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102822/new/ https://reviews.llvm.org/D102822 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/C

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet updated this revision to Diff 346657. gchatelet added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Remove dependency on iterable_range header - Simplified implementation, added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

rjmccall added a comment. If these builtins are generally supposed to be accessed through a compiler-provided header, you could make that header define these functions using underlying builtins that have a `__builtin` prefix. That's not completely necessary, though; we do support some other no

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h:36 + +class FindWhereConstrained : public BugReporterVisitor { +private: nit: class name should be a noun (functions and methods are verbs) Comment at: c

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

DavidSpickett added a comment. > If multiple instances of the -arm-implicit-it option is passed to > the backend, it errors out. Does it make sense to fix that side too? Seems like we have a few options to handle this on clang's side: 1. Last of `-mimplicit-it` and `-Wa,-mimplicit-it` wins 2. I

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

HazardyKnusperkeks added a comment. In D102706#2766871 , @vlovich wrote: > In D102706#2766680 , > @HazardyKnusperkeks wrote: > >> Maybe a bit more test cases with smaller lambdas? Or without the outer >> parenth

[PATCH] D102730: [clang-format] Support custom If macros

HazardyKnusperkeks added a comment. Looks good, but please add a test with the `else IF` and just `else` case. Also for me it would be ok to add your `KJ_IF_MAYBE` to the default configuration. But I have no experience on that. Comment at: clang/include/clang/Format/Format.h:

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet updated this revision to Diff 346669. gchatelet added a comment. - Forward argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102760/new/ https://reviews.llvm.org/D102760 Files: clang/include/clang/Basic/Module.h llvm/include/llv

[PATCH] D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr

tomasz-kaminski-sonarsource created this revision. tomasz-kaminski-sonarsource added a reviewer: dcoughlin. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. tomasz-kaminski-sonarsource reques

[PATCH] D102836: [clang] Fix Typo in AST Matcher Reference

mgartmann created this revision. mgartmann added a reviewer: klimek. mgartmann added a project: clang. mgartmann requested review of this revision. In AST Matcher Reference , the example of matcher `hasDeclContext` contained a typo. `cxx

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added a comment. Herald added a subscriber: manas. In D102273#2766531 , @NoQ wrote: > I've just been patching up clang-tidy's infinite loop checker and the problem > sounds s similar. Maybe we should move clang-tidy's alias analysis into

[PATCH] D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr

tomasz-kaminski-sonarsource updated this revision to Diff 346683. tomasz-kaminski-sonarsource added a comment. Added // no warn comment to line that was raising warning before the fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102835/new/ https://reviews.llvm.org/D102835 Files: c

[PATCH] D93565: scan-view: Remove Reporter.py and associated AppleScript files

puremourning added a comment. Unless i'm missing something, this change seems to have broken scan-view, as it now just says "ModuleNotFOundError: No module named 'Reporter'" Due to : `import Reporter` in `ScanView.py` Am i losing my mind? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D93565: scan-view: Remove Reporter.py and associated AppleScript files

puremourning added a comment. In D93565#2770709 , @puremourning wrote: > Unless i'm missing something, this change seems to have broken scan-view, as > it now just says > > "ModuleNotFOundError: No module named 'Reporter'" > > Due to : > > `import Report

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

fhahn added inline comments. Comment at: clang/include/clang/Basic/Module.h:98 public: + Module(const Module &) = default; + how is this related? Comment at: llvm/tools/llvm-xray/xray-converter.cpp:161 struct StackIdData { + StackIdData(con

[clang] 7defab0 - Reapply "[clang][deps] Support inferred modules"

Author: Michael Spencer Date: 2021-05-20T12:41:52+02:00 New Revision: 7defab082070adf3d04b326ba160b029394edc7c URL: https://github.com/llvm/llvm-project/commit/7defab082070adf3d04b326ba160b029394edc7c DIFF: https://github.com/llvm/llvm-project/commit/7defab082070adf3d04b326ba160b029394edc7c.dif

[PATCH] D102495: [clang][deps] Support inferred modules

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/modules-inferred-explicit-build.m:13-15 +// RUN: %clang @%t.inferred.cc1.rsp -pedantic -Werror +// RUN: %clang @%t.system.cc1.rsp -pedantic -Werror +// RUN: %clang -x objective-c -fsyntax-only %t.dir/modules

[PATCH] D102839: [RISCV][Clang] Add -mno-idiv option to disable hardware int division

ksyx created this revision. ksyx added reviewers: asb, rsmith, shiva0217. Herald added subscribers: vkmr, frasercrmck, dang, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, kito-c

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz updated this revision to Diff 346680. shchenz added a comment. 1: use the solution in the FE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. @dblaikie Hi David, should we change to use the FE solution? Maybe we should fix the issue where it happens? We should not let the FE generate the un-strict dwarf tag in FE and then fix it in the BE. I have changed this patch to fix this strict DWARF issue in FE. What d

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

mstorsjo added a comment. In D102812#2770516 , @DavidSpickett wrote: >> If multiple instances of the -arm-implicit-it option is passed to >> the backend, it errors out. > > Does it make sense to fix that side too? I guess it could, although I didn't loo

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

DavidSpickett added a comment. > If case 3 would mean that -mimplicit-it= is ignored when compiling assembly > files, that would indeed break existing use cases. If using the input file > type to disambiguate cases when there's conflicts, then that's fine, although > I'm not sure if there's nee

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet added inline comments. Comment at: clang/include/clang/Basic/Module.h:98 public: + Module(const Module &) = default; + fhahn wrote: > how is this related? > how is this related? I'm glad you ask! I'm still investigating the errors that led to this ad

[PATCH] D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr

Szelethus added a comment. This looks great! Comment at: clang/test/Analysis/NewDelete-checker-test.cpp:41-52 +// RUN: %clang_analyze_cc1 -std=c++17 -fblocks %s \ +// RUN: -verify=expected,newdelete \ +// RUN: -analyzer-checker=core \ +// RUN: -analyzer-checker=cplusplus.

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added a comment. Note: I don't have the right to re-run the failed build/test. I assume that it is not related to my change since the test compile and runs omp code(Static analyzer doesn't run on that test) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100252/new/ https://reviews.llvm.org/D100252 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr

tomasz-kaminski-sonarsource added inline comments. Comment at: clang/test/Analysis/NewDelete-checker-test.cpp:54-57 +// RUN: %clang_analyze_cc1 -std=c++17 -fblocks -verify %s \ +// RUN: -verify=expected,leak \ +// RUN: -analyzer-checker=core \ +// RUN: -analyzer-checker=cpl

[PATCH] D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr

tomasz-kaminski-sonarsource updated this revision to Diff 346700. tomasz-kaminski-sonarsource added a comment. Removed duplicated runs that were only differing by specifying c++-allocator-inlinging=true, which is the default value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102835/ne

[PATCH] D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr

tomasz-kaminski-sonarsource added inline comments. Comment at: clang/test/Analysis/NewDelete-checker-test.cpp:41-52 +// RUN: %clang_analyze_cc1 -std=c++17 -fblocks %s \ +// RUN: -verify=expected,newdelete \ +// RUN: -analyzer-checker=core \ +// RUN: -analyzer-checker=cplusp

[PATCH] D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr

steakhal added a comment. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102835/new/ https://reviews.llvm.org/D102835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr

Szelethus added inline comments. Comment at: clang/test/Analysis/NewDelete-checker-test.cpp:54-57 +// RUN: %clang_analyze_cc1 -std=c++17 -fblocks -verify %s \ +// RUN: -verify=expected,leak \ +// RUN: -analyzer-checker=core \ +// RUN: -analyzer-checker=cplusplus.NewDeleteLe

[PATCH] D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr

tomasz-kaminski-sonarsource updated this revision to Diff 346707. tomasz-kaminski-sonarsource added a comment. Adjusted Clang.Analysis::NewDelete-path-notes.cpp.plist for removed lines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102835/new/ https://reviews.llvm.org/D102835 Files:

[PATCH] D99455: [AST] Store regular ValueDecl* in BindingDecl

aaronpuchert added a comment. Ping @rsmith. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99455/new/ https://reviews.llvm.org/D99455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D99455: [AST] Store regular ValueDecl* in BindingDecl

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, please add `NFC` to the commit message though. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99455/new/ https://revi

[clang] 80c1adf - [clang] Invalidate a non-dependent-type RecordDecl when it has any dependent-type base class specifier.

Author: Haojian Wu Date: 2021-05-20T15:33:05+02:00 New Revision: 80c1adfd18b5308422827f8372c28cc2ecfaa015 URL: https://github.com/llvm/llvm-project/commit/80c1adfd18b5308422827f8372c28cc2ecfaa015 DIFF: https://github.com/llvm/llvm-project/commit/80c1adfd18b5308422827f8372c28cc2ecfaa015.diff LO

[PATCH] D102773: [clang] invalidate a non-dependent-type RecordDecl when it has any dependent-type base class specifier.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80c1adfd18b5: [clang] Invalidate a non-dependent-type RecordDecl when it has any dependent… (authored by hokein). Repository: rG LLVM Github Monor

[PATCH] D100991: Fix parsing of vector keyword in presence of conflicting uses.

ZarkoCA added inline comments. Comment at: clang/test/Parser/altivec-non-type-vector.c:1-24 +// RUN: %clang_cc1 -target-feature +altivec -fsyntax-only %s -triple powerpc64-ibm-aix +// RUN: %clang_cc1 -target-feature +altivec -fsyntax-only %s -triple powerpc64-ibm-aix-xcoff +//

[clang] d74b663 - Fix LIT failure on native aix

Author: Xiangling Liao Date: 2021-05-20T09:38:52-04:00 New Revision: d74b6635ef38d123793f025a2ea1ef28153d803a URL: https://github.com/llvm/llvm-project/commit/d74b6635ef38d123793f025a2ea1ef28153d803a DIFF: https://github.com/llvm/llvm-project/commit/d74b6635ef38d123793f025a2ea1ef28153d803a.diff

[PATCH] D102715: Fix LIT failure on native aix

This revision was automatically updated to reflect the committed changes. Closed by commit rGd74b6635ef38: Fix LIT failure on native aix (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102715/new/ https://reviews.llvm.org/D1

[clang] fa6e87c - [TableGen] [Clang] Clean up arm_mve.td file.

Author: Paul C. Anagnostopoulos Date: 2021-05-20T09:39:57-04:00 New Revision: fa6e87cc5a21f885a4f6d0c7a51ad0f40022f5c8 URL: https://github.com/llvm/llvm-project/commit/fa6e87cc5a21f885a4f6d0c7a51ad0f40022f5c8 DIFF: https://github.com/llvm/llvm-project/commit/fa6e87cc5a21f885a4f6d0c7a51ad0f40022

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa6e87cc5a21: [TableGen] [Clang] Clean up arm_mve.td file. (authored by Paul-C-Anagnostopoulos). Changed prior to commit: https://reviews.llvm.org

[clang] 603818b - [test] Fix pre-ra-sched.c to check for error message from stderr

Author: Hubert Tong Date: 2021-05-20T09:51:21-04:00 New Revision: 603818b97c795114f66a6fc13e8a5f0e54b49a13 URL: https://github.com/llvm/llvm-project/commit/603818b97c795114f66a6fc13e8a5f0e54b49a13 DIFF: https://github.com/llvm/llvm-project/commit/603818b97c795114f66a6fc13e8a5f0e54b49a13.diff L

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/pre-ra-sched.c:1-2 +// RUN: %clang %s -mllvm -pre-RA-sched=fast -c -o - | FileCheck %s +// RUN: %clang %s -mllvm -pre-RA-sched=linearize -c -o - | FileCheck %s + hubert.reinterpretcast w

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

kripken accepted this revision. kripken added a comment. This revision is now accepted and ready to land. I'm not very familiar with this code, but it looks right, and sgtm to add a warning here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102791

[PATCH] D100991: Fix parsing of vector keyword in presence of conflicting uses.

jamieschmeiser updated this revision to Diff 346722. jamieschmeiser added a comment. Remove unnecessary tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100991/new/ https://reviews.llvm.org/D100991 Files: clang/lib/Parse/Parser.cpp clang/test/Parser/altivec-non-type-vector.c

[clang] a5c2ec9 - [AST] Store regular ValueDecl* in BindingDecl (NFC)

Author: Aaron Puchert Date: 2021-05-20T16:28:58+02:00 New Revision: a5c2ec96e5f9f14b31b705e40bcb267257612316 URL: https://github.com/llvm/llvm-project/commit/a5c2ec96e5f9f14b31b705e40bcb267257612316 DIFF: https://github.com/llvm/llvm-project/commit/a5c2ec96e5f9f14b31b705e40bcb267257612316.diff

[PATCH] D99455: [AST] Store regular ValueDecl* in BindingDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5c2ec96e5f9: [AST] Store regular ValueDecl* in BindingDecl (NFC) (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

tbaeder updated this revision to Diff 346737. tbaeder added a comment. Use `hasFlag()` instead of `hasArg()` in Driver.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver

[PATCH] D100991: Fix parsing of vector keyword in presence of conflicting uses.

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100991/new/ https://reviews.llvm.org/D100991 ___ cfe-commits mailing list cf

[PATCH] D102689: [C++4OpenCL] Allow address space conversion in reinterpret_cast

Anastasia added a comment. Just to move the discussion from https://reviews.llvm.org/D101519 here. First of all I think this change should not be OpenCL specific i.e. there is not reason to do something different from C++ in general. Embedded C doesn't regulate the conversions between non-poin

[clang] 801ab71 - [ARM][AArch64] SLSHardening: make non-comdat thunks possible

Author: Daniel Kiss Date: 2021-05-20T17:07:05+02:00 New Revision: 801ab71032e157eb7bcd38efeb6486742a7c53bb URL: https://github.com/llvm/llvm-project/commit/801ab71032e157eb7bcd38efeb6486742a7c53bb DIFF: https://github.com/llvm/llvm-project/commit/801ab71032e157eb7bcd38efeb6486742a7c53bb.diff L

[PATCH] D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. danielkiss marked an inline comment as done. Closed by commit rG801ab71032e1: [ARM][AArch64] SLSHardening: make non-comdat thunks possible (authored by danielkiss). Her

[clang] beb5a3a - Correct some thread safety analysis diagnostics; NFC.

Author: Aaron Ballman Date: 2021-05-20T11:30:21-04:00 New Revision: beb5a3a298a1bb2687b421cb960d36a5e9b3ad43 URL: https://github.com/llvm/llvm-project/commit/beb5a3a298a1bb2687b421cb960d36a5e9b3ad43 DIFF: https://github.com/llvm/llvm-project/commit/beb5a3a298a1bb2687b421cb960d36a5e9b3ad43.diff

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser updated this revision to Diff 346751. jamieschmeiser added a comment. Fix formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticGroups.td clang/inc

[PATCH] D102849: [flang][driver] Add support for the "-init-only" option

stuartellis created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. Herald added a reviewer: awarzynski. stuartellis requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding the -init-only option and corres

[PATCH] D102850: [C++4OpenCL] Allow address space conversion in reinterpret_cast

olestrohm created this revision. olestrohm added reviewers: Anastasia, svenvh. olestrohm added a project: clang. Herald added subscribers: ldrumm, yaxunl. olestrohm requested review of this revision. Herald added a subscriber: cfe-commits. This fixes the prioritization of address spaces when choos

[clang] 2d574a1 - [CodeGen][AArch64][SVE] Canonicalize intrinsic rdffr{ => _z}

Author: Peter Waller Date: 2021-05-20T16:22:50Z New Revision: 2d574a110440597eefe1b2a8b6144e4e89c21d05 URL: https://github.com/llvm/llvm-project/commit/2d574a110440597eefe1b2a8b6144e4e89c21d05 DIFF: https://github.com/llvm/llvm-project/commit/2d574a110440597eefe1b2a8b6144e4e89c21d05.diff LOG:

[PATCH] D102623: [CodeGen][AArch64][SVE] Canonicalize intrinsic rdffr{ => _z}

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d574a110440: [CodeGen][AArch64][SVE] Canonicalize intrinsic rdffr{ => _z} (authored by peterwaller-arm). Repository: rG LLVM Github Monorepo CHA

[PATCH] D102756: [clang-repl] Tell the LLJIT the exact target triple we use.

lhames accepted this revision. lhames added a comment. This revision is now accepted and ready to land. LGTM. :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102756/new/ https://reviews.llvm.org/D102756 ___ cfe-commit

[clang] 136ced4 - When vector is found as a type or non-type id, check if it is really the altivec vector token.

Author: Jamie Schmeiser Date: 2021-05-20T12:39:04-04:00 New Revision: 136ced498ba84f6b6126051626e319f18ba740f5 URL: https://github.com/llvm/llvm-project/commit/136ced498ba84f6b6126051626e319f18ba740f5 DIFF: https://github.com/llvm/llvm-project/commit/136ced498ba84f6b6126051626e319f18ba740f5.dif

[PATCH] D100991: Fix parsing of vector keyword in presence of conflicting uses.

This revision was automatically updated to reflect the committed changes. Closed by commit rG136ced498ba8: When vector is found as a type or non-type id, check if it is really the… (authored by jamieschmeiser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 ___ cfe-commits mailing list cfe-com

[PATCH] D102818: [PGO] Don't reference functions unless value profiling is enabled

rnk added a comment. Thanks! I'll wait to see if I can get an ack from the Apple folks who indicated that they are using frontend PGO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102818/new/ https://reviews.llvm.org/D102818

[PATCH] D102818: [PGO] Don't reference functions unless value profiling is enabled

vsk accepted this revision. vsk added a comment. Thanks, lgtm as well. On Darwin, the __llvm_prf_data section is marked with S_ATTR_LIVE_SUPPORT to allow the linker to dead strip functions even if they are pointed-to by a profd global. Removing the reference altogether should yield even better

[PATCH] D102853: [OpenCL] Align definition of __IMAGE_SUPPORT__ feature macro with OpenCL version and __opencl_c_images feature macro definition

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D20401: [Lexer] Don't merge macro args from different macro files

vsk added a comment. In D20401#2770059 , @nickdesaulniers wrote: > I know this was sped up slightly in 3339c568c43e4644f02289e5edfc78c860f19c9f, > but this change makes `updateConsecutiveMacroArgTokens` the hottest function > in clang in a bottom up pro

[PATCH] D101479: [Driver] Support libc++ in MSVC

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, sorry for the delay, this fell off the end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D101479

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji updated this revision to Diff 346794. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102814/new/ https://reviews.llvm.org/D102814 Files: clang/test/CodeGenCXX/debug-info-byval.cpp llvm/include/llvm/M

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2369 -static bool AddARMImplicitITArgs(const ArgList &Args, ArgStringList &CmdArgs, +static bool CheckARMImplicitITArg(StringRef Value) { + return Value == "always" || Value == "never" || Value ==

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

yaxunl updated this revision to Diff 346796. yaxunl retitled this revision from "[CUDA][HIP] Fix implicit constant variable" to "[CUDA][HIP] Fix device variables used by host". yaxunl edited the summary of this revision. yaxunl added a comment. Fix the other regression CHANGES SINCE LAST ACTION

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. So I will hide it from "Ready to Review" list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

rnk added a comment. @hans, can you review this? I am trying to offload clang reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102517/new/ https://reviews.llvm.org/D102517 ___ cfe-commits mailing l

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

yaxunl marked 2 inline comments as done. yaxunl added a comment. In D102801#2769936 , @tra wrote: > This patch does not appear to fix the second regression introduced by the > D102237 . > > Trying to compile the followin

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

yaxunl marked 2 inline comments as done. yaxunl added a comment. In D102801#2769619 , @tra wrote: > Tentative LGTM as we need it to fix the regression soon. > > Summoning @rsmith for the 'big picture' opinion. > While the patch may fix this particular re

[clang] 8f20ac9 - [PGO] Don't reference functions unless value profiling is enabled

Author: Reid Kleckner Date: 2021-05-20T11:09:24-07:00 New Revision: 8f20ac9595c8b279641dace6f212b8a9673b24e4 URL: https://github.com/llvm/llvm-project/commit/8f20ac9595c8b279641dace6f212b8a9673b24e4 DIFF: https://github.com/llvm/llvm-project/commit/8f20ac9595c8b279641dace6f212b8a9673b24e4.diff

[PATCH] D102818: [PGO] Don't reference functions unless value profiling is enabled

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f20ac9595c8: [PGO] Don't reference functions unless value profiling is enabled (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 346800. nickdesaulniers added a comment. - fix lints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/new/ https://reviews.llvm.org/D102742 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

tra added a comment. In D102801#2771664 , @yaxunl wrote: > In the updated patch I have a simpler solution which is easier to explain to > the users. Basically we classify variables by how they are emitted: device > side only, host side only, both sides

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji added inline comments. Comment at: llvm/lib/MC/MCAsmStreamer.cpp:1008 + for (const unsigned char C : Data) { +if (!isPrint(C)) + return false; This still need some slight change to deal with the ending 0 so that we can handle .string. Repository

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

dschuff accepted this revision. dschuff added a comment. Got it, this makes sense to me too. And since it can be turned off, I'm not too worried about annoying users. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102791/new/ https://reviews.llvm.o

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD updated this revision to Diff 346808. RedDocMD marked 10 inline comments as done. RedDocMD added a comment. Code clean up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 Files: clang/lib/StaticAn

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:141-163 +auto bugReportOnGet = [&](const Expr *E) -> auto { + if (const auto *MCE = llvm::dyn_cast(E)) { +const auto *Method = MCE->getMethodDecl(); +

[PATCH] D102860: [clang][deps] NFC: Remove the `module-deps-to-rsp.py` utility

georgi_igna created this revision. georgi_igna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was upstreamed in https://reviews.llvm.org/D102495 and put into `clang/utils`. Merge commit 'b99b18eb59ed' from apple/main into internal/m

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD updated this revision to Diff 346817. RedDocMD added a comment. Removed un-necessary includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h

[PATCH] D102863: rdar://77307290 (Disable retain-count tracking for references to OSMetaClass)

georgi_igna created this revision. georgi_igna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. OSMetaClass does not use reference-counting. We should ignore references to OSMetaClass in class RetainSummaryManager. Repository: rG LLVM G

[PATCH] D102863: [analyzer] RetainCountChecker: Disable tracking for references to OSMetaClass.

NoQ added a comment. Please upload the actual change you want to make in the llvm.org main branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102863/new/ https://reviews.llvm.org/D102863 ___ cfe-commi

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. In D74436#2190566 , @lebedev.ri wrote: > In D74436#2190492 , @lebedev.ri > wrote: > >> <...> > > And by codegen changes i mostly mean newly-set/now-unset fp fast-math > instruction flags.

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. I created https://reviews.llvm.org/D102861 to make changes to the failing LNT tests. Hoping to push this commit after the test changes in D102862 are approved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

super_concat marked 3 inline comments as done. super_concat added a comment. @hans, could you land this for me? I do not have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100252/new/ https://reviews.llvm.org/D100252 ___ cfe-co

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji updated this revision to Diff 346830. jsji added a comment. Update .string handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102814/new/ https://reviews.llvm.org/D102814 Files: clang/test/CodeGenCXX/debug-info-byval.cpp llvm/include

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji added inline comments. Comment at: llvm/lib/MC/MCAsmStreamer.cpp:1008 + for (const unsigned char C : Data) { +if (!isPrint(C)) + return false; jsji wrote: > This still need some slight change to deal with the ending 0 so that we can > handle .stri

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12066 + enum CUDAVariableTarget { +CVT_Device, /// Device only tra wrote: > Wasn't there another kind, where the variable is emitted on the

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

yaxunl updated this revision to Diff 346831. yaxunl marked 3 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102801/new/ https://reviews.llvm.org/D102801 Files: clang/include/clang/Sema/Sema.h clang/lib/Code

[clang] 3eb12b0 - [WebAssembly] Warn on exception spec for Emscripten EH

Author: Heejin Ahn Date: 2021-05-20T13:00:20-07:00 New Revision: 3eb12b0ae11fe23dc06e55e526fb45e460f72f1e URL: https://github.com/llvm/llvm-project/commit/3eb12b0ae11fe23dc06e55e526fb45e460f72f1e DIFF: https://github.com/llvm/llvm-project/commit/3eb12b0ae11fe23dc06e55e526fb45e460f72f1e.diff LO

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

This revision was automatically updated to reflect the committed changes. Closed by commit rG3eb12b0ae11f: [WebAssembly] Warn on exception spec for Emscripten EH (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102791/new/ https:

  1   2   >