HazardyKnusperkeks added a comment.

Looks good, but please add a test with the `else IF` and just `else` case.

Also for me it would be ok to add your `KJ_IF_MAYBE` to the default 
configuration. But I have no experience on that.



================
Comment at: clang/include/clang/Format/Format.h:2098
+  ///
+  /// For example: KJ_IF_MAYBE.
+  std::vector<std::string> IfMacros;
----------------
vlovich wrote:
> Should I put a hyperlink to 
> https://github.com/capnproto/capnproto/blob/master/kjdoc/tour.md#maybes?
Maybe. *scnr*


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102730/new/

https://reviews.llvm.org/D102730

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to