[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

balazske added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:670 return llvm::Error::success(); + else if (index_error_code::no_error != InvocationListParsingError) +return llvm::make_error(InvocationListParsingError); martong

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

balazske added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:257 llvm::Optional InvocationList; +index_error_code InvocationListParsingError = index_error_code::no_error; }; martong wrote: > I think it would be more c

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

curdeius added a comment. Could you please rebase to re-run the CI (that failed for sum unrelated reason)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 ___ c

[PATCH] D101860: [clang-format] Fix C# nullable-related errors

curdeius added a comment. You can add a parent revision so that this patch will be applied upon its parent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101860/new/ https://reviews.llvm.org/D101860 ___

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM. I can take care of reverting if there are issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101191/new/ https://reviews.llvm.org/D101191

[PATCH] D101860: [clang-format] Fix C# nullable-related errors

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM pending CI. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2531 + parseRecord(); + // This does not apply for Java, JavaScript and C#. + if (Style.Language

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo marked 3 inline comments as done. wingo added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1324 +{LN->getChain(), Base}, LN->getMemoryVT(), LN->getMemOperand()); +return DAG.getMergeValues({GlobalGet, LN->getChain()}, DL);

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo updated this revision to Diff 342963. wingo marked 2 inline comments as done. wingo added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.llvm.org/D101608 Files: clang/lib/Basic/Targets

[PATCH] D100919: [AArch64] Support customizing stack protector guard

DavidSpickett added a reviewer: ostannard. DavidSpickett added a subscriber: ostannard. DavidSpickett added a comment. All my comments have been answered. Perhaps @ostannard can check AArch64InstrInfo.cpp ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

aheejin added a comment. Why do only these instructions have `const`? It doesn't apply to other read-only arguments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101884/new/ https://reviews.llvm.org/D101884 __

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo updated this revision to Diff 342970. wingo added a comment. Pull in fixes from D101140 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.llvm.org/D101608 Files: clang/lib/Basic/Ta

[PATCH] D101870: [clangd] Check if macro is already in the IdentifierTable before loading it

kadircet added a comment. oh wow thanks! would you mind adding a test case like: TEST(CompletionTest, NoCrashDueToMacroOrdering) { EXPECT_THAT(completions(R"cpp( #define ECHO(X) X #define ECHO2(X) ECHO(X) int finish_preamble = E^CHO(2);)cpp") .Completio

[PATCH] D101862: [clang-format] Rename common types between C#/JS

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM pending CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101862/new/ https://reviews.llvm.org/D101862 ___

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. I like the idea, but we need more tests. Comment at: clang/include/clang/Format/Format.h:93 + /// if ``true``, when using static initialization for an array

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

krasimir accepted this revision. krasimir added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1563 + if (Current.Previous) { +bool isIdentifier = +Style.Language == FormatStyle::LK_JavaScript nit: `s/isIdentifier/IsIden

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

krasimir added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:135 return; +} } nit: use spaces for indentation, no tabs (Phabricator makes it look this line starts with a tab character) Repository: rG LLVM Github Monorepo C

[clang] 4f4aa7b - Require asserts for clang/test/Headers/wasm.c

Author: Hans Wennborg Date: 2021-05-05T11:42:18+02:00 New Revision: 4f4aa7b78df5544b0a1c07ee98475939c1175990 URL: https://github.com/llvm/llvm-project/commit/4f4aa7b78df5544b0a1c07ee98475939c1175990 DIFF: https://github.com/llvm/llvm-project/commit/4f4aa7b78df5544b0a1c07ee98475939c1175990.diff

[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

hans added a comment. The test was failing in no-asserts builds, see output at https://ghostbin.com/paste/UMtJl I put "REQUIRES: asserts" on it in 4f4aa7b78df5544b0a1c07ee98475939c1175990 for now. Repository: rG LLVM Gith

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

jansvoboda11 added a comment. Thanks! This LGTM from command-line perspective, but I'll let others judge the functional change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101640/new/ https://reviews.llvm.org/D101640 ___

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev updated this revision to Diff 342980. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. - Check if we can use death tests; - Do not install clang-repl as being an early stage development. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ ht

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

jbcoe added a comment. Thanks for this patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 342991. reikdas added a comment. Update diff to avoid printing type information if MSVCFormatting printing policy is enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/include/clang/AST

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 added a comment. In D100934#2737130 , @dexonsmith wrote: > In D100934#2735955 , @jansvoboda11 > wrote: > >> 1. Fix `AsWritten` for umbrella headers/directories. >> 2. Add tests to `clang/test/Module

[PATCH] D101519: [C++4OpenCL] Fix reinterpret_cast of vectors and types with address spaces

Anastasia added inline comments. Comment at: clang/test/SemaOpenCLCXX/reinterpret-cast.clcpp:1 +// RUN: %clang_cc1 %s -pedantic -verify -fsyntax-only + olestrohm wrote: > Anastasia wrote: > > Btw I assume your patch also allows reinterpret_cast between vectors? W

[PATCH] D101899: std::forward_list::swap to use propagate_on_container_swap for noexcept specification

airglow923 created this revision. airglow923 added a project: libc++. airglow923 requested review of this revision. Herald added a project: clang. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. This revision is a patch for bug 50224

[PATCH] D101899: std::forward_list::swap to use propagate_on_container_swap for noexcept specification

airglow923 updated this revision to Diff 343011. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101899/new/ https://reviews.llvm.org/D101899 Files: libcxx/include/forward_list Index: libcxx/include/forward_list ===

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64

peter.smith added a comment. I've no comments on the code in D101872 , and D10873 they look reasonable to me. I guess it is down to whether this is the right thing to do or not. Just to check my understanding: - Clang default

[PATCH] D101901: [AMDGPU][OpenMP] Fix clang driver crash when provided -c

pdhaliwal created this revision. pdhaliwal added reviewers: JonChesterfield, ronlieb, jdoerfert, ye-luo, tianshilei1992. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers:

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10006 "use of %select{type|declaration}0 %1 requires %2 support">; +def ext_opencl_double_without_pragma : Extension< + "Clang permits use of type 'double' regardless pragma if 'cl_k

[PATCH] D101902: [clangd] Split CC and refs limit and increase refs limit to 1000

kbobyrev created this revision. kbobyrev added reviewers: kadircet, nridge. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Related discussion: https

[PATCH] D101901: [AMDGPU][OpenMP] Fix clang driver crash when provided -c

JonChesterfield added a comment. @jdoerfert This drops the logic for save-temps that I remember being contentious. Doing a no-op backend pass instead of skipping over it is probably more robust. Comment at: clang/lib/Driver/Driver.cpp:4600 + + if (const AssembleJobAction

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

TWeaver added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-vararg-ms.cpp:7 + +// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-vararg %t + Is the missing FileCheck call here on purpose? it seems to me

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-vararg-ms.cpp:7 + +// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-vararg %t + TWeaver wrote: > Is the missing FileCheck call here on purpos

[PATCH] D100934: [clang][modules] Build inferred modules

dexonsmith added inline comments. Comment at: clang/test/ClangScanDeps/modules-inferred-explicit-build.m:13-17 +// RUN: %clang @%t.inferred.rsp -pedantic -Werror +// RUN: %clang @%t.system.rsp -pedantic -Werror +// RUN: %clang -x objective-c -fsyntax-only %t.dir/modules_cdb_input

[PATCH] D101901: [AMDGPU][OpenMP] Fix clang driver crash when provided -c

jdoerfert added a comment. Cool, this makes sense :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101901/new/ https://reviews.llvm.org/D101901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] e994e74 - [OpenCL] Add clang extension for non-portable kernel parameters.

Author: Anastasia Stulova Date: 2021-05-05T14:58:23+01:00 New Revision: e994e74bca49831eb649e7c67955e9de7a1784b6 URL: https://github.com/llvm/llvm-project/commit/e994e74bca49831eb649e7c67955e9de7a1784b6 DIFF: https://github.com/llvm/llvm-project/commit/e994e74bca49831eb649e7c67955e9de7a1784b6.d

[PATCH] D101902: [clangd] Split CC and refs limit and increase refs limit to 1000

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:70 +/// Limit the number of references returned (0 means no limit). +size_t LimitReferences =

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 added a comment. In D99432#2736981 , @ABataev wrote: > In D99432#2736970 , @estewart08 > wrote: > >> In D99432#2728788 , @ABataev wrote: >> >>> In D99432#2726997

[PATCH] D100934: [clang][modules] Build inferred modules

dexonsmith added inline comments. Comment at: clang/test/ClangScanDeps/modules-inferred-explicit-build.m:13-17 +// RUN: %clang @%t.inferred.rsp -pedantic -Werror +// RUN: %clang @%t.system.rsp -pedantic -Werror +// RUN: %clang -x objective-c -fsyntax-only %t.dir/modules_cdb_input

[clang] 1f5cacf - [AMDGPU][OpenMP] Fix clang driver crash when provided -c

Author: Pushpinder Singh Date: 2021-05-05T14:26:58Z New Revision: 1f5cacfcb845fd4163dec5a8c7991934c53d6cb3 URL: https://github.com/llvm/llvm-project/commit/1f5cacfcb845fd4163dec5a8c7991934c53d6cb3 DIFF: https://github.com/llvm/llvm-project/commit/1f5cacfcb845fd4163dec5a8c7991934c53d6cb3.diff L

[PATCH] D101901: [AMDGPU][OpenMP] Fix clang driver crash when provided -c

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f5cacfcb845: [AMDGPU][OpenMP] Fix clang driver crash when provided -c (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101901/new/ ht

[PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

anirudhp added a comment. Hi @flip1995 My apologies, but you might have to rebase this on the latest main. I introduced a `MCSubtargetInfo` field in https://reviews.llvm.org/D100975. Some of the existing changes to the file may not be needed anymore. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2738859 , @estewart08 wrote: > In D99432#2736981 , @ABataev wrote: > >> In D99432#2736970 , @estewart08 >> wrote: >> >>> In D99432#2728788

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

TWeaver added a comment. whilst investigating an unrelated issue on our internal branch, I tried editting the check lines in this test and wasn't able to create a failure. but if I add '| FileCheck %s -check-prefix=CHECK-MESSAGES' to the run line and then edit the checks, I can induce an error

[PATCH] D101911: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev created this revision. ABataev added reviewers: jdoerfert, estewart08. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Follow the more general patch for now, do not try to SPMDize the

[PATCH] D101911: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. Hi Ethan, try this patch if it fixes the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101911/new/ https://reviews.llvm.org/D101911 ___ cfe-commits mailing list cfe-commit

[PATCH] D101352: [DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)

xgupta added a comment. @sushmaunnibhavi Please close this revision, I got some misunderstading. Changes are not expected here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101352/new/ https://reviews.llvm.org/D101352 ___

[PATCH] D101791: [clang-tidy] Aliasing: Add support for aggregates with references.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101791/new/ https://reviews.llvm.org/D101791 _

[PATCH] D101352: [DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)

sushmaunnibhavi added a comment. In D101352#2739003 , @xgupta wrote: > @sushmaunnibhavi Please close this revision, I got some misunderstading. > Changes are not expected here. Yes, will do it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D101787: [clang-tidy] Aliasing: Add more support for lambda captures.

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:1 // RUN: %check_clang_tidy %s bugprone-redundant-branch-condition %t You need to add `-fblocks` here to enable block support t

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

TWeaver added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-vararg-ms.cpp:7 + +// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-vararg %t + njames93 wrote: > TWeaver wrote: > > Is the missing FileCheck

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

aaron.ballman added a comment. In D96215#2737085 , @NoQ wrote: > In D96215#2735546 , @njames93 wrote: > >> Just my $0.02, We shouldn't worry too much about pathological cases like >> that. I imagine that code would

[PATCH] D101914: [clangd][index-sever] Limit results in repsonse

kadircet created this revision. kadircet added a reviewer: kbobyrev. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is to prevent server from b

[PATCH] D101915: [clangd][remote-client] Set HasMore to true for failure

kadircet created this revision. kadircet added a reviewer: kbobyrev. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Currently client was setting the

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sbc100 added a comment. Does this mean that the magic `__stack_pointer` global can be referenced at the IR level? I wonder if there are some hacks around handling of `__stack_pointer` that could be removed after this lands? Comment at: llvm/lib/Target/WebAssembly/Utils/WebA

[PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

flip1995 updated this revision to Diff 343056. flip1995 added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101462/new/ https://reviews.llvm.org/D101462 Files: clang/lib/Parse/ParseStmtAsm.cpp clang/tools/driver/cc1as_main.c

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/modules-inferred-explicit-build.m:13-17 +// RUN: %clang @%t.inferred.rsp -pedantic -Werror +// RUN: %clang @%t.system.rsp -pedantic -Werror +// RUN: %clang -x objective-c -fsyntax-only %t.dir/modules_cdb_inp

[PATCH] D101918: [clang][Driver] Add -fintegrate-as to debug-pass-structure test

jsji created this revision. jsji added reviewers: evgeny777, tejohnson. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CGProfilePass is not always on, it will be disabled when using non-intergrated assemblers. // Only enable CGProf

[clang] 67ee2f8 - Added a faster method to clone llvm project [DOCS]

Author: Sushma Unnibhavi Date: 2021-05-05T21:37:53+05:30 New Revision: 67ee2f870d3b06a5684251272eae36d6e0f519b0 URL: https://github.com/llvm/llvm-project/commit/67ee2f870d3b06a5684251272eae36d6e0f519b0 DIFF: https://github.com/llvm/llvm-project/commit/67ee2f870d3b06a5684251272eae36d6e0f519b0.di

[PATCH] D101433: Added a faster method to clone llvm project [DOCS]

This revision was automatically updated to reflect the committed changes. Closed by commit rG67ee2f870d3b: Added a faster method to clone llvm project [DOCS] (authored by sushmaunnibhavi, committed by xgupta). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D101918: [clang][Driver] Add -fintegrate-as to debug-pass-structure test

evgeny777 accepted this revision. evgeny777 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101918/new/ https://reviews.llvm.org/D101918 _

[clang] 20d0aca - [clang][Driver] Add -fintegrate-as to debug-pass-structure test

Author: Jinsong Ji Date: 2021-05-05T16:10:57Z New Revision: 20d0aca43073f18f70b1c5a665631dee1be1598d URL: https://github.com/llvm/llvm-project/commit/20d0aca43073f18f70b1c5a665631dee1be1598d DIFF: https://github.com/llvm/llvm-project/commit/20d0aca43073f18f70b1c5a665631dee1be1598d.diff LOG: [c

[PATCH] D101918: [clang][Driver] Add -fintegrate-as to debug-pass-structure test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20d0aca43073: [clang][Driver] Add -fintegrate-as to debug-pass-structure test (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. Thanks, @teemperor. I have addressed your last comments, too. I wanted to use the opportunity to ping @rjmccall and @rsmith. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 _

[clang] f16afcd - [clang] remove an incremental build workaround

Author: Nico Weber Date: 2021-05-05T12:21:56-04:00 New Revision: f16afcd9b5ce3054aac2b08b3a20472c07b6773a URL: https://github.com/llvm/llvm-project/commit/f16afcd9b5ce3054aac2b08b3a20472c07b6773a DIFF: https://github.com/llvm/llvm-project/commit/f16afcd9b5ce3054aac2b08b3a20472c07b6773a.diff LO

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman updated this revision to Diff 343087. dgoldman added a comment. Another attempt... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm.org/D101785 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-e

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Btw, given that you've had several of these approved, would you be interested in getting commit access (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access)?

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64

MaskRay added a comment. In D101873#2738643 , @peter.smith wrote: > I've no comments on the code in D101872 , > and D10873 they look reasonable to me. I > guess it is down to whether

[clang] 632ebc4 - [MC] Untangle MCContext and MCObjectFileInfo

Author: Philipp Krones Date: 2021-05-05T10:03:02-07:00 New Revision: 632ebc4ab4374e53fce1ec870465c587e0a33668 URL: https://github.com/llvm/llvm-project/commit/632ebc4ab4374e53fce1ec870465c587e0a33668 DIFF: https://github.com/llvm/llvm-project/commit/632ebc4ab4374e53fce1ec870465c587e0a33668.diff

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

Paul-C-Anagnostopoulos updated this revision to Diff 343100. Paul-C-Anagnostopoulos added a comment. Restored whitespace as requested by Jan. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101766/new/ https://reviews.llvm.org/D101766 Files: clang/include/clang/Driver/Options.td Index

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

probinson added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-vararg-ms.cpp:7 + +// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-vararg %t + TWeaver wrote: > njames93 wrote: > > TWeaver wrote: > > > Is

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

probinson added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-vararg-ms.cpp:7 + +// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-vararg %t + probinson wrote: > TWeaver wrote: > > njames93 wrote: > > >

[PATCH] D101572: Make `hasTypeLoc` matcher support more node types.

SilensAngelusNex updated this revision to Diff 343106. SilensAngelusNex added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101572/new/ https://reviews.llvm.org/D101572 Files: clang/include/clang/ASTMatchers/ASTMatchers.h cla

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. We may need more robust error handling around this. I'm seeing test failures when building clang, `clang-13: error: Cannot determine AMDGPU architecture: $HOME/llvm-build/llvm/./bin/amdgpu-arch: Execute failed: No such file or directory. Consider passing it via

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sbc100 added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1378 - if (GA->getAddressSpace() != 0) -fail(DL, DAG, "WebAssembly only expects the 0 address space"); Is it worth checking this is within `WasmAddressSpace`

[clang] aefbfbc - [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

Author: Nick Desaulniers Date: 2021-05-05T11:01:43-07:00 New Revision: aefbfbcbd776f5549b18cd6083d6408f661efacc URL: https://github.com/llvm/llvm-project/commit/aefbfbcbd776f5549b18cd6083d6408f661efacc DIFF: https://github.com/llvm/llvm-project/commit/aefbfbcbd776f5549b18cd6083d6408f661efacc.di

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaefbfbcbd776: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion (authored by nickdesaulniers). Repository: rG LLVM Gi

[PATCH] D101926: [amdgpu-arch] Fix rpath to run from build dir

JonChesterfield created this revision. JonChesterfield added reviewers: gregrodgers, pdhaliwal, tianshilei1992, jdoerfert. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, yaxunl, mgorny, nhaehnle, jvesely, kzhuravl. JonChesterfield requested review of this revision. Herald added subscri

[clang-tools-extra] 7907c46 - Make clangd CompletionModel not depend on directory layout.

Author: Harald van Dijk Date: 2021-05-05T19:25:34+01:00 New Revision: 7907c46fe6195728fafd843b8c0fb19a3e68e9ad URL: https://github.com/llvm/llvm-project/commit/7907c46fe6195728fafd843b8c0fb19a3e68e9ad DIFF: https://github.com/llvm/llvm-project/commit/7907c46fe6195728fafd843b8c0fb19a3e68e9ad.dif

[PATCH] D101851: Make clangd CompletionModel not depend on directory layout.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7907c46fe619: Make clangd CompletionModel not depend on directory layout. (authored by hvdijk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101851/new/ ht

[PATCH] D100782: [PowerPC] Improve f32 to i32 bitcast code gen

Conanap updated this revision to Diff 343115. Conanap marked 2 inline comments as done. Conanap added a comment. Updated `COPY_TO_REGCLASS` to `SUBREG_TO_REG`, added a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100782/new/ https://reviews.llvm.org/D100782 Files: llvm/li

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:135 return; +} } krasimir wrote: > nit: use spaces for indentation, no tabs (Phabricator makes it look this line > starts with a tab character) That's not a

[PATCH] D101934: [Utils][NFC] Rename replace-function-regex in update_cc_test_checks

ggeorgakoudis created this revision. Herald added a subscriber: arichardson. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo

[PATCH] D101935: [clang] Search runtimes build tree for openmp runtime

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, pdhaliwal, ronlieb, grokos, tianshilei1992. Herald added subscribers: guansong, yaxunl. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: cla

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks added a comment. I really like alignment! :) But why is this completely different than the other alignment options? You should also add an entry to the release notes. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:32 +// The notion here is that we

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

dblaikie added a comment. In D101684#2737868 , @tlively wrote: > In D101684#2737842 , @penzn wrote: > >> I think there is another dimension to this aside from project composition - >> intrinsics have a tendency t

[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

tlively added a comment. Thanks, @hans! That's very surprising; I'll take a deeper look at what was going wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101805/new/ https://reviews.llvm.org/D101805 __

[PATCH] D101805: [WebAssembly] Add codegen test for wasm_simd128.h

dblaikie added a comment. In D101805#2739814 , @tlively wrote: > Thanks, @hans! That's very surprising; I'll take a deeper look at what was > going wrong. Labels (& instructions/values) are only named in ASSERTS enabled builds (or you can opt into them

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv updated this revision to Diff 343142. exv marked 3 inline comments as done. exv added a comment. - Incorporate krasimir's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 Files: clang/lib/Fo

[PATCH] D101870: [clangd] Check if macro is already in the IdentifierTable before loading it

qdelacru updated this revision to Diff 343141. qdelacru added a comment. Added suggested new test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101870/new/ https://reviews.llvm.org/D101870 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/unittests/Code

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv added a comment. Rebased and comments addressed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D101860: [clang-format] Fix C# nullable-related errors

exv updated this revision to Diff 343143. exv marked an inline comment as done. exv added a comment. - Incorporate curdeius's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101860/new/ https://reviews.llvm.org/D101860 Files: clang/lib/Fo

[PATCH] D101862: [clang-format] Rename common types between C#/JS

exv updated this revision to Diff 343144. exv added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101862/new/ https://reviews.llvm.org/D101862 Files: clang/lib/Format/FormatToken.h clang/lib/Format/FormatTokenLexer.cpp clan

[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

tlively added a comment. It only matters for pointer parameters. For example, `const int *` is meaningfully different from `int *`, but `const int` is not usefully different from `int`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101884/new/ ht

[PATCH] D101860: [clang-format] Fix C# nullable-related errors

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101860/new/ https://reviews.llvm.org/D101860 ___ cfe-commits mailing list cfe-com

[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. I see, thanks. Then other load instructions are OK not to be fixed? - `v128.load` - `v128.loadN_splat` - `v128.loadNxM_s/u` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101937: [Clang][Manual] Mention -fdebug-info-for-profiling.

mbenfield created this revision. mbenfield added reviewers: rsmith, wmi. Herald added a subscriber: wenlei. mbenfield requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This option is necessary for effective AutoFDO, and it also seems that the

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

HazardyKnusperkeks added a comment. I have not a great knowledge about python, but it looks okay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 ___ cfe-commit

[PATCH] D101572: Make `hasTypeLoc` matcher support more node types.

steveire added a comment. Please run `llvm-project/clang/docs/tools/dump_ast_matchers.py` to generate updated documentation for this (there is a `urlopen(url)` which slows things down, so I usually comment that out when running it). Do you have this on a git clone somewhere? It's easier to take

[PATCH] D101883: [WebAssembly] Update narrowing builtin function operand types

This revision was automatically updated to reflect the committed changes. Closed by commit rG627a52695537: [WebAssembly] Update narrowing builtin function operand types (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101883/new/

  1   2   >