[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

akyrtzi added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:708 c = 'd'; break; +case BuiltinType::Ibm128: // FIXME: Need separate tag case BuiltinType::LongDouble: rjmccall wrote: > @akyrtzi @benlangmuir We can just a

[PATCH] D101130: [PowerPC] Provide XL-compatible builtins in altivec.h

nemanjai added inline comments. Comment at: clang/lib/Headers/altivec.h:3055 +#ifdef __XL_COMPAT_ALTIVEC__ +/* vec_ctf */ jsji wrote: > This only affects __VSX__ version right? If so, can we move `#ifdef > __XL_COMPAT_ALTIVEC__` into `#ifdef __VSX__`？ > Or eve

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

azabaznov added a comment. > We could of course keep it just for this particular case of doubles, but even > half is allowed in certain circumstances without the pragma and it is still > an extension. https://godbolt.org/z/K34sP81nx I am confused again... after looking into //OpenCL C 1.0, 9.10

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

JDevlieghere added a comment. In D45639#2706605 , @ldionne wrote: > In D45639#2706589 , @dexonsmith > wrote: > >> I'm not sure I'm totally following, but just want to double check that the >> tests won't somehow u

[clang] 6725b90 - [PowerPC] Add vec_ctsl and vec_ctul to altivec.h

Author: Nemanja Ivanovic Date: 2021-04-23T11:03:38-05:00 New Revision: 6725b90a02c6d2696385c0328bd000516913ce4b URL: https://github.com/llvm/llvm-project/commit/6725b90a02c6d2696385c0328bd000516913ce4b DIFF: https://github.com/llvm/llvm-project/commit/6725b90a02c6d2696385c0328bd000516913ce4b.di

[PATCH] D101095: [clang][amdgpu] Use implicit code object version

yaxunl added a comment. LGTM. However, I would like to hear Tony's opinion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101095/new/ https://reviews.llvm.org/D101095 ___ cfe-commits mailing list cfe-com

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2134-2151 +Sema::DeclareTargetContextInfo *DTCI = +new Sema::DeclareTargetContextInfo(DKind, DTLoc); +if (HasClauses) + ParseOMPDeclareTargetClauses(*DTCI); // Skip the last ann

[PATCH] D100929: [Clang] Allow the combination of loader_uninitialized and address spaces

jdoerfert updated this revision to Diff 340071. jdoerfert added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100929/new/ https://reviews.llvm.org/D100929 Files: clang/lib/Sema/SemaDecl.cpp clang/test/CodeGen/attr-loader-un

[clang] cbe8b57 - [Clang] Allow the combination of loader_uninitialized and address spaces

Author: Johannes Doerfert Date: 2021-04-23T11:21:52-05:00 New Revision: cbe8b57a675537183eaf8c32eaa6087cea3fc5da URL: https://github.com/llvm/llvm-project/commit/cbe8b57a675537183eaf8c32eaa6087cea3fc5da DIFF: https://github.com/llvm/llvm-project/commit/cbe8b57a675537183eaf8c32eaa6087cea3fc5da.d

[PATCH] D100929: [Clang] Allow the combination of loader_uninitialized and address spaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcbe8b57a6755: [Clang] Allow the combination of loader_uninitialized and address spaces (authored by jdoerfert). Repository: rG LLVM Github Monorep

[PATCH] D100929: [Clang] Allow the combination of loader_uninitialized and address spaces

JonChesterfield added a comment. Diff now shows unrelated changed (// C++ for OpenCL v1.0 s2.4:), maybe needs to be rebased? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100929/new/ https://reviews.llvm.org/D100929 __

[PATCH] D101166: This commit tries to revert Clang commit 40beb1f84a to see if that's the cause of failures in the Runtimes build.

ldionne updated this revision to Diff 340077. ldionne added a comment. Smaller bisect Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101166/new/ https://reviews.llvm.org/D101166 Files: libcxx/test/std/utilities/template.bitset/bitset.members/left

[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:646 +def BuiltinAlias : Attr { + let Spellings = [Clang<"clang_builtin_alias">]; + let Args = [IdentifierArgument<"BuiltinName">]; Hrm, this is interesting -- this will allow the

[PATCH] D101108: [PR49761] Fix variadic arg handling in matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for the fix! LGTM with some minor nits. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4760-4765 + unsigned numArgs = Node.getNumArgs(); +

[PATCH] D69498: IR: Invert convergent attribute handling

nhaehnle added a comment. In D69498#2711396 , @foad wrote: > I don't have much to add to the conversation except to point out that this > definition defines `noconvergent` in terms of divergent control flow, but the > langref itself doesn't define what d

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert marked 2 inline comments as done. jdoerfert added a comment. I'm testing a new version that does not allocate the structure on the heap. Instead we copy it. It is really infrequent and it should be <40 bytes when that happens, let's not over-optimize ;) Repository: rG LLVM Github M

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

ABataev added a comment. In D101030#2712738 , @jdoerfert wrote: > I'm testing a new version that does not allocate the structure on the heap. > Instead we copy it. It is really infrequent and it should be <40 bytes when > that happens, let's not over-op

[clang] df82fa8 - [AST] Update tests to query for introspection support

Author: Stephen Kelly Date: 2021-04-23T17:51:10+01:00 New Revision: df82fa8d9ba6891c0ad1061fc452ea9f271d8ad4 URL: https://github.com/llvm/llvm-project/commit/df82fa8d9ba6891c0ad1061fc452ea9f271d8ad4 DIFF: https://github.com/llvm/llvm-project/commit/df82fa8d9ba6891c0ad1061fc452ea9f271d8ad4.diff

[PATCH] D101166: This commit tries to revert Clang commit 40beb1f84a to see if that's the cause of failures in the Runtimes build.

ldionne abandoned this revision. ldionne added a comment. Fixed by 3b71de41cc7c79ca03b0d3a5d7fd383abebf4167 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101166/new/ https://re

[PATCH] D101108: [PR49761] Fix variadic arg handling in matcher

chrish_ericsson_atx added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4760-4765 + unsigned numArgs = Node.getNumArgs(); + if (FProto && FProto->isVariadic() && FProto->getNumParams() < numArgs) { +numArgs = FProto->getNumParams(); + } + fo

[PATCH] D101066: [clangd] Dont index deeply nested symbols

kadircet updated this revision to Diff 340091. kadircet added a comment. - Move depth check into a helper and add tests for it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101066/new/ https://reviews.llvm.org/D101066 Files: clang-tools-extra/c

[PATCH] D100501: [cland] Dont emit missing newline warnings when building preamble

kadircet added a comment. > Hit send too soon. But IIRC PP knows whether it's building a preamble. That's a good point. But PP doesn't know if there's trailing content or not (in clangd's case). So we'll end up not showing the diag even when we should (i.e. whole file is preamble without a new

[PATCH] D101108: [PR49761] Fix variadic arg handling in matcher

chrish_ericsson_atx updated this revision to Diff 340094. chrish_ericsson_atx added a comment. Addressed feedback from aaron.ballman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101108/new/ https://reviews.llvm.org/D101108 Files: clang-tools-e

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 340095. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DelayedDiagnostic.h clang/lib/Parse/ParseD

[clang] cae3b70 - [PR49761] Fix variadic arg handling in matcher

Author: Chris Hamilton Date: 2021-04-23T12:07:14-05:00 New Revision: cae3b70cebc1b7b762a8b466cafca2d4189e72a7 URL: https://github.com/llvm/llvm-project/commit/cae3b70cebc1b7b762a8b466cafca2d4189e72a7 DIFF: https://github.com/llvm/llvm-project/commit/cae3b70cebc1b7b762a8b466cafca2d4189e72a7.diff

[PATCH] D101108: [PR49761] Fix variadic arg handling in matcher

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcae3b70cebc1: [PR49761] Fix variadic arg handling in matcher (authored by chrish_ericsson_atx). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D101051: [clang][deps] Only generate absolute paths when asked to

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, with one nit to pick. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:392 std::vector ModuleDeps; -std::vector AdditonalCommandLine; +std

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 340099. aorlov added a comment. Updated. @krisb, please, verify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 Files: clang/include/clang/Parse/Parser.h clang/incl

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

tlively added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:171 + +#define wasm_v128_load8_lane(__ptr, __vec, __i) \ + ((v128_t)__builtin_wasm_load8_lane((signed char *)(__ptr), (__i8x16)(__vec), \ aheejin wrote:

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

dschuff added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:171 + +#define wasm_v128_load8_lane(__ptr, __vec, __i) \ + ((v128_t)__builtin_wasm_load8_lane((signed char *)(__ptr), (__i8x16)(__vec), \ tlively wrote:

[PATCH] D101017: [NewPM] Make GlobalsAA available earlier in the pipeline

aeubanks added a comment. ah the issue is LoopIdiomRecognize can't recognize the following as a memcpy: @__const.f.c = private unnamed_addr constant [20 x double] [double 1.051000e-01, double 1.57e-02, double 1.85e-02, double 0x3F823A29C779A6B5, double 2.19e-02, double 1.41e-0

[clang] a92dbad - [OpenMP] Fix -Wdeprecated-copy

Author: Fangrui Song Date: 2021-04-23T10:49:19-07:00 New Revision: a92dbadffe4ff81cbae7303b0f3e723e26fa77b1 URL: https://github.com/llvm/llvm-project/commit/a92dbadffe4ff81cbae7303b0f3e723e26fa77b1 DIFF: https://github.com/llvm/llvm-project/commit/a92dbadffe4ff81cbae7303b0f3e723e26fa77b1.diff

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

tlively updated this revision to Diff 340109. tlively added a comment. - "stand" => "standard" - Update builtins for v128.any_true Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101112/new/ https://reviews.llvm.org/D101112 Files: clang/include/cl

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. Great. If it's been approved, I am not able to commit, so I think someone else will have to do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581 ___

[PATCH] D99993: [clang-tidy] bugprone-argument-comment: ignore name mismatches for decls from system headers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I don't think we need to add an option for this until a user requests one, but I don't feel strongly either way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert updated this revision to Diff 340126. jdoerfert added a comment. Avoid heap memory, copy when necessary, add documentation, address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101030/new/ https://reviews.llvm.org/D101030 Files

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

ABataev added a comment. Looks good, but would be nice to check with sanitizers that there are no uses-after-delete. Comment at: clang/lib/CodeGen/CGDecl.cpp:2618-2619 + for (const Expr *E : D->varlists()) { +auto *DE = cast(E); +auto *VD = cast(DE->getDecl()); +i

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

tlively added a comment. In D101112#2710521 , @aheejin wrote: > General question about SIMD intrinsics: So we make dedicated wasm intrinsics > only for the cases there are not general intrinsics people can use instead? No, every instruction in the propo

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

nikic added inline comments. Comment at: llvm/test/Transforms/InstCombine/logical-select.ll:385 +; CHECK-NEXT:[[OR:%.*]] = select i1 [[AND1]], i1 true, i1 [[AND2]] +; CHECK-NEXT:ret i1 [[OR]] ; It looks like this fold could be salvaged, if we wanted to:

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall, mibintc, erichkeane. Herald added subscribers: dexonsmith, arphaman, kbarton, nemanjai. aaron.ballman requested review of this revision. Herald added a project: clang. WG14 adopted N2645 and WG21 EWG has accepted

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek added a comment. FYI I had to revert this change again because it broke ubsan build. The problem is that ubsan for Darwin is built as universal shared library and it links against libc++abi, but we currently don't support building libc++ and libc++abi as universal binaries in the runtime

[PATCH] D101192: Add support for #elifdef and #elifndef

erichkeane added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:754 break; + case tok::pp_elifdef: + case tok::pp_elifndef: Just looking through this, so forgive me if I there is something I don't understand... Why is this not doing

[PATCH] D101057: [clangd] Allow AST request without range

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81dae18dff7f: [clangd] Allow AST request without range (authored by ckandeler, committed by sammccall). Changed prior to commit: https://reviews.l

[clang-tools-extra] 81dae18 - [clangd] Allow AST request without range

Author: Christian Kandeler Date: 2021-04-23T21:35:42+02:00 New Revision: 81dae18dff7fe8c2783c7b73e5c08167d6c60b47 URL: https://github.com/llvm/llvm-project/commit/81dae18dff7fe8c2783c7b73e5c08167d6c60b47 DIFF: https://github.com/llvm/llvm-project/commit/81dae18dff7fe8c2783c7b73e5c08167d6c60b47.

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman marked 4 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:754 break; + case tok::pp_elifdef: + case tok::pp_elifndef: erichkeane wrote: > Just looking through this, so forgive

[PATCH] D100782: [PowerPC] Improve f32 to i32 bitcast code gen

Conanap updated this revision to Diff 340141. Conanap added a comment. Updated to remove uncessary `xrsp` and other `xxsldwi` as well CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100782/new/ https://reviews.llvm.org/D100782 Files: llvm/lib/Target/PowerPC/PPCInstrVSX.td llvm/test/C

[PATCH] D101192: Add support for #elifdef and #elifndef

erichkeane added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:642 + + CheckEndOfDirective(IsElifDef ? "elifdef" : "elifndef"); + aaron.ballman wrote: > erichkeane wrote: > > Can you just pass 'Directive' here? > I think I'd have to pass `D

[PATCH] D98746: [clang][amdgpu] Use implicit code object default

JonChesterfield abandoned this revision. JonChesterfield added a comment. Abandoning in favour of the more conservative D101095 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98746/new/ https://reviews.llvm.org/D9

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

phosek created this revision. phosek added a reviewer: MaskRay. Herald added subscribers: jgravelle-google, sbc100, dschuff. phosek requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Different platforms use different rules for multiarc

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

nemanjai added a comment. This breaks Clang's ability to bootstrap LLVM with `-Werror` as evidenced by the buildbot failure https://lab.llvm.org/buildbot/#/builders/36/builds/7587. Please revert or fix the `googletest` code that trips this warning. Pertinent file: FAILED: unittests/Support/C

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert added a comment. In D101030#2713117 , @ABataev wrote: > Looks good, but would be nice to check with sanitizers that there are no > uses-after-delete. There is no heap allocation anymore but I guess I could have messed up the stack stuff. I do

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

tlively added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:171 + +#define wasm_v128_load8_lane(__ptr, __vec, __i) \ + ((v128_t)__builtin_wasm_load8_lane((signed char *)(__ptr), (__i8x16)(__vec), \ dschuff wrote:

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101030/new/ https://reviews.llvm.org/D101030 ___

[clang] 19b29b1 - [PowerPC] Provide XL-compatible builtins in altivec.h

Author: Nemanja Ivanovic Date: 2021-04-23T15:13:46-05:00 New Revision: 19b29b1ed1baa3c91a8e48204a8fb229bf07f548 URL: https://github.com/llvm/llvm-project/commit/19b29b1ed1baa3c91a8e48204a8fb229bf07f548 DIFF: https://github.com/llvm/llvm-project/commit/19b29b1ed1baa3c91a8e48204a8fb229bf07f548.di

[PATCH] D101130: [PowerPC] Provide XL-compatible builtins in altivec.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19b29b1ed1ba: [PowerPC] Provide XL-compatible builtins in altivec.h (authored by nemanjai). Changed prior to commit: https://reviews.llvm.org/D101

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

tlively added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:969 +static __inline__ v128_t __DEFAULT_FN_ATTRS wasm_f32x4_ceil(v128_t __a) { + return (v128_t)__builtin_wasm_ceil_f32x4((__f32x4)__a); +} aheejin wrote: > Sometimes builtin names seem

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek added a comment. I don't see any checks to ensure that the selected ABI is compatible with the specified target, is that something you plan on implementing in a follow up change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ htt

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

sammccall added a comment. Herald added a subscriber: cfe-commits. The test results look good, but I have trouble following the code, I think more comments might help :-) Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:140 + // similar except that we use

[PATCH] D100741: [clangd] Rename HeuristicResolver::resolveCallExpr() to resolveReturnTypeOfCallExpr()

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Herald added a subscriber: cfe-commits. Agree this is confusing, thanks for fixing! Comment at: clang-tools-extra/clangd/HeuristicResolver.h:57 + std::vector + resolv

[clang] 502f540 - [WebAssembly] Finalize wasm_simd128.h intrinsics

Author: Thomas Lively Date: 2021-04-23T13:37:27-07:00 New Revision: 502f54049d17f5a107f833596fb2c31297a99773 URL: https://github.com/llvm/llvm-project/commit/502f54049d17f5a107f833596fb2c31297a99773 DIFF: https://github.com/llvm/llvm-project/commit/502f54049d17f5a107f833596fb2c31297a99773.diff

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG502f54049d17: [WebAssembly] Finalize wasm_simd128.h intrinsics (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D70340: Add a key method to Sema to optimize debug info size

erichkeane added a comment. I guess my point is: a better comment would have saved me some time. Basically point out that the 'debug' info for the whole type is emitted with a virtual method, and that non-virtual types have it emitted in every TU. Also that this causes it to be emitted in onl

[PATCH] D100731: [clangd] Omit parameter hint for setter functions

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: cfe-commits. Comment at: clang-tools-extra/clangd/InlayHints.cpp:114 +// void setTimeout(int timeoutMillis); +return Name.subst

[PATCH] D101139: Create install targets for scan-build-py.

phosek added a comment. I don't think this is sufficient. First, we want to be explicit and always list individual files to install, we don't use patterns. Second, since libscanbuild is a library, it shouldn't be installed inside the `bin` directory. I think those should go either into `lib` or

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

dgoldman added a comment. Herald added a subscriber: cfe-commits. Friendly ping, not sure if there's something in here and https://reviews.llvm.org/D99975 that I'm missing to properly support the one decl/type loc to multiple references here Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D100841: [clangd][Index][NFC] Make local class collection optional

sammccall added a comment. Herald added a subscriber: cfe-commits. This seems reasonable, but having found the problem, do we still want to land it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100841/new/ https://reviews.llvm.org/D100841 __

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman updated this revision to Diff 340157. aaron.ballman marked 4 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101192/new/ https://reviews.llvm.org/D101192 Files: clang/include/clang/B

[clang] 94340dd - Enable AST introspection on non-X86

Author: Stephen Kelly Date: 2021-04-23T21:56:36+01:00 New Revision: 94340dd5bb23fb7c4bc7d91d5ac0608eb25660a8 URL: https://github.com/llvm/llvm-project/commit/94340dd5bb23fb7c4bc7d91d5ac0608eb25660a8 DIFF: https://github.com/llvm/llvm-project/commit/94340dd5bb23fb7c4bc7d91d5ac0608eb25660a8.diff

[PATCH] D101192: Add support for #elifdef and #elifndef

erichkeane added a comment. I have one 'nit of preference', otherwise I think I don't want to +1 this without giving people a few days to take a look. Based on my looks through the surrounding code, this _LOOKS_ right enough as far as I can tell, but I still want to give others a few days.

[PATCH] D100715: [clangd] Omit parameter hint if parameter name comment is present

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Herald added a subscriber: cfe-commits. Just a few optional ideas, this is fine as-is Comment at: clang-tools-extra/clangd/InlayHints.cpp:108 +// Allow the comment

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb added a comment. The python script assumes relative directory while finding things. For example, for resources folder, it uses os.path.join(this_dir, 'resources') in report.py, which means resource need to be in the same dir as report.py. Similarly for the libscanbuild. it assumes the

[PATCH] D101202: Thread safety analysis: Fix false negative on break

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We weren't modifying the lock set when intersecting with one coming from a break-termina

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb added a comment. In D101139#2713450 , @phosek wrote: > I don't think this is sufficient. First, we want to be explicit and always > list individual files to install, we don't use patterns. Second, since > libscanbuild is a library, it shouldn't

[clang] 572fe08 - Thread safety analysis: Simplify intersectAndWarn (NFC)

Author: Aaron Puchert Date: 2021-04-23T23:19:15+02:00 New Revision: 572fe087765626529d63eaaefb2e1c5ba277f756 URL: https://github.com/llvm/llvm-project/commit/572fe087765626529d63eaaefb2e1c5ba277f756 DIFF: https://github.com/llvm/llvm-project/commit/572fe087765626529d63eaaefb2e1c5ba277f756.diff

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen added a comment. In D100739#2711698 , @ChuanqiXu wrote: >> This is an alternative to D97915 which >> missed proper deallocation of the over-allocated frame. This patch handles >> both allocations and deallocations

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen added a comment. In D100739#2712268 , @lxfind wrote: >> Sorry for the confusion. I think either overaligned or under-aligned could >> be used here to describe the problem: either "Handle overaligned frame" or >> "Fix under-aligned frame". Since c+

[PATCH] D101097: [Sema] Don't set BlockDecl's DoesNotEscape bit If the block is being passed to a function taking a reference parameter

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:5917 if (auto *BE = dyn_cast(Arg->IgnoreParenNoopCasts(Context))) BE->getBlockDecl()->setDoesNotEscape(); rjmccall wrote: > We need to be checking that the parameter typ

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 added a comment. In D79714#2713311 , @nemanjai wrote: > This breaks Clang's ability to bootstrap LLVM with `-Werror` as evidenced by > the buildbot failure https://lab.llvm.org/buildbot/#/builders/36/builds/7587. > Please revert or fix the `googl

[PATCH] D99540: [clangd] Preserve diags between tweak enumeration and execution

sammccall added a comment. Herald added a subscriber: cfe-commits. Sorry about taking forever to get around to this, I kept looking at it and not understanding it. IIUC the idea is: - tweaks depend on various data from the codeAction request - but we only have the codeAction request when enumer

[PATCH] D101202: Thread safety analysis: Fix false negative on break

aaronpuchert added inline comments. Comment at: clang/test/SemaCXX/warn-thread-safety-analysis.cpp:341 + sls_mu.Unlock(); // \ +// expected-warning{{releasing mutex 'sls_mu' that was not held}} } This is just a side effect, not the reason I did the change.

[PATCH] D101097: [Sema] Don't set BlockDecl's DoesNotEscape bit If the block is being passed to a function taking a reference parameter

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:5917 if (auto *BE = dyn_cast(Arg->IgnoreParenNoopCasts(Context))) BE->getBlockDecl()->setDoesNotEscape(); ahatanak wrote: > rjmccall wrote: > > We need to be checking th

[PATCH] D99052: [clangd] Produce semantic token for name referring to UnresolvedUsingValueDecl

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: cfe-commits. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:655 +struct $Class_decl[[Derived]] : $

[PATCH] D99056: [clangd] Use HeuristicResolver to produce a better semantic token for name referring to UnresolvedUsingValueDecl

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Herald added a subscriber: cfe-commits. Very nice :-D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99056/new/ https://reviews.llvm.org/D9

[PATCH] D101095: [clang][amdgpu] Use implicit code object version

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. I talked with Tony about the code object version arguments of clang. In general we think we should move toward the direction of clang being agnostic about code object version and let backend d

[PATCH] D101143: [RISCV] [1/2] Add IR intrinsic for Zbe extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoB.td:36 def riscv_unshflw: SDNode<"RISCVISD::UNSHFLW",SDT_RISCVIntBinOpW>; +def riscv_bcompress: SDNode<"RISCVISD::BCOMPRESS", SDTIntBinOp>; +def riscv_bcompressw : SDNode<"RISCVISD::BCOM

[PATCH] D100823: [RISCV] Implement the pseudo compare builtin.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100823/new/ https://reviews.llvm.org/D100823 ___

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen abandoned this revision. ychen added a comment. Pursue D100739 instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915

[PATCH] D101097: [Sema] Don't set BlockDecl's DoesNotEscape bit If the block is being passed to a function taking a reference parameter

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:5917 if (auto *BE = dyn_cast(Arg->IgnoreParenNoopCasts(Context))) BE->getBlockDecl()->setDoesNotEscape(); rjmccall wrote: > ahatanak wrote: > > rjmccall wrote: > > > We

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

aheejin added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:171 + +#define wasm_v128_load8_lane(__ptr, __vec, __i) \ + ((v128_t)__builtin_wasm_load8_lane((signed char *)(__ptr), (__i8x16)(__vec), \ tlively wrote:

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

sammccall added a comment. LG apart from a few nits & reverting the whitespace changes to unrelated tests. Comment at: clang-tools-extra/clangd/FindTarget.cpp:435 void VisitObjCObjectType(const ObjCObjectType *OOT) { -// FIXME: ObjCObjectTypeLoc has no children f

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Oops, meant to approve with above comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98984/new/ https://reviews.llvm.org/D98984

[PATCH] D101095: [clang][amdgpu] Use implicit code object version

JonChesterfield added a comment. In D101095#2713652 , @yaxunl wrote: > In general we think we should move toward the direction of clang being > agnostic about code object version and let backend decide which code object > version to use This sounds the

[clang] fc88d92 - [clang][amdgpu] Use implicit code object version

Author: Jon Chesterfield Date: 2021-04-23T23:52:50+01:00 New Revision: fc88d927e30de93bf75aef8cd2a835675fe904bc URL: https://github.com/llvm/llvm-project/commit/fc88d927e30de93bf75aef8cd2a835675fe904bc DIFF: https://github.com/llvm/llvm-project/commit/fc88d927e30de93bf75aef8cd2a835675fe904bc.di

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

tlively added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:171 + +#define wasm_v128_load8_lane(__ptr, __vec, __i) \ + ((v128_t)__builtin_wasm_load8_lane((signed char *)(__ptr), (__i8x16)(__vec), \ aheejin wrote:

[PATCH] D101095: [clang][amdgpu] Use implicit code object version

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc88d927e30d: [clang][amdgpu] Use implicit code object version (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101095/new/ http

[PATCH] D99975: [clangd][ObjC] Improve support for class properties

sammccall added inline comments. Herald added a subscriber: cfe-commits. Comment at: clang-tools-extra/clangd/FindTarget.cpp:309-313 +// FIXME: visiting this here allows us to hover on UIColor in +// `UIColor.blackColor` but then `blackColor` no longer refers to t

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert added a comment. I'm fixing the tests now, also realized that the `omp allocate` handling now always creates definitions, which is bad. I'll upload a new version soon, test case for this, which shows we also don't do a good job now, is here: https://godbolt.org/z/T9od5Mq7h Repository

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Herald added a subscriber: tmatheson. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3104 << A->getAsString(Args) << TripleStr; -if (Value != "tls" && Value != "global") { +if (Value != "tls" && Value != "global" && Val

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 340192. nickdesaulniers added a comment. This revision is now accepted and ready to land. - fix 32b ARM triple, add test for non-zero offset, actually load ptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: llvm/test/CodeGen/AArch64/stack-guard-sysreg-nonzero-offset.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc %s --stack-protector-guard=sysreg \ This can be combined

<    1   2   3   >