ABataev added a comment.
Looks good, but would be nice to check with sanitizers that there are no
uses-after-delete.
================
Comment at: clang/lib/CodeGen/CGDecl.cpp:2618-2619
+ for (const Expr *E : D->varlists()) {
+ auto *DE = cast<DeclRefExpr>(E);
+ auto *VD = cast<VarDecl>(DE->getDecl());
+ if (VD->hasGlobalStorage())
----------------
`const auto *`
================
Comment at: clang/lib/Parse/ParseOpenMP.cpp:2142-2143
+ if (HasImplicitMappings) {
+ Actions.ActOnStartOpenMPDeclareTargetContext(DTCI);
+ return nullptr;
}
----------------
Would be good to check how it works with sanitizers.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101030/new/
https://reviews.llvm.org/D101030
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
