[PATCH] D100727: [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch.

HazardyKnusperkeks added a comment. In D100727#2697490 , @curdeius wrote: > In D100727#2697419 , > @HazardyKnusperkeks wrote: > >> How is >> >> if (a) return; >> else >> return; >> >> formatted with the d

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99031/new/ https://reviews.llvm.org/D99031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D100727: [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch.

curdeius added a comment. Oh, you're right. Should we go for a separate option then? AllowShortElseStatementsOnASingleLine? What would control else if statements then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100727/new/ https://reviews.llvm

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9985 + "Address space agnostic languages only"); + LangAS DefaultGlobalAS = getLangASFromTargetAS( + CGM.getContext().getTargetAddressSpace(LangAS::sycl_global)); Anastasia wr

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

curdeius added a comment. In D99031#2697563 , @aybassiouny wrote: > After rechecking, turns out `AllowShortLambdasOnASingleLine` and > `BeforeLambdaBody` both need to be turned on in order for the regression to > be expressed, this affects the UT. Pleas

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3498 + !Tok.isOneOf(TT_ObjCBlockLBrace, TT_DictLiteral) && + !Tok.Previous->Previous->is(tok::kw_namespace)); } Please add at least asserts for `Tok.Previous` and `

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 338441. ggeorgakoudis marked 2 inline comments as done. ggeorgakoudis added a comment. Update for comments, fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis marked 4 inline comments as done. ggeorgakoudis added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1150 llvm::Value *IsMaster = Bld.CreateICmpEQ(RT.getGPUThreadID(CGF), getMasterThreadID(CGF)); Bld.CreateCondBr(IsMaster, MasterB

[PATCH] D100727: [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch.

HazardyKnusperkeks added a comment. In D100727#2697815 , @curdeius wrote: > Oh, you're right. Should we go for a separate option then? > AllowShortElseStatementsOnASingleLine? What would control else if statements > then? I think I would prefer to expa

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity added a comment. @aaron.ballman @alexfh Bump! How shall we move further? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D20689/new/ https://reviews.llvm.org/D20689 ___ cfe-commits mailing list c

[PATCH] D100368: [X86] Support some missing intrinsics

LiuChen3 updated this revision to Diff 338443. LiuChen3 added a comment. 1. Rebase. 2. Adding _mm512_i32loscatter_epi64 and _mm512_mask_i32loscatter_epi64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100368/new/ https://reviews.llvm.org/D100368

[clang] 782b985 - [clang] Rename CompilerInvocationBase to RefBase, split out ValueBase

Author: Jan Svoboda Date: 2021-04-19T10:31:11+02:00 New Revision: 782b9858882dde5f63463ea89b88983e920e URL: https://github.com/llvm/llvm-project/commit/782b9858882dde5f63463ea89b88983e920e DIFF: https://github.com/llvm/llvm-project/commit/782b9858882dde5f63463ea89b88983e920e.diff L

[PATCH] D100455: [clang] Rename CompilerInvocationBase to RefBase, split out ValueBase

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG782b9858882d: [clang] Rename CompilerInvocationBase to RefBase, split out ValueBase (authored by jansvoboda11). Repository: rG LLVM Github Monorep

[PATCH] D100368: [X86] Support some missing intrinsics

LiuChen3 updated this revision to Diff 338445. LiuChen3 added a comment. Fix format issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100368/new/ https://reviews.llvm.org/D100368 Files: clang/lib/Headers/avx512fintrin.h clang/test/CodeGen/X

[PATCH] D100368: [X86] Support some missing intrinsics

LiuChen3 added inline comments. Comment at: clang/test/CodeGen/X86/avx512f-builtins.c:10853 + +__m512i test_mm512_mask_i32logather_epi64(__m512i __v1_old, __mmask8 __mask, __m512i __index, void const *__addr) { + // CHECK-LABEL: @test_mm512_mask_i32logather_epi64 --

[clang] 26bbb87 - [clang] Implement CompilerInvocation copy assignment

Author: Jan Svoboda Date: 2021-04-19T11:12:22+02:00 New Revision: 26bbb8700bb0ea0ce29e4158e5aa7999ab0d5386 URL: https://github.com/llvm/llvm-project/commit/26bbb8700bb0ea0ce29e4158e5aa7999ab0d5386 DIFF: https://github.com/llvm/llvm-project/commit/26bbb8700bb0ea0ce29e4158e5aa7999ab0d5386.diff L

[PATCH] D100473: [clang] Implement CompilerInvocation copy assignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG26bbb8700bb0: [clang] Implement CompilerInvocation copy assignment (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D100473?vs=337422&id=338449#toc Repository: rG LLVM Gi

[clang] 64e4dfd - [clang][cli] NFC: Use Diags to report parsing success/failure

Author: Jan Svoboda Date: 2021-04-19T11:17:16+02:00 New Revision: 64e4dfd72b42ba76186c61a6e463a5f5cbb0340c URL: https://github.com/llvm/llvm-project/commit/64e4dfd72b42ba76186c61a6e463a5f5cbb0340c DIFF: https://github.com/llvm/llvm-project/commit/64e4dfd72b42ba76186c61a6e463a5f5cbb0340c.diff L

[PATCH] D100644: [clang][cli] NFC: Use Diags to report parsing success/failure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64e4dfd72b42: [clang][cli] NFC: Use Diags to report parsing success/failure (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANG

[clang] 6cb7631 - [OpenCL] Change OpenCL builtin version encoding

Author: Sven van Haastregt Date: 2021-04-19T10:23:13+01:00 New Revision: 6cb7631df348a0fa8bb64c518d47838525f4a40b URL: https://github.com/llvm/llvm-project/commit/6cb7631df348a0fa8bb64c518d47838525f4a40b DIFF: https://github.com/llvm/llvm-project/commit/6cb7631df348a0fa8bb64c518d47838525f4a40b.

[PATCH] D100492: [OpenCL] Change OpenCL builtin version encoding

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6cb7631df348: [OpenCL] Change OpenCL builtin version encoding (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fb2aa63 - [clang][cli] NFC: Move conditional LangOptions parsing/generation

Author: Jan Svoboda Date: 2021-04-19T11:25:40+02:00 New Revision: fb2aa63d7dc54800d8a08df198e261a95bcefdbe URL: https://github.com/llvm/llvm-project/commit/fb2aa63d7dc54800d8a08df198e261a95bcefdbe DIFF: https://github.com/llvm/llvm-project/commit/fb2aa63d7dc54800d8a08df198e261a95bcefdbe.diff L

[PATCH] D100653: [clang][cli] NFC: Move conditional LangOptions parsing/generation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb2aa63d7dc5: [clang][cli] NFC: Move conditional LangOptions parsing/generation (authored by jansvoboda11). Repository: rG LLVM Github Monorepo C

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99839/new/ https://reviews.llvm.org/D99839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D99936: [clang][parser] Unify rejecting (non) decl stmt with gnu attributes

tbaeder updated this revision to Diff 338459. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99936/new/ https://reviews.llvm.org/D99936 Files: clang/lib/Parse/ParseStmt.cpp clang/test/SemaCXX/warn-unused-label-error.cpp Index: clang/test/SemaCXX/warn-unused-label-error.cpp =

[clang] 32219c8 - [clang][deps] Simplify function discovering .pcm and .modulemap files

Author: Jan Svoboda Date: 2021-04-19T12:11:39+02:00 New Revision: 32219c8c44787c79edbd68962b554860338651e8 URL: https://github.com/llvm/llvm-project/commit/32219c8c44787c79edbd68962b554860338651e8 DIFF: https://github.com/llvm/llvm-project/commit/32219c8c44787c79edbd68962b554860338651e8.diff L

[PATCH] D100531: [clang][deps] Simplify function discovering .pcm and .modulemap files

This revision was automatically updated to reflect the committed changes. Closed by commit rG32219c8c4478: [clang][deps] Simplify function discovering .pcm and .modulemap files (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D100531?vs=337647&id=338461#toc Reposit

[clang] 2b73565 - [clang][deps] Remove the -full-command-line flag

Author: Jan Svoboda Date: 2021-04-19T12:28:02+02:00 New Revision: 2b73565210ef0b3b29e0f067eef150a32adbb967 URL: https://github.com/llvm/llvm-project/commit/2b73565210ef0b3b29e0f067eef150a32adbb967 DIFF: https://github.com/llvm/llvm-project/commit/2b73565210ef0b3b29e0f067eef150a32adbb967.diff L

[PATCH] D100533: [clang][deps] Remove the -full-command-line flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b73565210ef: [clang][deps] Remove the -full-command-line flag (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D1005

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. In D100630#2694681 , @probinson wrote: > If DBX is going to be really pedantic about not recognizing tags or > attributes that don't align with the DWARF version, maybe we're better off > with really supporting `-gstrict-dwarf`

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

dblaikie added a comment. In D100630#2697728 , @shchenz wrote: > In D100630#2694681 , @probinson > wrote: > >> If DBX is going to be really pedantic about not recognizing tags or >> attributes that don't align w

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9985 + "Address space agnostic languages only"); + LangAS DefaultGlobalAS = getLangASFromTargetAS( + CGM.getContext().getTargetAddressSpace(LangAS::sycl_global)); bader wr

[clang] 320311a - [clang][parser] Unify rejecting (non) decl stmts with gnu attributes

Author: Timm Bäder Date: 2021-04-19T12:43:55+02:00 New Revision: 320311a01b4938fca8f5127193167d367d1a9f87 URL: https://github.com/llvm/llvm-project/commit/320311a01b4938fca8f5127193167d367d1a9f87 DIFF: https://github.com/llvm/llvm-project/commit/320311a01b4938fca8f5127193167d367d1a9f87.diff LO

[PATCH] D99936: [clang][parser] Unify rejecting (non) decl stmt with gnu attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG320311a01b49: [clang][parser] Unify rejecting (non) decl stmts with gnu attributes (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99936

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9985 + "Address space agnostic languages only"); + LangAS DefaultGlobalAS = getLangASFromTargetAS( + CGM.getContext().getTargetAddressSpace(LangAS::sycl_global)); Anastasia wr

[PATCH] D69498: IR: Invert convergent attribute handling

JonChesterfield added a subscriber: sameerds. JonChesterfield added a comment. Herald added subscribers: Naghasan, lxfind, okura, bbn, kuter, kerbowa, pengfei, jrtc27. Herald added a reviewer: sstefan1. Herald added a reviewer: baziotis. I've managed to run a bug in some freestanding c++ compiled

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

steakhal added a comment. I really want to move this forward so I made a further evaluation on this, on the MongoDB project. The analysis took approx. 22 and half hours on 24 cores for the baseline and for this revision as well. There were 7116 common reports, 5 disappeared and new 34 were intr

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

protze.joachim requested changes to this revision. protze.joachim added a comment. This revision now requires changes to proceed. I tested the patch and still get wrong results (I modified the `declare_mapper_nested_default_mappers_complex_structure.cpp` test to use my verbose printf from bugzil

[PATCH] D100752: clang-format: [JS] do not merge imports and exports.

mprobst created this revision. mprobst added a reviewer: krasimir. mprobst requested review of this revision. Herald added a project: clang. Previously, clang-format would erroneously merge import and export statements. These need to be kept separate, as the semantics differ. Repository: rG LL

[clang] fbc3259 - [SystemZ][z/OS] Set files in FileRemapper.cpp are text

Author: Abhina Sreeskantharajan Date: 2021-04-19T07:59:42-04:00 New Revision: fbc325934661076c9a7c17a5dba64c4983787503 URL: https://github.com/llvm/llvm-project/commit/fbc325934661076c9a7c17a5dba64c4983787503 DIFF: https://github.com/llvm/llvm-project/commit/fbc325934661076c9a7c17a5dba64c498378

[PATCH] D100056: [SystemZ][z/OS] Set files in FileRemapper.cpp are text

This revision was automatically updated to reflect the committed changes. Closed by commit rGfbc325934661: [SystemZ][z/OS] Set files in FileRemapper.cpp are text (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100

[PATCH] D100534: [clang][deps] Generate the full command-line for modules

jansvoboda11 added a comment. Thanks for the review! Comment at: clang/include/clang/Frontend/CompilerInstance.h:230 + + std::shared_ptr getInvocationPtr() { assert(Invocation && "Compiler instance has no invocation!"); dexonsmith wrote: > Is `get*Ptr()`

[clang] 0a92e09 - [clang][deps] Generate the full command-line for modules

Author: Jan Svoboda Date: 2021-04-19T14:32:49+02:00 New Revision: 0a92e09c078527b46e37e31dc8c2615a207c7639 URL: https://github.com/llvm/llvm-project/commit/0a92e09c078527b46e37e31dc8c2615a207c7639 DIFF: https://github.com/llvm/llvm-project/commit/0a92e09c078527b46e37e31dc8c2615a207c7639.diff L

[PATCH] D100534: [clang][deps] Generate the full command-line for modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a92e09c0785: [clang][deps] Generate the full command-line for modules (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.o

[PATCH] D100675: [clang] Do not crash on template specialization following a fatal error

adamcz updated this revision to Diff 338497. adamcz added a comment. minor changes to test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100675/new/ https://reviews.llvm.org/D100675 Files: clang/lib/Sema/SemaTemplateDeduction.cpp clang/test/Se

[clang] 95588c0 - [clang][deps] NFC: Remove unused FullDependencies member

Author: Jan Svoboda Date: 2021-04-19T15:02:54+02:00 New Revision: 95588c0da4ef08d8e497f7e4b094d96f6c38c3e5 URL: https://github.com/llvm/llvm-project/commit/95588c0da4ef08d8e497f7e4b094d96f6c38c3e5 DIFF: https://github.com/llvm/llvm-project/commit/95588c0da4ef08d8e497f7e4b094d96f6c38c3e5.diff L

[PATCH] D100536: [clang][deps] NFC: Remove unused FullDependencies member

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95588c0da4ef: [clang][deps] NFC: Remove unused FullDependencies member (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.o

[PATCH] D100759: Rename -show-skipped-includes to -fshow-skipped-includes and make it a driver option

hans created this revision. hans added a reviewer: thakis. Herald added subscribers: jansvoboda11, dang. hans requested review of this revision. Herald added a project: clang. This is a user-facing option, so it doesn't make sense for it to be cc1 only. Follow-up to D100420

[clang] bb36dc8 - Rename -show-skipped-includes to -fshow-skipped-includes and make it a driver option

Author: Hans Wennborg Date: 2021-04-19T15:22:15+02:00 New Revision: bb36dc8dcf1c4a16cafdafc6b225ec6036144f41 URL: https://github.com/llvm/llvm-project/commit/bb36dc8dcf1c4a16cafdafc6b225ec6036144f41 DIFF: https://github.com/llvm/llvm-project/commit/bb36dc8dcf1c4a16cafdafc6b225ec6036144f41.diff

[PATCH] D100759: Rename -show-skipped-includes to -fshow-skipped-includes and make it a driver option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb36dc8dcf1c: Rename -show-skipped-includes to -fshow-skipped-includes and make it a driver… (authored by hans). Repository: rG LLVM Github Monore

[PATCH] D100654: [SystemZ][z/OS] Set more text files as text

Jonathan.Crowther accepted this revision. Jonathan.Crowther added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100654/new/ https://reviews.llvm.org/D100654 _

[PATCH] D100727: [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch.

curdeius planned changes to this revision. curdeius added a subscriber: klimek. curdeius added a comment. More I look at the current state of this option, more I think it's misleading. I would expect that the if after else is also controlled by this option. And, the last else as well (adding yet

[PATCH] D100654: [SystemZ][z/OS] Set more text files as text

This revision was automatically updated to reflect the committed changes. Closed by commit rG05b4babc9d85: [SystemZ][z/OS] Set more text files as text (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100654/new/ h

[clang] 05b4bab - [SystemZ][z/OS] Set more text files as text

Author: Abhina Sreeskantharajan Date: 2021-04-19T09:31:46-04:00 New Revision: 05b4babc9d85a6669a39a58351fd8b1ebca2ab96 URL: https://github.com/llvm/llvm-project/commit/05b4babc9d85a6669a39a58351fd8b1ebca2ab96 DIFF: https://github.com/llvm/llvm-project/commit/05b4babc9d85a6669a39a58351fd8b1ebca2

[clang] aa1e391 - Fix test/Frontend/print-header-includes.c

Author: Hans Wennborg Date: 2021-04-19T15:39:09+02:00 New Revision: aa1e3914020b1211e6bdd306d4f5f2010971d6ee URL: https://github.com/llvm/llvm-project/commit/aa1e3914020b1211e6bdd306d4f5f2010971d6ee DIFF: https://github.com/llvm/llvm-project/commit/aa1e3914020b1211e6bdd306d4f5f2010971d6ee.diff

[PATCH] D100460: [WIP][clang] Move deep copy into CompilerInvocation::clone

jansvoboda11 updated this revision to Diff 338507. jansvoboda11 added a comment. Rebase, delete RefBase copy assignment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100460/new/ https://reviews.llvm.org/D100460 Files: clang-tools-extra/clangd/TU

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98193/new/ https://reviews.llvm.org/D98193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100762: [clang][cli] Extract AST dump format into extra option

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arichardson. Herald added subscribers: dang, usaxena95, kadircet, arphaman. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM, clang-tools-extra. Herald added subscribers: llvm-

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin updated this revision to Diff 338517. DmitryPolukhin added a comment. Put feature behind flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90835/new/ https://reviews.llvm.org/D90835 Files: clang-tools-extra/clang-tidy/ClangTidyDi

[PATCH] D93978: [clangd] Use dirty filesystem when performing cross file tweaks

njames93 updated this revision to Diff 338518. njames93 added a comment. Fix up compilation failures and test failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93978/new/ https://reviews.llvm.org/D93978 Files: clang-tools-extra/clangd/Clan

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin updated this revision to Diff 338520. DmitryPolukhin added a comment. Fix wrong character Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90835/new/ https://reviews.llvm.org/D90835 Files: clang-tools-extra/clang-tidy/ClangTidyDiagno

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev added a comment. In D100673#2698168 , @protze.joachim wrote: > I tested the patch and still get wrong results (I modified the > `declare_mapper_nested_default_mappers_complex_structure.cpp` test to use my > verbose printf from bugzilla): > >

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

fhahn added a comment. In D96418#2676338 , @lebedev.ri wrote: > Seems fine to me. > Might be good for someone else (@aaron.ballman ?) to also take a look, not > sure. ping. @aaron.ballman any chance you could take another quick look? Repository: rG L

[PATCH] D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: jfb, guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. In OpenMP 5.1, the required f

[PATCH] D99433: [Matrix] Including __builtin_matrix_multiply_add for the matrix type extension.

fhahn requested changes to this revision. fhahn added a comment. This revision now requires changes to proceed. In D99433#2662275 , @everton.constantino wrote: > Great, Ill update the patch then. Thanks for the comments! Sounds good to me, thanks! Markin

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:591-592 return Bld.CreateAnd(Bld.CreateNUWSub(NumThreads, Bld.getInt32(1)), Bld.CreateNot(Mask), "master_tid"); } This is another undefined codege

[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

rsanthir.quic added a comment. Thanks for looking into this @DavidSpickett ! What you found makes sense. I'll update this patch to remove only the poly128 vadd from the mapping. I'll also add another patch that will correctly enable the remaining vadd intrinsics for ARM. Repository: rG LLVM

[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

rsanthir.quic updated this revision to Diff 338539. rsanthir.quic added a comment. only the pol128 intrinsic is incompatible with ARM, the rest should be supported. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100499/new/ https://reviews.llvm.org/D100499 Files: clang/lib/CodeGen/CG

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

aaron.ballman added a comment. In D99861#2697449 , @Qix- wrote: > I'm not sure exactly how to continue after the last few comments - what > should the approach be for this patch? Or are these things we can shoot for > in later patches? I don't think the

[PATCH] D100772: [ARM] Neon Polynomial vadd Intrinsic fix

rsanthir.quic created this revision. rsanthir.quic added reviewers: t.p.northover, DavidSpickett, labrinea, apazos. Herald added subscribers: danielkiss, kristof.beyls. rsanthir.quic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Neon

[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

rsanthir.quic added a comment. Here's the fix for enabling these on ARM: https://reviews.llvm.org/D100772 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100499/new/ https://reviews.llvm.org/D100499 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Small test nit. LGTM otherwise. Comment at: clang/test/CodeGenCUDA/device-use-host-var.cu:22 + +// CHECK: store i32 1 +// CHECK: store i32 2 Nit: You may want to a

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/CodeGenCUDA/device-use-host-var.cu:22 + +// CHECK: store i32 1 +// CHECK: store i32 2 tra wrote: > Nit: You may want to add a `CHECK-LABEL: `. It does not make > much o

[clang] 6a72ed2 - [clang] NFC: Fix range-based for loop warnings related to decl lookup

Author: Jan Svoboda Date: 2021-04-19T18:31:31+02:00 New Revision: 6a72ed239cc3f30c1149721f07de463b4b459b16 URL: https://github.com/llvm/llvm-project/commit/6a72ed239cc3f30c1149721f07de463b4b459b16 DIFF: https://github.com/llvm/llvm-project/commit/6a72ed239cc3f30c1149721f07de463b4b459b16.diff L

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

aaron.ballman accepted this revision. aaron.ballman added a comment. I only found one tiny nit, and otherwise it LGTM, but this is a bit out of my wheelhouse. Comment at: clang/lib/CodeGen/CodeGenFunction.h:529 +// following (6.9.2.3.1 in C++11): +// - terminate, +

[clang] 369c0e0 - [AIX] Diagnose thinLTO usage in clang on AIX.

Author: Wael Yehia Date: 2021-04-19T16:39:48Z New Revision: 369c0e0f48dd3585566d251cc99955dbdeed84a1 URL: https://github.com/llvm/llvm-project/commit/369c0e0f48dd3585566d251cc99955dbdeed84a1 DIFF: https://github.com/llvm/llvm-project/commit/369c0e0f48dd3585566d251cc99955dbdeed84a1.diff LOG: [A

[PATCH] D100350: [AIX] Diagnose thinLTO usage in clang on AIX.

This revision was automatically updated to reflect the committed changes. Closed by commit rG369c0e0f48dd: [AIX] Diagnose thinLTO usage in clang on AIX. (authored by w2yehia). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok added a comment. In D99160#2671899 , @dblaikie wrote: > In D99160#2670460 , @djtodoro wrote: > >> In D99160#2669576 , @dblaikie wrote: >> >>> In D99160#2668977

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

MaskRay added subscribers: vitalybuka, eugenis. MaskRay added a comment. @eugenis @vitalybuka Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100251/new/ https://reviews.llvm.org/D100251 ___ cfe-commits ma

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 338551. pzheng added a comment. Add missing comments. Thanks for spotting it, @xbolva00. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNot

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

dblaikie added a comment. In D99160#2698980 , @alok wrote: > In D99160#2671899 , @dblaikie wrote: > >> In D99160#2670460 , @djtodoro wrote: >> >>> In D99160#2669576

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

yaxunl updated this revision to Diff 338552. yaxunl marked an inline comment as done. yaxunl added a comment. Rebase and fix HIP header bug exposed by this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98193/new/ https://reviews.llvm.org/D98193 Files: clang/lib/Headers/__clang

[PATCH] D99554: [ThinLTO] During module importing, close one source module before open another one for distributed mode.

tejohnson added a comment. In D99554#2674229 , @wenlei wrote: > Does this help non-distributed ThinLTO as well? cc: @weiwang No. See the note in Wei's description about this: > Note that this patch only changes the distributed thinlto mode. For in > pro

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 338554. ggeorgakoudis marked 2 inline comments as done. ggeorgakoudis added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/lib/Code

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. For the following function: void foo(std::unique_ptr P) { A* praw = P.get(); A* other = praw; if (other) {} P->foo(); } Where do we expect a note? Where `praw` is initialized, where `other` is initialized or both? Repository: rG LLVM Github Mono

[PATCH] D100720: [AST] Update introspection API to use const-ref for copyable types

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LG with 1 nit. Comment at: clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py:14 +RefClades = ["NestedNameSpecifierLoc", "TemplateArgumentLoc", "TypeLoc"] + --

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

thakis created this revision. thakis added a reviewer: rnk. Herald added subscribers: dexonsmith, kerbowa, kbarton, mgorny, nhaehnle, jvesely, nemanjai. thakis requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reverts parts of https://review

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 338565. abhina.sreeskantharajan added a comment. Rebase + set size of char as 1 when creating a StringRef to fix lit failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93031/new/ https://revi

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos created this revision. penagos added reviewers: Saldivarcher, MyDeveloperDay, JakeMerdichAMD, krasimir. penagos requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This serves to augment the improvements made in https://reviews.llvm.or

[PATCH] D100282: [Coroutines] Set presplit attribute in Clang instead of CoroEarly pass

rjmccall added a comment. MLIR is an in-tree project that can be updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100282/new/ https://reviews.llvm.org/D100282 ___ cfe-commits mailing list cfe-commi

[PATCH] D98995: [CGAtomic] Lift stronger requirements on cmpxch and add support for acquire failure mode

yln added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:444-447 +// Prior to c++17, "the failure argument shall be no stronger than the +// success argument". This condition has been lifted and the only +// precondition is 31.7.2.18. Effectively treat th

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

yaxunl updated this revision to Diff 338575. yaxunl added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77013/new/ https://reviews.llvm.org/D77013 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen/TargetI

[PATCH] D100282: [Coroutines] Set presplit attribute in Clang instead of CoroEarly pass

lxfind added a comment. In D100282#2699171 , @rjmccall wrote: > MLIR is an in-tree project that can be updated. Sure, but I think there are some important differences. As far as I understand, in MLIR, unlike in C++/Swift frontend where a coroutine funct

[PATCH] D100762: [clang][cli] Extract AST dump format into extra option

dexonsmith requested changes to this revision. dexonsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/test/AST/ast-dump-comment-json.cpp:44 // CHECK-NEXT: "loc": { -// CHECK-NEXT: "offset": 72, +// CHECK-NEXT: "offset": 89, // CH

[PATCH] D100762: [clang][cli] Extract AST dump format into extra option

arichardson requested changes to this revision. arichardson added a reviewer: aaron.ballman. arichardson added a comment. I'm not sure it's a good idea to remove the `-ast-dump=json` option. While this is -cc1 option, there do seem to be external consumers based on a quick search for "-ast-dump=

[clang] d880557 - [CUDA][HIP] Allow non-ODR use of host var in device

Author: Yaxun (Sam) Liu Date: 2021-04-19T14:45:24-04:00 New Revision: d8805574c183484f02855fa82d2e8932415e URL: https://github.com/llvm/llvm-project/commit/d8805574c183484f02855fa82d2e8932415e DIFF: https://github.com/llvm/llvm-project/commit/d8805574c183484f02855fa82d2e8932415e.dif

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8805574c183: [CUDA][HIP] Allow non-ODR use of host var in device (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D100620: [OpenMP] Make sure classes work on the device as they do on the host

JonChesterfield added inline comments. Comment at: clang/lib/Headers/openmp_wrappers/__clang_openmp_device_functions.h:20 +// need to `include `. +#include +#endif jdoerfert wrote: > JonChesterfield wrote: > > I think there are legitimate use cases for writing

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

Quuxplusone added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7652 + verifyFormat("test < a - 1 >> 1;"); verifyFormat("test >> a >> b;"); IMO you should use `"test < a | b >> c;"` as your test case here, to reassure the reader that i

[PATCH] D100782: [PowerPC] Improve f32 to i32 bitcast code gen

Conanap created this revision. Conanap added reviewers: saghir, nemanjai, PowerPC. Conanap added projects: PowerPC, clang, LLVM. Herald added a subscriber: kbarton. Conanap requested review of this revision. The code gen for f32 to i32 bitcast is not currently the most efficient. For example:

  1   2   >