JonChesterfield added a subscriber: sameerds. JonChesterfield added a comment. Herald added subscribers: Naghasan, lxfind, okura, bbn, kuter, kerbowa, pengfei, jrtc27. Herald added a reviewer: sstefan1. Herald added a reviewer: baziotis.
I've managed to run a bug in some freestanding c++ compiled for amdgpu down to forgetting the convergent attribute in strategic places. OpenMP does now set the current attribute correctly, I think. I wonder if anyone has audited all the rocm device code to verify it is correctly annotated. The trailing comments above are 'that works for me' and 'not strongly opposed'. @sameerds is this something you're looking at picking up? Patch has probably rotted a bit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69498/new/ https://reviews.llvm.org/D69498 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits