[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha updated this revision to Diff 335216. SaurabhJha added a comment. Move back CK_MatrixCast definition to to just above CK_VectorSplat. The Matrix CodeGen is passing again but SemaOpenCL/sampler tests are failing again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99877: [Clang] Allow processing of attributes on statements by plugins

Qix- created this revision. Qix- added a reviewer: aaron.ballman. Qix- added a project: clang. Qix- requested review of this revision. Herald added a subscriber: cfe-commits. Pretty cut and dry; currently plugins can create attributes for declarations but any that are not recognized produce a dia

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban updated this revision to Diff 335221. yrouban marked 2 inline comments as done. yrouban added a comment. Addressed comments. Some tests were moved a separate patch (D99878 ). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91327/new/ https://revie

[clang] 1628486 - ignore -flto= options recognized by GCC

Author: Sylvestre Ledru Date: 2021-04-05T11:54:17+02:00 New Revision: 1628486548420f85b3467026d54663d1516404f5 URL: https://github.com/llvm/llvm-project/commit/1628486548420f85b3467026d54663d1516404f5 DIFF: https://github.com/llvm/llvm-project/commit/1628486548420f85b3467026d54663d1516404f5.dif

[PATCH] D99501: ignore -flto= options recognized by GCC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG162848654842: ignore -flto= options recognized by GCC (authored by sylvestre.ledru). Herald added a project: clang. Herald added a subscriber: cfe-co

[PATCH] D99501: ignore -flto= options recognized by GCC

lebedev.ri added a comment. Tests missing. This somehow wasn't sent to cfe-commits list Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99501/new/ https://reviews.llvm.org/D99501 ___ cfe-commits mailing li

[PATCH] D99879: [clang][cli] Ensure plugin args are generated in deterministic order

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, akhuang. Herald added a subscriber: mgrang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The '-plugin-arg' command-line arguments are n

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

jansvoboda11 added a comment. In D97462#298 , @dexonsmith wrote: > In D97462#2666485 , @jansvoboda11 > wrote: > >> Thanks for reporting that. D99606 fixes >> one aspect of `-p

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added a comment. @rjmccall @mstorsjo @aaron.ballman any advice on what to do next? Should I bring this discussion back to llvm-dev? I don't want this to justs stall here. I would like to have a clear decision on why it is or it is not a good idea to merge this in LLVM. Thanks! Reposi

[clang] 4dd3e0f - [DebugInfo, CallSites, test] Fix use of undef FileCheck var

Author: Thomas Preud'homme Date: 2021-04-05T11:39:24+01:00 New Revision: 4dd3e0feca9295c615f06f9f96f1e7ccdd63bb3d URL: https://github.com/llvm/llvm-project/commit/4dd3e0feca9295c615f06f9f96f1e7ccdd63bb3d DIFF: https://github.com/llvm/llvm-project/commit/4dd3e0feca9295c615f06f9f96f1e7ccdd63bb3d.

[PATCH] D99830: [DebugInfo, CallSites, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rG4dd3e0feca92: [DebugInfo, CallSites, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99830/new/ htt

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

skatkov accepted this revision. skatkov added a comment. This revision is now accepted and ready to land. with two nits. Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:422 + // Register all the standard instrumentation callbacks. If \p FAM is nullptr + // the

[PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. Is there any more feedback on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99426/new/ https://reviews.llvm.org/D99426 ___ cfe-commits mailing list cf

[PATCH] D99848: [OPENMP51]Initial support for nocontext clause

ABataev added a comment. Formatting Comment at: clang/lib/Sema/SemaOpenMP.cpp:14908 llvm::MapVector Captures; + ValExpr = tryBuildCapture(*this, ValExpr, Captures).get(); HelperValStmt = buildPreInits(Context, Captures); This must be fixed in

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranchCheck.cpp:200 + if (isa(Loop)) +return DO_LOOP; // loop_type = 0; + else if (isa(Loop)) Is loop ID is not enough? Why does comment with numerical

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 335246. arnamoy10 added a comment. 1. Separated test cases to check prescan, parse and sema differently. 2. Diagnostics is thrown when anything other that `error` is given for `-W`. This behaviour is reflected in `f18 CHANGES SINCE LAST ACTION https://

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 335255. arnamoy10 added a comment. Adding newline at the end of a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98657/new/ https://reviews.llvm.org/D98657 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Fla

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:561-568 + for (const auto *A : Attrs) { +if (A->getKind() == attr::MustTail) { + if (!checkMustTailAttr(SubStmt, *A)) { +return SubStmt; + } + setFunctionHasMustTail(); +}

[PATCH] D98657: [flang][driver] Add options for -Werror

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thank you for addressing my comments! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98657/new/ https://reviews.llvm.org/D98657 _

[PATCH] D99199: Make -fcrash-diagnostics-dir control the Windows (mini-)dump location

probinson added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99199/new/ https://reviews.llvm.org/D99199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

djtodoro added a comment. I think that the Debug Entry Values feature should not be enabled by default for non optimized code, so the `TargetOptions::ShouldEmitDebugEntryValues()` should be patched with checking of optimization level (it should be > 0). CHANGES SINCE LAST ACTION https://revi

[clang] 803b792 - [SemaObjC] Fix a -Wbridge-cast false-positive

Author: Erik Pilkington Date: 2021-04-05T11:41:40-04:00 New Revision: 803b79221edfc2517e6bfc373e5f55609565b0e4 URL: https://github.com/llvm/llvm-project/commit/803b79221edfc2517e6bfc373e5f55609565b0e4 DIFF: https://github.com/llvm/llvm-project/commit/803b79221edfc2517e6bfc373e5f55609565b0e4.dif

[PATCH] D99661: [SemaObjC] Fix a -Wbridge-cast false-positive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG803b79221edf: [SemaObjC] Fix a -Wbridge-cast false-positive (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Gith

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski added a comment. Hi @protze.joachim , thank you for testing this so thoroughly! In D99353#2656215 , @protze.joachim wrote: > I tested with `-Werror`: > > $ flang -fopenmp test-f77.f -ffree-form -c > $ clang -fopenmp test-f77.o -ffree-form

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl marked 4 inline comments as done. yaxunl added a comment. In D99683#2664674 , @tejohnson wrote: > I haven't looked extensively yet, but why import noinline functions? Also, > please add a patch description. AMDGPU backend does not support linking

[PATCH] D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::".

flx updated this revision to Diff 335267. flx marked an inline comment as done. flx added a comment. Create a NameMatcher class that handles matching against the best name variant (unqualified, qualified, fully qualified) of the NamedDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::".

flx marked 2 inline comments as done. flx added a comment. Thanks for the comments, PTAL! Comment at: clang-tools-extra/clang-tidy/utils/Matchers.h:79 +llvm::Regex Regex; +bool MatchQualifiedName = false; + }; ymandel wrote: > Worth a comment i think.

[PATCH] D99683: [HIP] Support ThinLTO

tejohnson added a comment. In D99683#2669047 , @yaxunl wrote: > In D99683#2664674 , @tejohnson wrote: > >> I haven't looked extensively yet, but why import noinline functions? Also, >> please add a patch descriptio

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski updated this revision to Diff 335270. awarzynski added a comment. Herald added subscribers: jansvoboda11, dang. Refine the behaviour when using diag options and add tests - `-Werror` will now elevate the warning generated here to an error. This is consistent with `gcc`. To this end I

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl updated this revision to Diff 335268. yaxunl marked 4 inline comments as done. yaxunl edited the summary of this revision. yaxunl added a comment. Herald added a subscriber: tpr. Revise by Artem's comments. Add patch description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99683

[PATCH] D99848: [OPENMP51]Initial support for nocontext clause

jyu2 updated this revision to Diff 335272. jyu2 added a comment. Fix formatting problem and address Alexey's comment. Thanks Alexey for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99848/new/ https://reviews.llvm.org/D99848 Files:

[PATCH] D99848: [OPENMP51]Initial support for nocontext clause

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:14908 llvm::MapVector Captures; + ValExpr = tryBuildCapture(*this, ValExpr, Captures).get(); HelperValStmt = buildPreInits(Context, Captures); ABataev wrote: > This must be f

[PATCH] D99848: [OPENMP51]Initial support for nocontext clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99848/new/ https://reviews.llvm.org/D99848 ___ c

[PATCH] D99811: [TextAPI] move source code files out of subdirectory, NFC

ributzka accepted this revision. ributzka added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99811/new/ https://reviews.llvm.org/D99811 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl added a comment. In D99683#2669080 , @tejohnson wrote: > In D99683#2669047 , @yaxunl wrote: > >> In D99683#2664674 , @tejohnson >> wrote: >> >>> I haven't looked exte

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski updated this revision to Diff 335275. awarzynski added a comment. Add more reviewers and remove unrelated changes (apologies for the noise!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99353/new/ https://reviews.llvm.org/D99353 Files:

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski added inline comments. Comment at: clang/lib/Driver/Driver.cpp:294-297 +// TODO: This currently doesn't work as information about aliases is +// lost when generating "unknown" options. +if (auto Alias = A->getAlias()) + ExpectedDistance

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 335157. Ericson2314 added a comment. Don't use CMAKE_INTALL_LIBDIR or convert compiler-rt for now These steps were suggested by @compnerd, IIUC. The compiler-rt stuff is in flux because I am now skeptical whether `COMPILER_RT_INSTALL_PATH` can now be so e

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Meinersbur added a comment. In D99484#2668225 , @Ericson2314 wrote: > Additionally, I have cleaned up the `polly` code so that I need not change it > so much, and it should still work with absolute or relative paths quite > flexibly. Looks fine to me. R

[PATCH] D99260: [analyzer] Fix false positives in inner pointer checker (PR49628)

NoQ added a comment. > It does make sense to split these in two, but I'm not so sure about > `evalCall`. `evalCall` should work great for this purpose but definitely not in this checker. Also this checker would still exercise its `checkPostCall` so it would still need to be silenced even if `e

[PATCH] D99181: [analyzer] Fix crash on spaceship operator (PR47511)

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp:169-171 + } else if (B->getOpcode() == BinaryOperatorKind::BO_Cmp) { +// We can't reason about C++20 spaceship operator yet. +return; steakhal wro

[PATCH] D99601: [-Wcompletion-handler] Don't recognize init methods as conventional

NoQ added inline comments. Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:1017 + static bool isInitMethod(Selector MethodSelector) { +return MethodSelector.getNameForSlot(0).startswith_lower(INIT_PREFIX); + } You can formally check whether it's an init

[clang] 7416e8a - [flang][driver] Add options for -Werror

Author: Arnamoy Bhattacharyya Date: 2021-04-05T12:47:52-04:00 New Revision: 7416e8a8431a0f2711be9d16e111d1781b74df96 URL: https://github.com/llvm/llvm-project/commit/7416e8a8431a0f2711be9d16e111d1781b74df96 DIFF: https://github.com/llvm/llvm-project/commit/7416e8a8431a0f2711be9d16e111d1781b74df

[PATCH] D98657: [flang][driver] Add options for -Werror

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7416e8a8431a: [flang][driver] Add options for -Werror (authored by arnamoy10). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] df64f47 - [analyzer] DynamicSize: Store the dynamic size

Author: Charusso Date: 2021-04-05T19:04:53+02:00 New Revision: df64f471d1e26fc1e9e2f9cdcfc77c063fe55b56 URL: https://github.com/llvm/llvm-project/commit/df64f471d1e26fc1e9e2f9cdcfc77c063fe55b56 DIFF: https://github.com/llvm/llvm-project/commit/df64f471d1e26fc1e9e2f9cdcfc77c063fe55b56.diff LOG:

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

This revision was automatically updated to reflect the committed changes. Charusso marked an inline comment as done. Closed by commit rGdf64f471d1e2: [analyzer] DynamicSize: Store the dynamic size (authored by Charusso). Changed prior to commit: https://reviews.llvm.org/D69726?vs=319940&id=3352

[clang] 89d210f - [analyzer] DynamicSize: Debug facility

Author: Charusso Date: 2021-04-05T19:17:52+02:00 New Revision: 89d210fe1a7a1c6cbf926df0595b6f107bc491d5 URL: https://github.com/llvm/llvm-project/commit/89d210fe1a7a1c6cbf926df0595b6f107bc491d5 DIFF: https://github.com/llvm/llvm-project/commit/89d210fe1a7a1c6cbf926df0595b6f107bc491d5.diff LOG:

[clang] 9b3df78 - [analyzer] DynamicSize: Rename 'size' to 'extent'

Author: Charusso Date: 2021-04-05T19:20:43+02:00 New Revision: 9b3df78b4c2ab7a7063e532165492e1ffa38d401 URL: https://github.com/llvm/llvm-project/commit/9b3df78b4c2ab7a7063e532165492e1ffa38d401 DIFF: https://github.com/llvm/llvm-project/commit/9b3df78b4c2ab7a7063e532165492e1ffa38d401.diff LOG:

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso added a comment. Cool, thanks! Debug facility NFC: https://reviews.llvm.org/rG89d210fe1a7a1c6cbf926df0595b6f107bc491d5 `size` -> `extent` conversion: https://reviews.llvm.org/rG9b3df78b4c2ab7a7063e532165492e1ffa38d401 Comment at: clang/lib/StaticAnalyzer/Checkers/Ex

[clang] 0116d04 - [TextAPI] move source code files out of subdirectory, NFC

Author: Cyndy Ishida Date: 2021-04-05T10:24:42-07:00 New Revision: 0116d04d04f20e9ae62ba847075840c3cb298080 URL: https://github.com/llvm/llvm-project/commit/0116d04d04f20e9ae62ba847075840c3cb298080 DIFF: https://github.com/llvm/llvm-project/commit/0116d04d04f20e9ae62ba847075840c3cb298080.diff

[PATCH] D99811: [TextAPI] move source code files out of subdirectory, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0116d04d04f2: [TextAPI] move source code files out of subdirectory, NFC (authored by cishida). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall)).

varungandhi-apple updated this revision to Diff 335293. varungandhi-apple added a comment. Herald added subscribers: llvm-commits, dexonsmith, hiraditya. Herald added a project: LLVM. 1. Remove '::' when calling static function. 2. Fix bug in function merging around missing musttail. 3. Add off-by

[PATCH] D99857: [OpenCL, test] Fix use of undef FileCheck var

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99857/new/ https://reviews.llvm.org/D99857

[PATCH] D98726: [analyzer] Enabling MallocChecker to take up after SmartPtrModelling

NoQ added a comment. In D98726#2630947 , @RedDocMD wrote: > @NoQ, regarding https://godbolt.org/z/1EczEW, I don't think there should be a > warning since the original pointer may be needed in the caller. You're absolutely right! I missed this point! I s

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5011 +!ValType->isFloatingType()) { + Diag(ExprRange.getBegin(), diag::err_atomic_op_needs_atomic_int_ptr_or_fp) << IsC11 << Ptr->getType() << Ptr->getSourceRange(); -

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

flx added a comment. Could someone take a look at this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D99879: [clang][cli] Ensure plugin args are generated in deterministic order

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Based on git-blame, this was added in 6c78974b298d619ec11e243fb6fdea0b16f87a66 (https://reviews.llvm.org/D17959) and the choice of unordered vs. ordered looks incidental (not mot

[PATCH] D99199: Make -fcrash-diagnostics-dir control the Windows (mini-)dump location

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99199/new/ https://reviews.llvm.org/D99199 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D99893: [WIP] Replace std::forward & std::move by cast expression

cor3ntin created this revision. Herald added subscribers: dexonsmith, martong. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99893 Files: clang/include/clang/AST

[clang] 7078ef4 - [OPENMP51]Initial support for nocontext clause.

Author: Jennifer Yu Date: 2021-04-05T11:45:49-07:00 New Revision: 7078ef47225091a9a42357b9ebf92e83a5665d43 URL: https://github.com/llvm/llvm-project/commit/7078ef47225091a9a42357b9ebf92e83a5665d43 DIFF: https://github.com/llvm/llvm-project/commit/7078ef47225091a9a42357b9ebf92e83a5665d43.diff L

[PATCH] D99848: [OPENMP51]Initial support for nocontext clause

This revision was automatically updated to reflect the committed changes. jyu2 marked an inline comment as done and an inline comment as not done. Closed by commit rG7078ef472250: [OPENMP51]Initial support for nocontext clause. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:561-568 + for (const auto *A : Attrs) { +if (A->getKind() == attr::MustTail) { + if (!checkMustTailAttr(SubStmt, *A)) { +return SubStmt; + } + setFunctionHasMustTail(); +}

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen marked 13 inline comments as done. tentzen added a comment. hi, I believe I'd addressed all issues or concerns, and it's rebased to up-to-date source in new _main branch now. Does this look good to everyone? If I don't hear any objection in a couple of days, I will go ahead make this pa

[PATCH] D99893: [WIP] Replace std::forward & std::move by cast expressions during Sema

aaron.ballman added reviewers: rsmith, Quuxplusone, rjmccall. aaron.ballman added a comment. Adding a few more reviewers for early feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99893/new/ https://reviews.llvm.org/D99893 _

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

fhahn added a comment. In D99037#2667484 , @SaurabhJha wrote: > Addressed most of the comments. I couldn't understand "..would also be good > to have C++ tests that test casting with matrix types where some of the > dimensions are template arguments...".

[PATCH] D89490: Introduce __attribute__((darwin_abi))

rjmccall added a comment. Sorry, it's just been a busy month for me. In D89490#2539950 , @aguinet wrote: > In D89490#2516255 , @rjmccall wrote: > >> In D89490#2514695 , @agu

[PATCH] D99893: [WIP] Replace std::forward & std::move by cast expressions during Sema

lebedev.ri added a comment. To be noted, this generally goes against the [current] spirit of the AST, those were calls in the source code, but they won't be represented as such any longer, which is likely not very expected by whatever tool that could be consuming the AST. Though, i'm not sure ho

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1324 + +if (SrcElementTy->isFloatTy() || SrcElementTy->isDoubleTy()) { + QualType DstElementType = DstType->castAs()->getElementType(); I think we should support all floating po

[PATCH] D99893: [WIP] Replace std::forward & std::move by cast expressions during Sema

rjmccall added a comment. I think a pattern-match in IRGen is probably a much more reasonable alternative if the goal is primarily to avoid the code-generation overheads at -O0 / optimization costs at -O. You'd still have template instantiation overheads; I don't know how significant those rea

[PATCH] D99879: [clang][cli] Ensure plugin args are generated in deterministic order

akhuang added a comment. also just confirming that this fixes the issue we were seeing in Chrome Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99879/new/ https://reviews.llvm.org/D99879 ___ cfe-commits m

[PATCH] D99896: Rework the way statement attributes are processed; NFC

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, haberman, erichkeane. aaron.ballman requested review of this revision. Herald added a project: clang. This changes our approach to processing statement attributes to be more similar to how we process declaration attribute

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:561-568 + for (const auto *A : Attrs) { +if (A->getKind() == attr::MustTail) { + if (!checkMustTailAttr(SubStmt, *A)) { +return SubStmt; + } + setFunctionHasMustTail(); +}

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:588 + + const CallExpr *CE = dyn_cast(Ex->IgnoreUnlessSpelledInSource()); + haberman wrote: > rsmith wrote: > > `IgnoreUnlessSpelledInSource` is a syntactic check that's only really > > inten

[clang] 828ec9e - [OpenCL, test] Fix use of undef FileCheck var

Author: Thomas Preud'homme Date: 2021-04-05T21:11:39+01:00 New Revision: 828ec9e9e5da8a2e7d1bfa523b9a712658ee6ffc URL: https://github.com/llvm/llvm-project/commit/828ec9e9e5da8a2e7d1bfa523b9a712658ee6ffc DIFF: https://github.com/llvm/llvm-project/commit/828ec9e9e5da8a2e7d1bfa523b9a712658ee6ffc.

[PATCH] D99857: [OpenCL, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rG828ec9e9e5da: [OpenCL, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99857/new/ https://reviews.l

[PATCH] D99896: Rework the way statement attributes are processed; NFC

erichkeane added a comment. It is really sad that the attributes can't 'auto transform' themselves. ParsedAttr could (since it has a union of expressions/identifiers), but we don't really seem to have a good way to do it for Attr. Could we possibly do some table-gen to auto create the 'simple'

[PATCH] D99896: Rework the way statement attributes are processed; NFC

aaron.ballman added a comment. In D99896#2669471 , @erichkeane wrote: > It is really sad that the attributes can't 'auto transform' themselves. > ParsedAttr could (since it has a union of expressions/identifiers), but we > don't really seem to have a go

[PATCH] D99896: Rework the way statement attributes are processed; NFC

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. SGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99896/new/ https://reviews.llvm.org/D99896

[PATCH] D99896: Rework the way statement attributes are processed; NFC

haberman added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:1316 Stmt *SubStmt) { -return SemaRef.ActOnAttributedStmt(AttrLoc, Attrs, SubStmt); +return SemaRef.BuildAttributedStmt(AttrLoc, Attrs, SubStmt); } --

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: ddunbar, MaskRay, rjmccall, spatel, arsenm, hfinkel, void, mcrosier. thopre requested review of this revision. Herald added a subscriber: wdng. Herald added a project: clang. Clang test CodeGen/libcalls.c contains CHECK-NOT directives using a

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

dblaikie added a comment. In D99160#2668977 , @djtodoro wrote: > I think that the Debug Entry Values feature should not be enabled by default > for non optimized code, so the `TargetOptions::ShouldEmitDebugEntryValues()` > should be patched with checking

[PATCH] D99901: [Driver][test] Test intended target only

jsji created this revision. jsji added a reviewer: MaskRay. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 6fe7de90b9e4e466a5c2baadafd5f72d3203651d changed GNU to

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze updated this revision to Diff 335334. zukatsinadze edited the summary of this revision. zukatsinadze added a comment. Gentle ping - Diff with context - Added some more tests - Updated documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D99896: Rework the way statement attributes are processed; NFC

aaron.ballman added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:1316 Stmt *SubStmt) { -return SemaRef.ActOnAttributedStmt(AttrLoc, Attrs, SubStmt); +return SemaRef.BuildAttributedStmt(AttrLoc, Attrs, SubStmt); } -

[clang] 9711118 - Rework the way statement attributes are processed; NFC

Author: Aaron Ballman Date: 2021-04-05T17:52:17-04:00 New Revision: 978d2edf7aed133616de1eb7f633c263c4b5 URL: https://github.com/llvm/llvm-project/commit/978d2edf7aed133616de1eb7f633c263c4b5 DIFF: https://github.com/llvm/llvm-project/commit/978d2edf7aed133616de1eb7f633c263c4b5.diff

[PATCH] D99896: Rework the way statement attributes are processed; NFC

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in 978d2edf7aed133616de1eb7f633c263c4b5 , thanks for the really quick reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D99896: Rework the way statement attributes are processed; NFC

haberman added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:1316 Stmt *SubStmt) { -return SemaRef.ActOnAttributedStmt(AttrLoc, Attrs, SubStmt); +return SemaRef.BuildAttributedStmt(AttrLoc, Attrs, SubStmt); } --

[PATCH] D99903: [Clang][Sema] better -Wcast-function-type diagnose for pointer parameters and parameters with cv-qualifiers

ychen created this revision. ychen added a reviewer: rsmith. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 1. Skip diagnosing all pointer-like parameters. 2. Replace `Context.hasSameUnqualifiedType` with `Context.hasSimilarType`. 3.

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:561-568 + for (const auto *A : Attrs) { +if (A->getKind() == attr::MustTail) { + if (!checkMustTailAttr(SubStmt, *A)) { +return SubStmt; + } + setFunctionHasMustTail(); +}

[PATCH] D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h

hbae updated this revision to Diff 335347. hbae added a comment. Added inline after static to avoid unused function warning. Added a RUN line to the test to catch unused function warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99447/new/ htt

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

zigwei added a comment. This is a helpful feature. We had exactly the same problem with both GFLAG and GTEST, too. But I am not sure if HeaderFilterRegex is the right option to control it. Is a new filter better for the ignored headers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D99630: phase 01: add new command line flag to enable UAR in 3 modes (always, [runtime], never).

kda updated this revision to Diff 335362. kda added a comment. I think this patch is near completion. But the new code generated for the 'Always' case is definitely wrong. I could use some coaching. I will eventually figure it out, but an interactive session would probably help me along. Repos

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

antonl added a comment. Let me second that this will be a very useful feature. Without enabling some clang-tidy checks will be very noisy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90835/new/ https://reviews.llvm.org/D90835 __

[PATCH] D99893: [WIP] Replace std::forward & std::move by cast expressions during Sema

rsmith added a comment. In D99893#2669441 , @rjmccall wrote: > I think a pattern-match in IRGen is probably a much more reasonable > alternative if the goal is primarily to avoid the code-generation overheads > at -O0 / optimization costs at -O. You'd s

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5011 +!ValType->isFloatingType()) { + Diag(ExprRange.getBegin(), diag::err_atomic_op_needs_atomic_int_ptr_or_fp) << IsC11 << Ptr->getType()

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl updated this revision to Diff 335366. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by John's comments. Do not allow atomic fetch add with x86_fp80. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 Files: clang

[PATCH] D99237: [AVR][clang] Fix wrong calling convention in functions return struct type

benshi001 updated this revision to Diff 335368. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99237/new/ https://reviews.llvm.org/D99237 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/avr/struct.c Index: clang/test/CodeGen/avr/struct.c ==

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39e3e3aa51d6: [NewPM] Redesign of PreserveCFG Checker (authored by yrouban). Changed prior to commit: https://reviews.llvm.org/D91327?vs=335221&id

[clang] 39e3e3a - [NewPM] Redesign of PreserveCFG Checker

Author: Yevgeny Rouban Date: 2021-04-06T12:35:49+07:00 New Revision: 39e3e3aa51d628722637c1bfa507f9ec2c532120 URL: https://github.com/llvm/llvm-project/commit/39e3e3aa51d628722637c1bfa507f9ec2c532120 DIFF: https://github.com/llvm/llvm-project/commit/39e3e3aa51d628722637c1bfa507f9ec2c532120.diff

[PATCH] D99901: [Driver][test] Test intended target only

MaskRay added inline comments. Comment at: clang/test/Driver/nostdincxx.cpp:4 // RUN: not %clangxx -nostdlibinc %s 2>&1 | FileCheck %s -// RUN: not %clangxx -fsyntax-only -nostdinc -nostdinc++ %s 2>&1 | FileCheck /dev/null --implicit-check-not=-Wunused-command-line-argument +//

  1   2   >