Eugene.Zelenko added inline comments.
================
Comment at:
clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranchCheck.cpp:200
+ if (isa<DoStmt>(Loop))
+ return DO_LOOP; // loop_type = 0;
+ else if (isa<WhileStmt>(Loop))
----------------
Is loop ID is not enough? Why does comment with numerical code used? Same below.
================
Comment at:
clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranchCheck.h:1
+//===--- IdDependentBackwardBranchCheck.h -
clang-tidy---------------------===//
+//
----------------
Please add space after clang-tidy and language code. See other checks as
example.
================
Comment at:
clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranchCheck.h:36
+ : FieldDeclaration(Declaration), Location(Location), Message(Message)
{}
+ IdDependencyRecord() {}
+ const VarDecl *VariableDeclaration;
----------------
Please use `= default;`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70094/new/
https://reviews.llvm.org/D70094
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
