[PATCH] D99809: Use tablegen to diagnose mutually exclusive attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Accepting on my own authority so I can close in a moment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99809/new/ https://reviews.llvm.org/D99809 _

[PATCH] D99809: Use tablegen to diagnose mutually exclusive attributes

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in 4be8a26951da9a6e04de327b38dd158f4c8e3280 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99809/new/ https://reviews.llvm.org/D99809 _

[clang] 0fe8af9 - Fix build bot problem with missing OMPC_novariants in switch.

Author: Jennifer Yu Date: 2021-04-02T13:58:39-07:00 New Revision: 0fe8af94688aa03c01913c2001d6a1a911f42ce6 URL: https://github.com/llvm/llvm-project/commit/0fe8af94688aa03c01913c2001d6a1a911f42ce6 DIFF: https://github.com/llvm/llvm-project/commit/0fe8af94688aa03c01913c2001d6a1a911f42ce6.diff L

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rsmith added a comment. Thanks, I think this is looking really good. @rjmccall, no explicit need to review; I just wanted to make sure you'd seen this and had a chance to express any concerns before we go ahead. Comment at: clang/include/clang/Basic/AttrDocs.td:452 +optimizat

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5315-5317 +// TODO(haberman): insert checks/assertions to verify that this early exit +// is safe. We tried to verify this in Sema but we should double-check +// here. rsmith wrote

Re: [clang] 9320ac9 - [Clang] Only run test when X86 backend is built.

On Thu, Apr 1, 2021 at 1:29 PM Florian Hahn wrote: > > > > On Thu, Apr 1, 2021 at 8:11 PM David Blaikie wrote: >> >> On Thu, Apr 1, 2021 at 1:16 AM Florian Hahn wrote: >> > >> > Hi, >> > >> > On Tue, Mar 30, 2021 at 7:52 PM David Blaikie wrote: >> >> >> >> Is there a more reliable remark that c

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rjmccall added a reviewer: varungandhi-apple. rjmccall added a comment. CC'ing Varun Gandhi. Is `musttail` actually supported generically on all LLVM backends, or does this need a target restriction? You should structure this code so it's easy to add exceptions for certain calling conventions

[PATCH] D99791: [CGCall] Annotate pointer argument with alignment

efriedma added a comment. This feels scary: the C standard technically allows this, but we haven't done it in the past, and it could break otherwise functioning code. (We've only assumed alignment about pointers that are dereferenced/dereferenceable.) For D99790

[PATCH] D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h

hbae updated this revision to Diff 335034. hbae added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Removed omp_is_initial_device() from clang built-ins. Added a new test under openmp/libomptarget. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h

hbae added inline comments. Comment at: openmp/runtime/src/include/omp.h.var:479 +# endif + # undef __KAI_KMPC_CONVENTION jdoerfert wrote: > Do we want them to be static? I would have expected odr linkage instead. > > > Current clang fails to link two fil

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rsmith added a comment. In D99517#2667025 , @rjmccall wrote: > You should structure this code so it's easy to add exceptions for certain > calling conventions that can support tail calls with weaker restrictions > (principally, callee-pop conventions).

[PATCH] D99821: [PGO, test] Fix typo in FileCheck var

thopre created this revision. thopre added reviewers: bogner, xur, davidxl. Herald added a subscriber: wenlei. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99821 Fi

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rjmccall added a comment. In D99517#2667088 , @rsmith wrote: > In D99517#2667025 , @rjmccall wrote: > >> You should structure this code so it's easy to add exceptions for certain >> calling conventions that can sup

[PATCH] D99225: [clang] cxx tests: cleanup, update and add some new ones

mizvekov updated this revision to Diff 335044. mizvekov added a comment. Includes some new NRVO tests which will be used in D99696 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99225/new/ https://reviews.llvm.org

[PATCH] D99696: [clang] WIP: NRVO: Improvements and handling of more cases.

mizvekov updated this revision to Diff 335045. mizvekov added a comment. Fixes for auto&, decltype(auto). Exclude candidates from functions with dependent / undeduced return types which are references. Adjusts the CodeGen tests from D99225 . Repository: rG LLV

[PATCH] D99821: [PGO, test] Fix typo in FileCheck var

xur accepted this revision. xur added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99821/new/ https://reviews.llvm.org/D99821 ___ cfe-com

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

Quuxplusone added a comment. LGTM (just a bunch of style comments from me), but I think you'll have to get someone else's attention if you're expecting to get signoff from someone to land this. I also think it would make sense for you to land the absolutely trivial trailing-whitespace diffs ri

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

mizvekov added a comment. @Quuxplusone Thank you for the review. All your points are good ones and will be addressed in time! The new NRVO propagation `clang/test/CodeGen/nrvo-tracking.cpp` is also breaking on the buildbot, but it works on my machine. Will also take a look at that one. =

[PATCH] D99826: [clang] NFC: remove trailing white spaces from some tests

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99826 Files: clang/test/CXX/drs/dr3xx.cpp clang/test/CXX/expr/expr.prim/expr.prim

[clang] bac74a5 - [clang] NFC: remove trailing white spaces from some tests

Author: Matheus Izvekov Date: 2021-04-03T03:18:22+02:00 New Revision: bac74a50e99f3d014d6e5a67272fd3b20eeb7fed URL: https://github.com/llvm/llvm-project/commit/bac74a50e99f3d014d6e5a67272fd3b20eeb7fed DIFF: https://github.com/llvm/llvm-project/commit/bac74a50e99f3d014d6e5a67272fd3b20eeb7fed.dif

[PATCH] D99826: [clang] NFC: remove trailing white spaces from some tests

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbac74a50e99f: [clang] NFC: remove trailing white spaces from some

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

mizvekov updated this revision to Diff 335055. mizvekov added a comment. Just rebased, removing trailing whitespace noise. Other review points to be addressed later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99225/new/ https://reviews.llvm.org

[clang] 2458aa0 - Add missing override to clang tblgen AttrEmitter

Author: David Blaikie Date: 2021-04-02T20:47:49-07:00 New Revision: 2458aa0b9136e7616f529b027d1d478cf699340f URL: https://github.com/llvm/llvm-project/commit/2458aa0b9136e7616f529b027d1d478cf699340f DIFF: https://github.com/llvm/llvm-project/commit/2458aa0b9136e7616f529b027d1d478cf699340f.diff

[PATCH] D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, thanks Comment at: openmp/runtime/src/include/omp.h.var:479 +# endif + # undef __KAI_KMPC_CONVENTION hbae wrote: > jdoerfert wrote: > > Do we

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder added a comment. I compiled libc++ with a clang that has this patch applied and didn't run into more problems. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 ___ cfe-commits mailing list cfe-

[clang] b4f2e80 - [RISCV] Refactor conversion of B extensions to IR intrinsics a little to reduce clang binary size.

Author: Craig Topper Date: 2021-04-02T23:49:44-07:00 New Revision: b4f2e8060075761dd0e9727ea01ca0142b4e767f URL: https://github.com/llvm/llvm-project/commit/b4f2e8060075761dd0e9727ea01ca0142b4e767f DIFF: https://github.com/llvm/llvm-project/commit/b4f2e8060075761dd0e9727ea01ca0142b4e767f.diff

<    1   2