[clang] a89fb29 - [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType

Author: oToToT Date: 2021-04-02T15:31:20+08:00 New Revision: a89fb29398dc0ce48dfe6f45f99d6ae7df4c6b46 URL: https://github.com/llvm/llvm-project/commit/a89fb29398dc0ce48dfe6f45f99d6ae7df4c6b46 DIFF: https://github.com/llvm/llvm-project/commit/a89fb29398dc0ce48dfe6f45f99d6ae7df4c6b46.diff LOG: [

[PATCH] D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478)

This revision was automatically updated to reflect the committed changes. Closed by commit rGa89fb29398dc: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (authored by oToToT). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99407/new

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:886 HelpText<"Enable C++ exceptions">, Flags<[CC1Option]>; +def fasync_exceptions: Flag<["-"], "fasync-exceptions">, Group, + HelpText<"Enable EH Asynchronous exceptions">, Flags<[CC1Option]

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

anastasiia_lukianenko updated this revision to Diff 334918. anastasiia_lukianenko edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/For

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

lebedev.ri created this revision. lebedev.ri added reviewers: efriedma, rjmccall, rsmith, erichkeane, nikic. lebedev.ri added a project: LLVM. Herald added a subscriber: lxfind. lebedev.ri requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits,

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

arichardson added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2314 + llvm::Align Alignment = + getNaturalTypeAlignment(ThisTy, /*BaseInfo=*/nullptr, + /*TBAAInfo=*/nullptr, Shouldn't the alignment also

[PATCH] D99791: [CGCall] Annotate pointer argument with alignment

lebedev.ri created this revision. lebedev.ri added reviewers: efriedma, rjmccall, rsmith, erichkeane, aaron.ballman, nikic. lebedev.ri added a project: LLVM. lebedev.ri requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Same idea as D99790

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2314 + llvm::Align Alignment = + getNaturalTypeAlignment(ThisTy, /*BaseInfo=*/nullptr, + /*TBAAInfo=*/nullptr, arichardson wrote: > Shouldn't

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader updated this revision to Diff 334927. bader marked 4 inline comments as done. bader added a comment. Address comments from @Anastasia. - Removed controversial clarifications. - Reshuffled text to keep language semantics clarifications closer to each other. Repository: rG LLVM Github Mo

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader marked 4 inline comments as done. bader added inline comments. Comment at: clang/docs/SYCLSupport.rst:243 +Similar to other single-source C++-based GPU programming modes like +OpenMP/CUDA/HIP, SYCL uses clang's "default" address space for types with no +explicit address spa

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

lebedev.ri updated this revision to Diff 334929. lebedev.ri marked 5 inline comments as done. lebedev.ri added a comment. Addressed review comments. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93822/new/ https://reviews.llvm.org/D93822 F

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok updated this revision to Diff 334931. alok added a comment. Updated testcase to use option "-O0", earlier default option was being used instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99160/new/ https://reviews.llvm.org/D99160 Files: llvm/lib/CodeGen/SelectionDAG/FastISe

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok added a comment. In D99160#2665580 , @probinson wrote: > FastISel is normally used only at -O0, I wouldn't expect any parameters to be > optimized out at -O0. > The test is running llc with default optimization, which is -O2, and forcing > fast-isel

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

djtodoro added a comment. In D99160#2666066 , @alok wrote: > In D99160#2665580 , @probinson wrote: > >> FastISel is normally used only at -O0, I wouldn't expect any parameters to >> be optimized out at -O0. >> The

[clang] 0f7bbbc - Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

Author: Sander de Smalen Date: 2021-04-02T10:55:22+01:00 New Revision: 0f7bbbc481e20a152c74bc315f8995b62d54c8c0 URL: https://github.com/llvm/llvm-project/commit/0f7bbbc481e20a152c74bc315f8995b62d54c8c0 DIFF: https://github.com/llvm/llvm-project/commit/0f7bbbc481e20a152c74bc315f8995b62d54c8c0.di

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f7bbbc481e2: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag… (authored by sdesmalen). Changed prior to commit: h

[PATCH] D99703: [debug-info][XCOFF] set `-gno-column-info` by default for DBX

This revision was automatically updated to reflect the committed changes. Closed by commit rGf026e1f52055: [debug-info][XCOFF] set `-gno-column-info` by default for DBX (authored by shchenz). Changed prior to commit: https://reviews.llvm.org/D99703?vs=334589&id=334879#toc Repository: rG LLVM

[PATCH] D99703: [debug-info][XCOFF] set `-gno-column-info` by default for DBX

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3974 + // Microsoft debuggers don't handle missing end columns well, and the AIX + // debugger DBX also doesn't handle the columns well, so it's bettre not to + // include any column info. ---

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok added a comment. In D99160#2666068 , @djtodoro wrote: > In D99160#2666066 , @alok wrote: > >> In D99160#2665580 , @probinson >> wrote: >> >>> FastISel is normally used

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

djtodoro added a comment. In D99160#2666104 , @alok wrote: > In D99160#2666068 , @djtodoro wrote: > >> In D99160#2666066 , @alok wrote: >> >>> In D99160#2665580

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2665361 , @aganea wrote: > I am still concerned by the fact that this patch doesn't fix the issue > mentionned in https://reviews.llvm.org/D96363#2650460 > Was the intention to fix that issue? Will the fi

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha updated this revision to Diff 334942. SaurabhJha added a comment. Updating D99037 : [Matrix] Implement explicit type conversions for matrix types Latest update includes code gen for c style casts along with some lit tests Repository: rG LLVM Github

[PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 334941. abhina.sreeskantharajan retitled this revision from "[Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text" to "[SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text". abhina.

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha added a comment. I pushed some unwanted changes that I used for debugging..fixing/removing them now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/ https://reviews.llvm.org/D99037 _

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha updated this revision to Diff 334945. SaurabhJha added a comment. Updating D99037 : [Matrix] Implement explicit type conversions for matrix types Removed unused variables and includes and fix codegen lit tests Repository: rG LLVM Github Monorepo CH

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha added a comment. Added some inline comments on where I have some doubts. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:547 + case CK_MatrixCast: { +// TODO: Handle MatrixCast here. + } I thought doing changes here is is

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

fhahn added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:547 + case CK_MatrixCast: { +// TODO: Handle MatrixCast here. + } SaurabhJha wrote: > I thought doing changes here is is outside the scope of casting so I jus

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

fhahn added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2916 // Require the operand to be a scalar or vector. + if (!SrcType->isScalarType() && !SrcType->isVectorType() && ` ... or a matrix`? Comment at: clang/test/Sema/matri

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

fhahn added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7400 + } else { +return Diag(R.getBegin(), +diag::err_invalid_conversion_between_matrix_and_scalar) When we get here, `SrcTy` may not necessarily be a scalar I think (see my

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha updated this revision to Diff 334951. SaurabhJha added a comment. Update commit message to more accurately reflect the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/ https://reviews.llvm.org/D99037 Files: clang/include

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui updated this revision to Diff 334952. kamleshbhalui added a comment. Making changes effective only for windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https://reviews.llvm.org/D99580 Files: clang/lib/CodeGen/CGDebu

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder updated this revision to Diff 334954. tbaeder added a comment. Herald added a subscriber: jdoerfert. A little earlier than expected. Happy Easter :P CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 Files: clang/include/clang/Parse/Pars

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 updated this revision to Diff 334955. Ericson2314 added a comment. Remove add_subdirectory(runtime) for deleted dir Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99755/new/ https://reviews.llvm.org/D99755 Files: clang/CMakeLists.txt

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

jyu2 updated this revision to Diff 334956. jyu2 added a comment. Fix format problem as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99679/new/ https://reviews.llvm.org/D99679 Files: clang/include/clang/AST/OpenMPClause.h clang/incl

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 added a comment. So unfortunately it seems the `clang/runtime`'s use was triggered by `LLVM_BUILD_EXTERNAL_COMPILER_RT`, which is in use in a few places still? (And not just Apple ones.) On the other hand, since this is doing an *external* CMake for compiler-rt, I fail to see why `

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:7659 +/// clause with condition 'a > 5'. +class OMPNovariantsClause : public OMPClause, public OMPClauseWithPreInit { + friend class OMPClauseReader; `final` Com

[clang] 3ebfa36 - Remove attribute handling code for simple attributes; NFC

Author: Aaron Ballman Date: 2021-04-02T11:35:10-04:00 New Revision: 3ebfa363f356eff744b73885023cc1fc62fad973 URL: https://github.com/llvm/llvm-project/commit/3ebfa363f356eff744b73885023cc1fc62fad973 DIFF: https://github.com/llvm/llvm-project/commit/3ebfa363f356eff744b73885023cc1fc62fad973.diff

[PATCH] D99537: [OPENMP51]Initial support for the dispatch directive

jdoerfert added a subscriber: jyu2. jdoerfert added a comment. Cool, are you expecting to hook this up to the variant selection logic as well? @jyu2 similarly do you intend to hook up `novariant`? We should also update https://clang.llvm.org/docs/OpenMPSupport.html to claim parts you are workin

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

fhahn added a comment. In D99037#2666230 , @SaurabhJha wrote: > Update commit message to more accurately reflect the patch Just FYI, `arc diff ` does not update the patch description on Phabricator. I think you have to edit it via the web-interface. Re

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list= to match gcc options.

oliverbrowne added a comment. Hi Folks, don't know if this review is still active but I can provide some context on the GCC behavior with respect to namespaces, template params and function arguments, they were bugs, fixed in 2019. Associated bug reports for namespace/class, and template parame

[PATCH] D95808: [test] Use host platform specific error message substitution in lit tests - continued

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. In D95808#2657744 , @jhenderson wrote: > @ASDenysPetrov, I think you need to mark this patch as Accepted so that > someone can close this

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. In D95246#2606343 , @abhina.sreeskantharajan wrote: > This issue has been fixed in https://reviews.llvm.org/D97472. > @ASDenysPetrov I'm

[PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

aganea added a comment. In D99426#2666141 , @abhina.sreeskantharajan wrote: > In D99426#2665361 , @aganea wrote: > >> I am still concerned by the fact that this patch doesn't fix the issue >> mentionned in https:/

[PATCH] D99797: [analyzer] Handle intersections and adjacency in RangeSet::Factory::add function

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: vsavchenko, steakhal, NoQ, xazax.hun, dcoughlin, Szelethus. ASDenysPetrov added a project: clang. Herald added subscribers: martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware.

[PATCH] D99797: [analyzer] Handle intersections and adjacency in RangeSet::Factory::add function

vsavchenko added a comment. Thanks for working on improvements of the solver and constraints! However, I have some tough questions about this patch. What I really want to understand here is motivation. Why do we need to have `add` operation semantics like this in the first place? My guess is

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

akhuang added a comment. In Chrome we noticed that plugin flags are not being roundtripped (and build fails with `error: Generated arguments do not match in round-trip`): example of the differing args: "-plugin-arg-blink-gc-plugin" "no-members-in-stack-allocated" "-plugin-arg-find-bad-con

[PATCH] D99537: [OPENMP51]Initial support for the dispatch directive

mikerice added a comment. @jyu2 is currently working on the novariants and nocontext clauses. We are still working on the overall construct so I'm not sure yet what more we will have to contribute. I'll look into updating the support doc. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

jyu2 updated this revision to Diff 334969. jyu2 added a comment. Thank you, Alexey for the review!!! This changes have been addressed as you suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99679/new/ https://reviews.llvm.org/D99679 Files:

[PATCH] D99797: [analyzer] Handle intersections and adjacency in RangeSet::Factory::add function

ASDenysPetrov added a comment. In D99797#2666358 , @vsavchenko wrote: > Thanks for working on improvements of the solver and constraints! However, I > have some tough questions about this patch. > > What I really want to understand here is motivation. W

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:13567-13568 +case OMPD_dispatch: + CaptureRegion = OMPD_task; + break; +default: What about other directives? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

jansvoboda11 added a comment. In D97462#2666366 , @akhuang wrote: > In Chrome we noticed that plugin flags are not being roundtripped (and build > fails with `error: Generated arguments do not match in round-trip`): > > example of the differing args: > >

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

ffrankies updated this revision to Diff 334979. ffrankies added a comment. - Rebased on top of latest changes in main branch - The diagnostic that identifies the code location where an ID-dependent variable/field is assigned has been changed from a warning to a note - Changes addressing code styl

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 334985. haberman added a comment. - Fixed unit test by running `opt` in a separate invocation. - Formatting fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 File

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/altera-id-dependent-backward-branch.rst:9 + +Based on the `Altera SDK for OpenCL: Best Practices Guide +

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5066 +CmdArgs.push_back("-mllvm"); +CmdArgs.push_back("-treat-scalable-fixed-error-as-warning"); + } Does this introduce an option in the CC1 command line for most cases? We

[PATCH] D99797: [analyzer] Handle intersections and adjacency in RangeSet::Factory::add function

ASDenysPetrov added a comment. @vsavchenko OK, what do you think of ***adjacency*** feature? I mean it simplifies such ranges `[1,2][3,4][5,6]` to `[1,6]`. Is it worth for implementation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ ht

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

dblaikie added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1648 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs, T.getArch())) prob

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

aaron.ballman added inline comments. Comment at: clang/test/Parser/cxx0x-attributes.cpp:377 + template friend class[[]] vector2; // expected-error {{an attribute list cannot appear here}} + template friend class [[clang::__type_visib

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok marked 2 inline comments as done. alok added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1648 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs,

[clang] b001d57 - [RISCV] Add IR intrinsic for Zbr extension

Author: Levy Hsu Date: 2021-04-02T10:58:45-07:00 New Revision: b001d574d7d94bcf1508fa4cdc22e02a0bf4adea URL: https://github.com/llvm/llvm-project/commit/b001d574d7d94bcf1508fa4cdc22e02a0bf4adea DIFF: https://github.com/llvm/llvm-project/commit/b001d574d7d94bcf1508fa4cdc22e02a0bf4adea.diff LOG:

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb001d574d7d9: [RISCV] Add IR intrinsic for Zbr extension (authored by LevyHsu, committed by craig.topper). Changed prior to commit: https://review

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha added inline comments. Comment at: clang/test/CodeGen/matrix-cast.c:15 + // CHECK: [[C:%.*]] = load <25 x i8>, <25 x i8>* {{.*}}, align 1 + // CHECK-NEXT: [[CONV:%.*]] = zext <25 x i8> [[C]] to <25 x i32> + // CHECK-NEXT: store <25 x i32> [[CONV]], <25 x i32

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

jrtc27 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11190 +def err_riscv_builtin_requires_extension : Error< + "builtin requires %0 extension support to be enabled">; } // end of sema component. This lost the quotes

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

dblaikie added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1648 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs, T.getArch())) alok

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

craig.topper added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11190 +def err_riscv_builtin_requires_extension : Error< + "builtin requires %0 extension support to be enabled">; } // end of sema component. jrtc27 wrote: > This

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

jrtc27 added a comment. Thanks, and good point re ordering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99009/new/ https://reviews.llvm.org/D99009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok marked an inline comment as done. alok added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1648 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs,

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:13567-13568 +case OMPD_dispatch: + CaptureRegion = OMPD_task; + break; +default: ABataev wrote: > What about other directives? Hi Alexey, As of now "novariants" clause only a

[clang] 1808194 - [RISCV] Add IR intrinsic for Zbb extension

Author: Craig Topper Date: 2021-04-02T11:23:57-07:00 New Revision: 1808194590dd2b308bc146406425d5d52e46b7e6 URL: https://github.com/llvm/llvm-project/commit/1808194590dd2b308bc146406425d5d52e46b7e6 DIFF: https://github.com/llvm/llvm-project/commit/1808194590dd2b308bc146406425d5d52e46b7e6.diff

[PATCH] D99808: [Sema] Move 'char-expression-as-unsigned < 0' into a separate diagnostic

AntonBikineev created this revision. AntonBikineev added reviewers: aaron.ballman, thakis. AntonBikineev requested review of this revision. Herald added a project: clang. This change splits '-Wtautological-unsigned-zero-compare' by reporting char-expressions-interpreted-as-unsigned under a separat

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

fhahn added inline comments. Comment at: clang/test/CodeGen/matrix-cast.c:15 + // CHECK: [[C:%.*]] = load <25 x i8>, <25 x i8>* {{.*}}, align 1 + // CHECK-NEXT: [[CONV:%.*]] = zext <25 x i8> [[C]] to <25 x i32> + // CHECK-NEXT: store <25 x i32> [[CONV]], <25 x i32>* {{

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

dexonsmith added a comment. In D97462#2666485 , @jansvoboda11 wrote: > Thanks for reporting that. D99606 fixes one > aspect of `-plugin-arg`, but it seems the order of generation is > non-deterministic (most likely rela

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:13567-13568 +case OMPD_dispatch: + CaptureRegion = OMPD_task; + break; +default: jyu2 wrote: > ABataev wrote: > > What about other directives? > Hi Alexey, > > As of now "

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99679/new/ https://reviews.llvm.org/D99679 ___ c

[clang] 1f0b309 - Revert "[RISCV] Add IR intrinsic for Zbb extension"

Author: Craig Topper Date: 2021-04-02T11:47:02-07:00 New Revision: 1f0b309f24ba7ed144ddcd20cccedc284d990074 URL: https://github.com/llvm/llvm-project/commit/1f0b309f24ba7ed144ddcd20cccedc284d990074 DIFF: https://github.com/llvm/llvm-project/commit/1f0b309f24ba7ed144ddcd20cccedc284d990074.diff

[clang] 944adbf - Recommit "[RISCV] Add IR intrinsic for Zbb extension"

Author: Levy Hsu Date: 2021-04-02T11:50:19-07:00 New Revision: 944adbf285505ac481551157c4ee3cc3c0724900 URL: https://github.com/llvm/llvm-project/commit/944adbf285505ac481551157c4ee3cc3c0724900 DIFF: https://github.com/llvm/llvm-project/commit/944adbf285505ac481551157c4ee3cc3c0724900.diff LOG:

[PATCH] D99320: [RISCV] [1/2] Add intrinsic for Zbb extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG944adbf28550: Recommit "[RISCV] Add IR intrinsic for Zbb extension" (authored by LevyHsu, committed by craig.topper). Changed prior to commit: htt

[PATCH] D99809: Use tablegen to diagnose mutually exclusive attributes

aaron.ballman created this revision. aaron.ballman added a reviewer: rsmith. aaron.ballman requested review of this revision. Herald added a project: clang. Currently, when one or more attributes are mutually exclusive, the developer adding the attribute has to manually emit diagnostics. In pract

[PATCH] D99809: Use tablegen to diagnose mutually exclusive attributes

aaron.ballman added a comment. @rsmith -- I am posting the review so that I can see how the CI pipeline likes the functionality (because this impacts so many different attributes), but I intend to commit it on my own authority once CI passes. Feel free to review it if you'd like and I'll addres

[PATCH] D99811: [TextAPI] move source code files out of subdirectory, NFC

cishida created this revision. cishida added reviewers: steven_wu, ributzka. Herald added subscribers: hiraditya, mgorny. Herald added a reviewer: int3. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. cishida requested review of this revision. Herald added projects: clang, LL

[clang] f78d932 - [RISCV] Add IR intrinsics for Zbc extension

Author: Levy Hsu Date: 2021-04-02T12:09:13-07:00 New Revision: f78d932cf23a6521a1f9a08c539d1a00148ebe54 URL: https://github.com/llvm/llvm-project/commit/f78d932cf23a6521a1f9a08c539d1a00148ebe54 DIFF: https://github.com/llvm/llvm-project/commit/f78d932cf23a6521a1f9a08c539d1a00148ebe54.diff LOG:

[PATCH] D99711: [RISCV] [1/2] Add intrinsic for Zbc extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGf78d932cf23a: [RISCV] Add IR intrinsics for Zbc extension (authored by LevyHsu, committed by craig.topper). Changed prior to commit: https://reviews.llvm.org/D99711?vs=334882&id=335008#toc Repository:

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

thakis added a comment. Looks like this doesn't build on windows: http://45.33.8.238/win/36271/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99009/new/ https://reviews.l

[clang] 1bd4986 - [Sema] Fix Windows build after b001d574d7d9

Author: Jessica Clarke Date: 2021-04-02T20:27:58+01:00 New Revision: 1bd4986e7cdc124fecbf4b4527039a9a845e61f5 URL: https://github.com/llvm/llvm-project/commit/1bd4986e7cdc124fecbf4b4527039a9a845e61f5 DIFF: https://github.com/llvm/llvm-project/commit/1bd4986e7cdc124fecbf4b4527039a9a845e61f5.diff

[clang] 5311abc - [RISCV] Try using toupper instead of std::toupper to make the build bots happy.

Author: Craig Topper Date: 2021-04-02T12:29:07-07:00 New Revision: 5311abc7a24e4170e5e6d06f1022da87f1413dd7 URL: https://github.com/llvm/llvm-project/commit/5311abc7a24e4170e5e6d06f1022da87f1413dd7 DIFF: https://github.com/llvm/llvm-project/commit/5311abc7a24e4170e5e6d06f1022da87f1413dd7.diff

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

jrtc27 added a comment. In D99009#2666793 , @thakis wrote: > Looks like this doesn't build on windows: > http://45.33.8.238/win/36271/step_4.txt > > Please take a look and revert for now if it takes a while to fix. Hopefully fixed in 1bd4986e7cdc

[clang] be7358d - Revert "[RISCV] Try using toupper instead of std::toupper to make the build bots happy."

Author: Craig Topper Date: 2021-04-02T12:30:23-07:00 New Revision: be7358df1e3066d09171159211b9fa578272585e URL: https://github.com/llvm/llvm-project/commit/be7358df1e3066d09171159211b9fa578272585e DIFF: https://github.com/llvm/llvm-project/commit/be7358df1e3066d09171159211b9fa578272585e.diff

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek added a comment. @ldionne I have update the change description to explain the new layout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 ___ cfe-commits m

[clang] 2165c0d - [OPENMP][DOCS]Update status of the supported constructs, NFC.

Author: Mike Rice Date: 2021-04-02T12:31:36-07:00 New Revision: 2165c0d389c0b8f7dfd383ea6abd0d9b5d2ee07f URL: https://github.com/llvm/llvm-project/commit/2165c0d389c0b8f7dfd383ea6abd0d9b5d2ee07f DIFF: https://github.com/llvm/llvm-project/commit/2165c0d389c0b8f7dfd383ea6abd0d9b5d2ee07f.diff LOG

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

MaskRay added a comment. > This layout matches the layout use by other compilers like GCC. Clarification: this is similar but not match GCC's layout, where the multiarch path component (e.g. `/x86_64-linux-gnu`) is appended to `.../include` % clang++ --target=aarch64-pc-linux-gnu a.cc '-###'

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

thakis added a comment. In D99009#2666797 , @jrtc27 wrote: > In D99009#2666793 , @thakis wrote: > >> Looks like this doesn't build on windows: >> http://45.33.8.238/win/36271/step_4.txt >> >> Please take a look and

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder updated this revision to Diff 335016. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/ParsedAttr.h clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D99797: [analyzer] Handle intersections and adjacency in RangeSet::Factory::add function

ASDenysPetrov updated this revision to Diff 335011. ASDenysPetrov added a comment. Updated. Restored complexity to O(N). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstr

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

rjmccall added inline comments. Comment at: clang/test/CodeGen/matrix-cast.c:15 + // CHECK: [[C:%.*]] = load <25 x i8>, <25 x i8>* {{.*}}, align 1 + // CHECK-NEXT: [[CONV:%.*]] = zext <25 x i8> [[C]] to <25 x i32> + // CHECK-NEXT: store <25 x i32> [[CONV]], <25 x i32>*

[PATCH] D99797: [analyzer] Handle intersections and adjacency in RangeSet::Factory::add function

ASDenysPetrov added a comment. @vsavchenko FYI. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:112-113 +RangeSet RangeSet::Factory::add(RangeSet LHS, RangeSet RHS) { + if (LHS.isEmpty()) +return RHS; + for (const Range &R : RHS) Also

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov added a comment. @steakhal thanks for the approval. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:564-565 } - - llvm_unreachable("Unknown SVal kind"); } steakhal wrote: > You probably don't want to remove this. The same applies to

[PATCH] D99809: Use tablegen to diagnose mutually exclusive attributes

aaron.ballman updated this revision to Diff 335021. aaron.ballman added a comment. Correcting lint warnings, adding documentation for the new feature. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99809/new/ https://reviews.llvm.org/D99809 Files: clang/docs/InternalsManual.rst clan

[clang] cb424fe - [OPENMP5.1]Initial support for novariants clause.

Author: Jennifer Yu Date: 2021-04-02T13:19:01-07:00 New Revision: cb424fee3d6b27dbd38de666382b702100935286 URL: https://github.com/llvm/llvm-project/commit/cb424fee3d6b27dbd38de666382b702100935286 DIFF: https://github.com/llvm/llvm-project/commit/cb424fee3d6b27dbd38de666382b702100935286.diff L

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

jyu2 closed this revision. jyu2 added a comment. cb424fee3d6b27dbd38de666382b702100935286 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99679/new/ https://reviews.llvm.org/D9967

[clang] 4be8a26 - Use tablegen to diagnose mutually exclusive attributes

Author: Aaron Ballman Date: 2021-04-02T16:34:42-04:00 New Revision: 4be8a26951da9a6e04de327b38dd158f4c8e3280 URL: https://github.com/llvm/llvm-project/commit/4be8a26951da9a6e04de327b38dd158f4c8e3280 DIFF: https://github.com/llvm/llvm-project/commit/4be8a26951da9a6e04de327b38dd158f4c8e3280.diff

  1   2   >